Re: [PATCH] glamor: explicitly check for GL_OES_EGL_image

[Emil Velikov]

Hi Eric,

On 17 September 2015 at 15:52, Eric Anholt  wrote:
> Emil Velikov  writes:
>
>> Otherwise we'll fail miserably later on as we try to use
>> glEGLImageTargetTexture2DOES.
>
> I thought this had been implied by other extensions we check for, but I
> don't see it.
>
> I think this would go next to the EGL_EXT_image_dma_buf_import check --
> we won't use it unless we're doing the other import/export paths, right?
Good point. Seems like Adam missed your reply and pushed the original patch.
Incremental fix on its way.

Thanks
Emil
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] glamor: explicitly check for GL_OES_EGL_image

[Eric Anholt]

Emil Velikov  writes:

> Otherwise we'll fail miserably later on as we try to use
> glEGLImageTargetTexture2DOES.

I thought this had been implied by other extensions we check for, but I
don't see it.

I think this would go next to the EGL_EXT_image_dma_buf_import check --
we won't use it unless we're doing the other import/export paths, right?


signature.asc
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] glamor: explicitly check for GL_OES_EGL_image

[Adam Jackson]

On Wed, 2015-09-16 at 22:10 +0100, Emil Velikov wrote:
> Otherwise we'll fail miserably later on as we try to use
> glEGLImageTargetTexture2DOES.
> 
> Signed-off-by: Emil Velikov 

Merged:

   139e36d..58d54ee  master -> master

- ajax
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] glamor: explicitly check for GL_OES_EGL_image

[Michel Dänzer]

On 16.09.2015 17:10, Emil Velikov wrote:
> Otherwise we'll fail miserably later on as we try to use
> glEGLImageTargetTexture2DOES.
> 
> Signed-off-by: Emil Velikov 
> ---
>  glamor/glamor.c | 5 +
>  1 file changed, 5 insertions(+)
> 
> diff --git a/glamor/glamor.c b/glamor/glamor.c
> index d4a0236..8178785 100644
> --- a/glamor/glamor.c
> +++ b/glamor/glamor.c
> @@ -545,6 +545,11 @@ glamor_init(ScreenPtr screen, unsigned int flags)
>  }
>  }
>  
> +if (!epoxy_has_gl_extension("GL_OES_EGL_image")) {
> +ErrorF("GL_OES_EGL_image not available\n");
> +goto fail;
> +}
> +
>  glamor_priv->has_rw_pbo = FALSE;
>  if (glamor_priv->gl_flavor == GLAMOR_GL_DESKTOP)
>  glamor_priv->has_rw_pbo = TRUE;
> 

Reviewed-by: Michel Dänzer 


-- 
Earthling Michel Dänzer   |   http://www.amd.com
Libre software enthusiast | Mesa and X developer
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] glamor: explicitly check for GL_OES_EGL_image

[Emil Velikov]

Otherwise we'll fail miserably later on as we try to use
glEGLImageTargetTexture2DOES.

Signed-off-by: Emil Velikov 
---
 glamor/glamor.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/glamor/glamor.c b/glamor/glamor.c
index d4a0236..8178785 100644
--- a/glamor/glamor.c
+++ b/glamor/glamor.c
@@ -545,6 +545,11 @@ glamor_init(ScreenPtr screen, unsigned int flags)
 }
 }
 
+if (!epoxy_has_gl_extension("GL_OES_EGL_image")) {
+ErrorF("GL_OES_EGL_image not available\n");
+goto fail;
+}
+
 glamor_priv->has_rw_pbo = FALSE;
 if (glamor_priv->gl_flavor == GLAMOR_GL_DESKTOP)
 glamor_priv->has_rw_pbo = TRUE;
-- 
2.4.4

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel