Re: [PATCH: scrnsaverproto] Fix id attributes, linkend and olinks

2011-09-25 Thread Gaetan Nadon
On Sat, 2011-09-24 at 20:23 -0600, Matt Dew wrote:

> ---
>  specs/saver.xml |   30 +++---
>  1 files changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/specs/saver.xml b/specs/saver.xml
> index b1e6f95..bcdd3a0 100644
> --- a/specs/saver.xml
> +++ b/specs/saver.xml
> @@ -39,7 +39,7 @@ implied warranty.
>  
>  
>  
> -
> +
>  Introduction
>  
>  The X Window System provides support for changing the image on a display 
> screen
> @@ -464,7 +464,7 @@ window attributes.
>  
>  
>  
> -
> +
>  Events
>  
>  The Screen Saver extension adds one event:
> @@ -649,7 +649,7 @@ SETofSCREENSAVEREVENT
>  
>  
>  
> -
> +
>  Events
>  
>  
> @@ -673,7 +673,7 @@ SETofSCREENSAVEREVENT
>  
>  
>  
> -
> +
>  Inter-Client Communications Conventions
>  
>  Screen saver clients should create at least one resource value whose
> @@ -705,7 +705,7 @@ The include file for this extension is
>  
>  
> 
> -
> +
>  
>Bool XScreenSaverQueryExtension
>  Display *display
> @@ -728,7 +728,7 @@ no additional errors are defined by this extension, the 
> results
>  of error_base are not defined.
>  
>  
> -
> +
>  
>Status XScreenSaverQueryVersion
>  Display *display
> @@ -753,14 +753,14 @@ set and 0 is returned.
>  
>  This routine allocates and returns an
>  XScreenSaverInfo structure
> -for use in calls to XScreenSaverQueryInfo.
> +for use in calls to .

Are you considering adding "xrefstyle" with pageabbrev to all xref
links?
If so, consider this suggestion to put it in the customization layer.
http://lists.oasis-open.org/archives/docbook-apps/200405/msg00121.html
This attribute was meant to override the default in a few instances.

Consider that we might want to change the xrefstyle at later point in
time.


>  All fields in the
>  structure are initialized to zero.  If insufficient memory is available,
>  NULL is returned.  The results of this routine can be released
> -using XFree.
> +using  targetptr='XFree'>XFree.

I assume that libX11 xfree will be changed to XFree.

>  
>  
> -
> +
>  
>Status XScreenSaverQueryInfo
>  Display *display
> @@ -795,7 +795,7 @@ description of the fields.  If the extension is not 
> supported,
>  is returned.
>  
>  
> -
> +
>  
>void XScreenSaverSelectInput
>  Display *display
> @@ -832,7 +832,7 @@ See the definition of the
>  of the allowed event masks.   
>  
>  
> -
> +
>  
>void XScreenSaverSetAttributes
>  Display *dpy
> @@ -858,7 +858,7 @@ of the ScreenSaverSetAttributes 
> request for a
>  description of each of the arguments.
>  
>  
> -
> +
>  
>void XScreenSaverUnsetAttributes
>  Display *display
> @@ -872,7 +872,7 @@ extension, this routine instructs the server to discard
>  any previous screen saver window attributes set by this client.
>  
>  
> -
> +
>  
>Status XScreenSaverRegister
>  Display *display
> @@ -891,7 +891,7 @@ is encountered and the property is not changed, otherwise 
> it returns
>  non-zero.
>  
>  
> -
> +
>  
>Status XScreenSaverUnregister
>  Display *display
> @@ -906,7 +906,7 @@ It returns zero if an error is encountered and the 
> property is changed,
>  otherwise it returns non-zero.
>  
>  
> -
> +
>  
>Status XScreenSaverGetRegistered
>  Display *display





signature.asc
Description: This is a digitally signed message part
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH: scrnsaverproto] Fix id attributes, linkend and olinks

2011-09-26 Thread Matt Dew

On 09/25/2011 11:55 AM, Gaetan Nadon wrote:

On Sat, 2011-09-24 at 20:23 -0600, Matt Dew wrote:

---
  specs/saver.xml |   30 +++---
  1 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/specs/saver.xml b/specs/saver.xml
index b1e6f95..bcdd3a0 100644
--- a/specs/saver.xml
+++ b/specs/saver.xml
@@ -39,7 +39,7 @@ implied warranty.
  
  

-
+
  Introduction
  
  The X Window System provides support for changing the image on a display 
screen
@@ -464,7 +464,7 @@ window attributes.
  
  

-
+
  Events
  
  The Screen Saver extension adds one event:
@@ -649,7 +649,7 @@ SETofSCREENSAVEREVENT
  
  

-
+
  Events

  
@@ -673,7 +673,7 @@ SETofSCREENSAVEREVENT
  
  

-
+
  Inter-Client Communications Conventions
  
  Screen saver clients should create at least one resource value whose
@@ -705,7 +705,7 @@ The include file for this extension is
  


-
+
  
BoolXScreenSaverQueryExtension
  Display*display
@@ -728,7 +728,7 @@ no additional errors are defined by this extension, the 
results
  oferror_base  are not defined.
  

-
+
  
StatusXScreenSaverQueryVersion
  Display*display
@@ -753,14 +753,14 @@ set and 0 is returned.
  
  This routine allocates and returns an
  XScreenSaverInfo  structure
-for use in calls toXScreenSaverQueryInfo.
+for use in calls to.

Are you considering adding "xrefstyle" with pageabbrev to all xref links?
If so, consider this suggestion to put it in the customization layer.


No, there are places where it doesn't make sense.  A lot of links are 
very close to the target so a page # feels unnecessary.  Same page, 
sometimes the very preceeding or next paragraph so it doesn't make sense 
to do it everywhere.




http://lists.oasis-open.org/archives/docbook-apps/200405/msg00121.html
This attribute was meant to override the default in a few instances.

Consider that we might want to change the xrefstyle at later point in time.



Yep, everything I do is with the thought that style can and will change 
in the future.



  All fields in the
  structure are initialized to zero.  If insufficient memory is available,
  NULL is returned.  The results of this routine can be released
-usingXFree.
+usingXFree.

I assume that libX11 xfree will be changed to XFree.


Yep.



  

-
+
  
StatusXScreenSaverQueryInfo
  Display*display
@@ -795,7 +795,7 @@ description of the fields.  If the extension is not 
supported,
  is returned.
  

-
+
  
voidXScreenSaverSelectInput
  Display*display
@@ -832,7 +832,7 @@ See the definition of the
  of the allowed event masks.
  

-
+
  
voidXScreenSaverSetAttributes
  Display*dpy
@@ -858,7 +858,7 @@ of theScreenSaverSetAttributes  
request for a
  description of each of the arguments.
  

-
+
  
voidXScreenSaverUnsetAttributes
  Display*display
@@ -872,7 +872,7 @@ extension, this routine instructs the server to discard
  any previous screen saver window attributes set by this client.
  

-
+
  
StatusXScreenSaverRegister
  Display*display
@@ -891,7 +891,7 @@ is encountered and the property is not changed, otherwise 
it returns
  non-zero.
  

-
+
  
StatusXScreenSaverUnregister
  Display*display
@@ -906,7 +906,7 @@ It returns zero if an error is encountered and the property 
is changed,
  otherwise it returns non-zero.
  

-
+
  
StatusXScreenSaverGetRegistered
  Display*display





___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel


Re: [PATCH: scrnsaverproto] Fix id attributes, linkend and olinks

2011-09-26 Thread Matt Dew




Are you considering adding "xrefstyle" with pageabbrev to all xref links?
If so, consider this suggestion to put it in the customization layer.
http://lists.oasis-open.org/archives/docbook-apps/200405/msg00121.html
This attribute was meant to override the default in a few instances.

Consider that we might want to change the xrefstyle at later point in time


After looking into it some more and thinking about it, here's what I'm 
thinking.


External links = olink
internal links = xref

xrefs and olinks,  there's a docbook 5 path. It requires some sed-lovin' 
no matter what we do.


I like that we can style xrefs. Should we, at some point in the future, 
decide xref is a pain and we'd prefer link,  it's sed-able. No great pain.


If no objections, this is the path I'm going,
Matt

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel


Re: [PATCH: scrnsaverproto] Fix id attributes, linkend and olinks

2011-09-27 Thread Gaetan Nadon
On Mon, 2011-09-26 at 18:38 -0600, Matt Dew wrote:

> On 09/25/2011 11:55 AM, Gaetan Nadon wrote:
> > On Sat, 2011-09-24 at 20:23 -0600, Matt Dew wrote:
> >> ---
> >>   specs/saver.xml |   30 +++---
> >>   1 files changed, 15 insertions(+), 15 deletions(-)
> >>
> >> diff --git a/specs/saver.xml b/specs/saver.xml
> >> index b1e6f95..bcdd3a0 100644
> >> --- a/specs/saver.xml
> >> +++ b/specs/saver.xml
> >> @@ -39,7 +39,7 @@ implied warranty.
> >>   
> >>   
> >>
> >> -
> >> +
> >>   Introduction
> >>   
> >>   The X Window System provides support for changing the image on a display 
> >> screen
> >> @@ -464,7 +464,7 @@ window attributes.
> >>   
> >>   
> >>
> >> -
> >> +
> >>   Events
> >>   
> >>   The Screen Saver extension adds one event:
> >> @@ -649,7 +649,7 @@ SETofSCREENSAVEREVENT
> >>   
> >>   
> >>
> >> -
> >> +
> >>   Events
> >>
> >>   
> >> @@ -673,7 +673,7 @@ SETofSCREENSAVEREVENT
> >>   
> >>   
> >>
> >> -
> >> +
> >>   Inter-Client Communications Conventions
> >>   
> >>   Screen saver clients should create at least one resource value whose
> >> @@ -705,7 +705,7 @@ The include file for this extension is
> >>   
> >>
> >>
> >> -
> >> +
> >>   
> >> BoolXScreenSaverQueryExtension
> >>   Display*display
> >> @@ -728,7 +728,7 @@ no additional errors are defined by this extension, 
> >> the results
> >>   oferror_base  are not defined.
> >>   
> >>
> >> -
> >> +
> >>   
> >> StatusXScreenSaverQueryVersion
> >>   Display*display
> >> @@ -753,14 +753,14 @@ set and 0 is returned.
> >>   
> >>   This routine allocates and returns an
> >>   XScreenSaverInfo  structure
> >> -for use in calls toXScreenSaverQueryInfo.
> >> +for use in calls to >> xrefstyle='select: title pageabbrev'/>.
> > Are you considering adding "xrefstyle" with pageabbrev to all xref links?
> > If so, consider this suggestion to put it in the customization layer.
> 
> No, there are places where it doesn't make sense.  A lot of links are 
> very close to the target so a page # feels unnecessary.  Same page, 
> sometimes the very preceeding or next paragraph so it doesn't make sense 
> to do it everywhere.
> 
> 
> > http://lists.oasis-open.org/archives/docbook-apps/200405/msg00121.html
> > This attribute was meant to override the default in a few instances.
> >
> > Consider that we might want to change the xrefstyle at later point in time.
> >
> 
> Yep, everything I do is with the thought that style can and will change 
> in the future.
> 
> >>   All fields in the
> >>   structure are initialized to zero.  If insufficient memory is available,
> >>   NULL is returned.  The results of this routine can be released
> >> -usingXFree.
> >> +using >> targetptr='XFree'>XFree.
> > I assume that libX11 xfree will be changed to XFree.
> 
> Yep.
> 
> 
> >>   
> >>
> >> -
> >> +
> >>   
> >> StatusXScreenSaverQueryInfo
> >>   Display*display
> >> @@ -795,7 +795,7 @@ description of the fields.  If the extension is not 
> >> supported,
> >>   is returned.
> >>   
> >>
> >> -
> >> +
> >>   
> >> voidXScreenSaverSelectInput
> >>   Display*display
> >> @@ -832,7 +832,7 @@ See the definition of the
> >>   of the allowed event masks.
> >>   
> >>
> >> -
> >> +
> >>   
> >> voidXScreenSaverSetAttributes
> >>   Display*dpy
> >> @@ -858,7 +858,7 @@ of theScreenSaverSetAttributes  
> >> request for a
> >>   description of each of the arguments.
> >>   
> >>
> >> -
> >> +
> >>   
> >> voidXScreenSaverUnsetAttributes
> >>   Display*display
> >> @@ -872,7 +872,7 @@ extension, this routine instructs the server to discard
> >>   any previous screen saver window attributes set by this client.
> >>   
> >>
> >> -
> >> +
> >>   
> >> StatusXScreenSaverRegister
> >>   Display*display
> >> @@ -891,7 +891,7 @@ is encountered and the property is not changed, 
> >> otherwise it returns
> >>   non-zero.
> >>   
> >>
> >> -
> >> +
> >>   
> >> StatusXScreenSaverUnregister
> >>   Display*display
> >> @@ -906,7 +906,7 @@ It returns zero if an error is encountered and the 
> >> property is changed,
> >>   otherwise it returns non-zero.
> >>   
> >>
> >> -
> >> +
> >>   
> >> StatusXScreenSaverGetRegistered
> >>   Display*display
> >
> >
> 

Reviewed-by: Gaetan Nadon 


signature.asc
Description: This is a digitally signed message part
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH: scrnsaverproto] Fix id attributes, linkend and olinks

2011-09-27 Thread Gaetan Nadon
On Mon, 2011-09-26 at 19:03 -0600, Matt Dew wrote:

> 
> 
> > Are you considering adding "xrefstyle" with pageabbrev to all xref links?
> > If so, consider this suggestion to put it in the customization layer.
> > http://lists.oasis-open.org/archives/docbook-apps/200405/msg00121.html
> > This attribute was meant to override the default in a few instances.
> >
> > Consider that we might want to change the xrefstyle at later point in time
> 
> After looking into it some more and thinking about it, here's what I'm 
> thinking.
> 
> External links = olink
> internal links = xref
> 
> xrefs and olinks,  there's a docbook 5 path. It requires some sed-lovin' 
> no matter what we do.
> 
> I like that we can style xrefs. Should we, at some point in the future, 
> decide xref is a pain and we'd prefer link,  it's sed-able. No great pain.
> 
> If no objections, this is the path I'm going,

It looks like the best solution to me. Have a look at the Apache docs.
They use olinks and it'd be interesting to see what they use for
internal links.

> Matt
> 




signature.asc
Description: This is a digitally signed message part
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel