[jira] [Moved] (YARN-4959) MiniYARNCluster should implement AutoCloseable

2016-04-13 Thread John Zhuge (JIRA)

 [ 
https://issues.apache.org/jira/browse/YARN-4959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Zhuge moved HDFS-10288 to YARN-4959:
-

 Assignee: (was: John Zhuge)
Affects Version/s: (was: 2.7.0)
   2.7.0
 Target Version/s: 2.8.0  (was: 2.8.0)
  Component/s: (was: test)
   test
  Key: YARN-4959  (was: HDFS-10288)
  Project: Hadoop YARN  (was: Hadoop HDFS)

> MiniYARNCluster should implement AutoCloseable
> --
>
> Key: YARN-4959
> URL: https://issues.apache.org/jira/browse/YARN-4959
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: test
>Affects Versions: 2.7.0
>Reporter: John Zhuge
>Priority: Trivial
>
> {{MiniYARNCluster}} should implement {{AutoCloseable}} in order to support 
> [try-with-resources|https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html].
>  It will make test code a little cleaner and more reliable.
> Since {{AutoCloseable}} is only in Java 1.7 or later, this can not be 
> backported to Hadoop version prior to 2.7.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (YARN-4959) MiniYARNCluster should implement AutoCloseable

2016-04-25 Thread John Zhuge (JIRA)

 [ 
https://issues.apache.org/jira/browse/YARN-4959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Zhuge resolved YARN-4959.
--
   Resolution: Not A Problem
Fix Version/s: 2.7.0

Already supported because:
* {{MiniYARNCluster}} inherits from {{CompositeService}} => {{AbstractService}} 
=> {{Service}} => {{Closeable}} => {{AutoCloseable}}.
* {{AbstractService.close}} calls {{stop}} which calls {{serviceStop}}.
* {{MiniYARNCluster}} performs cleanup in its overridden {{serviceStop}}

Thanks, [~boky01], for point it out in a comment for HDFS-10287.

> MiniYARNCluster should implement AutoCloseable
> --
>
> Key: YARN-4959
> URL: https://issues.apache.org/jira/browse/YARN-4959
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: test
>Affects Versions: 2.7.0
>Reporter: John Zhuge
>Priority: Trivial
> Fix For: 2.7.0
>
>
> {{MiniYARNCluster}} should implement {{AutoCloseable}} in order to support 
> [try-with-resources|https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html].
>  It will make test code a little cleaner and more reliable.
> Since {{AutoCloseable}} is only in Java 1.7 or later, this can not be 
> backported to Hadoop version prior to 2.7.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-4994) Use MiniYARNCluster with try-with-resources in tests

2016-04-26 Thread John Zhuge (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258340#comment-15258340
 ] 

John Zhuge commented on YARN-4994:
--

Sure. A little busy now, may get to it tomorrow afternoon. If not, then next 
Monday.

Other reviewers feel free to jump in.

> Use MiniYARNCluster with try-with-resources in tests
> 
>
> Key: YARN-4994
> URL: https://issues.apache.org/jira/browse/YARN-4994
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: test
>Affects Versions: 2.7.0
>Reporter: Andras Bokor
>Assignee: Andras Bokor
>Priority: Trivial
> Fix For: 2.7.0
>
> Attachments: HDFS-10287.01.patch
>
>
> In tests MiniYARNCluster is used with the following pattern:
> In try-catch block create a MiniYARNCluster instance and in finally block 
> close it.
> [Try-with-resources|https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html]
>  is preferred since Java7 instead of the pattern above.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-4994) Use MiniYARNCluster with try-with-resources in tests

2016-05-02 Thread John Zhuge (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266958#comment-15266958
 ] 

John Zhuge commented on YARN-4994:
--

Nice work, [~boky01].

TestHadoopArchiveLogsRunner.java:
* 134-136: put {{fs}} into try clause since it is {{AutoCloseable}}.

TestHedgingRequestRMFailoverProxyProvider.java
* 43: any change?
* 45: any change?

TestAMRMProxy.java
* 163-165, 241-243, 282-284: put {{rmClient}} into try clause since it is 
{{AutoCloseable}}

TestYarnCLI.java
* 1583-1585: put {{yarnClient}} into try clause since it is {{AutoCloseable}}

TestMiniYarnCluster.java
* 45, 62, 91: javac errors, switch to non-deprecated constructor?


> Use MiniYARNCluster with try-with-resources in tests
> 
>
> Key: YARN-4994
> URL: https://issues.apache.org/jira/browse/YARN-4994
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: test
>Affects Versions: 2.7.0
>Reporter: Andras Bokor
>Assignee: Andras Bokor
>Priority: Trivial
> Fix For: 2.7.0
>
> Attachments: HDFS-10287.01.patch, HDFS-10287.02.patch, 
> HDFS-10287.03.patch
>
>
> In tests MiniYARNCluster is used with the following pattern:
> In try-catch block create a MiniYARNCluster instance and in finally block 
> close it.
> [Try-with-resources|https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html]
>  is preferred since Java7 instead of the pattern above.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-4994) Use MiniYARNCluster with try-with-resources in tests

2016-05-03 Thread John Zhuge (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268376#comment-15268376
 ] 

John Zhuge commented on YARN-4994:
--

bq. Last week I created a new JIRA ticket to follow up this. Please check 
YARN-5007. Is it fine with you if I resolve it with the ticket I linked?
Good plan.

Unit test failures may be unrelated. To be sure, run the same tests on a clean 
tree before your patch. BTW, I do hit test errors in TestYarnClient, 
TestGetGroups, and TestAMRMProxy on Ubuntu 14.04.

> Use MiniYARNCluster with try-with-resources in tests
> 
>
> Key: YARN-4994
> URL: https://issues.apache.org/jira/browse/YARN-4994
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: test
>Affects Versions: 2.7.0
>Reporter: Andras Bokor
>Assignee: Andras Bokor
>Priority: Trivial
> Fix For: 2.7.0
>
> Attachments: HDFS-10287.01.patch, HDFS-10287.02.patch, 
> HDFS-10287.03.patch
>
>
> In tests MiniYARNCluster is used with the following pattern:
> In try-catch block create a MiniYARNCluster instance and in finally block 
> close it.
> [Try-with-resources|https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html]
>  is preferred since Java7 instead of the pattern above.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-4994) Use MiniYARNCluster with try-with-resources in tests

2016-05-06 Thread John Zhuge (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274332#comment-15274332
 ] 

John Zhuge commented on YARN-4994:
--

Could you rename the patches from HDFS-10287.* to YARN-4994.*?

Let me try patch 03 again.

> Use MiniYARNCluster with try-with-resources in tests
> 
>
> Key: YARN-4994
> URL: https://issues.apache.org/jira/browse/YARN-4994
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: test
>Affects Versions: 2.7.0
>Reporter: Andras Bokor
>Assignee: Andras Bokor
>Priority: Trivial
> Fix For: 2.7.0
>
> Attachments: HDFS-10287.01.patch, HDFS-10287.02.patch, 
> HDFS-10287.03.patch
>
>
> In tests MiniYARNCluster is used with the following pattern:
> In try-catch block create a MiniYARNCluster instance and in finally block 
> close it.
> [Try-with-resources|https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html]
>  is preferred since Java7 instead of the pattern above.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Created] (YARN-5054) Remove redundent TestMiniDFSCluster.testDualClusters

2016-05-06 Thread John Zhuge (JIRA)
John Zhuge created YARN-5054:


 Summary: Remove redundent TestMiniDFSCluster.testDualClusters
 Key: YARN-5054
 URL: https://issues.apache.org/jira/browse/YARN-5054
 Project: Hadoop YARN
  Issue Type: Test
  Components: test
Affects Versions: 2.6.0
Reporter: John Zhuge
Priority: Trivial


Unit test {{TestMiniDFSCluster.testDualClusters}} is redundant because 
{{testClusterWithoutSystemProperties}} already proves 
{{cluster.getDataDirectory() == getProp(HDFS_MINIDFS_BASEDIR) + "/data"}}. This 
unit test sets HDFS_MINIDFS_BASEDIR to 2 different values and brings up 2 
clusters, of course they will have different data directory.

Remove it to save the time to bring up 2 mini clusters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Resolved] (YARN-5054) Remove redundent TestMiniDFSCluster.testDualClusters

2016-05-06 Thread John Zhuge (JIRA)

 [ 
https://issues.apache.org/jira/browse/YARN-5054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Zhuge resolved YARN-5054.
--
Resolution: Invalid

Move to HDFS project.

> Remove redundent TestMiniDFSCluster.testDualClusters
> 
>
> Key: YARN-5054
> URL: https://issues.apache.org/jira/browse/YARN-5054
> Project: Hadoop YARN
>  Issue Type: Test
>  Components: test
>Affects Versions: 2.6.0
>Reporter: John Zhuge
>Priority: Trivial
>  Labels: newbie
>
> Unit test {{TestMiniDFSCluster.testDualClusters}} is redundant because 
> {{testClusterWithoutSystemProperties}} already proves 
> {{cluster.getDataDirectory() == getProp(HDFS_MINIDFS_BASEDIR) + "/data"}}. 
> This unit test sets HDFS_MINIDFS_BASEDIR to 2 different values and brings up 
> 2 clusters, of course they will have different data directory.
> Remove it to save the time to bring up 2 mini clusters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-4994) Use MiniYARNCluster with try-with-resources in tests

2016-05-06 Thread John Zhuge (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274420#comment-15274420
 ] 

John Zhuge commented on YARN-4994:
--

TestGetGroups is known to fail: YARN-4351. Tests in h.y.c.TestGetGroups get 
failed on trunk.

> Use MiniYARNCluster with try-with-resources in tests
> 
>
> Key: YARN-4994
> URL: https://issues.apache.org/jira/browse/YARN-4994
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: test
>Affects Versions: 2.7.0
>Reporter: Andras Bokor
>Assignee: Andras Bokor
>Priority: Trivial
> Fix For: 2.7.0
>
> Attachments: HDFS-10287.01.patch, HDFS-10287.02.patch, 
> HDFS-10287.03.patch
>
>
> In tests MiniYARNCluster is used with the following pattern:
> In try-catch block create a MiniYARNCluster instance and in finally block 
> close it.
> [Try-with-resources|https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html]
>  is preferred since Java7 instead of the pattern above.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-4994) Use MiniYARNCluster with try-with-resources in tests

2016-05-06 Thread John Zhuge (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274437#comment-15274437
 ] 

John Zhuge commented on YARN-4994:
--

YARN-4982 Test timeout :yarn-client testcase timeout and failures" seems to 
have a fix for these failures.

> Use MiniYARNCluster with try-with-resources in tests
> 
>
> Key: YARN-4994
> URL: https://issues.apache.org/jira/browse/YARN-4994
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: test
>Affects Versions: 2.7.0
>Reporter: Andras Bokor
>Assignee: Andras Bokor
>Priority: Trivial
> Fix For: 2.7.0
>
> Attachments: HDFS-10287.01.patch, HDFS-10287.02.patch, 
> HDFS-10287.03.patch
>
>
> In tests MiniYARNCluster is used with the following pattern:
> In try-catch block create a MiniYARNCluster instance and in finally block 
> close it.
> [Try-with-resources|https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html]
>  is preferred since Java7 instead of the pattern above.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-5034) Failing tests after using try-with-resources

2016-05-06 Thread John Zhuge (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-5034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274481#comment-15274481
 ] 

John Zhuge commented on YARN-5034:
--

A dup of YARN-4982. To confirm, run the tests on a clean trunk.

> Failing tests after using try-with-resources
> 
>
> Key: YARN-5034
> URL: https://issues.apache.org/jira/browse/YARN-5034
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: test
>Affects Versions: 2.7.0
>Reporter: Andras Bokor
>Assignee: Andras Bokor
>Priority: Trivial
> Fix For: 2.7.0
>
> Attachments: YARN-5034.01.patch, YARN-5034.02.patch, 
> YARN-5034.03.patch, YARN-5034.04.patch, YARN-5034.05.patch, 
> YARN-5034.06.patch, YARN-5034.07.patch, YARN-5034.08.patch, 
> YARN-5034.09.patch, YARN-5034.10.patch, YARN-5034.11.patch, 
> YARN-5034.12.patch, YARN-5034.13.patch
>
>
> This JIRA for following up failing tests. I am not able to reproduce locally 
> neither on mac nor CentOS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-4351) Tests in h.y.c.TestGetGroups get failed on trunk

2016-05-06 Thread John Zhuge (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274502#comment-15274502
 ] 

John Zhuge commented on YARN-4351:
--

Dup to YARN-4982? Its patch 0003 fixes TestGetGroups failure. I am not sure 
whether it is the same failure because the test report link in Description is 
no longer valid.

> Tests in h.y.c.TestGetGroups get failed on trunk
> 
>
> Key: YARN-4351
> URL: https://issues.apache.org/jira/browse/YARN-4351
> Project: Hadoop YARN
>  Issue Type: Test
>  Components: test
>Reporter: Junping Du
>
> From test report: 
> https://builds.apache.org/job/PreCommit-YARN-Build/9661/testReport/, we can 
> see there are several test failures for TestGetGroups.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-4982) Test timeout :yarn-client testcase timeout and failures

2016-05-06 Thread John Zhuge (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274586#comment-15274586
 ] 

John Zhuge commented on YARN-4982:
--

[~bibinchundatt], in TestAMRMClient.java#732 of patch 0003: Why increase the 
timeout from 30s to 300s?

> Test timeout :yarn-client testcase timeout and failures
> ---
>
> Key: YARN-4982
> URL: https://issues.apache.org/jira/browse/YARN-4982
> Project: Hadoop YARN
>  Issue Type: Test
>  Components: test
>Reporter: Bibin A Chundatt
>Priority: Blocker
> Attachments: 0001-YARN-4982.patch, 0002-YARN-4982.patch, 
> 0003-YARN-4982.patch
>
>
> https://builds.apache.org/job/PreCommit-YARN-Build/11088/testReport/junit/org.apache.hadoop.yarn.client.api.impl/TestAMRMProxy/testAMRMProxyE2E/
> In hadoop-yarn-client package test {{TestAMRMProxy}} testcase timeout always
> {noformat}
> java.lang.Exception: test timed out after 6 milliseconds
>   at java.lang.Thread.sleep(Native Method)
>   at 
> org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:160)
>   at com.sun.proxy.$Proxy85.getNewApplication(Unknown Source)
>   at 
> org.apache.hadoop.yarn.client.api.impl.YarnClientImpl.getNewApplication(YarnClientImpl.java:227)
>   at 
> org.apache.hadoop.yarn.client.api.impl.YarnClientImpl.createApplication(YarnClientImpl.java:235)
>   at 
> org.apache.hadoop.yarn.client.api.impl.TestAMRMProxy.createApp(TestAMRMProxy.java:367)
>   at 
> org.apache.hadoop.yarn.client.api.impl.TestAMRMProxy.testAMRMProxyE2E(TestAMRMProxy.java:110)
> {noformat}
> Other classes having similar failures
> org.apache.hadoop.yarn.client.cli.TestYarnCLI
> org.apache.hadoop.yarn.client.api.impl.TestYarnClient
> org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
> org.apache.hadoop.yarn.client.api.impl.TestNMClien



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-4994) Use MiniYARNCluster with try-with-resources in tests

2016-05-10 Thread John Zhuge (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278664#comment-15278664
 ] 

John Zhuge commented on YARN-4994:
--

I will take a quick look. Thanks for the great work!

John Zhuge
Software Engineer, Cloudera

On Tue, May 10, 2016 at 11:22 AM, Andras Bokor (JIRA) 



> Use MiniYARNCluster with try-with-resources in tests
> 
>
> Key: YARN-4994
> URL: https://issues.apache.org/jira/browse/YARN-4994
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: test
>Affects Versions: 2.7.0
>Reporter: Andras Bokor
>Assignee: Andras Bokor
>Priority: Trivial
> Fix For: 2.7.0
>
> Attachments: HDFS-10287.01.patch, HDFS-10287.02.patch, 
> HDFS-10287.03.patch, YARN-4994.04.patch, YARN-4994.05.patch, 
> YARN-4994.06.patch, YARN-4994.07.patch
>
>
> In tests MiniYARNCluster is used with the following pattern:
> In try-catch block create a MiniYARNCluster instance and in finally block 
> close it.
> [Try-with-resources|https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html]
>  is preferred since Java7 instead of the pattern above.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-4994) Use MiniYARNCluster with try-with-resources in tests

2016-05-10 Thread John Zhuge (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278894#comment-15278894
 ] 

John Zhuge commented on YARN-4994:
--

+1 LGTM

javac warnings:
* YARN-5007 to fix the deprecated warnings

checkstyle warnings:
* Ignore the warning about 
{{TestJobHistoryEventHandler#testTimelineEventHandling}} being longer than 150 
lines. Leave it to the next poor soul. If you are really in the mood, you can 
get it down to 150 by replacing {{tEntity.getEvents()}} with a var {{events}}.

Unit test failures:
* TestAMRMProxy: same failures on a clean stock build, so ignore.
* Other failures: unrelated to the changes.

> Use MiniYARNCluster with try-with-resources in tests
> 
>
> Key: YARN-4994
> URL: https://issues.apache.org/jira/browse/YARN-4994
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: test
>Affects Versions: 2.7.0
>Reporter: Andras Bokor
>Assignee: Andras Bokor
>Priority: Trivial
> Fix For: 2.7.0
>
> Attachments: HDFS-10287.01.patch, HDFS-10287.02.patch, 
> HDFS-10287.03.patch, YARN-4994.04.patch, YARN-4994.05.patch, 
> YARN-4994.06.patch, YARN-4994.07.patch
>
>
> In tests MiniYARNCluster is used with the following pattern:
> In try-catch block create a MiniYARNCluster instance and in finally block 
> close it.
> [Try-with-resources|https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html]
>  is preferred since Java7 instead of the pattern above.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Updated] (YARN-4994) Use MiniYARNCluster with try-with-resources in tests

2016-05-10 Thread John Zhuge (JIRA)

 [ 
https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Zhuge updated YARN-4994:
-
Hadoop Flags: Reviewed

> Use MiniYARNCluster with try-with-resources in tests
> 
>
> Key: YARN-4994
> URL: https://issues.apache.org/jira/browse/YARN-4994
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: test
>Affects Versions: 2.7.0
>Reporter: Andras Bokor
>Assignee: Andras Bokor
>Priority: Trivial
> Fix For: 2.7.0
>
> Attachments: HDFS-10287.01.patch, HDFS-10287.02.patch, 
> HDFS-10287.03.patch, YARN-4994.04.patch, YARN-4994.05.patch, 
> YARN-4994.06.patch, YARN-4994.07.patch
>
>
> In tests MiniYARNCluster is used with the following pattern:
> In try-catch block create a MiniYARNCluster instance and in finally block 
> close it.
> [Try-with-resources|https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html]
>  is preferred since Java7 instead of the pattern above.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-5007) MiniYarnCluster contains deprecated constructor which is called by the other constructors

2016-05-19 Thread John Zhuge (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292245#comment-15292245
 ] 

John Zhuge commented on YARN-5007:
--

Like your idea of including MiniMRYarnCluster and MiniYarnCluster in this JIRA 
and MiniDFSCluster in another in HDFS project.

Another con of lumping everything in one patch, especially across components: 
much tougher to pass unit tests. Remember we struggled to overcome this 
obstacle in YARN-4994? :(

> MiniYarnCluster contains deprecated constructor which is called by the other 
> constructors
> -
>
> Key: YARN-5007
> URL: https://issues.apache.org/jira/browse/YARN-5007
> Project: Hadoop YARN
>  Issue Type: Test
>  Components: timelineserver
>Affects Versions: 2.6.0
>Reporter: Andras Bokor
>Assignee: Andras Bokor
>Priority: Minor
> Fix For: 2.8.0
>
>
> MiniYarnCluster has a deprecated constructor which is called by the other 
> constructors and it causes javac warnings during the build.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-5777) TestLogsCLI#testFetchApplictionLogsAsAnotherUser fails

2016-10-25 Thread John Zhuge (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-5777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15606081#comment-15606081
 ] 

John Zhuge commented on YARN-5777:
--

+1 (non-binding) The change looks good to me. Thanks [~ajisakaa] for 
investigation and fix.

> TestLogsCLI#testFetchApplictionLogsAsAnotherUser fails
> --
>
> Key: YARN-5777
> URL: https://issues.apache.org/jira/browse/YARN-5777
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: test
>Reporter: Akira Ajisaka
>Assignee: Akira Ajisaka
> Attachments: YARN-5777.01.patch
>
>
> {noformat}
> Running org.apache.hadoop.yarn.client.cli.TestLogsCLI
> Tests run: 14, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 5.876 sec 
> <<< FAILURE! - in org.apache.hadoop.yarn.client.cli.TestLogsCLI
> testFetchApplictionLogsAsAnotherUser(org.apache.hadoop.yarn.client.cli.TestLogsCLI)
>   Time elapsed: 0.199 sec  <<< ERROR!
> java.io.IOException: Invalid directory or I/O error occurred for dir: 
> /Users/aajisaka/git/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/target/logs/priority/logs/application_1477371285256_1000
> at org.apache.hadoop.fs.FileUtil.list(FileUtil.java:1148)
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.listStatus(RawLocalFileSystem.java:469)
> at 
> org.apache.hadoop.fs.DelegateToFileSystem.listStatus(DelegateToFileSystem.java:169)
> at org.apache.hadoop.fs.ChecksumFs.listStatus(ChecksumFs.java:519)
> at 
> org.apache.hadoop.fs.AbstractFileSystem$1.(AbstractFileSystem.java:890)
> at 
> org.apache.hadoop.fs.AbstractFileSystem.listStatusIterator(AbstractFileSystem.java:888)
> at org.apache.hadoop.fs.FileContext$22.next(FileContext.java:1492)
> at org.apache.hadoop.fs.FileContext$22.next(FileContext.java:1487)
> at org.apache.hadoop.fs.FSLinkResolver.resolve(FSLinkResolver.java:90)
> at org.apache.hadoop.fs.FileContext.listStatus(FileContext.java:1494)
> at 
> org.apache.hadoop.yarn.logaggregation.LogCLIHelpers.getRemoteNodeFileDir(LogCLIHelpers.java:592)
> at 
> org.apache.hadoop.yarn.logaggregation.LogCLIHelpers.dumpAllContainersLogs(LogCLIHelpers.java:348)
> at 
> org.apache.hadoop.yarn.client.cli.LogsCLI.fetchApplicationLogs(LogsCLI.java:971)
> at 
> org.apache.hadoop.yarn.client.cli.LogsCLI.runCommand(LogsCLI.java:299)
> at org.apache.hadoop.yarn.client.cli.LogsCLI.run(LogsCLI.java:106)
> at 
> org.apache.hadoop.yarn.client.cli.TestLogsCLI.testFetchApplictionLogsAsAnotherUser(TestLogsCLI.java:868)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Created] (YARN-7002) branch-2 build is broken by AllocationFileLoaderService.java

2017-08-11 Thread John Zhuge (JIRA)
John Zhuge created YARN-7002:


 Summary: branch-2 build is broken by 
AllocationFileLoaderService.java
 Key: YARN-7002
 URL: https://issues.apache.org/jira/browse/YARN-7002
 Project: Hadoop YARN
  Issue Type: Bug
  Components: resourcemanager
Affects Versions: 2.9.0
Reporter: John Zhuge


branch-2 build is broken:
{noformat}
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on 
project hadoop-yarn-server-resourcemanager: Compilation failure
[ERROR] 
/Users/jzhuge/hadoop-commit/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java:[270,39]
 incompatible types: java.util.HashSet cannot be converted to 
java.util.Set

{noformat}




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-7002) branch-2 build is broken by AllocationFileLoaderService.java

2017-08-11 Thread John Zhuge (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-7002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124470#comment-16124470
 ] 

John Zhuge commented on YARN-7002:
--

Thanks for the quick fix [~templedf].

> branch-2 build is broken by AllocationFileLoaderService.java
> 
>
> Key: YARN-7002
> URL: https://issues.apache.org/jira/browse/YARN-7002
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: resourcemanager
>Affects Versions: 2.9.0
>Reporter: John Zhuge
>Assignee: Daniel Templeton
>
> branch-2 build is broken:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) 
> on project hadoop-yarn-server-resourcemanager: Compilation failure
> [ERROR] 
> /Users/jzhuge/hadoop-commit/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java:[270,39]
>  incompatible types: java.util.HashSet cannot be converted 
> to java.util.Set
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Created] (YARN-6501) FSSchedulerNode.java failed to build with JDK7

2017-04-19 Thread John Zhuge (JIRA)
John Zhuge created YARN-6501:


 Summary: FSSchedulerNode.java failed to build with JDK7
 Key: YARN-6501
 URL: https://issues.apache.org/jira/browse/YARN-6501
 Project: Hadoop YARN
  Issue Type: Bug
  Components: resourcemanager
Affects Versions: 2.9.0
Reporter: John Zhuge


{noformat}
[ERROR] 
/Users/jzhuge/hadoop-commit/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java:[183,18]
 cannot find symbol
[ERROR] symbol:   method 
putIfAbsent(org.apache.hadoop.yarn.api.records.ApplicationAttemptId,org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSAppAttempt)
[ERROR] location: variable appIdToAppMap of type 
java.util.Map
[ERROR] 
/Users/jzhuge/hadoop-commit/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java:[184,29]
 cannot find symbol
[ERROR] symbol:   method 
putIfAbsent(org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSAppAttempt,org.apache.hadoop.yarn.api.records.Resource)
[ERROR] location: variable resourcesPreemptedForApp of type 
java.util.Map
{noformat}

{{Map#putIfAbsent}} is introduced in JDK8.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-6432) FairScheduler: Reserve preempted resources for corresponding applications

2017-04-19 Thread John Zhuge (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975905#comment-15975905
 ] 

John Zhuge commented on YARN-6432:
--

[~kasha] {{FSSchedulerNode.java}} failed to build with JDK7 in branch-2, 
{{Map#putIfAbsent}} is introduced in JDK8. Tracked in YARN-6501. I am surprised 
there is no JDK7 post-commit build.

> FairScheduler: Reserve preempted resources for corresponding applications
> -
>
> Key: YARN-6432
> URL: https://issues.apache.org/jira/browse/YARN-6432
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Miklos Szegedi
>Assignee: Miklos Szegedi
> Fix For: 2.9.0, 3.0.0-alpha3
>
> Attachments: YARN-6432.000.patch, YARN-6432.001.patch, 
> YARN-6432.002.patch, YARN-6432.branch-2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Assigned] (YARN-6501) FSSchedulerNode.java failed to build with JDK7

2017-04-19 Thread John Zhuge (JIRA)

 [ 
https://issues.apache.org/jira/browse/YARN-6501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Zhuge reassigned YARN-6501:


Assignee: John Zhuge

> FSSchedulerNode.java failed to build with JDK7
> --
>
> Key: YARN-6501
> URL: https://issues.apache.org/jira/browse/YARN-6501
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: resourcemanager
>Affects Versions: 2.9.0
>Reporter: John Zhuge
>Assignee: John Zhuge
>
> {noformat}
> [ERROR] 
> /Users/jzhuge/hadoop-commit/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java:[183,18]
>  cannot find symbol
> [ERROR] symbol:   method 
> putIfAbsent(org.apache.hadoop.yarn.api.records.ApplicationAttemptId,org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSAppAttempt)
> [ERROR] location: variable appIdToAppMap of type 
> java.util.Map
> [ERROR] 
> /Users/jzhuge/hadoop-commit/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java:[184,29]
>  cannot find symbol
> [ERROR] symbol:   method 
> putIfAbsent(org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSAppAttempt,org.apache.hadoop.yarn.api.records.Resource)
> [ERROR] location: variable resourcesPreemptedForApp of type 
> java.util.Map
> {noformat}
> {{Map#putIfAbsent}} is introduced in JDK8.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Updated] (YARN-6501) FSSchedulerNode.java fails to compile with JDK7

2017-04-19 Thread John Zhuge (JIRA)

 [ 
https://issues.apache.org/jira/browse/YARN-6501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Zhuge updated YARN-6501:
-
Summary: FSSchedulerNode.java fails to compile with JDK7  (was: 
FSSchedulerNode.java failed to build with JDK7)

> FSSchedulerNode.java fails to compile with JDK7
> ---
>
> Key: YARN-6501
> URL: https://issues.apache.org/jira/browse/YARN-6501
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: resourcemanager
>Affects Versions: 2.9.0
>Reporter: John Zhuge
>Assignee: John Zhuge
>
> {noformat}
> [ERROR] 
> /Users/jzhuge/hadoop-commit/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java:[183,18]
>  cannot find symbol
> [ERROR] symbol:   method 
> putIfAbsent(org.apache.hadoop.yarn.api.records.ApplicationAttemptId,org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSAppAttempt)
> [ERROR] location: variable appIdToAppMap of type 
> java.util.Map
> [ERROR] 
> /Users/jzhuge/hadoop-commit/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java:[184,29]
>  cannot find symbol
> [ERROR] symbol:   method 
> putIfAbsent(org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSAppAttempt,org.apache.hadoop.yarn.api.records.Resource)
> [ERROR] location: variable resourcesPreemptedForApp of type 
> java.util.Map
> {noformat}
> {{Map#putIfAbsent}} is introduced in JDK8.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Updated] (YARN-6501) FSSchedulerNode.java fails to compile with JDK7

2017-04-19 Thread John Zhuge (JIRA)

 [ 
https://issues.apache.org/jira/browse/YARN-6501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Zhuge updated YARN-6501:
-
Attachment: YARN-6501.branch-2.001.patch

Patch branch-2.001
* Replace {{putIfAbsent}} with "get(), check {{v == null}}, then put()", as the 
default implementation of {{putIfAbsent}} described in JDK8 doc
* No synchronization necessary

> FSSchedulerNode.java fails to compile with JDK7
> ---
>
> Key: YARN-6501
> URL: https://issues.apache.org/jira/browse/YARN-6501
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: resourcemanager
>Affects Versions: 2.9.0
>Reporter: John Zhuge
>Assignee: John Zhuge
> Attachments: YARN-6501.branch-2.001.patch
>
>
> {noformat}
> [ERROR] 
> /Users/jzhuge/hadoop-commit/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java:[183,18]
>  cannot find symbol
> [ERROR] symbol:   method 
> putIfAbsent(org.apache.hadoop.yarn.api.records.ApplicationAttemptId,org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSAppAttempt)
> [ERROR] location: variable appIdToAppMap of type 
> java.util.Map
> [ERROR] 
> /Users/jzhuge/hadoop-commit/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java:[184,29]
>  cannot find symbol
> [ERROR] symbol:   method 
> putIfAbsent(org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSAppAttempt,org.apache.hadoop.yarn.api.records.Resource)
> [ERROR] location: variable resourcesPreemptedForApp of type 
> java.util.Map
> {noformat}
> {{Map#putIfAbsent}} is introduced in JDK8.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-6432) FairScheduler: Reserve preempted resources for corresponding applications

2017-04-19 Thread John Zhuge (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976037#comment-15976037
 ] 

John Zhuge commented on YARN-6432:
--

No problem [~miklos.szeg...@cloudera.com].

In the addendum patch, you probably should use the following code as specified 
by by [Map#putIfAbsent JDK8 
doc|https://docs.oracle.com/javase/8/docs/api/java/util/Map.html#putIfAbsent-K-V-]
bq. If the specified key is not already associated with a value (or is mapped 
to null)..."
{code}
  if (get(key) == null) {
put(key, value);
  }
{code}

You can see [my patch posted to 
YARN-6501|https://issues.apache.org/jira/secure/attachment/12864183/YARN-6501.branch-2.001.patch].

> FairScheduler: Reserve preempted resources for corresponding applications
> -
>
> Key: YARN-6432
> URL: https://issues.apache.org/jira/browse/YARN-6432
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Miklos Szegedi
>Assignee: Miklos Szegedi
> Fix For: 2.9.0, 3.0.0-alpha3
>
> Attachments: YARN-6432.000.patch, YARN-6432.001.patch, 
> YARN-6432.002.patch, YARN-6432.branch-2.addendum.patch, 
> YARN-6432.branch-2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-6432) FairScheduler: Reserve preempted resources for corresponding applications

2017-04-19 Thread John Zhuge (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976118#comment-15976118
 ] 

John Zhuge commented on YARN-6432:
--

Sounds good [~miklos.szeg...@cloudera.com].

> FairScheduler: Reserve preempted resources for corresponding applications
> -
>
> Key: YARN-6432
> URL: https://issues.apache.org/jira/browse/YARN-6432
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Miklos Szegedi
>Assignee: Miklos Szegedi
> Fix For: 2.9.0, 3.0.0-alpha3
>
> Attachments: YARN-6432.000.patch, YARN-6432.001.patch, 
> YARN-6432.002.patch, YARN-6432.branch-2.addendum.patch, 
> YARN-6432.branch-2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-6501) FSSchedulerNode.java fails to compile with JDK7

2017-04-20 Thread John Zhuge (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-6501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977025#comment-15977025
 ] 

John Zhuge commented on YARN-6501:
--

Thanks [~jlowe] for the review and commit. Thanks [~ajisakaa] and 
[~miklos.szeg...@cloudera.com] for the review and discussion. It is my first 
YARN commit :)

> FSSchedulerNode.java fails to compile with JDK7
> ---
>
> Key: YARN-6501
> URL: https://issues.apache.org/jira/browse/YARN-6501
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: resourcemanager
>Affects Versions: 2.9.0
>Reporter: John Zhuge
>Assignee: John Zhuge
> Fix For: 2.9.0
>
> Attachments: YARN-6501.branch-2.001.patch
>
>
> {noformat}
> [ERROR] 
> /Users/jzhuge/hadoop-commit/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java:[183,18]
>  cannot find symbol
> [ERROR] symbol:   method 
> putIfAbsent(org.apache.hadoop.yarn.api.records.ApplicationAttemptId,org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSAppAttempt)
> [ERROR] location: variable appIdToAppMap of type 
> java.util.Map
> [ERROR] 
> /Users/jzhuge/hadoop-commit/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSSchedulerNode.java:[184,29]
>  cannot find symbol
> [ERROR] symbol:   method 
> putIfAbsent(org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSAppAttempt,org.apache.hadoop.yarn.api.records.Resource)
> [ERROR] location: variable resourcesPreemptedForApp of type 
> java.util.Map
> {noformat}
> {{Map#putIfAbsent}} is introduced in JDK8.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-5007) Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster

2017-04-24 Thread John Zhuge (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982364#comment-15982364
 ] 

John Zhuge commented on YARN-5007:
--

If 3.0 is not a good time to remove deprecated method, when is a good time?

Maybe the method should not have been marked as {{deprecated}}?

> Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
> ---
>
> Key: YARN-5007
> URL: https://issues.apache.org/jira/browse/YARN-5007
> Project: Hadoop YARN
>  Issue Type: Test
>Reporter: Andras Bokor
>Assignee: Andras Bokor
>  Labels: oct16-easy
> Fix For: 3.0.0-alpha3
>
> Attachments: YARN-5007.01.patch, YARN-5007.02.patch, 
> YARN-5007.03.patch
>
>
> MiniYarnCluster has a deprecated constructor which is called by the other 
> constructors and it causes javac warnings during the build.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-5007) Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster

2017-04-25 Thread John Zhuge (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982939#comment-15982939
 ] 

John Zhuge commented on YARN-5007:
--

+1 Thanks [~boky01] and [~ajisakaa] for the clarification.

> Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
> ---
>
> Key: YARN-5007
> URL: https://issues.apache.org/jira/browse/YARN-5007
> Project: Hadoop YARN
>  Issue Type: Test
>Reporter: Andras Bokor
>Assignee: Andras Bokor
>  Labels: oct16-easy
> Fix For: 3.0.0-alpha3
>
> Attachments: YARN-5007.01.patch, YARN-5007.02.patch, 
> YARN-5007.03.patch
>
>
> MiniYarnCluster has a deprecated constructor which is called by the other 
> constructors and it causes javac warnings during the build.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-7180) Remove class ResourceType

2017-10-09 Thread John Zhuge (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196599#comment-16196599
 ] 

John Zhuge commented on YARN-7180:
--

[~rohithsharma] hadoop-yarn-server-resourcemanager: Compilation failure
{noformat}
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on 
project hadoop-yarn-server-resourcemanager: Compilation failure: Compilation 
failure:
[ERROR] 
/Users/jzhuge/hadoop-commit/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairSchedulerConfiguration.java:[32,62]
 cannot find symbol
[ERROR] symbol:   class ResourceType
[ERROR] location: package org.apache.hadoop.yarn.server.resourcemanager.resource
[ERROR] 
/Users/jzhuge/hadoop-commit/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairSchedulerConfiguration.java:[316,46]
 cannot find symbol
[ERROR] symbol:   variable ResourceType
[ERROR] location: class 
org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairSchedulerConfiguration
[ERROR] 
/Users/jzhuge/hadoop-commit/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairSchedulerConfiguration.java:[320,27]
 cannot find symbol
[ERROR] symbol:   variable ResourceType
[ERROR] location: class 
org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairSchedulerConfiguration
{noformat}


> Remove class ResourceType
> -
>
> Key: YARN-7180
> URL: https://issues.apache.org/jira/browse/YARN-7180
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: resourcemanager, scheduler
>Reporter: Yufei Gu
>Assignee: Sunil G
> Fix For: 3.1.0
>
> Attachments: YARN-7180.001.patch
>
>
> org.apache.hadoop.yarn.server.resourcemanager.resource.ResourceType isn't 
> needed any more with the new resource type change.  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org