[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analog APIs
[ https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919170#comment-13919170 ] Mayank Bansal commented on YARN-1389: - Thanks [~zjshen] for the review bq. 1. ApplicationClientProtocol and ApplicationHistoryProtocol are able to share a base interface now? I think we decided we will keep the interfaces seprate. bq. 2. Javadoc in ApplicationHistoryProtocol says the data is obtained from AHS, which is not correct. Done bq. 3. YarnClientImpl misses the implementation for getting attempts/container/containers Done bq. 4. Users are not able to get completed application list via YarnClient Done bq. 5. Like RMApp, make createApplicationAttemptReport/ContainerReport as part of RMAppAttempt/RMContainer. These are just utility functions, do you think they are needed in RMAPPATtempt and RMContainer? Updating the latest patch. Thanks, Mayank ApplicationClientProtocol and ApplicationHistoryProtocol should expose analog APIs -- Key: YARN-1389 URL: https://issues.apache.org/jira/browse/YARN-1389 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Mayank Bansal Attachments: YARN-1389-1.patch, YARN-1389-2.patch As we plan to have the APIs in ApplicationHistoryProtocol to expose the reports of *finished* application attempts and containers, we should do the same for ApplicationClientProtocol, which will return the reports of *running* attempts and containers. Later on, we can improve YarnClient to direct the query of running instance to ApplicationClientProtocol, while that of finished instance to ApplicationHistoryProtocol, making it transparent to the users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analog APIs
[
https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919301#comment-13919301
]
Hadoop QA commented on YARN-1389:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12632479/YARN-1389-3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3239//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/3239//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3239//console
This message is automatically generated.
ApplicationClientProtocol and ApplicationHistoryProtocol should expose analog
APIs
--
Key: YARN-1389
URL: https://issues.apache.org/jira/browse/YARN-1389
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Mayank Bansal
Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch
As we plan to have the APIs in ApplicationHistoryProtocol to expose the
reports of *finished* application attempts and containers, we should do the
same for ApplicationClientProtocol, which will return the reports of
*running* attempts and containers.
Later on, we can improve YarnClient to direct the query of running instance
to ApplicationClientProtocol, while that of finished instance to
ApplicationHistoryProtocol, making it transparent to the users.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analog APIs
[
https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919732#comment-13919732
]
Zhijie Shen commented on YARN-1389:
---
Thanks for the new patch. Here're some more comments.
1. I still see codeApplicationHistoryServer/code in
ApplicationClientProtocol. And some description sounds not accurate. For
example,
{code}
+ * p
+ * The interface used by clients to get a report of all Application attempts
+ * in the cluster from the codeApplicationHistoryServer/code.
+ * /p
{code}
Please double check the javadoc
2. ApplicationHistoryProtocol's javadoc has been wrongly modified.
3. Is it better to simplify the following condition? Same for all the similar
conditions in the patch
{code}
+ if (!((e.getClass() == ApplicationNotFoundException.class) || (e
+ .getClass() == ApplicationAttemptNotFoundException.class))) {
{code}
to
{code}
+ if (e.getClass() != ApplicationNotFoundException.class e
+ .getClass() != ApplicationAttemptNotFoundException.class) {
{code}
4. Please match the NotFoundException that will be thrown in
ClientRMService, and that is analyzed in YarnClientImpl.
5. It is still an in-progress patch, isn't it? The test cases are still missing.
bq. 4. Users are not able to get completed application list via YarnClient
bq. Done
Didn't see the change to allow user to get the application list from the history
bq. These are just utility functions, do you think they are needed in
RMAPPATtempt and RMContainer?
Please see what RMApp does
ApplicationClientProtocol and ApplicationHistoryProtocol should expose analog
APIs
--
Key: YARN-1389
URL: https://issues.apache.org/jira/browse/YARN-1389
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Mayank Bansal
Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch
As we plan to have the APIs in ApplicationHistoryProtocol to expose the
reports of *finished* application attempts and containers, we should do the
same for ApplicationClientProtocol, which will return the reports of
*running* attempts and containers.
Later on, we can improve YarnClient to direct the query of running instance
to ApplicationClientProtocol, while that of finished instance to
ApplicationHistoryProtocol, making it transparent to the users.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analog APIs
[
https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917826#comment-13917826
]
Hadoop QA commented on YARN-1389:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12632192/YARN-1389-2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color:red}. The patch appears to cause the build to
fail.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3228//console
This message is automatically generated.
ApplicationClientProtocol and ApplicationHistoryProtocol should expose analog
APIs
--
Key: YARN-1389
URL: https://issues.apache.org/jira/browse/YARN-1389
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Mayank Bansal
Attachments: YARN-1389-1.patch, YARN-1389-2.patch
As we plan to have the APIs in ApplicationHistoryProtocol to expose the
reports of *finished* application attempts and containers, we should do the
same for ApplicationClientProtocol, which will return the reports of
*running* attempts and containers.
Later on, we can improve YarnClient to direct the query of running instance
to ApplicationClientProtocol, while that of finished instance to
ApplicationHistoryProtocol, making it transparent to the users.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analog APIs
[ https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918401#comment-13918401 ] Zhijie Shen commented on YARN-1389: --- [~mayank_bansal], the patch still doesn't compile. Would you please check it again? ApplicationClientProtocol and ApplicationHistoryProtocol should expose analog APIs -- Key: YARN-1389 URL: https://issues.apache.org/jira/browse/YARN-1389 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Mayank Bansal Attachments: YARN-1389-1.patch, YARN-1389-2.patch As we plan to have the APIs in ApplicationHistoryProtocol to expose the reports of *finished* application attempts and containers, we should do the same for ApplicationClientProtocol, which will return the reports of *running* attempts and containers. Later on, we can improve YarnClient to direct the query of running instance to ApplicationClientProtocol, while that of finished instance to ApplicationHistoryProtocol, making it transparent to the users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analog APIs
[ https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13916618#comment-13916618 ] Zhijie Shen commented on YARN-1389: --- Some high level comments for the initial patch: 1. ApplicationClientProtocol and ApplicationHistoryProtocol are able to share a base interface now? 2. Javadoc in ApplicationHistoryProtocol says the data is obtained from AHS, which is not correct. 3. YarnClientImpl misses the implementation for getting attempts/container/containers 4. Users are not able to get completed application list via YarnClient 5. Like RMApp, make createApplicationAttemptReport/ContainerReport as part of RMAppAttempt/RMContainer. ApplicationClientProtocol and ApplicationHistoryProtocol should expose analog APIs -- Key: YARN-1389 URL: https://issues.apache.org/jira/browse/YARN-1389 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Mayank Bansal Attachments: YARN-1389-1.patch As we plan to have the APIs in ApplicationHistoryProtocol to expose the reports of *finished* application attempts and containers, we should do the same for ApplicationClientProtocol, which will return the reports of *running* attempts and containers. Later on, we can improve YarnClient to direct the query of running instance to ApplicationClientProtocol, while that of finished instance to ApplicationHistoryProtocol, making it transparent to the users. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analog APIs
[
https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914365#comment-13914365
]
Hadoop QA commented on YARN-1389:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12631496/YARN-1389-1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color:red}. The patch appears to cause the build to
fail.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3205//console
This message is automatically generated.
ApplicationClientProtocol and ApplicationHistoryProtocol should expose analog
APIs
--
Key: YARN-1389
URL: https://issues.apache.org/jira/browse/YARN-1389
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Mayank Bansal
Assignee: Mayank Bansal
Attachments: YARN-1389-1.patch
As we plan to have the APIs in ApplicationHistoryProtocol to expose the
reports of *finished* application attempts and containers, we should do the
same for ApplicationClientProtocol, which will return the reports of
*running* attempts and containers.
Later on, we can improve YarnClient to direct the query of running instance
to ApplicationClientProtocol, while that of finished instance to
ApplicationHistoryProtocol, making it transparent to the users.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analog APIs
[ https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13824208#comment-13824208 ] Mayank Bansal commented on YARN-1389: - Hi [~zjshen] This we needed for implementing the attempt reports and container reports for YARN CLI. Reopening it Thanks, Mayank ApplicationClientProtocol and ApplicationHistoryProtocol should expose analog APIs -- Key: YARN-1389 URL: https://issues.apache.org/jira/browse/YARN-1389 Project: Hadoop YARN Issue Type: Sub-task Reporter: Mayank Bansal Assignee: Mayank Bansal As we plan to have the APIs in ApplicationHistoryProtocol to expose the reports of *finished* application attempts and containers, we should do the same for ApplicationClientProtocol, which will return the reports of *running* attempts and containers. Later on, we can improve YarnClient to direct the query of running instance to ApplicationClientProtocol, while that of finished instance to ApplicationHistoryProtocol, making it transparent to the users. -- This message was sent by Atlassian JIRA (v6.1#6144)
