[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[
https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923039#comment-13923039
]
Karthik Kambatla commented on YARN-1525:
bq. In the case the standby RM, where isStandbyMode() returns true and we start
to buildRedirectPath, switches to be active, keeping the variable
RMWebApp#standbyMode allows the behavior to be consistent from the time we
tested isStandbyMode() first in RMDispatcher.service().
I see. This can be a little confusing. Can we change {{boolean isStandbyMode}}
to {{void checkStandbyMode}} and set the field standbyMode. We can then may be
access this field directly or through an accessor.
bq. I've been using a temporary configuration (which you can find from
RMWebApp.getRedirectPath()). I was actually resetting RMid back in the original
code. It was necessary if I was not using a temporary configuration. But I'll
remove them since I've been using temporary configuration.
Now I see why it was working fine. Still, I think we should also fix
RMHAUtils#findActiveRMHAId to use a copy and not mutate the conf that is passed
to it, as this is a util method and will likely be used at other places.
We should also get rid of getting and setting rm-id in
RMWebApp#buildRedirectPath.
Web UI should redirect to active RM when HA is enabled.
---
Key: YARN-1525
URL: https://issues.apache.org/jira/browse/YARN-1525
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Xuan Gong
Assignee: Cindy Li
Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch,
YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3,
YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch,
Yarn1525.secure.patch, Yarn1525.secure.patch
When failover happens, web UI should redirect to the current active rm.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[
https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923395#comment-13923395
]
Hadoop QA commented on YARN-1525:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12633269/YARN1525.secure.v10.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The following test timeouts occurred in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.client.api.impl.TestNMClient
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3286//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3286//console
This message is automatically generated.
Web UI should redirect to active RM when HA is enabled.
---
Key: YARN-1525
URL: https://issues.apache.org/jira/browse/YARN-1525
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Xuan Gong
Assignee: Cindy Li
Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch,
YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3,
YARN1525.secure.v10.patch, YARN1525.v7.patch, YARN1525.v7.patch,
YARN1525.v8.patch, YARN1525.v9.patch, Yarn1525.secure.patch,
Yarn1525.secure.patch
When failover happens, web UI should redirect to the current active rm.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923398#comment-13923398 ] Cindy Li commented on YARN-1525: The test org.apache.hadoop.yarn.client.api.impl.TestNMClient is irrelevant. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch, YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3, YARN1525.secure.v10.patch, YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch, Yarn1525.secure.patch, Yarn1525.secure.patch When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923406#comment-13923406 ] Cindy Li commented on YARN-1525: That was for another patch... Ok. I should've removed that. Thanks for removing that. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch, YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3, YARN1525.secure.v10.patch, YARN1525.secure.v11.patch, YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch, Yarn1525.secure.patch, Yarn1525.secure.patch When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[
https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923492#comment-13923492
]
Hadoop QA commented on YARN-1525:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12633287/YARN1525.secure.v11.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3288//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3288//console
This message is automatically generated.
Web UI should redirect to active RM when HA is enabled.
---
Key: YARN-1525
URL: https://issues.apache.org/jira/browse/YARN-1525
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Xuan Gong
Assignee: Cindy Li
Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch,
YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3,
YARN1525.secure.v10.patch, YARN1525.secure.v11.patch, YARN1525.v7.patch,
YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch,
Yarn1525.secure.patch, Yarn1525.secure.patch
When failover happens, web UI should redirect to the current active rm.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923531#comment-13923531 ] Karthik Kambatla commented on YARN-1525: Thanks Cindy. +1 on the latest patch. Committing this shortly. We can address any improvements in follow-up JIRAs. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch, YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3, YARN1525.secure.v10.patch, YARN1525.secure.v11.patch, YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch, Yarn1525.secure.patch, Yarn1525.secure.patch When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[
https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923551#comment-13923551
]
Hadoop QA commented on YARN-1525:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12633287/YARN1525.secure.v11.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3291//console
This message is automatically generated.
Web UI should redirect to active RM when HA is enabled.
---
Key: YARN-1525
URL: https://issues.apache.org/jira/browse/YARN-1525
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Xuan Gong
Assignee: Cindy Li
Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch,
YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3,
YARN1525.secure.v10.patch, YARN1525.secure.v11.patch, YARN1525.v7.patch,
YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch,
Yarn1525.secure.patch, Yarn1525.secure.patch
When failover happens, web UI should redirect to the current active rm.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13921516#comment-13921516 ] Cindy Li commented on YARN-1525: @Karthik, Thanks for reviewing it. To respond to your comments: 1, I've been using a temporary configuration (which you can find from RMWebApp.getRedirectPath()). I was actually resetting RMid back in the original code. It was necessary if I was not using a temporary configuration. But I'll remove them since I've been using temporary configuration. 4, Please note that the access is changed for this function to protected. 2, yes, I can remove that line. 3, In the case the standby RM, where isStandbyMode() returns true and we start to buildRedirectPath, switches to be active, keeping the variable RMWebApp#standbyMode allows the behavior to be consistent from the time we tested isStandbyMode() first in RMDispatcher.service(). Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch, YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3, YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch, Yarn1525.secure.patch, Yarn1525.secure.patch When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[
https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13920133#comment-13920133
]
Hadoop QA commented on YARN-1525:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12632660/Yarn1525.secure.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3251//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/3251//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3251//console
This message is automatically generated.
Web UI should redirect to active RM when HA is enabled.
---
Key: YARN-1525
URL: https://issues.apache.org/jira/browse/YARN-1525
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Xuan Gong
Assignee: Cindy Li
Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch,
YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3,
YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch,
Yarn1525.secure.patch
When failover happens, web UI should redirect to the current active rm.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13920203#comment-13920203 ] Cindy Li commented on YARN-1525: The findbug warning is easy to fix. Other than that, Karthik, Vinod, Xuan, can any of you give the patch a final review? Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch, YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3, YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch, Yarn1525.secure.patch When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13920208#comment-13920208 ] Xuan Gong commented on YARN-1525: - Looking at the patch now Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch, YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3, YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch, Yarn1525.secure.patch When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[
https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13920287#comment-13920287
]
Hadoop QA commented on YARN-1525:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12632705/Yarn1525.secure.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3253//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3253//console
This message is automatically generated.
Web UI should redirect to active RM when HA is enabled.
---
Key: YARN-1525
URL: https://issues.apache.org/jira/browse/YARN-1525
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Xuan Gong
Assignee: Cindy Li
Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch,
YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3,
YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch,
Yarn1525.secure.patch, Yarn1525.secure.patch
When failover happens, web UI should redirect to the current active rm.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13920395#comment-13920395 ] Karthik Kambatla commented on YARN-1525: Verified - the redirection works as expected on a secure cluster. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch, YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3, YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch, Yarn1525.secure.patch, Yarn1525.secure.patch When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[
https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13920402#comment-13920402
]
Karthik Kambatla commented on YARN-1525:
Comments on the latest patch (it would be easier to refer to patches if they
are versioned):
# RMHAUtils#findActiveRMId: looks like we return before resetting the id to
initial RM-id? It might be safer to just create a copy of the conf - new
YarnConfiguration(yarnConf), so we don't have to store the initial value and
reset at the end.
{code}
if (haState.equals(HAServiceState.ACTIVE)) {
yarnConf.set(YarnConfiguration.RM_HA_ID, rmId);
return currentId;
}
} catch (Exception e) {
}
}
yarnConf.set(YarnConfiguration.RM_HA_ID, rmId);
{code}
# RMDispatcher: remove TODO
{code}
RMDispatcher(WebApp webApp, Injector injector, Router router) {
super(webApp, injector, router);
// TODO Auto-generated constructor stub
}
{code}
# Don't see much use for RMWebApp#standbyMode. Why not just use isStandbyMode().
# Nit: Spurious commit. Get rid of it?
{code}
- void setRedirectPath(String path) { this.redirectPath = path; }
+ protected void setRedirectPath(String path) {
+this.redirectPath = path;
+ }
{code}
Web UI should redirect to active RM when HA is enabled.
---
Key: YARN-1525
URL: https://issues.apache.org/jira/browse/YARN-1525
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Xuan Gong
Assignee: Cindy Li
Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch,
YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3,
YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch,
Yarn1525.secure.patch, Yarn1525.secure.patch
When failover happens, web UI should redirect to the current active rm.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13916651#comment-13916651 ] Cindy Li commented on YARN-1525: @Karthik, can you also post the error message in your log? I see kerberos related exception in my log when trying to produce your problem. 2014-02-28 16:43:28,039 WARN org.apache.hadoop.security.UserGroupInformation: PriviledgedActionException as:yarn/localhost@LOCALHOST (auth:KERBEROS) cause:java.io.IOException: java.lang.IllegalArgumentException : Failed to specify server's Kerberos principal name Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch, YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3, YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915275#comment-13915275 ] Karthik Kambatla commented on YARN-1525: Just checking if there are any updates here. [~cindy2012] - if you are caught up with other things, we can lend a hand. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch, YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3, YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915279#comment-13915279 ] Cindy Li commented on YARN-1525: @Karthik, I've been trying to reproduce your problem. It takes me a while to setup a secure cluster. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch, YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3, YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13909993#comment-13909993 ] Karthik Kambatla commented on YARN-1525: I deployed this on a secure cluster and accessed - http://standby:8088/cluster - it refreshes every 3 seconds, but doesn't redirect to the active. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch, YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3, YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[
https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13909134#comment-13909134
]
Hadoop QA commented on YARN-1525:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12630420/YARN1525.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The following test timeouts occurred in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.client.api.impl.TestNMClient
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3151//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3151//console
This message is automatically generated.
Web UI should redirect to active RM when HA is enabled.
---
Key: YARN-1525
URL: https://issues.apache.org/jira/browse/YARN-1525
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Xuan Gong
Assignee: Cindy Li
Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch,
YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3,
YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch
When failover happens, web UI should redirect to the current active rm.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[
https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906591#comment-13906591
]
Hadoop QA commented on YARN-1525:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12629988/YARN1525.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3130//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3130//console
This message is automatically generated.
Web UI should redirect to active RM when HA is enabled.
---
Key: YARN-1525
URL: https://issues.apache.org/jira/browse/YARN-1525
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Xuan Gong
Assignee: Cindy Li
Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch,
YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3, YARN1525.v7.patch,
YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch
When failover happens, web UI should redirect to the current active rm.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13900672#comment-13900672 ] Cindy Li commented on YARN-1525: org.apache.hadoop.yarn.client.api.impl.TestNMClient is irrelevant. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3, YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[
https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13899550#comment-13899550
]
Hadoop QA commented on YARN-1525:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12628549/YARN1525.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The following test timeouts occurred in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.client.api.impl.TestNMClient
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3086//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3086//console
This message is automatically generated.
Web UI should redirect to active RM when HA is enabled.
---
Key: YARN-1525
URL: https://issues.apache.org/jira/browse/YARN-1525
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Xuan Gong
Assignee: Cindy Li
Attachments: YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2,
YARN1525.patch.v3, YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch,
YARN1525.v9.patch
When failover happens, web UI should redirect to the current active rm.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13899603#comment-13899603 ] Cindy Li commented on YARN-1525: The test failure org.apache.hadoop.yarn.client.api.impl.TestNMClient is irrelevant. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li Attachments: YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3, YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[
https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13899668#comment-13899668
]
Karthik Kambatla commented on YARN-1525:
Thanks Cindy. Thanks for your patience through the reviews.
Functionally, the patch looks good. Some comments on the cosmetics:
* The following indentation needs to be fixed:
{code}
@Override
public boolean isStandbyMode() {
{code}
* Setting the redirect path in WebApp#isStandbyMode() is a little misleading.
Can we leave isStandbyMode() to only report whether the RM is in standby mode,
and may be getRedirectPath() can take care of constructing the path if
required.
* Rename RMWebApp#findRedirectPath to buildRedirectPath?
* Couple of lines longer than 80 chars
{code}
if (webApp.isStandbyMode() !uri.equals(/ + webApp.name() +
/cluster)) {
String redirectPath = webApp.getRedirectPath();
if (redirectPath != null !redirectPath.isEmpty()) {
String redirectMsg =
This is a standby resource manager, redirecting to the current
active one:
+ redirectPath;
{code}
* TestRMFailover#testRMWebAppFailover
** Rename to testRMWebAppRedirect to capture the behavior better
** If it is not too much trouble, given the test doesn't do any failover, we
should probably move it to TestRMHA?
* Let us add Private-Unstable annotations to RMHAUtils so we can move the
methods or even remove this class if we don't see the code being reused.
I ll be glad to test the updated patch out on a secure cluster for verification.
Web UI should redirect to active RM when HA is enabled.
---
Key: YARN-1525
URL: https://issues.apache.org/jira/browse/YARN-1525
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Xuan Gong
Assignee: Cindy Li
Attachments: YARN1525.patch, YARN1525.patch.v1, YARN1525.patch.v2,
YARN1525.patch.v3, YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch,
YARN1525.v9.patch
When failover happens, web UI should redirect to the current active rm.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[
https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1383#comment-1383
]
Hadoop QA commented on YARN-1525:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12628660/YARN1525.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The following test timeouts occurred in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.client.api.impl.TestNMClient
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3091//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3091//console
This message is automatically generated.
Web UI should redirect to active RM when HA is enabled.
---
Key: YARN-1525
URL: https://issues.apache.org/jira/browse/YARN-1525
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Xuan Gong
Assignee: Cindy Li
Attachments: YARN1525.patch, YARN1525.patch, YARN1525.patch.v1,
YARN1525.patch.v2, YARN1525.patch.v3, YARN1525.v7.patch, YARN1525.v7.patch,
YARN1525.v8.patch, YARN1525.v9.patch
When failover happens, web UI should redirect to the current active rm.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898487#comment-13898487 ] Karthik Kambatla commented on YARN-1525: Nits before actual review: # webapp/Dispatcher.java and webapp/Dispatcher.java have spurious changes to the license header - may be IDE induced. # The methods in RMHAUtils can be moved to HAUtil. It would be nice to get this done soon, so these are also taken care of by Vinod's attempt to clean up HAUtil. Sorry for the additional trouble, Vinod. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li Attachments: YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3, YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[
https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898488#comment-13898488
]
Karthik Kambatla commented on YARN-1525:
Oh - missed these - would be nice to not include these either:
{code}
-@InterfaceAudience.LimitedPrivate({YARN, MapReduce})
+@InterfaceAudience.LimitedPrivate({ YARN, MapReduce })
public abstract class WebApp extends ServletModule {
private static final Logger LOG = LoggerFactory.getLogger(WebApp.class);
- public enum HTTP { GET, POST, HEAD, PUT, DELETE };
+ public enum HTTP {
+GET, POST, HEAD, PUT, DELETE
+ };
{code}
Web UI should redirect to active RM when HA is enabled.
---
Key: YARN-1525
URL: https://issues.apache.org/jira/browse/YARN-1525
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Xuan Gong
Assignee: Cindy Li
Attachments: YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3,
YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch
When failover happens, web UI should redirect to the current active rm.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[
https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898497#comment-13898497
]
Hadoop QA commented on YARN-1525:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12628362/YARN1525.v9.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:red}-1 javac{color:red}. The patch appears to cause the build to
fail.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3071//console
This message is automatically generated.
Web UI should redirect to active RM when HA is enabled.
---
Key: YARN-1525
URL: https://issues.apache.org/jira/browse/YARN-1525
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Xuan Gong
Assignee: Cindy Li
Attachments: YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3,
YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch
When failover happens, web UI should redirect to the current active rm.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898500#comment-13898500 ] Cindy Li commented on YARN-1525: @Karthik, RMHAUtils.java couldn't be merged into HAUtil.java because of project setup, as it uses RMHAServiceTarget which would not be accessible from HAUtil.java. Yes. the format are automatically changed by IDE. I can try to manually remove them. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li Attachments: YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3, YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch, YARN1525.v9.patch When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[
https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13896936#comment-13896936
]
Hadoop QA commented on YARN-1525:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12628032/YARN1525.v7.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:red}-1 release audit{color}. The applied patch generated 2
release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3052//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/3052//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3052//console
This message is automatically generated.
Web UI should redirect to active RM when HA is enabled.
---
Key: YARN-1525
URL: https://issues.apache.org/jira/browse/YARN-1525
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Xuan Gong
Assignee: Cindy Li
Attachments: YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3,
YARN1525.v7.patch, YARN1525.v7.patch
When failover happens, web UI should redirect to the current active rm.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13897349#comment-13897349 ] Karthik Kambatla commented on YARN-1525: The latest patch seems to have several spurious formatting changes. Can we limit these formatting changes to only those lines that the patch needs to modify. That would make it much easier to review. Thanks. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li Attachments: YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3, YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[
https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13897373#comment-13897373
]
Xuan Gong commented on YARN-1525:
-
One more thing :
{code}
setRedirectPath(http://; + path);
{code}
in RMWebApp:: isStandbyMode(). We need to have either http or https based
on the security.
Also, in TestRMFailover, this comment // Due to the limitation of
MiniYARNCluster, we couldn't test the case after. I think that the root cause
is because the org.apache.hadoop.yarn.webapp.Dispatcher is singleton.
Web UI should redirect to active RM when HA is enabled.
---
Key: YARN-1525
URL: https://issues.apache.org/jira/browse/YARN-1525
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Xuan Gong
Assignee: Cindy Li
Attachments: YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3,
YARN1525.v7.patch, YARN1525.v7.patch, YARN1525.v8.patch
When failover happens, web UI should redirect to the current active rm.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[
https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13895768#comment-13895768
]
Hadoop QA commented on YARN-1525:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12627837/YARN1525.v7.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:red}-1 release audit{color}. The applied patch generated 2
release audit warnings.
{color:red}-1 core tests{color}. The following test timeouts occurred in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.client.api.impl.TestNMClient
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3046//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/3046//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/3046//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3046//console
This message is automatically generated.
Web UI should redirect to active RM when HA is enabled.
---
Key: YARN-1525
URL: https://issues.apache.org/jira/browse/YARN-1525
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Xuan Gong
Assignee: Cindy Li
Attachments: YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3,
YARN1525.v7.patch
When failover happens, web UI should redirect to the current active rm.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[
https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13884409#comment-13884409
]
Xuan Gong commented on YARN-1525:
-
Comments:
1.{code}
if (webApp.isStandbyMode() !uri.equals(/ + webApp.name() + /cluster)
+ !uri.equals(/ + webApp.wsName() + /v1/cluster/info))
{code}
Can we remote (!uri.equals(/ + webApp.wsName() + /v1/cluster/info)) here?
We can handle it in ws ticket if needed.
2.In RMWebApp#findRedirectPath,
{code}
+if (activeRMHAId != null) {
+ yarnConf.set(YarnConfiguration.RM_HA_ID, activeRMHAId);
+ InetSocketAddress sock =
+ yarnConf.getSocketAddr(YarnConfiguration.RM_WEBAPP_ADDRESS,
+ YarnConfiguration.DEFAULT_RM_WEBAPP_ADDRESS,
+ YarnConfiguration.DEFAULT_RM_WEBAPP_PORT);
+ return sock.getHostName() + : + Integer.toString(sock.getPort());
+}
{code}
If HttpConfig.isSecure() is enable, we will use RM_WEBAPP_HTTPS_ADDRESS instead
of RM_WEBAPP_ADDRESS. So, when we create the redirectPath, we need consider it.
3.For the testcase, current the test case you created is more like a
functionality test. Can you add an end-to-end test (You can use
miniYarnCluster) ? Please take a look at TestRMFailover.
4.Also, please click the submit patch if you have a new patch available. The
jekins will apply your patch, do several verifications, and make sure that this
patch will not break previous tests.
Web UI should redirect to active RM when HA is enabled.
---
Key: YARN-1525
URL: https://issues.apache.org/jira/browse/YARN-1525
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Xuan Gong
Assignee: Cindy Li
Attachments: YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3
When failover happens, web UI should redirect to the current active rm.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881354#comment-13881354 ] Cindy Li commented on YARN-1525: [~xgong], thanks for your comments. In the current code, it just loop through all the available RM ids. There is already an rpcTimeoutForChecks when querying HAState, do we need to set additional MAXIMUM_waiting time here too? @Karthik, thanks for your comments. I can make it into HAUtil. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li Attachments: YARN1525.patch.v1, YARN1525.patch.v2 When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881600#comment-13881600 ] Cindy Li commented on YARN-1525: I'll work on a new ticket for the web service redirection part. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li Attachments: YARN1525.patch.v1, YARN1525.patch.v2, YARN1525.patch.v3 When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879488#comment-13879488 ] Karthik Kambatla commented on YARN-1525: Just skimmed through the patch. Can we abstract out the code to find the Active RM Id as a helper method in HAUtil? Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li Attachments: YARN1525.patch.v1, YARN1525.patch.v2 When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[
https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877716#comment-13877716
]
Xuan Gong commented on YARN-1525:
-
[~cindy2012]
Comments:
* Looks like the web service does not work.
* Can we add some test cases ?
* At RMWebApp#findRedirectPath()
{code}
for (String currentId : rmIds) {
.
.
}
{code}
Can we use while loop until we find the active rm ? Also, we may need to set a
MAX_WAITTING_TIME. Then we can break the while loop either we find the active
rm or it exceeds the MAX_WAITTING_TIME.
* nit
{code}
InetSocketAddress rmSock =
yarnConf.getSocketAddr(YarnConfiguration.RM_WEBAPP_ADDRESS,
YarnConfiguration.DEFAULT_RM_WEBAPP_ADDRESS,
YarnConfiguration.DEFAULT_RM_WEBAPP_PORT);
{code}
The variable is not used. We can remove it.
Web UI should redirect to active RM when HA is enabled.
---
Key: YARN-1525
URL: https://issues.apache.org/jira/browse/YARN-1525
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Xuan Gong
Assignee: Cindy Li
Attachments: YARN1525.patch.v1, YARN1525.patch.v2
When failover happens, web UI should redirect to the current active rm.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13877921#comment-13877921 ] Cindy Li commented on YARN-1525: Xuan, did you apply patch v1 or v2 for testing it? Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li Attachments: YARN1525.patch.v1, YARN1525.patch.v2 When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13876175#comment-13876175 ] Xuan Gong commented on YARN-1525: - Yes. [~cindy2012]. Please do that. It is hard to view what exact changes. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li Attachments: YARN1525.patch.v1 When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875553#comment-13875553 ] Karthik Kambatla commented on YARN-1525: Thanks [~cindy2012] for the patch. Would it be possible to leave out formatting changes unrelated to the patch? For intstance, the license header in the beginning of each file? That way, it would be easy to review what exact changes went into the commit. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li Attachments: YARN1525.patch.v1 When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13869939#comment-13869939 ] Karthik Kambatla commented on YARN-1525: I have very limited experience with the RM web services. I like the redirect, can we redirect for everything but (1) the REST API for ClusterInfo (/ws/v1/cluster/info), and may be (2) About (/cluster/cluster)? Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13869167#comment-13869167 ] Zhijie Shen commented on YARN-1525: --- Personally, I like proposal 1. In addition, is it good to have a temporal page, which stays for around 10 seconds and says users are going to be redirected to the active RM, before the redirecting is executed? Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13868563#comment-13868563 ] Cindy Li commented on YARN-1525: In practice, users mostly go to the RM webUI to see their application's status. I want to get some comments for the two different designs: Proposal 1. When a user enters the index page's url of the standby RM, user will be redirected to that of the active RM. so user will stay in the webUI of the active RM after redirection. eg: if a user enters standby RM's url: http://localhost:23188/ he/she will be redirect to http://localhost:33188/ Proposal 2. Redirect some pages only when user clicks on them. eg: when user enters standby RM's url: http://localhost:23188/ actually by default it currently goes to http://localhost:23188/cluster. As this page shows application information, the standby RM needs to get that from the active RM. If we don't redirect that to the active RM's url http://localhost:33188/cluster, as proposal 1 does, we'll have to retrieve that information from the active RM, either through active RM's web service or through RPC calls. The speed of this is not as good as letting users go to that page directly. @Karthik, can you comment on keeping HA state info based on the two different proposals above? Proposal 1 looks more convenient for cluster users (who submit jobs and want to see job info) and has nearly no performance impact on standby RM or active RM. Proposal 2 looks more costly than proposal 1. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867004#comment-13867004 ] Cindy Li commented on YARN-1525: I've been thinking about the best way to find the current active RM for a standby RM. Considering two options now: one is to establish connection to zookeeper, the other is to query active/standby state related to YARN-1033. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867002#comment-13867002 ] Karthik Kambatla commented on YARN-1525: Thinking out loud: Given that YARN-1482 enables webapp even in Standby mode, I think there is merit to not redirecting to the Active always. How about we redirect only when querying applications/nodes etc, and have the About section not redirect? Also, if it is not too much trouble, I would prefer getting in YARN-1033 in first so we can verify we aren't messing with that functionality either. I should have a patch later today. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867022#comment-13867022 ] Cindy Li commented on YARN-1525: @Karthik Kambatla, I'm proposing the following. From a user's perspective, it would be convenient to be able to access the current active RM's URL. If a user types in the url of a standby RM (which used to be the active one after failover), YARN-1033 will show this is a standby node. Then this jira YARN-1525 will use that information to redirect to the current active RM's webpage, and showing a message redirecting to the current active RM: active RM's url, then the user can go to that url directly next time. This looks more convenient for users. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867294#comment-13867294 ] Karthik Kambatla commented on YARN-1525: I am sorry if I came out wrong, I do see merit to redirecting to the Active. I think we should redirect in a way that the HA state information exposed by YARN-1033 continues to be available on both Active/ Standby RMs. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867420#comment-13867420 ] Cindy Li commented on YARN-1525: Ok. I'll try to accommodate the change in YARN-1033. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Cindy Li When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1525) Web UI should redirect to active RM when HA is enabled.
[ https://issues.apache.org/jira/browse/YARN-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13854710#comment-13854710 ] Xuan Gong commented on YARN-1525: - Let me explain more : Assume we have RM1 with web address : localhost : , and RM2 with web address : localhost:. We set RM1 to active, if we type localhost:, it should redirect to localhost: which is the web address for the active RM automatically. Web UI should redirect to active RM when HA is enabled. --- Key: YARN-1525 URL: https://issues.apache.org/jira/browse/YARN-1525 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Xuan Gong When failover happens, web UI should redirect to the current active rm. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
