[jira] [Commented] (YARN-1883) TetsRMAdminService fails due to inconsistent entries in UserGroups

2014-03-26 Thread Mit Desai (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948581#comment-13948581
 ] 

Mit Desai commented on YARN-1883:
-

Working on the fix. Will be posting a patch soon

 TetsRMAdminService fails due to inconsistent entries in UserGroups
 --

 Key: YARN-1883
 URL: https://issues.apache.org/jira/browse/YARN-1883
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 3.0.0, 2.4.0
Reporter: Mit Desai
Assignee: Mit Desai
  Labels: java7

 testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider fails 
 with the following error:
 {noformat}
 java.lang.AssertionError: null
   at org.junit.Assert.fail(Assert.java:92)
   at org.junit.Assert.assertTrue(Assert.java:43)
   at org.junit.Assert.assertTrue(Assert.java:54)
   at 
 org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider(TestRMAdminService.java:421)
   at 
 org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testOrder(TestRMAdminService.java:104)
 {noformat}
 Line Numbers will be inconsistent as I was testing to run it in a particular 
 order. But the Line on which the failure occurs is
 {code}
 Assert.assertTrue(groupBefore.contains(test_group_A)
  groupBefore.contains(test_group_B)
  groupBefore.contains(test_group_C)  groupBefore.size() == 3);
 {code}
 testRMInitialsWithFileSystemBasedConfigurationProvider() and
 testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider()
 calls the function {{MockUnixGroupsMapping.updateGroups();}} which changes 
 the list of userGroups.
 testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider() 
 tries to verify the groups before changing it and fails if 
 testRMInitialsWithFileSystemBasedConfigurationProvider() already ran and made 
 the changes.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (YARN-1883) TetsRMAdminService fails due to inconsistent entries in UserGroups

2014-03-26 Thread Akira AJISAKA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948800#comment-13948800
 ] 

Akira AJISAKA commented on YARN-1883:
-

Good catch and thanks for the patch.
{code}
+// reset the groups to what it were before updating
+MockUnixGroupsMapping.resetGroups();
{code}
I think it would be better to move {{resetGroups()}} into {{setup()}} method to 
avoid developers forgetting to call {{resetGroup()}} in each required method. 
That way we can remove the initialization
{code}
@SuppressWarnings(serial)
private static ListString group = new ArrayListString() {{
  add(test_group_A);
  add(test_group_B);
  add(test_group_C);
}};
{code}

 TetsRMAdminService fails due to inconsistent entries in UserGroups
 --

 Key: YARN-1883
 URL: https://issues.apache.org/jira/browse/YARN-1883
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 3.0.0, 2.4.0
Reporter: Mit Desai
Assignee: Mit Desai
  Labels: java7
 Attachments: YARN-1883.patch


 testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider fails 
 with the following error:
 {noformat}
 java.lang.AssertionError: null
   at org.junit.Assert.fail(Assert.java:92)
   at org.junit.Assert.assertTrue(Assert.java:43)
   at org.junit.Assert.assertTrue(Assert.java:54)
   at 
 org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider(TestRMAdminService.java:421)
   at 
 org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testOrder(TestRMAdminService.java:104)
 {noformat}
 Line Numbers will be inconsistent as I was testing to run it in a particular 
 order. But the Line on which the failure occurs is
 {code}
 Assert.assertTrue(groupBefore.contains(test_group_A)
  groupBefore.contains(test_group_B)
  groupBefore.contains(test_group_C)  groupBefore.size() == 3);
 {code}
 testRMInitialsWithFileSystemBasedConfigurationProvider() and
 testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider()
 calls the function {{MockUnixGroupsMapping.updateGroups();}} which changes 
 the list of userGroups.
 testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider() 
 tries to verify the groups before changing it and fails if 
 testRMInitialsWithFileSystemBasedConfigurationProvider() already ran and made 
 the changes.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (YARN-1883) TetsRMAdminService fails due to inconsistent entries in UserGroups

2014-03-26 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948818#comment-13948818
 ] 

Hadoop QA commented on YARN-1883:
-

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12637040/YARN-1883.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/3469//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3469//console

This message is automatically generated.

 TetsRMAdminService fails due to inconsistent entries in UserGroups
 --

 Key: YARN-1883
 URL: https://issues.apache.org/jira/browse/YARN-1883
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 3.0.0, 2.4.0
Reporter: Mit Desai
Assignee: Mit Desai
  Labels: java7
 Attachments: YARN-1883.patch


 testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider fails 
 with the following error:
 {noformat}
 java.lang.AssertionError: null
   at org.junit.Assert.fail(Assert.java:92)
   at org.junit.Assert.assertTrue(Assert.java:43)
   at org.junit.Assert.assertTrue(Assert.java:54)
   at 
 org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider(TestRMAdminService.java:421)
   at 
 org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testOrder(TestRMAdminService.java:104)
 {noformat}
 Line Numbers will be inconsistent as I was testing to run it in a particular 
 order. But the Line on which the failure occurs is
 {code}
 Assert.assertTrue(groupBefore.contains(test_group_A)
  groupBefore.contains(test_group_B)
  groupBefore.contains(test_group_C)  groupBefore.size() == 3);
 {code}
 testRMInitialsWithFileSystemBasedConfigurationProvider() and
 testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider()
 calls the function {{MockUnixGroupsMapping.updateGroups();}} which changes 
 the list of userGroups.
 testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider() 
 tries to verify the groups before changing it and fails if 
 testRMInitialsWithFileSystemBasedConfigurationProvider() already ran and made 
 the changes.



--
This message was sent by Atlassian JIRA
(v6.2#6252)