[jira] [Commented] (YARN-5834) TestNodeStatusUpdater.testNMRMConnectionConf compares nodemanager wait time to the incorrect value
[ https://issues.apache.org/jira/browse/YARN-5834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655347#comment-15655347 ] Hudson commented on YARN-5834: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10814 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10814/]) YARN-5834. TestNodeStatusUpdater.testNMRMConnectionConf compares (kasha: rev 3a98419532687e4362ffc26abbc1264232820db7) * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java > TestNodeStatusUpdater.testNMRMConnectionConf compares nodemanager wait time > to the incorrect value > -- > > Key: YARN-5834 > URL: https://issues.apache.org/jira/browse/YARN-5834 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Miklos Szegedi >Assignee: Chang Li >Priority: Trivial > Fix For: 2.9.0, 3.0.0-alpha2 > > Attachments: YARN-5834-branch-2.001.patch > > > The function is TestNodeStatusUpdater#testNMRMConnectionConf() > I believe the connectionWaitMs references below were meant to be > nmRmConnectionWaitMs. > {code} > conf.setLong(YarnConfiguration.NM_RESOURCEMANAGER_CONNECT_MAX_WAIT_MS, > nmRmConnectionWaitMs); > conf.setLong(YarnConfiguration.RESOURCEMANAGER_CONNECT_MAX_WAIT_MS, > connectionWaitMs); > ... > long t = System.currentTimeMillis(); > long duration = t - waitStartTime; > boolean waitTimeValid = (duration >= nmRmConnectionWaitMs) && > (duration < (*connectionWaitMs* + delta)); > if(!waitTimeValid) { > // throw exception if NM doesn't retry long enough > throw new Exception("NM should have tried re-connecting to RM during > " + > "period of at least " + *connectionWaitMs* + " ms, but " + > "stopped retrying within " + (*connectionWaitMs* + delta) + > " ms: " + e, e); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5834) TestNodeStatusUpdater.testNMRMConnectionConf compares nodemanager wait time to the incorrect value
[ https://issues.apache.org/jira/browse/YARN-5834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655304#comment-15655304 ] Karthik Kambatla commented on YARN-5834: +1. Checking this in.. > TestNodeStatusUpdater.testNMRMConnectionConf compares nodemanager wait time > to the incorrect value > -- > > Key: YARN-5834 > URL: https://issues.apache.org/jira/browse/YARN-5834 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Miklos Szegedi >Assignee: Chang Li >Priority: Trivial > Attachments: YARN-5834-branch-2.001.patch > > > The function is TestNodeStatusUpdater#testNMRMConnectionConf() > I believe the connectionWaitMs references below were meant to be > nmRmConnectionWaitMs. > {code} > conf.setLong(YarnConfiguration.NM_RESOURCEMANAGER_CONNECT_MAX_WAIT_MS, > nmRmConnectionWaitMs); > conf.setLong(YarnConfiguration.RESOURCEMANAGER_CONNECT_MAX_WAIT_MS, > connectionWaitMs); > ... > long t = System.currentTimeMillis(); > long duration = t - waitStartTime; > boolean waitTimeValid = (duration >= nmRmConnectionWaitMs) && > (duration < (*connectionWaitMs* + delta)); > if(!waitTimeValid) { > // throw exception if NM doesn't retry long enough > throw new Exception("NM should have tried re-connecting to RM during > " + > "period of at least " + *connectionWaitMs* + " ms, but " + > "stopped retrying within " + (*connectionWaitMs* + delta) + > " ms: " + e, e); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5834) TestNodeStatusUpdater.testNMRMConnectionConf compares nodemanager wait time to the incorrect value
[ https://issues.apache.org/jira/browse/YARN-5834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15654682#comment-15654682 ] Miklos Szegedi commented on YARN-5834: -- +1 non-binding. Thank you, [~lichangleo]! The change looks good to me. > TestNodeStatusUpdater.testNMRMConnectionConf compares nodemanager wait time > to the incorrect value > -- > > Key: YARN-5834 > URL: https://issues.apache.org/jira/browse/YARN-5834 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Miklos Szegedi >Assignee: Chang Li >Priority: Minor > Attachments: YARN-5834-branch-2.001.patch > > > The function is TestNodeStatusUpdater#testNMRMConnectionConf() > I believe the connectionWaitMs references below were meant to be > nmRmConnectionWaitMs. > {code} > conf.setLong(YarnConfiguration.NM_RESOURCEMANAGER_CONNECT_MAX_WAIT_MS, > nmRmConnectionWaitMs); > conf.setLong(YarnConfiguration.RESOURCEMANAGER_CONNECT_MAX_WAIT_MS, > connectionWaitMs); > ... > long t = System.currentTimeMillis(); > long duration = t - waitStartTime; > boolean waitTimeValid = (duration >= nmRmConnectionWaitMs) && > (duration < (*connectionWaitMs* + delta)); > if(!waitTimeValid) { > // throw exception if NM doesn't retry long enough > throw new Exception("NM should have tried re-connecting to RM during > " + > "period of at least " + *connectionWaitMs* + " ms, but " + > "stopped retrying within " + (*connectionWaitMs* + delta) + > " ms: " + e, e); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5834) TestNodeStatusUpdater.testNMRMConnectionConf compares nodemanager wait time to the incorrect value
[ https://issues.apache.org/jira/browse/YARN-5834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15653530#comment-15653530 ] Hadoop QA commented on YARN-5834: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 17s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 52s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 25s{color} | {color:green} branch-2 passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s{color} | {color:green} branch-2 passed with JDK v1.7.0_111 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 21s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 31s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 15s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 54s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s{color} | {color:green} branch-2 passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} branch-2 passed with JDK v1.7.0_111 {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 26s{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 26s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 28s{color} | {color:green} the patch passed with JDK v1.7.0_111 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 29s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 15s{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s{color} | {color:green} the patch passed with JDK v1.7.0_111 {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 15m 36s{color} | {color:green} hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_111. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 17s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 47m 9s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:b59b8b7 | | JIRA Issue | YARN-5834 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12838319/YARN-5834-branch-2.001.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 87018bab2daf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | branch-2 / f7b2542 | | Default Java | 1.7.0_111 | | Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 | | findbugs | v3.0.0 | | JDK v1.7
[jira] [Commented] (YARN-5834) TestNodeStatusUpdater.testNMRMConnectionConf compares nodemanager wait time to the incorrect value
[ https://issues.apache.org/jira/browse/YARN-5834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15653391#comment-15653391 ] Chang Li commented on YARN-5834: Thanks for reporting. Yes it's meant to be nmRmConnectionWaitMs. Provide branch-2 patch since this test does not exist in trunk > TestNodeStatusUpdater.testNMRMConnectionConf compares nodemanager wait time > to the incorrect value > -- > > Key: YARN-5834 > URL: https://issues.apache.org/jira/browse/YARN-5834 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Miklos Szegedi >Assignee: Chang Li >Priority: Minor > Attachments: YARN-5834-branch-2.001.patch > > > The function is TestNodeStatusUpdater#testNMRMConnectionConf() > I believe the connectionWaitMs references below were meant to be > nmRmConnectionWaitMs. > {code} > conf.setLong(YarnConfiguration.NM_RESOURCEMANAGER_CONNECT_MAX_WAIT_MS, > nmRmConnectionWaitMs); > conf.setLong(YarnConfiguration.RESOURCEMANAGER_CONNECT_MAX_WAIT_MS, > connectionWaitMs); > ... > long t = System.currentTimeMillis(); > long duration = t - waitStartTime; > boolean waitTimeValid = (duration >= nmRmConnectionWaitMs) && > (duration < (*connectionWaitMs* + delta)); > if(!waitTimeValid) { > // throw exception if NM doesn't retry long enough > throw new Exception("NM should have tried re-connecting to RM during > " + > "period of at least " + *connectionWaitMs* + " ms, but " + > "stopped retrying within " + (*connectionWaitMs* + delta) + > " ms: " + e, e); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5834) TestNodeStatusUpdater.testNMRMConnectionConf compares nodemanager wait time to the incorrect value
[ https://issues.apache.org/jira/browse/YARN-5834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15651467#comment-15651467 ] Miklos Szegedi commented on YARN-5834: -- [~lichangleo], could you please look at this bug, if the description is correct? > TestNodeStatusUpdater.testNMRMConnectionConf compares nodemanager wait time > to the incorrect value > -- > > Key: YARN-5834 > URL: https://issues.apache.org/jira/browse/YARN-5834 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Miklos Szegedi >Priority: Minor > > The function is TestNodeStatusUpdater#testNMRMConnectionConf() > I believe the connectionWaitMs references below were meant to be > nmRmConnectionWaitMs. > {code} > conf.setLong(YarnConfiguration.NM_RESOURCEMANAGER_CONNECT_MAX_WAIT_MS, > nmRmConnectionWaitMs); > conf.setLong(YarnConfiguration.RESOURCEMANAGER_CONNECT_MAX_WAIT_MS, > connectionWaitMs); > ... > long t = System.currentTimeMillis(); > long duration = t - waitStartTime; > boolean waitTimeValid = (duration >= nmRmConnectionWaitMs) && > (duration < (*connectionWaitMs* + delta)); > if(!waitTimeValid) { > // throw exception if NM doesn't retry long enough > throw new Exception("NM should have tried re-connecting to RM during > " + > "period of at least " + *connectionWaitMs* + " ms, but " + > "stopped retrying within " + (*connectionWaitMs* + delta) + > " ms: " + e, e); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org