[jira] [Commented] (YARN-9378) Create Image Localizer
[
https://issues.apache.org/jira/browse/YARN-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790997#comment-16790997
]
Chandni Singh commented on YARN-9378:
-
[~eyang] I attached the patch in which I had created an ImageLocalizer that
executes the DockerImagePull command.
The reason I didn't integrate DockerImagePull command with
LinuxContainerExecutor is because that API is tied to Containers but this
command is independent of containers.
Please take a look at {{ImageLocalizer.java}} class and these methods
- findLocalImages()
- ImageStatusRetriever.run()
Let me know your thoughts.
> Create Image Localizer
> --
>
> Key: YARN-9378
> URL: https://issues.apache.org/jira/browse/YARN-9378
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Chandni Singh
>Assignee: Chandni Singh
>Priority: Major
> Attachments: YARN-9378.001.patch
>
>
> {{LinuxContainerExecutor}} is for container operations. DockerImagesCommand
> is independent of any container. The image localizer acts as a service that
> will localize docker images and maintain an image cache. Other components can
> use this to query about the images on the node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-9378) Create Image Localizer
[
https://issues.apache.org/jira/browse/YARN-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791052#comment-16791052
]
Eric Yang commented on YARN-9378:
-
Code looks good with one suggestion:
{code}
String output = DockerCommandExecutor.executeDockerCommand(
pullCommand, Long.toHexString(System.currentTimeMillis()),
null, privOpExecutor, false, localizer.nmContext);
{code}
In this context, there is no container id, maybe we can fix
preparePrivilegedOperation to accept null instead of passing system time to
make this more readable.
> Create Image Localizer
> --
>
> Key: YARN-9378
> URL: https://issues.apache.org/jira/browse/YARN-9378
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Chandni Singh
>Assignee: Chandni Singh
>Priority: Major
> Attachments: YARN-9378.001.patch
>
>
> {{LinuxContainerExecutor}} is for container operations. DockerImagesCommand
> is independent of any container. The image localizer acts as a service that
> will localize docker images and maintain an image cache. Other components can
> use this to query about the images on the node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-9378) Create Image Localizer
[
https://issues.apache.org/jira/browse/YARN-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792055#comment-16792055
]
Chandni Singh commented on YARN-9378:
-
{quote}
In this context, there is no container id, maybe we can fix
preparePrivilegedOperation to accept null instead of passing system time to
make this more readable.
{quote}
If I remember correctly, preparePrivilegedOperator requires that string to
construct the filename of the docker command file. I can re-check. We can think
of a better string to pass, possibly the "image name and the version".
> Create Image Localizer
> --
>
> Key: YARN-9378
> URL: https://issues.apache.org/jira/browse/YARN-9378
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Chandni Singh
>Assignee: Chandni Singh
>Priority: Major
> Attachments: YARN-9378.001.patch
>
>
> {{LinuxContainerExecutor}} is for container operations. DockerImagesCommand
> is independent of any container. The image localizer acts as a service that
> will localize docker images and maintain an image cache. Other components can
> use this to query about the images on the node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-9378) Create Image Localizer
[
https://issues.apache.org/jira/browse/YARN-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792072#comment-16792072
]
Eric Yang commented on YARN-9378:
-
[~csingh] ".cmd" file without container association may want to use a specific
reserved keyword or null. This can help to write .cmd file in same directory
and help the clean up process of the .cmd file after docker image command is
executed.
> Create Image Localizer
> --
>
> Key: YARN-9378
> URL: https://issues.apache.org/jira/browse/YARN-9378
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Chandni Singh
>Assignee: Chandni Singh
>Priority: Major
> Attachments: YARN-9378.001.patch
>
>
> {{LinuxContainerExecutor}} is for container operations. DockerImagesCommand
> is independent of any container. The image localizer acts as a service that
> will localize docker images and maintain an image cache. Other components can
> use this to query about the images on the node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
