Re: [zfs-discuss] new logbias property

2009-08-13 Thread Robert Milkowski

Eric Schrock wrote:

On 08/11/09 06:03, Darren J Moffat wrote:


I thought so too initially, then I changed my mind and I like it the 
way it is.  The reason being is that describing the intent allows 
changing the implementation and keeping the meaning.  It is the 
intent that matters to the administrator not the implementation.




Also worth noting that is the fact that the use of WR_INDIRECT log 
writes is altered depending on this property.  Even in a pool with no 
dedicated log devices, changing this property can have an effect on 
overall performance, so it clearly cannot be defined as simply as use 
log devices or not.


- Eric


That's good to know.
Eric, Darren - thanks for clarification - it makes sense :)

___
zfs-discuss mailing list
zfs-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/zfs-discuss


[zfs-discuss] new logbias property

2009-08-11 Thread Robert Milkowski
Hi,

I like the new feature but I was thinking that maybe the keywords being used 
should be different?

Currently it is:

# zfs set logbias=latency {dataset}
# zfs set logbias=throughput {dataset}

Maybe it would be more clear this way:

# zfs set logdest=dedicated {dataset}
# zfs set logdest=pool {dataset}

or even intentlog={dedicated|pool} ?

IMHO it would better describe what the feature actually does.

-- 
Robert Milkowski
http://milek.blogspot.com
-- 
This message posted from opensolaris.org
___
zfs-discuss mailing list
zfs-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/zfs-discuss


Re: [zfs-discuss] new logbias property

2009-08-11 Thread Darren J Moffat

Robert Milkowski wrote:

Hi,

I like the new feature but I was thinking that maybe the keywords being used 
should be different?

Currently it is:

# zfs set logbias=latency {dataset}
# zfs set logbias=throughput {dataset}

Maybe it would be more clear this way:

# zfs set logdest=dedicated {dataset}
# zfs set logdest=pool {dataset}

or even intentlog={dedicated|pool} ?

IMHO it would better describe what the feature actually does.


I thought so too initially, then I changed my mind and I like it the way 
it is.  The reason being is that describing the intent allows changing 
the implementation and keeping the meaning.  It is the intent that 
matters to the administrator not the implementation.


--
Darren J Moffat
___
zfs-discuss mailing list
zfs-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/zfs-discuss


Re: [zfs-discuss] new logbias property

2009-08-11 Thread przemolicc
On Tue, Aug 11, 2009 at 05:42:31AM -0700, Robert Milkowski wrote:
 Hi,
 
 I like the new feature but I was thinking that maybe the keywords being used 
 should be different?
 
 Currently it is:
 
 # zfs set logbias=latency {dataset}
 # zfs set logbias=throughput {dataset}
 
 Maybe it would be more clear this way:
 
 # zfs set logdest=dedicated {dataset}
 # zfs set logdest=pool {dataset}
 
 or even intentlog={dedicated|pool} ?
 
 IMHO it would better describe what the feature actually does.

I am not sure if 'logbias' is better then 'logdest' but IMHO
'latency' and 'throughput' is much more intuitive :-)

Regards
Przemyslaw Bak (przemol)
--
http://przemol.blogspot.com/





























--
Wybierz dziewczyne lub chlopaka lata!
Final trwa  http://link.interia.pl/f22c4 


___
zfs-discuss mailing list
zfs-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/zfs-discuss


Re: [zfs-discuss] new logbias property

2009-08-11 Thread Darren J Moffat

przemol...@poczta.fm wrote:

On Tue, Aug 11, 2009 at 05:42:31AM -0700, Robert Milkowski wrote:

Hi,

I like the new feature but I was thinking that maybe the keywords being used 
should be different?

Currently it is:

# zfs set logbias=latency {dataset}
# zfs set logbias=throughput {dataset}

Maybe it would be more clear this way:

# zfs set logdest=dedicated {dataset}
# zfs set logdest=pool {dataset}

or even intentlog={dedicated|pool} ?

IMHO it would better describe what the feature actually does.


I am not sure if 'logbias' is better then 'logdest' but IMHO
'latency' and 'throughput' is much more intuitive :-)


That would make sense though, eg:

logdest=latency|throughput

Which is why it is logbias, it isn't the destination of the log that is 
latency or throughput but the bias.


--
Darren J Moffat
___
zfs-discuss mailing list
zfs-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/zfs-discuss


Re: [zfs-discuss] new logbias property

2009-08-11 Thread Eric Schrock

On 08/11/09 06:03, Darren J Moffat wrote:


I thought so too initially, then I changed my mind and I like it the way 
it is.  The reason being is that describing the intent allows changing 
the implementation and keeping the meaning.  It is the intent that 
matters to the administrator not the implementation.




Also worth noting that is the fact that the use of WR_INDIRECT log 
writes is altered depending on this property.  Even in a pool with no 
dedicated log devices, changing this property can have an effect on 
overall performance, so it clearly cannot be defined as simply as use 
log devices or not.


- Eric

--
Eric Schrock, Fishworkshttp://blogs.sun.com/eschrock
___
zfs-discuss mailing list
zfs-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/zfs-discuss