[jira] Commented: (ZOOKEEPER-507) Improve error handling of BookKeeper client

2009-11-23 Thread Mahadev konar (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781779#action_12781779
 ] 

Mahadev konar commented on ZOOKEEPER-507:
-

ben,
  will you be adding javadocs to the classes?

> Improve error handling of BookKeeper client
> ---
>
> Key: ZOOKEEPER-507
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
>Assignee: Utkarsh Srivastava
> Attachments: ZOOKEEPER-507.patch
>
>
> Error handling is far from ideal currently in the BookKeeper client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-587) client should log timeout negotiated with server

2009-11-23 Thread Mahadev konar (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781741#action_12781741
 ] 

Mahadev konar commented on ZOOKEEPER-587:
-

+1 the patch looks good. 
Though we sshould add apis for getting the sesssion timeout. In c we have 
zoo_recv_timeout (which sadly doesnt have any docs on it) but in java we dont 
have any. We should add it and document saying that the session timeout is 
negotiated and how and why. This could be another jira!

> client should log timeout negotiated with server
> 
>
> Key: ZOOKEEPER-587
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.2.1
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-587.patch, ZOOKEEPER-587.patch
>
>
> The ZK client should log the timeout negotiated with the server if the time 
> is different than the timeout parameter specified by the client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-587) client should log timeout negotiated with server

2009-11-23 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781737#action_12781737
 ] 

Hadoop QA commented on ZOOKEEPER-587:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12425919/ZOOKEEPER-587.patch
  against trunk revision 882744.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no tests are needed for this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/75/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/75/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/75/console

This message is automatically generated.

> client should log timeout negotiated with server
> 
>
> Key: ZOOKEEPER-587
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.2.1
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-587.patch, ZOOKEEPER-587.patch
>
>
> The ZK client should log the timeout negotiated with the server if the time 
> is different than the timeout parameter specified by the client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-587) client should log timeout negotiated with server

2009-11-23 Thread Patrick Hunt (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-587:
---

Attachment: ZOOKEEPER-587.patch

Updated server to log message.

Note there are no tests for this - it's a logging change only. Already 
exercised by existing code.

> client should log timeout negotiated with server
> 
>
> Key: ZOOKEEPER-587
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.2.1
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-587.patch, ZOOKEEPER-587.patch
>
>
> The ZK client should log the timeout negotiated with the server if the time 
> is different than the timeout parameter specified by the client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-587) client should log timeout negotiated with server

2009-11-23 Thread Patrick Hunt (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-587:
---

Status: Patch Available  (was: Open)

> client should log timeout negotiated with server
> 
>
> Key: ZOOKEEPER-587
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.2.1
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-587.patch, ZOOKEEPER-587.patch
>
>
> The ZK client should log the timeout negotiated with the server if the time 
> is different than the timeout parameter specified by the client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[VOTE] Release ZooKeeper 3.2.2 (candidate 0)

2009-11-23 Thread Patrick Hunt 
I've created a candidate build for ZooKeeper 3.2.2. This is a bug fix 
release addressing eleven issues (two critical) -- see the release notes 
for details.


*** Please download, test and VOTE before the
*** vote closes 5pm pacific time, Friday, November 27.***

http://people.apache.org/~phunt/zookeeper-3.2.2-candidate-0/

Should we release this?

Patrick

[jira] Updated: (ZOOKEEPER-587) client should log timeout negotiated with server

2009-11-23 Thread Patrick Hunt (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-587:
---

Status: Open  (was: Patch Available)

I should be logging this in the server log as well.

> client should log timeout negotiated with server
> 
>
> Key: ZOOKEEPER-587
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.2.1
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-587.patch
>
>
> The ZK client should log the timeout negotiated with the server if the time 
> is different than the timeout parameter specified by the client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[VOTE] Release ZooKeeper 3.1.2 (candidate 0)

2009-11-23 Thread Patrick Hunt 
I've created a candidate build for ZooKeeper 3.1.2. This is a bug fix 
release addressing just two critical issues -- see the release notes for 
details.


*** Please download, test and VOTE before the
*** vote closes 4pm pacific time, Friday, November 27.***

http://people.apache.org/~phunt/zookeeper-3.1.2-candidate-0/

Should we release this?

Patrick

Hudson build is back to normal: ZooKeeper-trunk #548

2009-11-23 Thread Apache Hudson Server 
See

[jira] Commented: (ZOOKEEPER-425) Add OSGi metadata to zookeeper.jar

2009-11-23 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781578#action_12781578
 ] 

Hadoop QA commented on ZOOKEEPER-425:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12425830/buildxmlpatch.patch
  against trunk revision 882744.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no tests are needed for this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/74/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/74/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/74/console

This message is automatically generated.

> Add OSGi metadata to zookeeper.jar
> --
>
> Key: ZOOKEEPER-425
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-425
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: build
>Reporter: David Bosschaert
> Fix For: 3.3.0
>
> Attachments: buildxmlpatch.patch, MANIFEST.MF, zk_patch3.patch
>
>
> After adding OSGi metadata to zookeeper.jar it can be used as both an OSGi 
> bundle as well as an ordinary jar file. 
> In the CXF/DOSGi project the buildsystem does this using the 
> maven-bundle-plugin: 
> http://svn.apache.org/repos/asf/cxf/dosgi/trunk/discovery/distributed/zookeeper-wrapper/pom.xml
> The MANIFEST.MF generated by maven-bundle-plugin is attached to this bug, 
> this works for the CXF/DOSGi project.
> If your buildsystem isn't using maven, I would advise to use bnd 
> (http://www.aqute.biz/Code/Bnd). BND defines its own ant task in which you 
> should be able to use more or less the same instructions as were used in 
> maven:
> 
>   ZooKeeper bundle
>   This bundle contains the ZooKeeper 
> library
>   org.apache.hadoop.zookeeper
>   3.1.1
>   *
>   *;version=3.1.1
> 
> Oh and one other thing. Is it really necessary to put the source code in the 
> Jar file too? I would put that in a separate source distribution :)
> See also: 
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-user/200905.mbox/%3c4a2009b1.3030...@yahoo-inc.com%3e

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-588) remove unnecessary/annoying log of tostring error in Request.toString()

2009-11-23 Thread Patrick Hunt (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-588:
---

Attachment: ZOOKEEPER-588.patch

fixed the tostring and also addressed a problem in the caller 

1) caller now tries to log the path if it knows it (since we may not be able to 
figure out in req tostring as that's sorta a hack

2) added a few more exceptions to attempts to print reqpath in tostring

3) added more sanity checks before attempting to determine path

4) removed the annoying log message that caused this issue in the first place.

> remove unnecessary/annoying log of tostring error in Request.toString()
> ---
>
> Key: ZOOKEEPER-588
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-588
> Project: Zookeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.2.1
>Reporter: Patrick Hunt
>Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-588.patch
>
>
> Why are we logging this? It's unnecessary and just annoying afaict. We should 
> remove it entirely.
> 2009-11-18 05:37:29,312 WARN org.apache.zookeeper.server.Request: Ignoring 
> exception during toString
> java.nio.BufferUnderflowException
>   at java.nio.HeapByteBuffer.get(HeapByteBuffer.java:127)
>   at java.nio.ByteBuffer.get(ByteBuffer.java:675)
>   at org.apache.zookeeper.server.Request.toString(Request.java:199)
>   at java.lang.String.valueOf(String.java:2827)
>   at java.lang.StringBuilder.append(StringBuilder.java:115)
>   at 
> org.apache.zookeeper.server.quorum.CommitProcessor.processRequest(CommitProcessor.java:167)
>   at 
> org.apache.zookeeper.server.quorum.FollowerRequestProcessor.run(FollowerRequestProcessor.java:68)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-588) remove unnecessary/annoying log of tostring error in Request.toString()

2009-11-23 Thread Patrick Hunt (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-588:
---

Assignee: Patrick Hunt
  Status: Patch Available  (was: Open)

> remove unnecessary/annoying log of tostring error in Request.toString()
> ---
>
> Key: ZOOKEEPER-588
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-588
> Project: Zookeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.2.1
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
>Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-588.patch
>
>
> Why are we logging this? It's unnecessary and just annoying afaict. We should 
> remove it entirely.
> 2009-11-18 05:37:29,312 WARN org.apache.zookeeper.server.Request: Ignoring 
> exception during toString
> java.nio.BufferUnderflowException
>   at java.nio.HeapByteBuffer.get(HeapByteBuffer.java:127)
>   at java.nio.ByteBuffer.get(ByteBuffer.java:675)
>   at org.apache.zookeeper.server.Request.toString(Request.java:199)
>   at java.lang.String.valueOf(String.java:2827)
>   at java.lang.StringBuilder.append(StringBuilder.java:115)
>   at 
> org.apache.zookeeper.server.quorum.CommitProcessor.processRequest(CommitProcessor.java:167)
>   at 
> org.apache.zookeeper.server.quorum.FollowerRequestProcessor.run(FollowerRequestProcessor.java:68)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Fwd: Re: 1st Hadoop India User Group meet]

2009-11-23 Thread Patrick Hunt 
See attached - Hadoop India User Group meet up on 28th November 2009 in 
Noida, India. Aby Abraham will be presenting on ZooKeeper.


Patrick
--- Begin Message ---
Here is the updated agenda for Hadoop India User Group meet up on 28th November 
2009 in Noida-
- Introductions
- Sessions-
- "Enterprise perspective of Hadoop" - by Rajeev Gupta, IBM Research 
Lab, IBM
- "Apache Zookeeper" - by Aby Abraham, Yahoo! Bangalore
- "Advanced Hadoop Tuning and Optimizations"- by Sanjay Sharma, Impetus

- Establishing agenda for the next few meetings
- Information exchange: tips, tricks, problems and open discussion, sharing 
experiences on Hadoop and related technologies

The registrations are still open at http://hug-india.eventbrite.com/



Regards,
Sanjay Sharma
Impetus
t: +91-120-4363300 Extn 2761
m: +91-9958790163

-Original Message-
From: Sanjay Sharma
Sent: Tuesday, November 10, 2009 11:50 AM
To: 'gene...@hadoop.apache.org'
Subject: 1st Hadoop India User Group meet

We are planning to hold first Hadoop India user group meet up on 28th November 
2009 in Noida.

We would be talking about our experiences with Apache 
Hadoop/Hbase/Hive/PIG/Nutch/etc.

The agenda would be:
- Introductions
- Sharing experiences on Hadoop and related technologies
- Establishing agenda for the next few meetings
- Information exchange: tips, tricks, problems and open discussion
- Possible speaker TBD (invitations open!!)  {we do have something to share on 
"Hadoop for newbie" & "Hadoop Advanced Tuning"}

My company (Impetus) would be providing the meeting room and we should be able 
to accommodate around 40-60 friendly people. Coffee, Tea, and some snacks will 
be provided.

Please join the linked-in Hadoop India User Group 
(http://www.linkedin.com/groups?home=&gid=2258445&trk=anet_ug_hm) OR Yahoo 
group (http://tech.groups.yahoo.com/group/hadoopind/) and confirm your 
attendance.

Regards,
Sanjay Sharma

Follow our updates on www.twitter.com/impetuscalling.

* Impetus Technologies is exhibiting it capabilities in Mobile and Wireless in 
the GSMA Mobile Asia Congress, Hong Kong from November 16-18, 2009. Visit 
http://www.impetus.com/mlabs/GSMA_events.html for details.

NOTE: This message may contain information that is confidential, proprietary, 
privileged or otherwise protected by law. The message is intended solely for 
the named addressee. If received in error, please destroy and notify the 
sender. Any use of this email is prohibited when received in error. Impetus 
does not represent, warrant and/or guarantee, that the integrity of this 
communication has been maintained nor that the communication is free of errors, 
virus, interception or interference.
--- End Message ---

[jira] Commented: (ZOOKEEPER-425) Add OSGi metadata to zookeeper.jar

2009-11-23 Thread David Bosschaert (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781445#action_12781445
 ] 

David Bosschaert commented on ZOOKEEPER-425:


Yes, I agree that it would be better to put uses clauses on the Export-Package 
declaration. However, you really need a tool such as BND 
(http://www.aqute.biz/Code/Bnd) (or the maven-bundle-plugin which uses bnd) to 
generate these for you. Putting them in by hand is hard, error prone and 
difficult to maintain (IMHO). 

I already mention BND in the patch and would be happy to update it to get ant 
to use BND if people think this would be good. We can then let BND generate the 
uses clauses for us.

> Add OSGi metadata to zookeeper.jar
> --
>
> Key: ZOOKEEPER-425
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-425
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: build
>Reporter: David Bosschaert
> Fix For: 3.3.0
>
> Attachments: buildxmlpatch.patch, MANIFEST.MF, zk_patch3.patch
>
>
> After adding OSGi metadata to zookeeper.jar it can be used as both an OSGi 
> bundle as well as an ordinary jar file. 
> In the CXF/DOSGi project the buildsystem does this using the 
> maven-bundle-plugin: 
> http://svn.apache.org/repos/asf/cxf/dosgi/trunk/discovery/distributed/zookeeper-wrapper/pom.xml
> The MANIFEST.MF generated by maven-bundle-plugin is attached to this bug, 
> this works for the CXF/DOSGi project.
> If your buildsystem isn't using maven, I would advise to use bnd 
> (http://www.aqute.biz/Code/Bnd). BND defines its own ant task in which you 
> should be able to use more or less the same instructions as were used in 
> maven:
> 
>   ZooKeeper bundle
>   This bundle contains the ZooKeeper 
> library
>   org.apache.hadoop.zookeeper
>   3.1.1
>   *
>   *;version=3.1.1
> 
> Oh and one other thing. Is it really necessary to put the source code in the 
> Jar file too? I would put that in a separate source distribution :)
> See also: 
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-user/200905.mbox/%3c4a2009b1.3030...@yahoo-inc.com%3e

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-425) Add OSGi metadata to zookeeper.jar

2009-11-23 Thread Alan Cabrera (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781441#action_12781441
 ] 

Alan Cabrera commented on ZOOKEEPER-425:


Just curious, no "uses" clauses?

> Add OSGi metadata to zookeeper.jar
> --
>
> Key: ZOOKEEPER-425
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-425
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: build
>Reporter: David Bosschaert
> Fix For: 3.3.0
>
> Attachments: buildxmlpatch.patch, MANIFEST.MF, zk_patch3.patch
>
>
> After adding OSGi metadata to zookeeper.jar it can be used as both an OSGi 
> bundle as well as an ordinary jar file. 
> In the CXF/DOSGi project the buildsystem does this using the 
> maven-bundle-plugin: 
> http://svn.apache.org/repos/asf/cxf/dosgi/trunk/discovery/distributed/zookeeper-wrapper/pom.xml
> The MANIFEST.MF generated by maven-bundle-plugin is attached to this bug, 
> this works for the CXF/DOSGi project.
> If your buildsystem isn't using maven, I would advise to use bnd 
> (http://www.aqute.biz/Code/Bnd). BND defines its own ant task in which you 
> should be able to use more or less the same instructions as were used in 
> maven:
> 
>   ZooKeeper bundle
>   This bundle contains the ZooKeeper 
> library
>   org.apache.hadoop.zookeeper
>   3.1.1
>   *
>   *;version=3.1.1
> 
> Oh and one other thing. Is it really necessary to put the source code in the 
> Jar file too? I would put that in a separate source distribution :)
> See also: 
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-user/200905.mbox/%3c4a2009b1.3030...@yahoo-inc.com%3e

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-99) All MXBeans interfaces that don't use complex paramters need to be renamed as MBean interaces.

2009-11-23 Thread Hiram Chirino (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781376#action_12781376
 ] 

Hiram Chirino commented on ZOOKEEPER-99:


Hi Patrick, if it runs fine on java 1.5, then it should run fine in JBoss.

> All MXBeans interfaces that don't use complex paramters need to be renamed as 
> MBean interaces. 
> ---
>
> Key: ZOOKEEPER-99
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-99
> Project: Zookeeper
>  Issue Type: Bug
>  Components: jmx
>Reporter: Hiram Chirino
> Attachments: ZOOKEEPER-99.patch
>
>
> All the MXBean interfaces that I've looked at are standard MBean interfaces.  
> The interface names should get renamed to MBean instaead of MXBean. That way 
> the server can also run on a the Java 1.5 Platform.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-425) Add OSGi metadata to zookeeper.jar

2009-11-23 Thread David Bosschaert (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert updated ZOOKEEPER-425:
---

Attachment: buildxmlpatch.patch

The patch named 'buildxmlpatch.patch' contains changes to the build.xml to 
cover case 1.

It does an export-package of 
  org.apache.zookeeper.server
  org.apache.zookeeper.server.quorum
to make it possible to launch the server process from a separate bundle. 

If the general feeling is that the Zookeeper codebase isn't ready for case 3, 
I'm happy to host my Activator/ManageService elsewhere until it is ready for it.

> Add OSGi metadata to zookeeper.jar
> --
>
> Key: ZOOKEEPER-425
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-425
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: build
>Reporter: David Bosschaert
> Fix For: 3.3.0
>
> Attachments: buildxmlpatch.patch, MANIFEST.MF, zk_patch3.patch
>
>
> After adding OSGi metadata to zookeeper.jar it can be used as both an OSGi 
> bundle as well as an ordinary jar file. 
> In the CXF/DOSGi project the buildsystem does this using the 
> maven-bundle-plugin: 
> http://svn.apache.org/repos/asf/cxf/dosgi/trunk/discovery/distributed/zookeeper-wrapper/pom.xml
> The MANIFEST.MF generated by maven-bundle-plugin is attached to this bug, 
> this works for the CXF/DOSGi project.
> If your buildsystem isn't using maven, I would advise to use bnd 
> (http://www.aqute.biz/Code/Bnd). BND defines its own ant task in which you 
> should be able to use more or less the same instructions as were used in 
> maven:
> 
>   ZooKeeper bundle
>   This bundle contains the ZooKeeper 
> library
>   org.apache.hadoop.zookeeper
>   3.1.1
>   *
>   *;version=3.1.1
> 
> Oh and one other thing. Is it really necessary to put the source code in the 
> Jar file too? I would put that in a separate source distribution :)
> See also: 
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-user/200905.mbox/%3c4a2009b1.3030...@yahoo-inc.com%3e

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-425) Add OSGi metadata to zookeeper.jar

2009-11-23 Thread David Bosschaert (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert updated ZOOKEEPER-425:
---

 Tags: osgi
Fix Version/s: 3.3.0
Affects Version/s: (was: 3.1.1)
   Status: Patch Available  (was: Open)

> Add OSGi metadata to zookeeper.jar
> --
>
> Key: ZOOKEEPER-425
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-425
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: build
>Reporter: David Bosschaert
> Fix For: 3.3.0
>
> Attachments: MANIFEST.MF, zk_patch3.patch
>
>
> After adding OSGi metadata to zookeeper.jar it can be used as both an OSGi 
> bundle as well as an ordinary jar file. 
> In the CXF/DOSGi project the buildsystem does this using the 
> maven-bundle-plugin: 
> http://svn.apache.org/repos/asf/cxf/dosgi/trunk/discovery/distributed/zookeeper-wrapper/pom.xml
> The MANIFEST.MF generated by maven-bundle-plugin is attached to this bug, 
> this works for the CXF/DOSGi project.
> If your buildsystem isn't using maven, I would advise to use bnd 
> (http://www.aqute.biz/Code/Bnd). BND defines its own ant task in which you 
> should be able to use more or less the same instructions as were used in 
> maven:
> 
>   ZooKeeper bundle
>   This bundle contains the ZooKeeper 
> library
>   org.apache.hadoop.zookeeper
>   3.1.1
>   *
>   *;version=3.1.1
> 
> Oh and one other thing. Is it really necessary to put the source code in the 
> Jar file too? I would put that in a separate source distribution :)
> See also: 
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-user/200905.mbox/%3c4a2009b1.3030...@yahoo-inc.com%3e

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (ZOOKEEPER-591) The C Client cannot exit properly in some situation

2009-11-23 Thread Qian Ye (JIRA) 
The C Client cannot exit properly in some situation
---

 Key: ZOOKEEPER-591
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-591
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.2.1
 Environment: Linux db-passport-test05.vm 2.6.9_5-4-0-5 #1 SMP Tue Apr 
14 15:56:24 CST 2009 x86_64 x86_64 x86_64 GNU/Linux 
Reporter: Qian Ye


The following code produce a situation, where the C Client can not exit 
properly,

#include "include/zookeeper.h"

void default_zoo_watcher(zhandle_t *zzh, int type, int state, const char *path, 
void* context){
int zrc = 0;
struct String_vector str_vec = {0, NULL};
printf("in the default_zoo_watcher\n");
zrc = zoo_wget_children(zzh, "/mytest", default_zoo_watcher, NULL, 
&str_vec);
printf("zoo_wget_children, error: %d\n", zrc);

return;
}

int main()
{
int zrc = 0;
int buff_len = 10; 
char buff[10] = "hello";
char path[512];
struct Stat stat;
struct String_vector str_vec = {0, NULL};

zhandle_t *zh = zookeeper_init("10.81.20.62:2181", NULL, 3, 0, 0, 0); 
zrc = zoo_create(zh, "/mytest", buff, 10, &ZOO_OPEN_ACL_UNSAFE, 0, path, 
512);
printf("zoo_create, error: %d\n", zrc);

zrc = zoo_wget_children(zh, "/mytest", default_zoo_watcher, NULL, &str_vec);
printf("zoo_wget_children, error: %d\n", zrc);

zrc = zoo_create(zh, "/mytest/test1", buff, 10, &ZOO_OPEN_ACL_UNSAFE, 0, 
path, 512);
printf("zoo_create, error: %d\n", zrc);

zrc = zoo_wget_children(zh, "/mytest", default_zoo_watcher, NULL, &str_vec);
printf("zoo_wget_children, error: %d\n", zrc);

zrc = zoo_delete(zh, "/mytest/test1", -1);

printf("zoo_delete, error: %d\n", zrc);
zookeeper_close(zh);
return 0;
}


running this code can cause the program hang at zookeeper_close(zh);(line 38). 
using gdb to attach the process, I found that the main thread is waiting for 
do_completion thread to finish,
(gdb) bt
#0  0x00302b806ffb in pthread_join () from /lib64/tls/libpthread.so.0
#1  0x0040de3b in adaptor_finish (zh=0x515b60) at src/mt_adaptor.c:219
#2  0x004060ba in zookeeper_close (zh=0x515b60) at src/zookeeper.c:2100
#3  0x0040220b in main ()

and the thread which handle the zoo_wget_children(in the default_zoo_watcher) 
is waiting for sc->cond. 
(gdb) thread 2
[Switching to thread 2 (Thread 1094719840 (LWP 25093))]#0  0x00302b8089aa 
in pthread_cond_wait@@GLIBC_2.3.2 ()
   from /lib64/tls/libpthread.so.0
(gdb) bt
#0  0x00302b8089aa in pthread_cond_wait@@GLIBC_2.3.2 () from 
/lib64/tls/libpthread.so.0
#1  0x0040d88b in wait_sync_completion (sc=0x5167f0) at 
src/mt_adaptor.c:82
#2  0x004082c9 in zoo_wget_children (zh=0x515b60, path=0x40ebc0 
"/mytest", watcher=0x401fd8 , watcherCtx=Variable 
"watcherCtx" is not available.)
at src/zookeeper.c:2884
#3  0x00402037 in default_zoo_watcher ()
#4  0x0040d664 in deliverWatchers (zh=0x515b60, type=4, state=3, 
path=0x515100 "/mytest", list=0x5177d8) at src/zk_hashtable.c:274
#5  0x00403861 in process_completions (zh=0x515b60) at 
src/zookeeper.c:1631
#6  0x0040e1b5 in do_completion (v=Variable "v" is not available.) at 
src/mt_adaptor.c:333
#7  0x00302b80610a in start_thread () from /lib64/tls/libpthread.so.0
#8  0x00302afc6003 in clone () from /lib64/tls/libc.so.6
#9  0x in ?? ()

here, a deadlock presents.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-587) client should log timeout negotiated with server

2009-11-23 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781332#action_12781332
 ] 

Hadoop QA commented on ZOOKEEPER-587:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12425811/ZOOKEEPER-587.patch
  against trunk revision 882744.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no tests are needed for this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/73/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/73/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/73/console

This message is automatically generated.

> client should log timeout negotiated with server
> 
>
> Key: ZOOKEEPER-587
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.2.1
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-587.patch
>
>
> The ZK client should log the timeout negotiated with the server if the time 
> is different than the timeout parameter specified by the client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-587) client should log timeout negotiated with server

2009-11-23 Thread Patrick Hunt (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-587:
---

Assignee: Patrick Hunt
  Status: Patch Available  (was: Open)

> client should log timeout negotiated with server
> 
>
> Key: ZOOKEEPER-587
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.2.1
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-587.patch
>
>
> The ZK client should log the timeout negotiated with the server if the time 
> is different than the timeout parameter specified by the client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-587) client should log timeout negotiated with server

2009-11-23 Thread Patrick Hunt (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-587:
---

Attachment: ZOOKEEPER-587.patch

this patch adds negotiated timeout to both the c and java log messages

I also add the destination server for the session to the java message (already 
on c log message)

> client should log timeout negotiated with server
> 
>
> Key: ZOOKEEPER-587
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.2.1
>Reporter: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-587.patch
>
>
> The ZK client should log the timeout negotiated with the server if the time 
> is different than the timeout parameter specified by the client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.