[jira] Commented: (ZOOKEEPER-690) AsyncTestHammer test fails on hudson.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12862594#action_12862594 ] Hadoop QA commented on ZOOKEEPER-690: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443246/ZOOKEEPER-690.patch against trunk revision 939172. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/77/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/77/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/77/console This message is automatically generated. AsyncTestHammer test fails on hudson. - Key: ZOOKEEPER-690 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-690 Project: Zookeeper Issue Type: Bug Reporter: Mahadev konar Assignee: Henry Robinson Priority: Blocker Fix For: 3.3.1, 3.4.0 Attachments: jstack-201004201053.txt, jstack-201004291409.txt, jstack-201004291527.txt, nohup-201004201053.txt, nohup-201004291409.txt, nohup-201004291527.txt, TEST-org.apache.zookeeper.test.AsyncHammerTest.txt, zoo.log, ZOOKEEPER-690.patch, ZOOKEEPER-690.patch, ZOOKEEPER-690.patch the hudson test failed on http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/2/testReport/. There are huge set of cancelledkeyexceptions in the logs. Still going through the logs to find out the reason for failure. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Hudson build is back to normal : ZooKeeper-trunk #809
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/809/
[jira] Updated: (ZOOKEEPER-758) zkpython segfaults on invalid acl with missing key
[
https://issues.apache.org/jira/browse/ZOOKEEPER-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-758:
-
Attachment: ZOOKEEPER-758.patch
Kapil -
Thanks for the patch! Unfortunately it didn't apply cleanly against trunk
because I think you had added 'test_acl_validity' to acl_test.py which was not
included in the diff.
I'm attaching a patch that applies cleanly to trunk - no code changes from your
patch.
Thanks,
Henry
zkpython segfaults on invalid acl with missing key
--
Key: ZOOKEEPER-758
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-758
Project: Zookeeper
Issue Type: Bug
Components: contrib-bindings
Affects Versions: 3.3.0, 3.4.0
Environment: ubuntu lucid (10.04)
Reporter: Kapil Thangavelu
Attachments: invalid-acl-fix-and-test.diff, ZOOKEEPER-758.patch
Currently when setting an acl, there is a minimal parse to ensure that its a
list of dicts, however if one of the dicts is missing a required key, the
subsequent usage doesn't check for it, and will segfault.. for example using
an acl of [{schema:id, id:world, permissions:PERM_ALL}] will segfault if
used, because the scheme key is missing (its been purposefully typo'd to
schema in example).
I've expanded the check_acl macro to include verifying that all keys are
present and added some unit tests against trunk in the attachments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-758) zkpython segfaults on invalid acl with missing key
[
https://issues.apache.org/jira/browse/ZOOKEEPER-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-758:
-
Status: Patch Available (was: Open)
Hadoop Flags: [Reviewed]
I have reviewed this, and it looks good. Thanks Kapil!
zkpython segfaults on invalid acl with missing key
--
Key: ZOOKEEPER-758
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-758
Project: Zookeeper
Issue Type: Bug
Components: contrib-bindings
Affects Versions: 3.3.0, 3.4.0
Environment: ubuntu lucid (10.04)
Reporter: Kapil Thangavelu
Attachments: invalid-acl-fix-and-test.diff, ZOOKEEPER-758.patch
Currently when setting an acl, there is a minimal parse to ensure that its a
list of dicts, however if one of the dicts is missing a required key, the
subsequent usage doesn't check for it, and will segfault.. for example using
an acl of [{schema:id, id:world, permissions:PERM_ALL}] will segfault if
used, because the scheme key is missing (its been purposefully typo'd to
schema in example).
I've expanded the check_acl macro to include verifying that all keys are
present and added some unit tests against trunk in the attachments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-758) zkpython segfaults on invalid acl with missing key
[
https://issues.apache.org/jira/browse/ZOOKEEPER-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12862745#action_12862745
]
Hadoop QA commented on ZOOKEEPER-758:
-
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12443299/ZOOKEEPER-758.patch
against trunk revision 939172.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/78/console
This message is automatically generated.
zkpython segfaults on invalid acl with missing key
--
Key: ZOOKEEPER-758
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-758
Project: Zookeeper
Issue Type: Bug
Components: contrib-bindings
Affects Versions: 3.3.0, 3.4.0
Environment: ubuntu lucid (10.04)
Reporter: Kapil Thangavelu
Attachments: invalid-acl-fix-and-test.diff, ZOOKEEPER-758.patch
Currently when setting an acl, there is a minimal parse to ensure that its a
list of dicts, however if one of the dicts is missing a required key, the
subsequent usage doesn't check for it, and will segfault.. for example using
an acl of [{schema:id, id:world, permissions:PERM_ALL}] will segfault if
used, because the scheme key is missing (its been purposefully typo'd to
schema in example).
I've expanded the check_acl macro to include verifying that all keys are
present and added some unit tests against trunk in the attachments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-758) zkpython segfaults on invalid acl with missing key
[
https://issues.apache.org/jira/browse/ZOOKEEPER-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-758:
-
Attachment: ZOOKEEPER-758.patch
forgot --no-prefix.
zkpython segfaults on invalid acl with missing key
--
Key: ZOOKEEPER-758
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-758
Project: Zookeeper
Issue Type: Bug
Components: contrib-bindings
Affects Versions: 3.3.0, 3.4.0
Environment: ubuntu lucid (10.04)
Reporter: Kapil Thangavelu
Attachments: invalid-acl-fix-and-test.diff, ZOOKEEPER-758.patch,
ZOOKEEPER-758.patch
Currently when setting an acl, there is a minimal parse to ensure that its a
list of dicts, however if one of the dicts is missing a required key, the
subsequent usage doesn't check for it, and will segfault.. for example using
an acl of [{schema:id, id:world, permissions:PERM_ALL}] will segfault if
used, because the scheme key is missing (its been purposefully typo'd to
schema in example).
I've expanded the check_acl macro to include verifying that all keys are
present and added some unit tests against trunk in the attachments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-758) zkpython segfaults on invalid acl with missing key
[
https://issues.apache.org/jira/browse/ZOOKEEPER-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-758:
-
Status: Patch Available (was: Open)
zkpython segfaults on invalid acl with missing key
--
Key: ZOOKEEPER-758
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-758
Project: Zookeeper
Issue Type: Bug
Components: contrib-bindings
Affects Versions: 3.3.0, 3.4.0
Environment: ubuntu lucid (10.04)
Reporter: Kapil Thangavelu
Attachments: invalid-acl-fix-and-test.diff, ZOOKEEPER-758.patch,
ZOOKEEPER-758.patch
Currently when setting an acl, there is a minimal parse to ensure that its a
list of dicts, however if one of the dicts is missing a required key, the
subsequent usage doesn't check for it, and will segfault.. for example using
an acl of [{schema:id, id:world, permissions:PERM_ALL}] will segfault if
used, because the scheme key is missing (its been purposefully typo'd to
schema in example).
I've expanded the check_acl macro to include verifying that all keys are
present and added some unit tests against trunk in the attachments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-758) zkpython segfaults on invalid acl with missing key
[
https://issues.apache.org/jira/browse/ZOOKEEPER-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-758:
-
Status: Open (was: Patch Available)
zkpython segfaults on invalid acl with missing key
--
Key: ZOOKEEPER-758
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-758
Project: Zookeeper
Issue Type: Bug
Components: contrib-bindings
Affects Versions: 3.3.0, 3.4.0
Environment: ubuntu lucid (10.04)
Reporter: Kapil Thangavelu
Attachments: invalid-acl-fix-and-test.diff, ZOOKEEPER-758.patch,
ZOOKEEPER-758.patch
Currently when setting an acl, there is a minimal parse to ensure that its a
list of dicts, however if one of the dicts is missing a required key, the
subsequent usage doesn't check for it, and will segfault.. for example using
an acl of [{schema:id, id:world, permissions:PERM_ALL}] will segfault if
used, because the scheme key is missing (its been purposefully typo'd to
schema in example).
I've expanded the check_acl macro to include verifying that all keys are
present and added some unit tests against trunk in the attachments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-758) zkpython segfaults on invalid acl with missing key
[
https://issues.apache.org/jira/browse/ZOOKEEPER-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12862768#action_12862768
]
Hadoop QA commented on ZOOKEEPER-758:
-
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12443301/ZOOKEEPER-758.patch
against trunk revision 939172.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/79/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/79/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/79/console
This message is automatically generated.
zkpython segfaults on invalid acl with missing key
--
Key: ZOOKEEPER-758
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-758
Project: Zookeeper
Issue Type: Bug
Components: contrib-bindings
Affects Versions: 3.3.0, 3.4.0
Environment: ubuntu lucid (10.04)
Reporter: Kapil Thangavelu
Attachments: invalid-acl-fix-and-test.diff, ZOOKEEPER-758.patch,
ZOOKEEPER-758.patch
Currently when setting an acl, there is a minimal parse to ensure that its a
list of dicts, however if one of the dicts is missing a required key, the
subsequent usage doesn't check for it, and will segfault.. for example using
an acl of [{schema:id, id:world, permissions:PERM_ALL}] will segfault if
used, because the scheme key is missing (its been purposefully typo'd to
schema in example).
I've expanded the check_acl macro to include verifying that all keys are
present and added some unit tests against trunk in the attachments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-737) some 4 letter words may fail with netcat (nc)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-737: Attachment: ZOOKEEPER-737.patch this patch makes all commands to run as threads. Also, this includes refactoring of the command code into seperate classes. I am really looking forward to Netty, this is just getting too hairy in NIOServerCnxn! some 4 letter words may fail with netcat (nc) - Key: ZOOKEEPER-737 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-737 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.3.0 Reporter: Patrick Hunt Assignee: Mahadev konar Priority: Blocker Fix For: 3.3.1, 3.4.0 Attachments: ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, ZOOKEEPER-737.patch nc closes the write channel as soon as it's sent it's information, for example echo stat|nc localhost 2181 in general this is fine, however the server code will close the socket as soon as it receives notice that nc has closed it's write channel. if not all the 4 letter word result has been written back to the client yet, this will cause some or all of the result to be lost - ie the client will not see the full result. this was introduced in 3.3.0 as part of a change to reduce blocking of the selector by long running 4letter words. here's an example of the logs from the server during this echo -n stat | nc localhost 2181 2010-04-09 21:55:36,124 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioservercnxn$fact...@251] - Accepted socket connection from /127.0.0.1:42179 2010-04-09 21:55:36,124 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@968] - Processing stat command from /127.0.0.1:42179 2010-04-09 21:55:36,125 - WARN [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@606] - EndOfStreamException: Unable to read additional data from client sessionid 0x0, likely client has closed socket 2010-04-09 21:55:36,125 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@1286] - Closed socket connection for client /127.0.0.1:42179 (no session established for client) [ph...@gsbl90850 zookeeper-3.3.0]$ 2010-04-09 21:55:36,126 - ERROR [Thread-15:nioserverc...@422] - Unexpected Exception: java.nio.channels.CancelledKeyException at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55) at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:59) at org.apache.zookeeper.server.NIOServerCnxn.sendBuffer(NIOServerCnxn.java:395) at org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(NIOServerCnxn.java:907) at org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.flush(NIOServerCnxn.java:945) at java.io.BufferedWriter.flush(BufferedWriter.java:236) at java.io.PrintWriter.flush(PrintWriter.java:276) at org.apache.zookeeper.server.NIOServerCnxn$2.run(NIOServerCnxn.java:1089) 2010-04-09 21:55:36,126 - ERROR [Thread-15:nioservercnxn$factor...@82] - Thread Thread[Thread-15,5,main] died java.nio.channels.CancelledKeyException at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55) at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:64) at org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.wakeup(NIOServerCnxn.java:927) at org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(NIOServerCnxn.java:909) at org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.flush(NIOServerCnxn.java:945) at java.io.BufferedWriter.flush(BufferedWriter.java:236) at java.io.PrintWriter.flush(PrintWriter.java:276) at org.apache.zookeeper.server.NIOServerCnxn$2.run(NIOServerCnxn.java:1089) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-737) some 4 letter words may fail with netcat (nc)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-737: Status: Open (was: Patch Available) some 4 letter words may fail with netcat (nc) - Key: ZOOKEEPER-737 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-737 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.3.0 Reporter: Patrick Hunt Assignee: Mahadev konar Priority: Blocker Fix For: 3.3.1, 3.4.0 Attachments: ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, ZOOKEEPER-737.patch nc closes the write channel as soon as it's sent it's information, for example echo stat|nc localhost 2181 in general this is fine, however the server code will close the socket as soon as it receives notice that nc has closed it's write channel. if not all the 4 letter word result has been written back to the client yet, this will cause some or all of the result to be lost - ie the client will not see the full result. this was introduced in 3.3.0 as part of a change to reduce blocking of the selector by long running 4letter words. here's an example of the logs from the server during this echo -n stat | nc localhost 2181 2010-04-09 21:55:36,124 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioservercnxn$fact...@251] - Accepted socket connection from /127.0.0.1:42179 2010-04-09 21:55:36,124 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@968] - Processing stat command from /127.0.0.1:42179 2010-04-09 21:55:36,125 - WARN [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@606] - EndOfStreamException: Unable to read additional data from client sessionid 0x0, likely client has closed socket 2010-04-09 21:55:36,125 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@1286] - Closed socket connection for client /127.0.0.1:42179 (no session established for client) [ph...@gsbl90850 zookeeper-3.3.0]$ 2010-04-09 21:55:36,126 - ERROR [Thread-15:nioserverc...@422] - Unexpected Exception: java.nio.channels.CancelledKeyException at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55) at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:59) at org.apache.zookeeper.server.NIOServerCnxn.sendBuffer(NIOServerCnxn.java:395) at org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(NIOServerCnxn.java:907) at org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.flush(NIOServerCnxn.java:945) at java.io.BufferedWriter.flush(BufferedWriter.java:236) at java.io.PrintWriter.flush(PrintWriter.java:276) at org.apache.zookeeper.server.NIOServerCnxn$2.run(NIOServerCnxn.java:1089) 2010-04-09 21:55:36,126 - ERROR [Thread-15:nioservercnxn$factor...@82] - Thread Thread[Thread-15,5,main] died java.nio.channels.CancelledKeyException at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55) at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:64) at org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.wakeup(NIOServerCnxn.java:927) at org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(NIOServerCnxn.java:909) at org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.flush(NIOServerCnxn.java:945) at java.io.BufferedWriter.flush(BufferedWriter.java:236) at java.io.PrintWriter.flush(PrintWriter.java:276) at org.apache.zookeeper.server.NIOServerCnxn$2.run(NIOServerCnxn.java:1089) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-737) some 4 letter words may fail with netcat (nc)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12862863#action_12862863 ] Hadoop QA commented on ZOOKEEPER-737: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443310/ZOOKEEPER-737.patch against trunk revision 939172. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/80/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/80/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/80/console This message is automatically generated. some 4 letter words may fail with netcat (nc) - Key: ZOOKEEPER-737 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-737 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.3.0 Reporter: Patrick Hunt Assignee: Mahadev konar Priority: Blocker Fix For: 3.3.1, 3.4.0 Attachments: ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, ZOOKEEPER-737.patch nc closes the write channel as soon as it's sent it's information, for example echo stat|nc localhost 2181 in general this is fine, however the server code will close the socket as soon as it receives notice that nc has closed it's write channel. if not all the 4 letter word result has been written back to the client yet, this will cause some or all of the result to be lost - ie the client will not see the full result. this was introduced in 3.3.0 as part of a change to reduce blocking of the selector by long running 4letter words. here's an example of the logs from the server during this echo -n stat | nc localhost 2181 2010-04-09 21:55:36,124 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioservercnxn$fact...@251] - Accepted socket connection from /127.0.0.1:42179 2010-04-09 21:55:36,124 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@968] - Processing stat command from /127.0.0.1:42179 2010-04-09 21:55:36,125 - WARN [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@606] - EndOfStreamException: Unable to read additional data from client sessionid 0x0, likely client has closed socket 2010-04-09 21:55:36,125 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@1286] - Closed socket connection for client /127.0.0.1:42179 (no session established for client) [ph...@gsbl90850 zookeeper-3.3.0]$ 2010-04-09 21:55:36,126 - ERROR [Thread-15:nioserverc...@422] - Unexpected Exception: java.nio.channels.CancelledKeyException at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55) at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:59) at org.apache.zookeeper.server.NIOServerCnxn.sendBuffer(NIOServerCnxn.java:395) at org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(NIOServerCnxn.java:907) at org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.flush(NIOServerCnxn.java:945) at java.io.BufferedWriter.flush(BufferedWriter.java:236) at java.io.PrintWriter.flush(PrintWriter.java:276) at org.apache.zookeeper.server.NIOServerCnxn$2.run(NIOServerCnxn.java:1089) 2010-04-09 21:55:36,126 - ERROR [Thread-15:nioservercnxn$factor...@82] - Thread Thread[Thread-15,5,main] died java.nio.channels.CancelledKeyException at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55) at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:64) at org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.wakeup(NIOServerCnxn.java:927) at org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(NIOServerCnxn.java:909) at org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.flush(NIOServerCnxn.java:945) at java.io.BufferedWriter.flush(BufferedWriter.java:236) at
[jira] Updated: (ZOOKEEPER-758) zkpython segfaults on invalid acl with missing key
[
https://issues.apache.org/jira/browse/ZOOKEEPER-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-758:
-
Status: Resolved (was: Patch Available)
Fix Version/s: 3.3.1
3.4.0
Resolution: Fixed
I just committed this. Thanks Kapil!
zkpython segfaults on invalid acl with missing key
--
Key: ZOOKEEPER-758
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-758
Project: Zookeeper
Issue Type: Bug
Components: contrib-bindings
Affects Versions: 3.3.0, 3.4.0
Environment: ubuntu lucid (10.04)
Reporter: Kapil Thangavelu
Fix For: 3.3.1, 3.4.0
Attachments: invalid-acl-fix-and-test.diff, ZOOKEEPER-758.patch,
ZOOKEEPER-758.patch
Currently when setting an acl, there is a minimal parse to ensure that its a
list of dicts, however if one of the dicts is missing a required key, the
subsequent usage doesn't check for it, and will segfault.. for example using
an acl of [{schema:id, id:world, permissions:PERM_ALL}] will segfault if
used, because the scheme key is missing (its been purposefully typo'd to
schema in example).
I've expanded the check_acl macro to include verifying that all keys are
present and added some unit tests against trunk in the attachments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-758) zkpython segfaults on invalid acl with missing key
[
https://issues.apache.org/jira/browse/ZOOKEEPER-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-758:
Assignee: Kapil Thangavelu
zkpython segfaults on invalid acl with missing key
--
Key: ZOOKEEPER-758
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-758
Project: Zookeeper
Issue Type: Bug
Components: contrib-bindings
Affects Versions: 3.3.0, 3.4.0
Environment: ubuntu lucid (10.04)
Reporter: Kapil Thangavelu
Assignee: Kapil Thangavelu
Fix For: 3.3.1, 3.4.0
Attachments: invalid-acl-fix-and-test.diff, ZOOKEEPER-758.patch,
ZOOKEEPER-758.patch
Currently when setting an acl, there is a minimal parse to ensure that its a
list of dicts, however if one of the dicts is missing a required key, the
subsequent usage doesn't check for it, and will segfault.. for example using
an acl of [{schema:id, id:world, permissions:PERM_ALL}] will segfault if
used, because the scheme key is missing (its been purposefully typo'd to
schema in example).
I've expanded the check_acl macro to include verifying that all keys are
present and added some unit tests against trunk in the attachments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
