[jira] Created: (ZOOKEEPER-776) API should sanity check sessionTimeout argument
API should sanity check sessionTimeout argument --- Key: ZOOKEEPER-776 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776 Project: Zookeeper Issue Type: Improvement Components: java client Affects Versions: 3.3.1, 3.3.0, 3.2.2 Environment: OSX 10.6.3, JVM 1.6.0-20 Reporter: Gregory Haskins Priority: Minor passing in a 0 sessionTimeout to ZooKeeper() constructor leads to errors in subsequent operations. It would be ideal to capture this configuration error at the source by throwing something like an IllegalArgument exception when the bogus sessionTimeout is specified, instead of later when it is utilized. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-777) setting acl on a non existant node should return no node error
setting acl on a non existant node should return no node error -- Key: ZOOKEEPER-777 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-777 Project: Zookeeper Issue Type: Bug Components: server Reporter: Kapil Thangavelu currently it just returns successfully, but the acl can't be retrieved, and if any value is being stored, its overwritten when the node is created. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-777) setting acl on a non existant node should return no node error
[ https://issues.apache.org/jira/browse/ZOOKEEPER-777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-777: --- Fix Version/s: 3.4.0 Affects Version/s: 3.3.1 3.3.0 Nice one! Fixing this would be a great opportunity for someone interested to learn more about server side code. ;-) setting acl on a non existant node should return no node error -- Key: ZOOKEEPER-777 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-777 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.3.0, 3.3.1 Reporter: Kapil Thangavelu Fix For: 3.4.0 currently it just returns successfully, but the acl can't be retrieved, and if any value is being stored, its overwritten when the node is created. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-776) API should sanity check sessionTimeout argument
[ https://issues.apache.org/jira/browse/ZOOKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-776: --- Fix Version/s: 3.4.0 Component/s: c client This would be a good hole to close. We should throw the exception/error log when 0 is passed. We need to fix java and also verify/fix C client code. This would be an excellent first project for someone interested in becoming a contributor to zk. :-) API should sanity check sessionTimeout argument --- Key: ZOOKEEPER-776 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776 Project: Zookeeper Issue Type: Improvement Components: c client, java client Affects Versions: 3.2.2, 3.3.0, 3.3.1 Environment: OSX 10.6.3, JVM 1.6.0-20 Reporter: Gregory Haskins Priority: Minor Fix For: 3.4.0 passing in a 0 sessionTimeout to ZooKeeper() constructor leads to errors in subsequent operations. It would be ideal to capture this configuration error at the source by throwing something like an IllegalArgument exception when the bogus sessionTimeout is specified, instead of later when it is utilized. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-769) Leader can treat observers as quorum members
[ https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870024#action_12870024 ] Patrick Hunt commented on ZOOKEEPER-769: Hudson seems to be having problems these days, 2 of the machines (h7/h8) have been offline all week, and h1 seems to be having issues as well. I think the failure is unrelated. ff to commit. Leader can treat observers as quorum members Key: ZOOKEEPER-769 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769 Project: Zookeeper Issue Type: Bug Affects Versions: 3.3.0 Environment: Ubuntu Karmic x64 Reporter: Sergey Doroshenko Assignee: Sergey Doroshenko Fix For: 3.4.0 Attachments: follower.log, leader.log, observer.log, warning.patch, zoo1.cfg, ZOOKEEPER-769.patch, ZOOKEEPER-769.patch In short: it seems leader can treat observers as quorum members. Steps to repro: 1. Server configuration: 3 voters, 2 observers (attached). 2. Bring up 2 voters and one observer. It's enough for quorum. 3. Shut down the one from the quorum who is the follower. As I understand, expected result is that leader will start a new election round so that to regain quorum. But the real situation is that it just says goodbye to that follower, and is still operable. (When I'm shutting down 3rd one -- observer -- leader starts trying to regain a quorum). (Expectedly, if on step 3 we shut down the leader, not the follower, remaining follower starta new leader election, as it should be). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-769) Leader can treat observers as quorum members
[ https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Robinson updated ZOOKEEPER-769: - Status: Resolved (was: Patch Available) Resolution: Fixed I just committed this - thanks Sergey! Leader can treat observers as quorum members Key: ZOOKEEPER-769 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769 Project: Zookeeper Issue Type: Bug Affects Versions: 3.3.0 Environment: Ubuntu Karmic x64 Reporter: Sergey Doroshenko Assignee: Sergey Doroshenko Fix For: 3.4.0 Attachments: follower.log, leader.log, observer.log, warning.patch, zoo1.cfg, ZOOKEEPER-769.patch, ZOOKEEPER-769.patch In short: it seems leader can treat observers as quorum members. Steps to repro: 1. Server configuration: 3 voters, 2 observers (attached). 2. Bring up 2 voters and one observer. It's enough for quorum. 3. Shut down the one from the quorum who is the follower. As I understand, expected result is that leader will start a new election round so that to regain quorum. But the real situation is that it just says goodbye to that follower, and is still operable. (When I'm shutting down 3rd one -- observer -- leader starts trying to regain a quorum). (Expectedly, if on step 3 we shut down the leader, not the follower, remaining follower starta new leader election, as it should be). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-776) API should sanity check sessionTimeout argument
[
https://issues.apache.org/jira/browse/ZOOKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gregory Haskins updated ZOOKEEPER-776:
--
Status: Patch Available (was: Open)
commit 840f56d388582e1df39f7513aa7f4d4ce0610718
Author: Gregory Haskins ghask...@novell.com
Date: Fri May 21 14:58:14 2010 -0400
javaclient: validate sessionTimeout field at ZooKeeper init
JIRA ZOOKEEPER-776 describes the following problem:
passing in a 0 sessionTimeout to ZooKeeper() constructor leads to errors
in subsequent operations. It would be ideal to capture this configuration
error at the source by throwing something like an IllegalArgument exception
when the bogus sessionTimeout is specified, instead of later when it is
utilized.
This patch is a proposal to fix the problem referenced above.
Signed-off-by: Gregory Haskins ghask...@novell.com
diff --git a/src/java/main/org/apache/zookeeper/ClientCnxn.java b/src/java/main/
index 8eb227d..682811b 100644
--- a/src/java/main/org/apache/zookeeper/ClientCnxn.java
+++ b/src/java/main/org/apache/zookeeper/ClientCnxn.java
@@ -353,6 +353,11 @@ public class ClientCnxn {
this.sessionId = sessionId;
this.sessionPasswd = sessionPasswd;
+ if (sessionTimeout = 0) {
+ throw new IOException(sessionTimeout + sessionTimeout
+ + is not valid);
+ }
+
// parse out chroot, if any
int off = hosts.indexOf('/');
if (off = 0) {
API should sanity check sessionTimeout argument
---
Key: ZOOKEEPER-776
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776
Project: Zookeeper
Issue Type: Improvement
Components: c client, java client
Affects Versions: 3.3.1, 3.3.0, 3.2.2
Environment: OSX 10.6.3, JVM 1.6.0-20
Reporter: Gregory Haskins
Priority: Minor
Fix For: 3.4.0
passing in a 0 sessionTimeout to ZooKeeper() constructor leads to errors in
subsequent operations. It would be ideal to capture this configuration error
at the source by throwing something like an IllegalArgument exception when
the bogus sessionTimeout is specified, instead of later when it is utilized.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-776) API should sanity check sessionTimeout argument
[ https://issues.apache.org/jira/browse/ZOOKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gregory Haskins updated ZOOKEEPER-776: -- Status: Open (was: Patch Available) API should sanity check sessionTimeout argument --- Key: ZOOKEEPER-776 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776 Project: Zookeeper Issue Type: Improvement Components: c client, java client Affects Versions: 3.3.1, 3.3.0, 3.2.2 Environment: OSX 10.6.3, JVM 1.6.0-20 Reporter: Gregory Haskins Priority: Minor Fix For: 3.4.0 passing in a 0 sessionTimeout to ZooKeeper() constructor leads to errors in subsequent operations. It would be ideal to capture this configuration error at the source by throwing something like an IllegalArgument exception when the bogus sessionTimeout is specified, instead of later when it is utilized. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[PATCH] javaclient: validate sessionTimeout field at ZooKeeper init (JIRA ZOOKEEPER-776)
Hi All,
First patch submission for me. If there are any patch submission
guidelines I should follow, kindly point me at them and accept my
apology if this approach violates any established procedures. I didn't
find anything obvious on the site wiki, so I just used some practices
learned on other projects.
-Greg
commit 840f56d388582e1df39f7513aa7f4d4ce0610718
Author: Gregory Haskins ghask...@novell.com
Date: Fri May 21 14:58:14 2010 -0400
javaclient: validate sessionTimeout field at ZooKeeper init
JIRA ZOOKEEPER-776 describes the following problem:
passing in a 0 sessionTimeout to ZooKeeper() constructor leads to
errors
in subsequent operations. It would be ideal to capture this
configuration
error at the source by throwing something like an IllegalArgument
exception
when the bogus sessionTimeout is specified, instead of later when it is
utilized.
This patch is a proposal to fix the problem referenced above.
Applies to svn-id: 946074
Signed-off-by: Gregory Haskins ghask...@novell.com
diff --git a/src/java/main/org/apache/zookeeper/ClientCnxn.java
b/src/java/main/
index 8eb227d..682811b 100644
--- a/src/java/main/org/apache/zookeeper/ClientCnxn.java
+++ b/src/java/main/org/apache/zookeeper/ClientCnxn.java
@@ -353,6 +353,11 @@ public class ClientCnxn {
this.sessionId = sessionId;
this.sessionPasswd = sessionPasswd;
+ if (sessionTimeout = 0) {
+ throw new IOException(sessionTimeout + sessionTimeout
+ + is not valid);
+ }
+
// parse out chroot, if any
int off = hosts.indexOf('/');
if (off = 0) {
signature.asc
Description: OpenPGP digital signature
Re: [PATCH] javaclient: validate sessionTimeout field at ZooKeeper init (JIRA ZOOKEEPER-776)
Hi Greg -
Thanks very much for contributing! We've got some guidelines here:
http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute - let me know if
they're not clear.
The main thing for you to do is to attach your patch to the JIRA and click
the 'Licensed for inclusion into Apache projects' button when you do. You
can do this by clicking 'Attach patch' on the JIRA itself. Once you've done
that, please click 'Submit patch' to kick off our automated QA procedures.
Assuming all goes well, a committer will pick up the baton from there and
get the patch into trunk (or let you know if they think changes are
necessary).
Thanks!
Henry
On 21 May 2010 12:22, Gregory Haskins gregory.hask...@gmail.com wrote:
Hi All,
First patch submission for me. If there are any patch submission
guidelines I should follow, kindly point me at them and accept my
apology if this approach violates any established procedures. I didn't
find anything obvious on the site wiki, so I just used some practices
learned on other projects.
-Greg
commit 840f56d388582e1df39f7513aa7f4d4ce0610718
Author: Gregory Haskins ghask...@novell.com
Date: Fri May 21 14:58:14 2010 -0400
javaclient: validate sessionTimeout field at ZooKeeper init
JIRA ZOOKEEPER-776 describes the following problem:
passing in a 0 sessionTimeout to ZooKeeper() constructor leads to
errors
in subsequent operations. It would be ideal to capture this
configuration
error at the source by throwing something like an IllegalArgument
exception
when the bogus sessionTimeout is specified, instead of later when it is
utilized.
This patch is a proposal to fix the problem referenced above.
Applies to svn-id: 946074
Signed-off-by: Gregory Haskins ghask...@novell.com
diff --git a/src/java/main/org/apache/zookeeper/ClientCnxn.java
b/src/java/main/
index 8eb227d..682811b 100644
--- a/src/java/main/org/apache/zookeeper/ClientCnxn.java
+++ b/src/java/main/org/apache/zookeeper/ClientCnxn.java
@@ -353,6 +353,11 @@ public class ClientCnxn {
this.sessionId = sessionId;
this.sessionPasswd = sessionPasswd;
+ if (sessionTimeout = 0) {
+ throw new IOException(sessionTimeout + sessionTimeout
+ + is not valid);
+ }
+
// parse out chroot, if any
int off = hosts.indexOf('/');
if (off = 0) {
--
Henry Robinson
Software Engineer
Cloudera
415-994-6679
[jira] Updated: (ZOOKEEPER-776) API should sanity check sessionTimeout argument
[ https://issues.apache.org/jira/browse/ZOOKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gregory Haskins updated ZOOKEEPER-776: -- Attachment: zookeeper-776-fix.patch API should sanity check sessionTimeout argument --- Key: ZOOKEEPER-776 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776 Project: Zookeeper Issue Type: Improvement Components: c client, java client Affects Versions: 3.2.2, 3.3.0, 3.3.1 Environment: OSX 10.6.3, JVM 1.6.0-20 Reporter: Gregory Haskins Priority: Minor Fix For: 3.4.0 Attachments: zookeeper-776-fix.patch passing in a 0 sessionTimeout to ZooKeeper() constructor leads to errors in subsequent operations. It would be ideal to capture this configuration error at the source by throwing something like an IllegalArgument exception when the bogus sessionTimeout is specified, instead of later when it is utilized. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-776) API should sanity check sessionTimeout argument
[ https://issues.apache.org/jira/browse/ZOOKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gregory Haskins updated ZOOKEEPER-776: -- Status: Patch Available (was: Open) Release Note: The attached patch is a proposed fix for the java client API should sanity check sessionTimeout argument --- Key: ZOOKEEPER-776 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776 Project: Zookeeper Issue Type: Improvement Components: c client, java client Affects Versions: 3.3.1, 3.3.0, 3.2.2 Environment: OSX 10.6.3, JVM 1.6.0-20 Reporter: Gregory Haskins Priority: Minor Fix For: 3.4.0 Attachments: zookeeper-776-fix.patch passing in a 0 sessionTimeout to ZooKeeper() constructor leads to errors in subsequent operations. It would be ideal to capture this configuration error at the source by throwing something like an IllegalArgument exception when the bogus sessionTimeout is specified, instead of later when it is utilized. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-776) API should sanity check sessionTimeout argument
[ https://issues.apache.org/jira/browse/ZOOKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870151#action_12870151 ] Hadoop QA commented on ZOOKEEPER-776: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445195/zookeeper-776-fix.patch against trunk revision 947063. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/101/console This message is automatically generated. API should sanity check sessionTimeout argument --- Key: ZOOKEEPER-776 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776 Project: Zookeeper Issue Type: Improvement Components: c client, java client Affects Versions: 3.2.2, 3.3.0, 3.3.1 Environment: OSX 10.6.3, JVM 1.6.0-20 Reporter: Gregory Haskins Priority: Minor Fix For: 3.4.0 Attachments: zookeeper-776-fix.patch passing in a 0 sessionTimeout to ZooKeeper() constructor leads to errors in subsequent operations. It would be ideal to capture this configuration error at the source by throwing something like an IllegalArgument exception when the bogus sessionTimeout is specified, instead of later when it is utilized. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-776) API should sanity check sessionTimeout argument
[ https://issues.apache.org/jira/browse/ZOOKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870152#action_12870152 ] Henry Robinson commented on ZOOKEEPER-776: -- Thanks Greg - can you generate your patch from git with --no-prefix, to make it svn compatible? API should sanity check sessionTimeout argument --- Key: ZOOKEEPER-776 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776 Project: Zookeeper Issue Type: Improvement Components: c client, java client Affects Versions: 3.2.2, 3.3.0, 3.3.1 Environment: OSX 10.6.3, JVM 1.6.0-20 Reporter: Gregory Haskins Priority: Minor Fix For: 3.4.0 Attachments: zookeeper-776-fix.patch passing in a 0 sessionTimeout to ZooKeeper() constructor leads to errors in subsequent operations. It would be ideal to capture this configuration error at the source by throwing something like an IllegalArgument exception when the bogus sessionTimeout is specified, instead of later when it is utilized. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-776) API should sanity check sessionTimeout argument
[ https://issues.apache.org/jira/browse/ZOOKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870159#action_12870159 ] Gregory Haskins commented on ZOOKEEPER-776: --- Hi Henry, I'll do one better and add a JUnit to address the first -1 as well ;) Im just testing the junit now, and will submit the updated patch shortly. Should I cancel the previous patch and delete the old attachment? API should sanity check sessionTimeout argument --- Key: ZOOKEEPER-776 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776 Project: Zookeeper Issue Type: Improvement Components: c client, java client Affects Versions: 3.2.2, 3.3.0, 3.3.1 Environment: OSX 10.6.3, JVM 1.6.0-20 Reporter: Gregory Haskins Priority: Minor Fix For: 3.4.0 Attachments: zookeeper-776-fix.patch passing in a 0 sessionTimeout to ZooKeeper() constructor leads to errors in subsequent operations. It would be ideal to capture this configuration error at the source by throwing something like an IllegalArgument exception when the bogus sessionTimeout is specified, instead of later when it is utilized. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-776) API should sanity check sessionTimeout argument
[ https://issues.apache.org/jira/browse/ZOOKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gregory Haskins updated ZOOKEEPER-776: -- Status: Open (was: Patch Available) API should sanity check sessionTimeout argument --- Key: ZOOKEEPER-776 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776 Project: Zookeeper Issue Type: Improvement Components: c client, java client Affects Versions: 3.3.1, 3.3.0, 3.2.2 Environment: OSX 10.6.3, JVM 1.6.0-20 Reporter: Gregory Haskins Priority: Minor Fix For: 3.4.0 Attachments: zookeeper-776-fix.patch passing in a 0 sessionTimeout to ZooKeeper() constructor leads to errors in subsequent operations. It would be ideal to capture this configuration error at the source by throwing something like an IllegalArgument exception when the bogus sessionTimeout is specified, instead of later when it is utilized. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-776) API should sanity check sessionTimeout argument
[ https://issues.apache.org/jira/browse/ZOOKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gregory Haskins updated ZOOKEEPER-776: -- Attachment: (was: zookeeper-776-fix.patch) API should sanity check sessionTimeout argument --- Key: ZOOKEEPER-776 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776 Project: Zookeeper Issue Type: Improvement Components: c client, java client Affects Versions: 3.2.2, 3.3.0, 3.3.1 Environment: OSX 10.6.3, JVM 1.6.0-20 Reporter: Gregory Haskins Priority: Minor Fix For: 3.4.0 Attachments: zookeeper-776-fix.patch passing in a 0 sessionTimeout to ZooKeeper() constructor leads to errors in subsequent operations. It would be ideal to capture this configuration error at the source by throwing something like an IllegalArgument exception when the bogus sessionTimeout is specified, instead of later when it is utilized. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-776) API should sanity check sessionTimeout argument
[ https://issues.apache.org/jira/browse/ZOOKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gregory Haskins updated ZOOKEEPER-776: -- Attachment: zookeeper-776-fix.patch API should sanity check sessionTimeout argument --- Key: ZOOKEEPER-776 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776 Project: Zookeeper Issue Type: Improvement Components: c client, java client Affects Versions: 3.2.2, 3.3.0, 3.3.1 Environment: OSX 10.6.3, JVM 1.6.0-20 Reporter: Gregory Haskins Priority: Minor Fix For: 3.4.0 Attachments: zookeeper-776-fix.patch passing in a 0 sessionTimeout to ZooKeeper() constructor leads to errors in subsequent operations. It would be ideal to capture this configuration error at the source by throwing something like an IllegalArgument exception when the bogus sessionTimeout is specified, instead of later when it is utilized. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-776) API should sanity check sessionTimeout argument
[ https://issues.apache.org/jira/browse/ZOOKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gregory Haskins updated ZOOKEEPER-776: -- Status: Patch Available (was: Open) API should sanity check sessionTimeout argument --- Key: ZOOKEEPER-776 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776 Project: Zookeeper Issue Type: Improvement Components: c client, java client Affects Versions: 3.3.1, 3.3.0, 3.2.2 Environment: OSX 10.6.3, JVM 1.6.0-20 Reporter: Gregory Haskins Priority: Minor Fix For: 3.4.0 Attachments: zookeeper-776-fix.patch passing in a 0 sessionTimeout to ZooKeeper() constructor leads to errors in subsequent operations. It would be ideal to capture this configuration error at the source by throwing something like an IllegalArgument exception when the bogus sessionTimeout is specified, instead of later when it is utilized. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-776) API should sanity check sessionTimeout argument
[ https://issues.apache.org/jira/browse/ZOOKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870164#action_12870164 ] Henry Robinson commented on ZOOKEEPER-776: -- Cancelling the patch is fine but there's no need to delete it - Hudson will always figure out what the latest patch is and it's good to see how a ticket evolved. Tests will also help :) API should sanity check sessionTimeout argument --- Key: ZOOKEEPER-776 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776 Project: Zookeeper Issue Type: Improvement Components: c client, java client Affects Versions: 3.2.2, 3.3.0, 3.3.1 Environment: OSX 10.6.3, JVM 1.6.0-20 Reporter: Gregory Haskins Priority: Minor Fix For: 3.4.0 Attachments: zookeeper-776-fix.patch passing in a 0 sessionTimeout to ZooKeeper() constructor leads to errors in subsequent operations. It would be ideal to capture this configuration error at the source by throwing something like an IllegalArgument exception when the bogus sessionTimeout is specified, instead of later when it is utilized. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-776) API should sanity check sessionTimeout argument
[ https://issues.apache.org/jira/browse/ZOOKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870165#action_12870165 ] Gregory Haskins commented on ZOOKEEPER-776: --- Ah, sorry, I had already deleted it before I saw your latest comment. I seem to be making a general mess of this JIRA entry. Bear with me while I learn :) In any case, I have submitted a fix that has a JUnit and a --no-prefix export, so hopefully Hudson is happier this time. I confirmed that the test fails without the fix, and passes with the fix. Let me know if there is anything else I should be doing. Thanks for all the help, -Greg API should sanity check sessionTimeout argument --- Key: ZOOKEEPER-776 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776 Project: Zookeeper Issue Type: Improvement Components: c client, java client Affects Versions: 3.2.2, 3.3.0, 3.3.1 Environment: OSX 10.6.3, JVM 1.6.0-20 Reporter: Gregory Haskins Priority: Minor Fix For: 3.4.0 Attachments: zookeeper-776-fix.patch passing in a 0 sessionTimeout to ZooKeeper() constructor leads to errors in subsequent operations. It would be ideal to capture this configuration error at the source by throwing something like an IllegalArgument exception when the bogus sessionTimeout is specified, instead of later when it is utilized. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-776) API should sanity check sessionTimeout argument
[ https://issues.apache.org/jira/browse/ZOOKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870175#action_12870175 ] Hadoop QA commented on ZOOKEEPER-776: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445200/zookeeper-776-fix.patch against trunk revision 947063. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/102/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/102/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/102/console This message is automatically generated. API should sanity check sessionTimeout argument --- Key: ZOOKEEPER-776 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776 Project: Zookeeper Issue Type: Improvement Components: c client, java client Affects Versions: 3.2.2, 3.3.0, 3.3.1 Environment: OSX 10.6.3, JVM 1.6.0-20 Reporter: Gregory Haskins Priority: Minor Fix For: 3.4.0 Attachments: zookeeper-776-fix.patch passing in a 0 sessionTimeout to ZooKeeper() constructor leads to errors in subsequent operations. It would be ideal to capture this configuration error at the source by throwing something like an IllegalArgument exception when the bogus sessionTimeout is specified, instead of later when it is utilized. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-776) API should sanity check sessionTimeout argument
[ https://issues.apache.org/jira/browse/ZOOKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870179#action_12870179 ] Henry Robinson commented on ZOOKEEPER-776: -- Greg - Don't worry - you should have seen the hash I made of my first patch! Hudson is misbehaving at the moment, so I'm not convinced that the test failures are as a result of your patch. You don't need to do anything right now - I'll take a look and update this ticket once I know what's going on. cheers, Henry API should sanity check sessionTimeout argument --- Key: ZOOKEEPER-776 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776 Project: Zookeeper Issue Type: Improvement Components: c client, java client Affects Versions: 3.2.2, 3.3.0, 3.3.1 Environment: OSX 10.6.3, JVM 1.6.0-20 Reporter: Gregory Haskins Priority: Minor Fix For: 3.4.0 Attachments: zookeeper-776-fix.patch passing in a 0 sessionTimeout to ZooKeeper() constructor leads to errors in subsequent operations. It would be ideal to capture this configuration error at the source by throwing something like an IllegalArgument exception when the bogus sessionTimeout is specified, instead of later when it is utilized. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
