[jira] Commented: (ZOOKEEPER-610) cleanup final fields, esp those used for locking
[ https://issues.apache.org/jira/browse/ZOOKEEPER-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789487#action_12789487 ] Hadoop QA commented on ZOOKEEPER-610: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12426874/ZOOKEEPER-610.patch against trunk revision 888216. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/23/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/23/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/23/console This message is automatically generated. cleanup final fields, esp those used for locking Key: ZOOKEEPER-610 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-610 Project: Zookeeper Issue Type: Bug Components: java client, server Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-610.patch There are a number of places where we have non-final fields that could (should) be declared as final. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-610) cleanup final fields, esp those used for locking
[ https://issues.apache.org/jira/browse/ZOOKEEPER-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789578#action_12789578 ] Henry Robinson commented on ZOOKEEPER-610: -- +1 from me, tests don't need to be included as there are no functional changes (compiler would pick up any problems). We are a bit inconsistent about when we initialise inline in the class, and when we initialise in the constructor, but that's not for this patch to fix. Will (attempt to) commit shortly. cleanup final fields, esp those used for locking Key: ZOOKEEPER-610 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-610 Project: Zookeeper Issue Type: Bug Components: java client, server Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-610.patch There are a number of places where we have non-final fields that could (should) be declared as final. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
