Re: [Zope-CMF] Re: SVN: CMF/branches/2.1/C - changed the way skins are set up, using __before_publishing_traverse__ instead of __of__
yuppie wrote at 2007-6-18 11:29 +0200: ... Please let me know if you think this checkin causes too much trouble and should be reverted. We are using portals and their skins widely in scripts executed outside of Zope. Especially, they do not use the ZPublisher to traverse to the objects but use more direct methods (which do not look for __before_publishing_traverse__). Your change will break all these scripts -- Dieter ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
[Zope-CMF] Re: SVN: CMF/branches/2.1/C - changed the way skins are set up, using __before_publishing_traverse__ instead of __of__
Hi, for some reason this change broken unit tests in all of the Plone packages, starting with Archetypes, ATContentTypes up to CMFPlone. It cannot find various skin methods and templates anymore. Do you have some idea what could cause this? I have seen you introduced a new __before_publishing_traverse__ method on PortalObject but as the PloneSite object is derived from the CMFDefault.CMFSite object and in return on PortalObject that method should be present on our site object as well. Any hints in which direction to look here? I have seen you changed the setup code in two tests as well, to setup the skin manually, is this something that is required now? Thx, Hanno Yvo Schubbe wrote: Log message for revision 76729: - changed the way skins are set up, using __before_publishing_traverse__ instead of __of__ Changed: U CMF/branches/2.1/CHANGES.txt U CMF/branches/2.1/CMFCalendar/tests/test_Calendar.py U CMF/branches/2.1/CMFCore/DynamicType.py U CMF/branches/2.1/CMFCore/PortalObject.py U CMF/branches/2.1/CMFCore/Skinnable.py U CMF/branches/2.1/CMFCore/tests/test_SkinsTool.py U CMF/branches/2.1/CMFDefault/tests/RegistrationTool.txt -=- Modified: CMF/branches/2.1/CHANGES.txt === --- CMF/branches/2.1/CHANGES.txt 2007-06-17 13:35:02 UTC (rev 76728) +++ CMF/branches/2.1/CHANGES.txt 2007-06-17 14:08:32 UTC (rev 76729) @@ -11,6 +11,12 @@ Bug Fixes +- SkinnableObjectManager: Changed the way skins are set up. + Acquisition wrapping no longer triggers 'setupCurrentSkin'. This is now + done on publishing traversal after the BeforeTraverseEvent triggers + 'setSite'. This fix replaces a temporary hack introduced in 2.1.0-beta, + making sure ISkinsTool is looked up after setting the site. + ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
[Zope-CMF] Re: SVN: CMF/branches/2.1/C - changed the way skins are set up, using __before_publishing_traverse__ instead of __of__
Hi! Hanno Schlichting wrote: for some reason this change broken unit tests in all of the Plone packages, starting with Archetypes, ATContentTypes up to CMFPlone. It cannot find various skin methods and templates anymore. Do you have some idea what could cause this? I have seen you introduced a new __before_publishing_traverse__ method on PortalObject but as the PloneSite object is derived from the CMFDefault.CMFSite object and in return on PortalObject that method should be present on our site object as well. Any hints in which direction to look here? I have seen you changed the setup code in two tests as well, to setup the skin manually, is this something that is required now? Sorry. I hope this is just a testing issue. Or do you have similar problems if you start up a Plone site? I guess most skin tests need now the manual skin setup. Only tests that do the publishing traversal and trigger the setup in __before_publishing_traverse__ don't need it. Please let me know if you think this checkin causes too much trouble and should be reverted. Cheers, Yuppie ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
[Zope-CMF] Re: SVN: CMF/branches/2.1/C - changed the way skins are set up, using __before_publishing_traverse__ instead of __of__
yuppie wrote: Hanno Schlichting wrote: for some reason this change broken unit tests in all of the Plone packages, starting with Archetypes, ATContentTypes up to CMFPlone. It cannot find various skin methods and templates anymore. Do you have some idea what could cause this? I have seen you introduced a new __before_publishing_traverse__ method on PortalObject but as the PloneSite object is derived from the CMFDefault.CMFSite object and in return on PortalObject that method should be present on our site object as well. Any hints in which direction to look here? I have seen you changed the setup code in two tests as well, to setup the skin manually, is this something that is required now? Sorry. I hope this is just a testing issue. Or do you have similar problems if you start up a Plone site? I guess most skin tests need now the manual skin setup. Only tests that do the publishing traversal and trigger the setup in __before_publishing_traverse__ don't need it. Please let me know if you think this checkin causes too much trouble and should be reverted. If it is just a testing setup issue we can probably fix that quite easily in the PloneTestCase/CMFTestCase setup which most of our tests use. I'll try to look into this in the next few days unless somebody beats me to it. Hanno ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See http://collector.zope.org/CMF for bug reports and feature requests
