Re: [Zope-dev] github etiquette

2013-09-19 Thread Maurits van Rees

Op 17-09-13 17:15, Marius Gedminas schreef:

On Tue, Sep 17, 2013 at 09:35:58AM -0400, Jim Fulton wrote:

On Tue, Sep 17, 2013 at 8:58 AM, Marius Gedminas  wrote:

FWIW the only reason I'm in favour of self-merges is that this
short-circuits the "have you signed the ZF committer agreement?" dance.
Only people who have can merge.


Sorry, I don't understand the point you're making.


I'll try to explain better.


I also feel silly when I ask this question from people with very
familiar names.  (I feel that I have to do when I don't see ZF
membership on their GitHub profile.)


So are you saying you don't merge other people's code because
you don't want to ask if they're contributors?


No.  I'm saying the reviewer-merges workflow looks like this:

1. Somebody creates a pull request
2. A reviewer reviews
3. OP fixes
4. Reviewer asks "have you signed the agreement?  if not please sign"
5. OP says he/she signed it
6. Reviewer trusts OP's word and merges

(I don't have a good short word for "somebody who created the pull
request", so I abused Original Poster.)

Whereas I'd prefer

1. Somebody creates a pull request
2. A reviewer reviews
3. OP fixes
4. Reviewer says "looks good to me, feel free to merge (if you're not a
committer already, see http://foundation.zope.org/agreements)"
5. OP merges

It's not a very strong preference.  I can feel myself changing my mind
already ;-)

OTOH the implicit trust in step 6 makes me a bit uneasy, and I'm not
quite sure how to verify the fact of the signing.  Wait for the user to
show up in https://github.com/zopefoundation?tab=members ?


Checking that list seems the best to me.

This could be a reason to prefer that the 'pull requester' creates a 
branch in the original repository within the zopefoundation: if he can 
do that, it proves he is authorized and has signed the agreement.


BTW, I have just now seen that I am on that list in the members tab, but 
in the greyed out section, which I think means that non-members do not 
see me listed.  There was a button 'Publicize membership' next to my 
name so I clicked and am now in the top 'full-color' list.  :-)  Others 
may want to do the same.



--
Maurits van Rees: http://maurits.vanrees.org/
Zest Software: http://zestsoftware.nl

___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] zope.pagetemplate release wanted [was: Re: zope-tests - FAILED: 1, OK: 21]

2013-01-23 Thread Maurits van Rees

Op 23-01-13 02:00, Zope tests summarizer schreef:

Non-OK results
--

[1]FAILED  winbot / z3c.ptcompat_py_265_32
https://mail.zope.org/pipermail/zope-tests/2013-January/071606.html


This should be fixed with a new zope.pagetemplate release.  Can anyone 
do that?


PyPI Package Index Owners are: baijum, J1m, ctheune, projekt01, 
srichter, philikon, benji, ignas, fdrake, chrism, mgedmin, pcardune, 
ccomb, faassen, chrisw, hathawsh, nadako, hannosch, icemac, tseaver, 
thefunny42, gary, roymath, kobold, tlotze, agroszer, menesis, davisagli


Thanks,

--
Maurits van Rees: http://maurits.vanrees.org/
Zest Software: http://zestsoftware.nl

___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope-tests - FAILED: 5, OK: 19

2013-01-18 Thread Maurits van Rees

Op 18-01-13 16:26, Tres Seaver schreef:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 01/18/2013 08:58 AM, Maurits van Rees wrote:

Op 16-01-13 18:47, Tres Seaver schreef:

[3]FAILED  winbot / z3c.ptcompat_py_265_32
https://mail.zope.org/pipermail/zope-tests/2013-January/071440.html






Same error related to the recent zope.pagetemplates changes.


This is a test that passes with standard zope.pagetemplates, but fails
  in combination with Chameleon.  It is in a recursion test that has
been added in zope.pagetemplate 4.0.0.

I have now added a bin/testcompat script in the zope.pagetemplates
buildout to test with z3c.pt(compat) plus Chameleon.

The expected output for this test is:


 root   first
second   

The real output is:


 root   first

second

  

The difference is that the two inner '' get an extra line before
  them with a single space character.

I have tried a few changes in the test template to see if that would
result in the output html being the same with and without Chameleon,
but that did not work.

Possibly this needs a change not in zope.pagetemplate but in Chameleon
  or one of the other packages.


Or use ElementTree to normalize the XHTML before testing (since the
whitespace diffreences are semantically irrelevant).


I did it in a crude way in zope.pagetemplate:

+# crude way of normalizing whitespace
+expect = expect.replace(' ', '').replace('\n\n', '\n')
+out = out.replace(' ', '').replace('\n\n', '\n')
 util.check_html(expect, out)

That works.

For the buildbot test to pass, a zope.pagetemplate 4.0.1 release would 
need to be made.



--
Maurits van Rees: http://maurits.vanrees.org/
Zest Software: http://zestsoftware.nl

___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zope-tests - FAILED: 5, OK: 19

2013-01-18 Thread Maurits van Rees

Op 16-01-13 18:47, Tres Seaver schreef:

[3]FAILED  winbot / z3c.ptcompat_py_265_32
https://mail.zope.org/pipermail/zope-tests/2013-January/071440.html


Same error related to the recent zope.pagetemplates changes.


This is a test that passes with standard zope.pagetemplates, but fails 
in combination with Chameleon.  It is in a recursion test that has been 
added in zope.pagetemplate 4.0.0.


I have now added a bin/testcompat script in the zope.pagetemplates 
buildout to test with z3c.pt(compat) plus Chameleon.


The expected output for this test is:



 root
 
 
 first

 
 
 
 second

 


The real output is:



 root
 
 
 first


 
 
 
 second


 


The difference is that the two inner '' get an extra line before 
them with a single space character.


I have tried a few changes in the test template to see if that would 
result in the output html being the same with and without Chameleon, but 
that did not work.


Possibly this needs a change not in zope.pagetemplate but in Chameleon 
or one of the other packages.



--
Maurits van Rees: http://maurits.vanrees.org/
Zest Software: http://zestsoftware.nl

___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] Latest z3c.recipe.tag upload to PyPI is broken

2012-09-07 Thread Maurits van Rees

Op 07-09-12 04:53, Barry Warsaw schreef:

The latest upload of z3c.recipe.tag appears to be broken.  I'm sending this
message to zope-dev@zope.org because that's the maintainer_email from the
setup.py, and I can't find any indication of where to submit bug reports.  I'm
also CC'ing distutils-sig, just 'cause. :)

Doing a buildout of the Mailman 3 trunk crashes today:

% bin/buildout
Develop: '/home/barry/projects/mailman/3.0/.'
[...]
Got z3c.recipe.scripts 1.0.1.
Getting distribution for 'zc.recipe.egg>=1.3.0'.
Got zc.recipe.egg 1.3.2.
Getting distribution for 'z3c.recipe.tag'.
error: /tmp/easy_install-ganUUb/z3c.recipe.tag-0.5/CHANGES.txt: No such file or 
directory
An error occurred when trying to install z3c.recipe.tag 0.5. Look above this 
message for any errors that were output by easy_install.
While:
   Installing.
   Getting section tags.
   Initializing section tags.
   Installing recipe z3c.recipe.tag.
   Getting distribution for 'z3c.recipe.tag'.
Error: Couldn't install: z3c.recipe.tag 0.5

PyPI says a new version of z3c.recipe.tags was uploaded today (2012-09-06).
It looks like a file was missing from the zip.


Fixed and 0.6 released by Christian Theune.  Thanks!


--
Maurits van Rees: http://maurits.vanrees.org/
Zest Software: http://zestsoftware.nl

___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] ssh access to svn.zope.org not working

2012-06-25 Thread Maurits van Rees

Op 25-06-12 15:17, Jim Fulton schreef:

On Mon, Jun 25, 2012 at 7:50 AM, Maurits van Rees
  wrote:

Hi,

I can access svn.zope.org over normal http just fine, but svn+ssh does not
work for me today. This has worked fine until last week.

$ svn ls svn+ssh://svn.zope.org/repos/main/zopetoolkit/doc
svn: E170001: Unable to connect to a repository at URL
'svn+ssh://svn.zope.org/repos/main/zopetoolkit/doc'
svn: E170001: Could not create SASL context: generic failure: No such file
or directory


Ah, this is a problem with cyrus-sasl2 2.1.25 on the Mac:
https://trac.macports.org/ticket/34861

The workaround in the ticket helps:
sudo port activate cyrus-sasl2 @2.1.23_3+kerberos

Thanks,

--
Maurits van Rees: http://maurits.vanrees.org/
Zest Software: http://zestsoftware.nl

___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] ssh access to svn.zope.org not working

2012-06-25 Thread Maurits van Rees

Hi,

I can access svn.zope.org over normal http just fine, but svn+ssh does 
not work for me today. This has worked fine until last week.


$ svn ls svn+ssh://svn.zope.org/repos/main/zopetoolkit/doc
svn: E170001: Unable to connect to a repository at URL 
'svn+ssh://svn.zope.org/repos/main/zopetoolkit/doc'
svn: E170001: Could not create SASL context: generic failure: No such 
file or directory


That is with subversion 1.7.  I tried 1.6 too, but this just says "svn: 
generic failure".


This is with the ssh key that I use for userid mauritsvanrees.  I did 
not change anything in my setup recently that I remember.


Anyone else having problems with this?


--
Maurits van Rees: http://maurits.vanrees.org/
Zest Software: http://zestsoftware.nl

___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Checkins] SVN: z3c.form/trunk/setup.py Get ready for 2.6.1 release.

2012-02-20 Thread Maurits van Rees

Op 20-02-12 08:07, Wolfgang Schnerring schreef:

* David Glick  [2012-02-19 22:56]:

On 2/16/12 11:55 PM, Adam GROSZER wrote:

So you say that if I add
 entry_points={
 'zest.releaser.releaser.after_checkout': [
 'zest_pocompile = zest.pocompile.compile:compile_in_tag',
 ],
 },

to z3c.form's setup.py fullrelease will take care of the po files?


You'll have to experiment -- the suggestion was based on what I've heard, not
personal experience with zest.releaser.


The entrypoint looks sound at first glance, but what I'm wondering (and
rather doubting, in fact) is whether zest.releaser includes the package
it currently is releasing to its PYTHONPATH. But yeah, as David said,
you'll probably need to fiddle around with this a little.


There is no need to add an entry point.  That is only needed in the 
setup.py of zest.pocompile itself.  You should just make sure that 
zest.pocompile is installed in the same environment as zest.releaser. 
In my case I have a central buildout with some tools and have this as 
buildout part:


[release]
recipe = zc.recipe.egg
eggs =
zest.releaser
gocept.zestreleaser.customupload
zest.pocompile

I think what makes this work is that zest.pocompile is included in the 
path in the generated fullrelease script, but maybe they just both need 
to be easy_installed/pipped; I don't remember from the top of my head 
how those setuptools entry points work.


What you need in your own package is a properly configured MANIFEST.in 
file.  See some examples on PyPI:

http://pypi.python.org/pypi/zest.pocompile


--
Maurits van Rees   http://maurits.vanrees.org/
Web App Programmer at Zest Software: http://zestsoftware.nl
"Logical thinking shows conclusively that logical thinking
is inconclusive." - My summary of Gödel, Escher, Bach

___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] New zc.queue release?

2011-12-17 Thread Maurits van Rees

Op 18-12-11 01:33, Zvezdan Petkovic schreef:


On Dec 17, 2011, at 7:13 PM, Maurits van Rees wrote:


There is a problem with the setup.py of 1.2 though: 'import os' is missing so 
it cannot be used.  I have fixed it on trunk.  Could you release a new version?


Done.
zc.queue-1.2.1 is now on PyPI.


Thank you, much appreciated.


--
Maurits van Rees   http://maurits.vanrees.org/
Web App Programmer at Zest Software: http://zestsoftware.nl
"Logical thinking shows conclusively that logical thinking
is inconclusive." - My summary of Gödel, Escher, Bach

___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] New zc.queue release?

2011-12-17 Thread Maurits van Rees

Op 18-12-11 01:10, Zvezdan Petkovic schreef:

On Dec 17, 2011, at 5:40 PM, Zvezdan Petkovic wrote:

I'll review and release.


Done.
zc.queue-1.2 is on PyPI.


Ah, thanks a lot!

There is a problem with the setup.py of 1.2 though: 'import os' is 
missing so it cannot be used.  I have fixed it on trunk.  Could you 
release a new version?


Thanks,


--
Maurits van Rees   http://maurits.vanrees.org/
Web App Programmer at Zest Software: http://zestsoftware.nl
"Logical thinking shows conclusively that logical thinking
is inconclusive." - My summary of Gödel, Escher, Bach

___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] New zc.queue release?

2011-12-16 Thread Maurits van Rees

Hi all,

Can someone create a new release of zc.queue?  zvezdan and gary are 
owners on PyPI.


Since 1.1 there have only been test fixes:

- Fixed undefined ZODB.POSException.StorageTransactionError in tests.

- Let tests pass with ZODB 3.8 and ZODB 3.9.

- Added test extra to declare test dependency on ``zope.testing``.

- Using Python's ``doctest`` module instead of depreacted
  ``zope.testing.doctest``.

My own use case is that the collective.singing tests pass on Plone 3 but 
fail on Plone 4.  Using zc.queue trunk fixes the failures on Plone 4 
(Plone 3 tests are still fine then).


Tests for zc.queue pass with python2.6 and latest ZODB3 3.10.5 and 
transaction 1.2.0.  And also with python2.4, ZODB3 3.9.7 and transaction 
1.1.1.¯


Thanks,

--
Maurits van Rees   http://maurits.vanrees.org/
Web App Programmer at Zest Software: http://zestsoftware.nl
"Logical thinking shows conclusively that logical thinking
is inconclusive." - My summary of Gödel, Escher, Bach

___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] adduser command: give feedback about success

2011-01-10 Thread Maurits van Rees
Op 09-01-11 10:32, Marius Gedminas schreef:
> On Fri, Jan 07, 2011 at 11:55:53PM +0100, Maurits van Rees wrote:
>> I propose to add this feedback.  This needs a few simple changes in
>> Zope2/utilities, Zope2/Startup, AccessControl,
>> Products.PluggableAuthService, and a few doctest fixes in Products.Five.
>>The change to Zope2/utilities/adduser.py would be this:
>>
>> ===
>> -adduser(app, user, pwd)
>> +result = adduser(app, user, pwd)
>> +if result:
>> +print "User %s created." % user
>> +else:
>> +print "Got no result back. User creation may have failed."
>> +print "Maybe the user already exists and nothing is done then."
>> +print "Or the implementation does not give info when it succeeds."
>
> I don't suppose you could somehow change the API so the script can
> report something useful?  "I don't even know if I succeeded or not"
> sounds pretty pathetic.

Agreed.  But with current releases of Products.PluggableAuthService 
(until and including 1.7.2) no result is given back, so we cannot be 
sure here if there is no result because the PAS is too old or because it 
really failed.

With the proposed changes, either the created user or None is returned, 
which you might consider an API change.  At least I mention in the 
interface in AccessControl that implementations should return the 
created user or None.

> Maybe it's better than surly silence.

That's the general idea.

I committed the changes on Zope2 trunk and branch 2.13, AccessControl 
trunk, and Products.PluggableAuthService trunk (used by Plone 4.0 and 
4.1).  Note that Zope2 2.13 also uses AccessControl trunk and in fact 
there are no official branches of that.

Note that in the do_adduser method that is used in 'bin/zopectl adduser' 
I used shorter output as that code gets printed on the command line so 
it should be very simple.  It either prints "Created user joe" or 
"Created user None".


Cheers,

-- 
Maurits van Rees
Programmer at Zest Software http://zestsoftware.nl
Personal website http://maurits.vanrees.org/

___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] adduser command: give feedback about success

2011-01-07 Thread Maurits van Rees
Hi all,

I saw that Hanno added an entry point in Zope2 to create a 
bin/addzope2user command, which does the same as the 'bin/zopectl 
adduser' command.

That got me thinking that I have always found it not very helpful that 
this command never gave feedback about whether the user addition was 
successful or not.  In standard Zope2 it should always work as the 
_doAddUser method in AccessControl simply overwrites an existing user. 
But with Plone or other systems using Products.PluggableAuthService 
nothing is done in this case and the script just stops, giving you no 
clue that it failed.

I propose to add this feedback.  This needs a few simple changes in 
Zope2/utilities, Zope2/Startup, AccessControl, 
Products.PluggableAuthService, and a few doctest fixes in Products.Five. 
  The change to Zope2/utilities/adduser.py would be this:

===
-adduser(app, user, pwd)
+result = adduser(app, user, pwd)
+if result:
+print "User %s created." % user
+else:
+print "Got no result back. User creation may have failed."
+print "Maybe the user already exists and nothing is done then."
+print "Or the implementation does not give info when it succeeds."
===

The wording leaves room for the current _doAddUser implementations that 
simply never return info.

Is it okay if I do this?

Should/may I backport this to Zope 2.13 and 2.12?


-- 
Maurits van Rees
Programmer, Zest Software

___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] Zope2 - Release Manager

2010-03-31 Thread Maurits van Rees
Op 31-03-10 14:39, Hanno Schlichting schreef:
> Hi there,
>
> I was in too much of a good mood while having some vacation. So I
> thought I need more work to do :)
>
> I'd like to step up as the release manager for Zope2 for the 2.12 and
> 2.13 (trunk) releases.

This is great news.  Thanks, Hanno!

Maurits


___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Checkins] SVN: zope.app.security/trunk/ keep trunk version at 0. Update changes

2009-09-14 Thread Maurits van Rees
Martijn Faassen, on 2009-09-11:
> (I think zest.releaser also does the version bumping before tagging if 
> I'm not mistaken, even with SVN.)

Correct.

These are the svn logs of releasing a demo package:

$ svn log -v file:///home/maurits/tmp/repo/demo/

r5 | maurits | 2009-09-14 14:39:50 +0200 (ma, 14 sep 2009) | 1 line
Changed paths:
   M /demo/trunk/CHANGES.txt
   M /demo/trunk/setup.py

Preparing release 0.1

r6 | maurits | 2009-09-14 14:39:55 +0200 (ma, 14 sep 2009) | 1 line
Changed paths:
   A /demo/tags/0.1 (from /demo/trunk:5)

Tagging 0.1

r7 | maurits | 2009-09-14 14:40:00 +0200 (ma, 14 sep 2009) | 1 line
Changed paths:
   M /demo/trunk/CHANGES.txt
   M /demo/trunk/setup.py

Back to development: 0.2dev



-- 
Maurits van Rees | http://maurits.vanrees.org/
Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]

___
Zope-Dev maillist  -  Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 https://mail.zope.org/mailman/listinfo/zope-announce
 https://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] plone.reload was: Re: refactoring site functionality

2009-06-02 Thread Maurits van Rees
Hanno Schlichting, on 2009-06-01:
> Stephan Richter wrote:
>> On Thursday 28 May 2009, Roger Ineichen wrote:
>>> btw, you are pointing to a good direction. Didn't we talk
>>> about reload global configuration during runtime years ago?
>> 
>> BTW, plone.reload looks really promising.
>
> For all I know plone.reload works and people use it during daily
> development including myself. The code reloading part has some
> limitations, like not dealing with properties / decorated methods, but
> the ZCML part should just work (tm).

Confirmed, I use it daily with great delight, so thanks for creating
it!

Some things indeed do not work, for example I usually get errors when
trying to reload code in plone portlets.  When errors like that occur,
or I notice some other problem that might be cuased by bad reloading,
I do not even think about it but first restart Zope to see if the
error is still there.

For a small zope 3 or grok application the startup is already small
though, so it may not be useful there.

Cheers,

-- 
Maurits van Rees | http://maurits.vanrees.org/
Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] zc.buildout problem

2009-05-24 Thread Maurits van Rees
Adam GROSZER, on 2009-05-24:
> Hello,
>
> Following just happened. The project has KGS 3.4 versions as a base,
> locally I wanted to override lxml to >= 2.1.1.
>
> [...snip...]
> extends = http://download.zope.org/zope3.4/3.4.0/versions.cfg
> versions = versions
>
> [versions]
> lxml >= 2.1.1

Only assignment (=) is allowed here, not comparison (>=).

Comparison is allowed in a few other spots, for example:

recipe = my.recipe.name >= 1.0

-- 
Maurits van Rees | http://maurits.vanrees.org/
Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] Zope 2.12.0a4 easy_installable - please test

2009-04-24 Thread Maurits van Rees
Michael Haubenwallner, on 2009-04-24:
>
> Michael Haubenwallner wrote:
>> Andreas Jung wrote:
>>> I just created a new Zope 2.12.0a4 that should easy_install nicely.
>> 
>>> Howto?
>> 
>>> virtualenv foo
>>> cd foo
>>> source bin/activate
>>> bin/easy_install -i http://download.zope.org/Zope2/index/2.12.0a4 Zope2
>> 
>>> Please give feedback.
>> 
>> 
>> Works for me - thanks!
>> 
>
> FTR: ubuntu8.04, python2.6 (built from source)

And on Ubuntu 9.04 with python2.4 it works fine for me.  Thanks
Andreas!

-- 
Maurits van Rees | http://maurits.vanrees.org/
Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] mechanize buildout error

2008-09-22 Thread Maurits van Rees
Roger Ineichen, on 2008-09-16:
> Hi 
>
> I've got the following error during mechanize buildout:
>
> %<
> Getting distribution for 'mechanize'.
> warning: no files found matching '0.1.0-changes.txt'
> no previously-included directories found matching 'docs-in-progress'
>   File "build\bdist.win32\egg\mechanize\_firefox3cookiejar.py", line 95
> yield row
> SyntaxError: 'yield' not allowed in a 'try' block with a 'finally' clause
> Got mechanize 0.1.8.
> %<
>
> I think this is not comming from our zope repos, right?

Correct.

Martijn Faassen saw this earlier, and I commented on it in the
grok-dev list:

http://www.nabble.com/grokproject-buildout-problems-td19291140.html

The SyntaxError only happens with python 2.4.  And that part of the
code is only executed when you run it with python 2.5.  So I do not
think anything can be done about that.

The warning is from an error in MANIFEST.in.  Same for another line
you may have spotted:

  no previously-included directories found matching 'docs-in-progress'

I just contacted the author about that.

-- 
Maurits van Rees | http://maurits.vanrees.org/
Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] Re: i18nmessageid has a broken link

2008-05-13 Thread Maurits van Rees
Philipp von Weitershausen, on 2008-05-13:
> Maurits van Rees wrote:
>> Without having tried pure Zope 3, only Grok --- I have been working on
>> grokproject during the Grokkerdam sprint --- the following in
>> buildout.cfg should work just as well:
>> 
>> find-links = http://download.zope.org/distribution/
>> extends = http://download.zope.org/zope3.4/versions.cfg
>> versions = versions
>> 
>> The find-links is needed because it has some package versions that
>> were never released on the cheese shop.  The versions.cfg defines
>> which versions are actually used.
>
> What packages are not released on PyPI yet? I was under the impression 
> that find-links is no longer needed.

Ah, for the 3.4 kgs which is discussed here that is probably true, so
it should indeed work without the find-links.  But for example the
Grok 0.12 versions file needs a few package versions that never made
it to the cheese shop so in that case find-links is still needed.  It
should not be necessary in the future.

-- 
Maurits van Rees | http://maurits.vanrees.org/
Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] Re: i18nmessageid has a broken link

2008-05-09 Thread Maurits van Rees
Sebastian Wehrmann, on 2008-05-09:
> Tim Terlegard schrieb:
>> On May 9, 2008, at 9:37 AM, Sebastian Wehrmann wrote:
>
>> Why do you need this linux specific egg anyway?
>
> I don't need this egg, my buildout is always requesting it instead of
> the source package.

For the record, my understanding is that this would never have worked
on Mac, only on Linux.  Not sure about Windows.

> I only wanted to ask if someone could please remove the broken link from
> the download.zope page so that everyone (including me) who indexed his
> buildout.cfg with the zope3.4 index will get the source package of
> zope.i18nmessageid instead of the egg (which does not exist anymore).

So this page needs to be changed so it only points to the tarball:

http://download.zope.org/zope3.4/zope.i18nmessageid/

Is someone able to do that?


Without having tried pure Zope 3, only Grok --- I have been working on
grokproject during the Grokkerdam sprint --- the following in
buildout.cfg should work just as well:

find-links = http://download.zope.org/distribution/
extends = http://download.zope.org/zope3.4/versions.cfg
versions = versions

The find-links is needed because it has some package versions that
were never released on the cheese shop.  The versions.cfg defines
which versions are actually used.

-- 
Maurits van Rees | http://maurits.vanrees.org/
Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] Re: AW: Re: AW: Re: New i18n locale extraction concept

2008-05-08 Thread Maurits van Rees
Hi Roger,

Roger Ineichen, on 2008-05-07:
> Uhaaa, that's a left over from a copied README.txt file.
> I need to review that part again.

I thought it might be something like that. :-)

>> Why specify both eggs and packages?  And why specify those 
>> packages in the setup.py too?  At least that is what I see in 
>> zam.locales.
>
> Eggs are needed for setup your project, or probably a working 
> setup like in any other package.
>
> Packages are used for extract locales from. That could be very 
> different then the egg setup. The i18nextrac.py will only deep
> into this packages, but probably this packages will need different
> eggs which they import from.

I would hope that it is possible to just list the eggs that you are
interested in, have buildout install all their requirements (as listed
in their setup.py) and have the recipe only extract message ids from
those original eggs without their dependencies.  Then the 'packages'
directive would not be necessary anymore.

Or perhaps when the packages option is empty, it takes the value of
the eggs option as default.

I do not know if this is possible and I have not gone in with a pdb to
check it.

> Note, if you run the i18nextract script, all module must be
> there like in a running application. You can't only use
> the files which will contain locales. Also modules which
> this packages import from must be there.

That should not be necessary I think.  At least I am not used to it.
When I use i18ndude for making pot/po files for a Plone
product/package and I have "from Products.CMFPlone import something"
in a file, then this import does not really take place.  I expect in
the case of python files it simply looks for lines like:

  _(u"My message to the world.")

> This isn't aproblem since the zope.app.locales dependes on 
> everyting which we developed the last years. Because 
> zope.app.locales depends on almost everything.

Do you envision using this recipe also for translating a single
package?  Or is your target really only big software collections like
zope.app.*?  I wonder a bit if it makes the second use case possible
by making the first use case harder.

It worked fine when I tried it on zam.locales btw, except that all
lines in the resulting .pot file were changed, but that is because of
Windows versus Unix line endings in subversion, which has nothing to
do with this recipe.

> I see, I 'll add a normalizer for that. I thought it was already
> there, but could be not correct implemented.

If you have a fix for that and you need me to test that on Linux, let
me know.

Cheers and thanks,

-- 
Maurits van Rees | http://maurits.vanrees.org/
Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] Re: AW: Re: AW: Re: New i18n locale extraction concept

2008-05-08 Thread Maurits van Rees
Stephan Richter, on 2008-05-08:
> On Wednesday 07 May 2008, Roger Ineichen wrote:
>> > I like that it can extract locales from eggs.  I don't like
>> > that it uses zcml for this.  Is the zcml really necessary?
>>
>> zcml is needed for exctract locales from page templates.  
>
> ZCML is needed to extract strings from ZCML.

I am looking at maybe using this recipe in grokproject.  Having that
zcml be *required* (which it currently is in that recipe) is a no-no
for us simple Grok folks. ;-)

I hope it is possible to remove that zcml requirement; the recipe is
still young, so who knows.  I am also looking at i18ndude for that, as
that is what I have been using in Plone-land so far.  Might work
nicely in the Grok-cave too.

-- 
Maurits van Rees | http://maurits.vanrees.org/
Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] Re: AW: Re: New i18n locale extraction concept

2008-05-07 Thread Maurits van Rees
Hi Roger,

Roger Ineichen, on 2008-05-01:
> I agree, a tool whould be great. But the first we need to 
> offer i18n extract script which can handle our new egg
> based buildout process. z3c.recipe.i18n is the only one 
> which could handle this right now.
>
>> Ideally, the recipe i18n tool should be able to extract, 
>> merge, and give stats, just like in the monolithic zope release.
>
> Yes, z3c.recipe.i18n does this right now. The -d option uses
> one or more egg or develop externals as argument instead of 
> one single path.

Some comments on that z3c.recipe.i18n

In README.txt you first mention z3c.recipe.start, then the i18n recipe
and then the app recipe.  Is the same meant in all three cases?

I like that it can extract locales from eggs.  I don't like that it
uses zcml for this.  Is the zcml really necessary?

Why specify both eggs and packages?  And why specify those packages in
the setup.py too?  At least that is what I see in zam.locales.


The tests don't run on Linux as there are Windows specific checks in
them, for example:

  File ".../z3c.recipe.i18n/src/z3c/recipe/i18n/README.txt", line 121,
  in README.txt
  Failed example:
  ls('bin')
  Expected:
  -  buildout-script.py
  -  buildout.exe
  -  i18nextract-script.py
  -  i18nextract.exe
  -  i18nmergeall-script.py
  -  i18nmergeall.exe
  -  i18nstats-script.py
  -  i18nstats.exe
  Got:
  -  buildout
  -  i18nextract
  -  i18nmergeall
  -  i18nstats

Of course quite likely there are also a lot of Linux/Mac packages that
fail on Windows because of similar reasons. :-/

-- 
Maurits van Rees | http://maurits.vanrees.org/
Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] Re: AW: Annoying: Download error: unknown url type: svn -- Some packages may not be found!

2008-05-07 Thread Maurits van Rees
Radim Novotny, on 2008-05-07:
> Roger Ineichen napsal(a):
>> Hi David
>>  
>>> Betreff: [Zope-dev] Annoying: Download error: unknown url 
>>> type: svn -- Some packages may not be found!
>>>
>>> Which package is emitting the Download error: unknown url 
>>> type: svn -- Some packages may not be found! Its quite 
>>> annoying and I have been seeing it crop up in a few builds. 
>>> Anyone else seeing this. Many thanks.
>> 
>> I see this too. Try the buildout debug option, probably this
>> will you give a better output.
>
> I have got the same error today. buildout - was not sufficient so I 
> added print output to setuptools/package_index.py and discovered this 
> message is caused by z3c.form:

The same happens for lovely.recipe:

http://pypi.python.org/simple/lovely.recipe

What is considered to be good practice here?  For example this is in
the setup.py of grokproject:

url='https://launchpad.net/grok',

download_url='svn://svn.zope.org/repos/main/grokproject/trunk#egg=grokproject-dev',

Looking at the simple cheese shop page:

http://pypi.python.org/simple/grokproject

I see that the home page url for all released versions is the
launchpad url which is probably fine.  But the download url is also
the same for every release that I checked, namely the trunk#egg, which
does not look like a good idea.

-- 
Maurits van Rees | http://maurits.vanrees.org/
Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] Re: New i18n locale extraction concept

2008-05-06 Thread Maurits van Rees
Christian Zagrodnick, on 2008-05-01:
> On 2008-05-01 02:06:17 +0200, "Roger Ineichen" <[EMAIL PROTECTED]> said:
>> 
>> 
>> What does this mean?
>> The locale extraction is now a part of a recipe
>> and not a part of a package itself.
>> 
>> My goal is to remove the dependencies in the
>> z3c.recipe.i18n, because right now it uses the
>> base implementation in zope.app.locales which makes
>> it depend on the hole zope namepsace. Because of
>> the overall zope.* dependenc in zope.app.locale.
>
> Actually, there is lovely.receipe:i18n which provides i18n extraction. 
> Does z3c.recipe.i18n something else or why is there yet another i18n 
> recipe?

For me a downside of lovely.recipe:i18n is that it has too many
dependencies: the whole of zope.  When easy installing it in a virtual
env, you end up with 44 MB of eggs.

For comparison, easy installing i18ndude needs about 6 MB.

See this (currently) small thread in grok-dev:
http://thread.gmane.org/gmane.comp.web.zope.grok.devel/4742

-- 
Maurits van Rees | http://maurits.vanrees.org/
Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] zope.app.locales i18nmergeall.py not used anymore?

2008-04-25 Thread Maurits van Rees
Hi,

zope/app/locales/TRANSLATE.txt says:

  ...
  After that, you need to merge those changes to all existing
  translations.  You can do that by executing the ``i18nmergeall.py``
  script from the ``utilities`` directory of your Zope 3 checkout:

$ python utilities/i18nmergeall.py -l src/zope/app/locales

So I tried that and found that in the 13 po files that are present,
over 80 thousand lines were changed (counting all lines in an svn
diff).  Since the files combined have about 100 thousand lines, this
could be called a fairly big change. :)

So: is there a reason this merging is not regularly done anymore?  Or
can I just go ahead and submit those 80 thousand lines?


Perhaps the zope.pot file should also be updated.  I get an error when
trying that though.  This is in a checkout of
svn.zope.org/repos/main/Zope3/trunk, with 'make' and 'make inplace'
executed as they seemed necessary and with the Zope3/src/ dir on my
PYTHONPATH:

[EMAIL PROTECTED]:~/svn/Zope3 $ python2.4 utilities/i18nextract.py -d zope -p 
src/zope -o app/locales
base path: '/home/maurits/svn/Zope3/'
search path: /home/maurits/svn/Zope3/src/zope
'site.zcml' location: None
exclude dirs: []
domain: 'zope'
include default domain: True
output file: '/home/maurits/svn/Zope3/src/zope/app/locales/zope.pot'
Python only: False
Traceback (most recent call last):
  File "utilities/i18nextract.py", line 175, in ?
main()
  File "utilities/i18nextract.py", line 163, in main
maker.add(zcml_strings(path, domain, site_zcml), base_dir)
  File "/home/maurits/svn/Zope3/src/zope/app/locales/extract.py", line 441, in 
zcml_strings
context = config(site_zcml, features=("devmode",), execute=False)
  File "/home/maurits/svn/Zope3/src/zope/app/appsetup/appsetup.py", line 111, 
in config
context = xmlconfig.file(file, context=context, execute=execute)
  File "/home/maurits/svn/Zope3/src/zope/configuration/xmlconfig.py", line 610, 
in file
include(context, name, package)
  File "/home/maurits/svn/Zope3/src/zope/configuration/xmlconfig.py", line 539, 
in include
f = openInOrPlain(path)
  File "/home/maurits/svn/Zope3/src/zope/configuration/xmlconfig.py", line 427, 
in openInOrPlain
fp = open(filename)
IOError: [Errno 2] No such file or directory: 
'/home/maurits/svn/Zope3/configure.zcml'


Ah, pointing the script at site.zcml helps:

[EMAIL PROTECTED]:~/svn/Zope3 $ python2.4 utilities/i18nextract.py -s site.zcml 
-d zope -p src/zope -o app/locales

Then about a thousand lines are changed in the zope.pot file.  So
apparently this is also not done every day. :-) Is it okay to commit
those changes as well (and merge those changes to the po files of
course)?

Should i18nextract.py be run with Zope3 trunk or with branches/3.4?
It may very well be that the number of changes are far less big when
run inside that branch.

Internationally yours,

-- 
Maurits van Rees | http://maurits.vanrees.org/
Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] What happened to the infrae.subversion and py eggs?

2008-04-08 Thread Maurits van Rees
Hi,

Sorry, I don't know where best to ask this question, but it is about
buildout, so I guess it could be called on-topic on the zope dev list.

Since about one day I have problems with buildouts using the
infrae.subversion and py eggs.  The problem can be seen with a
standard buildout.  Well, a plone 3 buildout anyway:

paster create -t plone3_buildout

In the created buildout.cfg I added this section and included it in
the parts section:

===
[productcheckouts]
recipe = infrae.subversion
urls =
===

This does not do anything really, but it should be enough to
demonstrate the problem that surfaces when running bin/buildout -v:

===
...
Installing 'infrae.subversion'.
We have no distributions for infrae.subversion that satisfies 
'infrae.subversion'.
Getting distribution for 'infrae.subversion'.
Got infrae.subversion 1.0dev-r28201.
Picked: infrae.subversion = 1.0dev-r28201
Getting required 'py==0.9.0'
  required by infrae.subversion 1.0dev-r28201.
We have no distributions for py that satisfies 'py==0.9.0'.
Getting distribution for 'py==0.9.0'.
While:
  Installing.
  Getting section productcheckouts.
  Initializing section productcheckouts.
  Installing recipe infrae.subversion.
  Getting distribution for 'py==0.9.0'.
Error: Couldn't find a distribution for 'py==0.9.0'.
===

At least, that happens when I do not yet have py-0.9.0-py2.4.egg in my
egg cache; no complaints when I already have that one.  Has something
changed in the py egg?  Other explanations for this error?  Meanwhile
in a virtualenv I can do this without errors:

  bin/easy_install py==0.9.0


Under the theory that the problem might be caused by the latest
version of the infrae.subversion recipe (released a few days ago I
think) having a wrong dependency or so, I pin this recipe to a
previous version that I know was on the cheeseshop last week as I got
it from there:

===
versions = versions

[versions]
infrae.subversion = 1.0dev-r27844
===

Then it can't find that version of the egg.  Well, my buildout could
not find it this afternoon, but of course now the reverse
demonstration effect strikes back and it goes fine:

===
Installing 'infrae.subversion'.
We have no distributions for infrae.subversion that satisfies 
'infrae.subversion==1.0dev-r27844'.
Getting distribution for 'infrae.subversion==1.0dev-r27844'.
Got infrae.subversion 1.0dev-r27844.
Getting required 'py'
  required by infrae.subversion 1.0dev-r27844.
Picked: py = 0.9.1
===

But this page does not exist:
http://pypi.python.org/pypi/infrae.subversion/1.0dev-r27844
and it is not listed here:
http://pypi.python.org/simple/infrae.subversion
So where does buildout get that egg now?  I emptied my egg cache.

Luckily for demonstration purposes this at least fails in a
virtualenv:

===
$ bin/easy_install infrae.subversion==1.0dev_r27844
Searching for infrae.subversion==1.0dev-r27844
Reading http://pypi.python.org/simple/infrae.subversion/
Reading https://svn.infrae.com/buildout/infrae.buildout/trunk/
No local packages or download links found for infrae.subversion==1.0dev-r27844
error: Could not find suitable distribution for 
Requirement.parse('infrae.subversion==1.0dev-r27844')
===

So has that version of the egg been removed from the cheeseshop?  And
can it be brought back?  I have buildouts that are pinned to that
version for stability and I would like those to work half a year from
now (or in fact tomorrow) in case I have to rebuild those buildouts on
a new server.  You never know when that meteor will hit your data
center. ;-)

Has anyone else seen this?

-- 
Maurits van Rees | http://maurits.vanrees.org/
Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] ZCatalog: updateMetadata and comparing string and unicode

2008-03-05 Thread Maurits van Rees
entId, obj, threshold, attr)
  File 
"/home/maurits/svn/Zope-210/lib/python/Products/PluginIndexes/KeywordIndex/KeywordIndex.py",
 line 85, in _index_object
fdiff = difference(oldKeywords, newKeywords)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 25: 
ordinal not in range(128)
===

This is a bit trickier to fix, as the variable fdiff that is
calculated here is needed later on.


But at this point I would like to ask: is this a solution direction I
want to explore?  Is the basic fix above sane?

Or should we change nothing here and should add-on developers just be
careful of what they let end up in the catalog?

The fix/workaround from a user's point of view is: clear and rebuild
the catalog as that gets rid of any old data so no comparison needs to
be done anymore.  That solves the problem for me.


For reference, the PoiIssue from above was created when its class had
this method (simplified):

def Description(self):
# return the contents of the details field
return self.getRawDetails()

And currently the code is this:

def Description(self):
details = self.getRawDetails()
if not isinstance(details, unicode):
encoding = getSiteEncoding(self)
details = unicode(details, encoding)
return details

And that change means to solve another occasional unicode error when
adding issues in Japanese: http://plone.org/products/poi/issues/135

I am the maintainer of Poi btw, and I am writing some migration code
now that triggers this error.  So writing some other migration to
first fix that recatalog issue specifically for the Poi content is
doable too.


-- 
Maurits van Rees | http://maurits.vanrees.org/
Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] Re: Mail to checkins list not coming through

2008-02-19 Thread Maurits van Rees
Jim Fulton, on 2008-02-19:
> You were getting this from the Checkins list, not zope-checkins.  I've  
> updated the list to accept your posts.

Ah, I see.  They come through now.  Thanks.

-- 
Maurits van Rees | http://maurits.vanrees.org/
Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] Mail to checkins list not coming through

2008-02-19 Thread Maurits van Rees
Hi,

I have Zope commit rights now.  I have subscribed to the zope-checkins
list:

http://mail.zope.org/mailman/options/zope-checkins

But when I commit something (I committed to the Sandbox and today to
z3c.sqlalchemy) I get an email:

  =
  Your mail to 'Checkins' with the subject

  SVN: Sandbox/mauritsvanrees-svn-test/ Removing test for my svn
  write access.

  Is being held until the list moderator can review it for approval.

  The reason it is being held:

  Post by non-member to a members-only list
  =

I am definitely a member though: I got a confirmation message about
that and can edit my options.  But I do not get any email and I am not
allowed to post, so that suggests otherwise.

Maybe a mailing list admin can look at outstanding moderator requests?

Thanks,

-- 
Maurits van Rees | http://maurits.vanrees.org/
Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] Re: Session concurrency problem

2008-01-30 Thread Maurits van Rees
Hi,

It's been a long day and I am way out of my league on this issue, so I
will just go in off-topic mode and share a bash trick.

Stephan Richter, on 2008-01-30:
> cd sessionIssue2
> for number in 1 2 3 4 5 6 7 8 ;do sh sessionTest.sh;done

You can also do:

  for number in $(seq 8); do sh sessionTest.sh;done

Thank you and good night. :)

-- 
Maurits van Rees | http://maurits.vanrees.org/
Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] Re: Request for commit access for updating zope.sendmail

2008-01-25 Thread Maurits van Rees
Darryl Cousins, on 2008-01-24:
> Hi Matthew,
>
> On Fri, 2008-01-25 at 09:51 +1300, Matthew Grant wrote:
>> Hi!
>> 
>> I have recently been doing a lot of work on zope.sendmail, and would
>> like to commit a lot of fixes, namely for:
>> 
>> 1) Handling of SMTP error 451 etc.
>> 2) Cleaning stale lock links out of the queue
>> 3) Handling Server disconnection
>> 4) Handling of connect() failure
>> 
>> The above are fixes for Bug #157104 
>> https://bugs.launchpad.net/zope3/+bug/157104
>> 
>> 5) A bit of a clean up QueueProcessorThread so that it complies with
>> IMailQueueProcessor in interfaces.py
>
> This all looks very cool. In order to become a zope contributor I
> believe this FAQ [1] is still valid and requires firstly to send a
> signed copy of this agreement [2] to the Zope Corporation. (I'm sure
> I'll be corrected if this has changed).
>
> [1] http://www.zope.org/DevHome/Subversion/ContributorFAQ
> [2] http://dev.zope.org/Subversion/Contributor.pdf

I was just looking for these things today as I am pondering becoming a
contributor myself.  For starters I am missing Dutch translations.

Anyway, I found this more recent committer agreement:

http://foundation.zope.org/agreements/ZopeFoundation_Committer_Agreement.pdf

I suggest you use that one.

-- 
Maurits van Rees | http://maurits.vanrees.org/
Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] Re: Is download.zope.org/ppix still being updated?

2008-01-21 Thread Maurits van Rees
Stephan Richter, on 2008-01-21:
> On Monday 21 January 2008, Jim Fulton wrote:
>> > I had intermittent problems reacing the cheese shop at the end of last
>> > week.  Maybe that is related?
>>
>> The cron jobs that update the mirror got hung up.  I'm not sure why.  
>> I've killed the hung processes and will keep an eye on them.
>
> PyPI was down this weekend for quiet a long time. I got about 800 messages 
> with failures. In my case the lock file ended up being out of sync with the 
> process, so I had to delete it and it worked again.

Works like a charm again.  Thanks Jim and Stephan!

(I thought for a minute it did not work when I looked at the page for
grok in the browser, but I just had to refresh.)

-- 
Maurits van Rees | http://maurits.vanrees.org/
Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] Is download.zope.org/ppix still being updated?

2008-01-21 Thread Maurits van Rees
Hi,

Is the ppix index still being updated?  It normally lags just a few
minutes behind the cheese shop, right?

I see for example that grok 0.11.1, which was released yesterday, and
is currently the next to last package on the most recent packages list
on the cheese shop, is not listed here yet:

http://download.zope.org/ppix/grok/

I had intermittent problems reacing the cheese shop at the end of last
week.  Maybe that is related?

-- 
Maurits van Rees | http://maurits.vanrees.org/
Work | http://zestsoftware.nl/
"This is your day, don't let them take it away." [Barlow Girl]

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] request.get vs request.form.get

2007-11-23 Thread Maurits van Rees
I have been busy with zope.formlib.  See this weblog entry for some
background:

http://maurits.vanrees.org/weblog/archive/2007/11/search-forms-with-zope-formlib-and-batching

This is Plone 3 with Zope 2.10.4 btw.


I discovered there is a difference between getting a value from the
request or from request.form when unicode is involved.  From a pdb
session:

>>> request.form.get('SearchableText')
u'\xff'
>>> request.get('SearchableText')
'\xc3\xbf'

This is the character ÿ: a y with something extra on top. :) You can
see the same in a python prompt (I hope this is readable for
everyone):

>>> u"ÿ"
u'\xff'
>>> "ÿ"
'\xc3\xbf'


This gave me problems while using zope.formlib.  In the method
zope.app.form.browser.textwidgets.TextWidget._getFormInput() the value
is fetched from the request and not request.form. So you get a
UnicodeDecodeError. In the weblog entry I mentioned I post some code
to guard against that in a setUpWidgets method in your own form page:
deliberately overwrite the variable in the request by the variable in
request.form.

But what I want to ask here is: does something need to be fixed
somewhere in zope?

Should the value in request and request.form really be the same
always?  Probably: always unicode?

Should zope.app.form.browser.textwidgets.TextWidget._getFormInput()
get the value from the form instead of from the request?

Thanks,

-- 
Maurits van Rees | http://maurits.vanrees.org/ [NL]
Work | http://zestsoftware.nl/
"Do not worry about your difficulties in computers,
 I can assure you mine are still greater."

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )