[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
Ghislain Fourny has proposed merging lp:~zorba-coders/zorba/bug-971782 into lp:zorba. Requested reviews: Dennis Knochenwefel (dennis-knochenwefel) Markos Zaharioudakis (markos-za) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Cleaning up attribute and element nodes' type handling and checking invariants, following an inconsistency discovered on Windows. -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-971782 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-971782 into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-971782 into lp:zorba has been updated. Status: Merged => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-971782 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-971782 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-971782 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-971782-2012-04-04T15-36-09.028Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-971782 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-971782 into lp:zorba has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-971782-2012-05-30T12-00-03.104Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
Validation queue job bug-971782-2012-05-30T12-00-03.104Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-971782 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-971782 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-971782-2012-06-26T10-11-07.167Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
Validation queue job bug-971782-2012-06-26T10-11-07.167Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-971782 into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/bug-971782 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job bug-971782-2012-04-04T15-36-09.028Z is finished. The final status was: No tests were run - build or configure step must have failed. Not commiting changes. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 3 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
Review: Approve looks good to me. -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
Review: Needs Information The bug has already been marked as "Fix Released". Which problem does this commit fix? -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
Ghislain and I did some cleanup. And I think this was a problem that appeared only on windows. I don't know if we ever added a bug report for it. Ghislain, do you remember more than I do? -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
I think that the existing code could lead the tree structure (attribute/element types) to an inconsistent state that led to windows crashes. As far as I can remember, it was originally because of QName comparison using == instead of equals. This merge proposal (i) brings more encapsulation to the node/tree classes by enforcing some invariants on accessible states w.r.t. types (in debug mode) to be on the safe side and (ii) fixes the code so that these invariants always hold outside of the type-handling functions. In particular, invariants should hold before and after calling setTree, so that the the consumer of this function does not need to worry about it. -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
I think that this bug was marked as "Fix Released" because it was raised against Sausalito, and this code is already in Sausalito. -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
Review: Needs Fixing -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
1. Why are the asserts in XmlTree::getType() converted to ifs? Did th asserts actually trigger ever? 2. The setTree() methods has been made virtual. This si not good, because the method is used rather often. 3. The 6 lines: #ifndef EMBEDED_TYPE #ifndef NDEBUG ATTRIBUTE_ELEMENT_INVARIANT1; ATTRIBUTE_ELEMENT_INVARIANT2; ATTRIBUTE_ELEMENT_INVARIANT3; #endif #endif should be converted to a single line via the use of a macro. -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
Hi Markos, Thanks a lot! 2. and 3. should be fixed. About 1: invariant 3 checks that the tree does not contain a type under certain circumstances, so it requires getType() to fail in a gracious manner. The asserts that were in getType() are actually "relocated" to the element and attribute invariants that are more precise. Does it make sense? -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
> Hi Markos, > > Thanks a lot! > > 2. and 3. should be fixed. > About 2, the problem is still there, because setTree now calls getNodeKind(), which is also a virtual method. But this is a more general problem; basically, we need a non-virtual getNodeKindInternal() method to be used everywhere inside the simple store (would this work for the Sausalito store as well?). So, you don't have to do anything about it in this branch. > About 1: invariant 3 checks that the tree does not contain a type under > certain circumstances, so it requires getType() to fail in a gracious manner. > The asserts that were in getType() are actually "relocated" to the element and > attribute invariants that are more precise. > > Does it make sense? Ok. -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-971782 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-971782/+merge/100788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
