1. This webrev is not against the 2D forest. Please re-generate against 2D.
2.
/local/work/jdk8/jdk8/jdk/src/share/classes/java/awt/GraphicsConfiguration.java:84:
error: malformed HTML
When you have < & > chars in code the preferred solution uses {@code
.. } like this :
http://cr.openjdk.
D'oh!
The argb value supplied to the PixelConverter is a non-premultiplied
value by definition (you would not be able to extract a non-pre value
from an already-pre value so we supply it as non-pre and any
premultiplied destination must then apply the premultiplication when it
converts it to
Hi guys,
I haven't looked at the code in question in quite a while, but my recollection
is that the OGL (and D3D) pipelines treated all surfaces -- including opaque
ones -- as premultiplied because the OpenGL blend modes weren't flexible enough
to replicate the equations used in our software lo
[I just saw Jim's reply but here's what I was going to send anyway].
On 9/30/2013 10:52 PM, Clemens Eisserer wrote:
Hi,
I am currently testing compatibility of the xrender pipeline with
different composition operations, and I noticed for AlphaComposite.SRC
the D3D and OGL pipelines store pre-mu
I'm not the greatest expert on generics (in particular, in terms of
issues of retrofitting generics into existing public code without
breaking compatibility), but I'll note that the properties on an image
were always "documented" to be String->Object, but that was well before
generics and so we
From looking at the code, it looks like this is probably a bug. The
default color model for TYPE_INT_RGB is non-premultiplied which means
that we should have unmultiplied the alpha before we stored the color.
Now, if you had used an alpha of 0, then we would have been unable to
reverse any pre
Apologies as this is an old bug, but I just looked at the fix and it
seems to me that it will allow shearing transforms to pass because the
tests are incomplete. The 0or180 flag only tests if the horizontal
lines stay horizontal, but they could shift relative to each other in
increasing Y whic
Approved.
Jennifer
On 8/30/2013 4:51 AM, Andrew Brygin wrote:
Hello,
could you please review a fix for CR 8022632?
Bug: http://bugs.sun.com/view_bug.do?bug_id=8022632
Webrev: http://cr.openjdk.java.net/~bae/8022632/webrev.00/
Suggested fix just makes WBMP spi canDecodeInput() method
more reli
Looks good.
-phil.
On 8/30/2013 4:51 AM, Andrew Brygin wrote:
Hello,
could you please review a fix for CR 8022632?
Bug: http://bugs.sun.com/view_bug.do?bug_id=8022632
Webrev: http://cr.openjdk.java.net/~bae/8022632/webrev.00/
Suggested fix just makes WBMP spi canDecodeInput() method
more rel
Changeset: f53aeb3c7eed
Author:prr
Date: 2013-10-02 11:22 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f53aeb3c7eed
7179526: xrender : closed/sun/java2d/volatileImage/LineClipTest.java failed
since jdk8b36
Reviewed-by: prr, jchen
! src/solaris/classes/sun/java2d/xr/Growab
Changeset: 5f3d984d8207
Author:prr
Date: 2013-10-02 11:16 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/5f3d984d8207
8025837: Extraneous changes in the fix for 8007386
Reviewed-by: jgodinez, jchen
! src/solaris/native/sun/java2d/x11/XRBackendNative.c
Approved.
Jennifer
On 10/2/2013 10:56 AM, Phil Race wrote:
This fix : http://cr.openjdk.java.net/~prr/8025837/
undoes some extraneous changes here :
http://cr.openjdk.java.net/~ceisserer/8007386/webrev.04/
they apparently crept into that updated final webrev as
they were not in http://cr.openj
Looks good.
Thanks,
Johnny Chen
On Oct 2, 2013, at 10:56 AM, Phil Race wrote:
> This fix : http://cr.openjdk.java.net/~prr/8025837/
>
> undoes some extraneous changes here :
> http://cr.openjdk.java.net/~ceisserer/8007386/webrev.04/
>
> they apparently crept into that updated final webrev as
This fix : http://cr.openjdk.java.net/~prr/8025837/
undoes some extraneous changes here :
http://cr.openjdk.java.net/~ceisserer/8007386/webrev.04/
they apparently crept into that updated final webrev as
they were not in http://cr.openjdk.java.net/~ceisserer/8007386/webrev.02
-phil.
Hi Jennifer,
Would it a big thing to have that fix ported back to OpenJDK 1.7? Should
I create a according webrev for it?
Cheers Patrick
On 09/26/2013 11:37 PM, Jennifer Godinez wrote:
Looks good.
Jennifer
On 9/26/2013 1:59 PM, Patrick Reinhart wrote:
Hi Jennifer,
See http://reinharts.dyn
java.awt.image is one of the Java2D packages, so I'm adding 2d-dev to
CC. Please, wait for at least one approval from Java2D team.
For easier review, I put the webrev here:
http://cr.openjdk.java.net/~art/srikalyc/8025684.00/
It looks fine to me. There is one "unchecked" warning still left,
Changeset: 96ff58f4
Author:vadim
Date: 2013-10-02 10:06 +0400
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/96ff58f4
8024343: Change different color with the "The XOR alternation color" combobox,
the color of the image can not shown immediately.
Reviewed-by: ceisserer, pr
17 matches
Mail list logo
