Hello,
On 02/06/2014 04:13 PM, Phil Race wrote:
Comments/questions on the changes :-
Font2D.java
108 protected ReferenceFontStrike lastFontStrike = new
SoftReference(null);
...
320 lastFontStrike = new SoftReference(strike);
So the diamond operator can be used in this 2nd case ?
On 1/22/2014 6:40 AM, Jim Graham wrote:
Hi Alexander,
Before we get too far down the road on this API, I think we understand
the way in which MacOS processes multi-resolution images for HiDPI
screens, but have we investigated the processes that Windows uses
under Windows 8? My impression is
Approved.
Jennifer
On 02/06/2014 02:31 PM, Phil Race wrote:
http://cr.openjdk.java.net/~prr/8032693/
This is a fix for https://bugs.openjdk.java.net/browse/JDK-8032693
It was introduced by the JDK 8 b115 fix for
https://bugs.openjdk.java.net/browse/JDK-8022536
The root of the issue is that
2nd reviewer anyone ? FWIW the external submitter of the bug report confirms
this fixes it for him too.
-phil.
On 2/7/2014 9:00 AM, Jennifer Godinez wrote:
Approved.
Jennifer
On 02/06/2014 02:31 PM, Phil Race wrote:
http://cr.openjdk.java.net/~prr/8032693/
This is a fix for
Hi , Phil.
Why we catch Throwable(OutOfMemoryError)? Probably we can use java
generics in defaultMap in CUPSPrinter?
Code from the test:
42 if (!os.equals(linux)) {
43 System.out.println(Linux specific test. No need to
continue);
44 }
No need to continue... and
On 2/7/2014 12:21 PM, Sergey Bylokhov wrote:
Hi , Phil.
Why we catch Throwable(OutOfMemoryError)?
Because I want to be as sure as I can be that we don't get
some random error causing us to fail completely as was happening.
Probably we can use java generics in defaultMap in CUPSPrinter?
On 08.02.2014 0:35, Phil Race wrote:
42 if (!os.equals(linux)) {
43 System.out.println(Linux specific test. No need to
continue);
44 }
No need to continue... and continue anyway?
Oops. Meant to have a return there :)
I'll fix before I push. Anything else ?
No. The fix
Thanks Joe for reviewing.
I would like to get 2d developer review as well before pushing this, let
me know if that's not necessary.
Also there was a discussion ealier on whether such change should go to
client or jdk9/dev repo, do we have a conclusion?
Cheers,
Henry
On 02/05/2014 06:01
Yes, it should get 2d review and I will look at this soon as priorities
permit but the *conclusion* is that the client team
ask that such changes go into the client forest. If this is a problem for
you then we will do it on your behalf. We do not want client changes
directly into dev. That is a
BMPMetadata.java
94 // Fields from CommentExtension
95 // List of byte[]
96 public Listbyte[] comments = null; // new ArrayList();
hmm .. how did you decide this was correct, other than trusting the comment?
The thing is I can't actually see where this field is used and I'm
On 2/7/2014 2:20 PM, Phil Race wrote:
Yes, it should get 2d review and I will look at this soon as priorities
permit but the *conclusion* is that the client team
ask that such changes go into the client forest. If this is a problem for
you then we will do it on your behalf. We do not want client
The primary thing that I was concerned about was the presence of
integers in the API when Windows uses non-integer multiples and also
what policy they use for choosing scaled images.
I don't see a mention of taking the current transform into account, just
physical issues like screen DPI and
On 02/07/2014 03:00 PM, Phil Race wrote:
BMPMetadata.java
94 // Fields from CommentExtension
95 // List of byte[]
96 public Listbyte[] comments = null; // new ArrayList();
hmm .. how did you decide this was correct, other than trusting the
comment?
For this one, I took it
Hi Anton,
In CPlatformLWWindow.java, why does it have to search for the right
device when it was created with/from a Window object that should already
know the right device?
SG2D, line 2114 - I think TRANSFORM_SCALE allows negative scale factors
so I think you need a little more protection
14 matches
Mail list logo
