Re: [OpenJDK 2D-Dev] Provide a way to make MultiResolutionImage screen compatible

2015-03-27 Thread Jim Graham
Thanks Sergey, Have you been following the rest of this thread? Any thoughts on how much the lack of PRE pixel format in the PNG loader might be hurting us? ...jim On 3/27/15 5:31 PM, Sergey Bylokhov wrote: 28.03.15 0:50, Jim Graham wrote: On 3/27/15 3:48 AM, Hendri

Re: [OpenJDK 2D-Dev] Provide a way to make MultiResolutionImage screen compatible

2015-03-27 Thread Sergey Bylokhov
28.03.15 0:50, Jim Graham wrote: On 3/27/15 3:48 AM, Hendrik Schreiber wrote: That's an odd bug. I'll note that it points out that we had missing loops in the OpenGL pipeline to directly deal with the non-PRE data and it links to a bug that adds those loops for more direct handling. Actually

Re: [OpenJDK 2D-Dev] [OpenJDK Rasterizer] Path2D optimizations

2015-03-27 Thread Jim Graham
Hi Laurent, Looks great. Some comments on the test: - A couple of methods have "/**" even though the comment is just informational to the programmer and not representing an API. It looks like "/**" is the standard practice for the @test comment at the top of the class even though jtreg isn'

Re: [OpenJDK 2D-Dev] Provide a way to make MultiResolutionImage screen compatible

2015-03-27 Thread Jim Graham
On 3/27/15 3:48 AM, Hendrik Schreiber wrote: If my understanding of the current drawing pipeline is correct, RGBA without premultiplication is slow as premultiplication is done on-the-fly when drawing—at least for OS X and OpenGL, as pointed out in https://bugs.openjdk.java.net/browse/JDK-8059

Re: [OpenJDK 2D-Dev] Provide a way to make MultiResolutionImage screen compatible

2015-03-27 Thread Jim Graham
Hi Hendrik, You also need to look at the texture caching that goes on. Decoders bring the image into a RAM representation and that can sometimes be used directly and so it's format might matter, but we typically upload image data into textures in VRAM and it is that format which is critical f

Re: [OpenJDK 2D-Dev] [OpenJDK Rasterizer] Path2D optimizations

2015-03-27 Thread Laurent Bourgès
Jim, Here is a new Path2d patch: http://cr.openjdk.java.net/~lbourges/path2D/Path2D.2/ Changes: - Fix ArrayIndexOutOfBounds in ptCrossing / rectCrossing when coords array is zero-sized (0 capacity constructor): bug present in jdk8 - new tests: Path2dEmpty to test this bug Path2dCopyConstructor to

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

2015-03-27 Thread Andrew Brygin
There is a minor update in the fix: it does not worth to blend black-on-white and white-on-black glyphs for the case of AA glyphs, because it makes no difference. CGGlyphImages.m, lines 294 - 325, 755 - 763, and 787 - 794: http://cr.openjdk.java.net/~bae/8023794/9/webrev.08 I have also modifie

Re: [OpenJDK 2D-Dev] Provide a way to make MultiResolutionImage screen compatible

2015-03-27 Thread Hendrik Schreiber
> On Mar 26, 2015, at 22:52, Jim Graham wrote: > On 3/26/15 9:21 AM, Hendrik Schreiber wrote: >> Nevertheless, I wouldn't mind some feedback regarding converting >> ToolKitImages easily to something that can be drawn faster >> (TYPE_INT_ARGB_PRE). Don't we all want that? >> Or asked the other w