[OpenJDK 2D-Dev] Fwd: [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

2015-05-26 Thread Torgeir Veimo
This looks extremely promising; https://bugzilla-attachments-216655.netbeans.org/bugzilla/attachment.cgi?id=153888 I'd say don't let perfect be the enemy of the good, please get this out into a jdk9 release and let the community provide more feedback. On 22 May 2015 at 00:23, Andrew Brygin

Re: [OpenJDK 2D-Dev] RFR [TestBug 8080086]: Test javax/imageio/plugins/png/ItxtUtf8Test.java fails on Linux with G1 GC

2015-05-26 Thread prasanta sadhukhan
Hi Sergey, Yes, the original bugs can still be reproduced with jdk1.6 with updated test. Regards Prasanta On 5/25/2015 9:19 PM, Sergey Bylokhov wrote: Hi, Prasanta. Can you confirm that an initial bugs( 6541476 6782079) still can be reproduced using an updated test on x86 and x64? On

Re: [OpenJDK 2D-Dev] RFR [TestBug 8080086]: Test javax/imageio/plugins/png/ItxtUtf8Test.java fails on Linux with G1 GC

2015-05-26 Thread Sergey Bylokhov
Thanks for clarification! The fix looks fine. On 26.05.15 9:12, prasanta sadhukhan wrote: Hi Sergey, Yes, the original bugs can still be reproduced with jdk1.6 with updated test. Regards Prasanta On 5/25/2015 9:19 PM, Sergey Bylokhov wrote: Hi, Prasanta. Can you confirm that an initial

Re: [OpenJDK 2D-Dev] [9] Review Request: 8080847 Copying of overlapping memory should be improved in java2d

2015-05-26 Thread Jim Graham
What crash in memcpy? The issue you pointed to is about dealing with overlapping memory. memcpy does not crash on overlapping memory copies, it just duplicates data oddly in a way that most uses probably don't want. Also, the fix you gave only fixed the problem for the horizontal direction,

Re: [OpenJDK 2D-Dev] [9] Review Request: 8080847 Copying of overlapping memory should be improved in java2d

2015-05-26 Thread Sergey Bylokhov
On 26.05.15 13:43, Jim Graham wrote: What crash in memcpy? Simply because behavior of this function is undefined if the two arrays to and from overlap. Plus this clears an output for the tools like valgrind and some other issues can be found easily. The issue you pointed to is about dealing

Re: [OpenJDK 2D-Dev] RFR: JDK-8079652: Could not enable D3D pipeline

2015-05-26 Thread Sergey Bylokhov
Hi, Vadim. The fix looks fine to me. On 26.05.15 16:09, Vadim Pakhnushev wrote: Could somebody take a look? On 13.05.2015 13:48, Vadim Pakhnushev wrote: Actually I've found a better solution - specify WS_POPUP window style. In this case the client area size will be exactly as specified

Re: [OpenJDK 2D-Dev] RFR: JDK-8079652: Could not enable D3D pipeline

2015-05-26 Thread Vadim Pakhnushev
Could somebody take a look? On 13.05.2015 13:48, Vadim Pakhnushev wrote: Actually I've found a better solution - specify WS_POPUP window style. In this case the client area size will be exactly as specified instead of adjusting for some default window style. So please review the second

Re: [OpenJDK 2D-Dev] [9] Review Request: 8080847 Copying of overlapping memory should be improved in java2d

2015-05-26 Thread Jim Graham
Undefined doesn't mean may crash in this case, it means that the contents of memory may not match what you would expect if the regions overlap because it is just a dump copy loop that does not do any aliasing checks. Is there a way to silence the warning? In this particular case we are

Re: [OpenJDK 2D-Dev] RFR: JDK-8079652: Could not enable D3D pipeline

2015-05-26 Thread Phil Race
I am OK with this too. -phil. On 05/26/2015 06:11 AM, Sergey Bylokhov wrote: Hi, Vadim. The fix looks fine to me. On 26.05.15 16:09, Vadim Pakhnushev wrote: Could somebody take a look? On 13.05.2015 13:48, Vadim Pakhnushev wrote: Actually I've found a better solution - specify WS_POPUP

Re: [OpenJDK 2D-Dev] [9] Review Request: 8080847 Copying of overlapping memory should be improved in java2d

2015-05-26 Thread Jim Graham
Compilers have also gotten really really good at recognizing memory copy loops and applying the same optimizations automatically depending on the optimization level. I'd really prefer to just leave this code alone and maybe find a way to tag the line to silence the warnings from the tool. If