+1
...jim
On 12/3/15 10:17 PM, prasanta sadhukhan wrote:
ok. Thanks Jim .
Please review the modified webrev
http://cr.openjdk.java.net/~psadhukhan/8140530/webrev.02/
Regards
Prasanta
On 12/4/2015 6:45 AM, Jim Graham wrote:
I think it makes sense to catch it at a higher level,
Looks fine.
ps: I am glad that my test is written in a style that allowed to find a
bug in a new plug-in.
On 04.12.15 2:43, joe darcy wrote:
The other failing test is closed and I will send a separate (internal)
review for that one :-)
Thanks,
-Joe
On 12/3/2015 1:10 PM, Phil Race wrote:
Hi Sergey,
Thanks for your suggestion.
I verified all other image writers with present code(For WBMP after changing
BufferedImageType to TYPE_BYTE_BINARY) there are no problems in them.
Cache is closed properly and we don't see IndexOutOfBoundsException.
Thanks,
Jay
-Original Message-
On 12/02/2015 10:26 PM, Andrew Hughes wrote:
- Original Message -
On 11/25/2015 06:53 PM, Andrew Hughes wrote:
- Original Message -
On 11/18/2015 06:17 PM, Jiri Vanek wrote:
On 11/12/2015 02:24 PM, Sergey Bylokhov wrote:
Hi, Jiri.
This is a valid point, did you file a new CR
ok. Thanks Jim .
Please review the modified webrev
http://cr.openjdk.java.net/~psadhukhan/8140530/webrev.02/
Regards
Prasanta
On 12/4/2015 6:45 AM, Jim Graham wrote:
I think it makes sense to catch it at a higher level, but also to
throw some type of exception from the X11 code as you do now
Some of our internal build servers only have access to an old (2.3.5)
version
of freetype whereas harfbuzz requires 2.4.2 - maybe even later, but at
least that.
The dependency comes from compiling in hb-ft.cc even though we do not
currently use that code since we now go via a custom JDK font
Laurent,
If you were to run this on a jigsaw EA build it would fail due to accessing
sun.java2d.pipe.RenderingEngine. I know this is "pre-existing" but
jigsaw is coming ...
So why not update it to set call
System.getProperty("sun.java2d.renderer.verbose");
and it'll print out the renderer
https://bugs.openjdk.java.net/browse/JDK-8144654
Please review this webrev that fixes logging issues in Marlin:
http://cr.openjdk.java.net/~lbourges/marlin/marlin-8144654.0/
Changes:
- Byte/Float/Int/ArrayCache: use logInfo instead of System.out
- MarlinConst: enableLogs uses
Looks fine.
On 04.12.15 0:35, Phil Race wrote:
Some of our internal build servers only have access to an old (2.3.5)
version
of freetype whereas harfbuzz requires 2.4.2 - maybe even later, but at
least that.
The dependency comes from compiling in hb-ft.cc even though we do not
currently use
I thought it was two tests ?
-phil.
On 12/03/2015 01:09 PM, joe darcy wrote:
Hello,
The test
javax/imageio/plugins/shared/WriteAfterAbort.java
is failing and should be problem listed until the underlying problem
is fixed (JDK-8144554).
Please review the patch below which does this.
Phil,
If you were to run this on a jigsaw EA build it would fail due to accessing
> sun.java2d.pipe.RenderingEngine. I know this is "pre-existing" but jigsaw
> is coming ...
>
You're right, sorry !
Here is a new webrev:
http://cr.openjdk.java.net/~lbourges/marlin/marlin-816.1/
Changes:
-
https://bugs.openjdk.java.net/browse/JDK-8144630
Please review this simple webrev that fixes the Thread creation in
RendererStats:
http://cr.openjdk.java.net/~lbourges/marlin/marlin-8144630.0/
Regards,
Laurent Bourgès
I think it makes sense to catch it at a higher level, but also to throw
some type of exception from the X11 code as you do now because
regardless of our higher level policy, the X11 implementation function
can never succeed there...
So, my preference would be to keep the existing pieces of
13 matches
Mail list logo
