Re: [OpenJDK 2D-Dev] Review request for JDK-8143562: JPEG reader returns null for getRawImageType()

2015-12-16 Thread Jayathirth D V
Thanks for the review Phil. Can I get one more review for new webrev : HYPERLINK "http://cr.openjdk.java.net/%7Ejdv/8143562/webrev.01/"http://cr.openjdk.java.net/~jdv/8143562/webrev.01/ Regards, Jay From: Phil Race Sent: Wednesday, December 16, 2015 12:00 AM To: Jayathirth D V Cc: 2d-de

Re: [OpenJDK 2D-Dev] RFR 8144718: Pisces / Marlin Strokers may generate invalid curves with huge coordinates and round joins

2015-12-16 Thread Phil Race
+1. -phil. On 12/15/2015 02:06 PM, Laurent Bourgès wrote: Jim & Phil, Here is an updated webrev: http://cr.openjdk.java.net/~lbourges/marlin/Stroker-8144718.3/ I have totally rewritten the test to: - enable Marlin doChecks=t

[OpenJDK 2D-Dev] RFR: 8145584: java/awt/font/TextLayout/TestGetPixelBounds.java fails on Linux

2015-12-16 Thread Phil Race
http://cr.openjdk.java.net/~prr/8145584/ https://bugs.openjdk.java.net/browse/JDK-8145584 The bug is that the code that tries to measure where the bounds of the rendering is not applying the same rounding of the rendering position as the rendering path does. It seems this test was just waiting f

Re: [OpenJDK 2D-Dev] RFR 6488522: PNG writer should permit setting compression level and iDAT chunk maximum size

2015-12-16 Thread Phil Race
Looks good. I will push it shortly. -phil. On 12/15/2015 07:25 AM, Laurent Bourgès wrote: Sergey, thanks for your review. Could you or Phil push it for me once another reviewer is OK ? Laurent 2015-12-15 16:22 GMT+01:00 Sergey Bylokhov >: Looks fine

Re: [OpenJDK 2D-Dev] Review request for JDK-8143562: JPEG reader returns null for getRawImageType()

2015-12-16 Thread Ambarish Rapte
Hi Jay, As per the specification getRawImageType() should return a valid ImageTypeSpecifier for each color space, which was missing for YCbCr. This patch fixes the issue & seems fine to me. Thanks, Ambarish From: Jayathirth D V Se