Re: [OpenJDK 2D-Dev] RFR 8149558: [TEST] add regression test for JDK-8150154

2016-02-26 Thread Alexander Stepanov
> Should we also test bmp and jpg? couldn't use writer for these formats "as is" (simply "writer.write(img)") - this causes IOExceptions. JPEGImageWriteParam or BMPImageWriteParam should be used and another signature for write() method. Extended test logic looks quite bulky with all this addit

Re: [OpenJDK 2D-Dev] RFR 8149558: [TEST] add regression test for JDK-8150154

2016-02-26 Thread Sergey Bylokhov
Should we also test bmp and jpg? You tested a different BI formats, but you do not check that the saved information actually relates to the particular image(all of them have a white color and same size). So you will not notice if the Writer will write the same(first) image in all subsequent cal

Re: [OpenJDK 2D-Dev] RFR 8149558: [TEST] add regression test for JDK-8150154

2016-02-26 Thread Alexander Stepanov
Hello, Sergey, Yes, I'll add the "please remove @ignore" comment to the initial JDK-8150154 in case of this test push. Thanks, Alexander On 2/26/2016 5:40 PM, Sergey Bylokhov wrote: Hi, Alexander. Who will responsible to remove @ignore tag? It seems this information should be added to JDK-8

Re: [OpenJDK 2D-Dev] RFR 8149558: [TEST] add regression test for JDK-8150154

2016-02-26 Thread Sergey Bylokhov
Hi, Alexander. Who will responsible to remove @ignore tag? It seems this information should be added to JDK-8150154? On 25.02.16 18:17, Alexander Stepanov wrote: Sorry, just a reminder. Thanks, Alexander On 2/12/2016 1:35 PM, Alexander Stepanov wrote: Hello, Could you please review the fol

Re: [OpenJDK 2D-Dev] Review request for 8069348 SunGraphics2D.copyArea() does not properly work for scaled graphics in D3D

2016-02-26 Thread Sergey Bylokhov
+1 On 02.02.16 4:38, Jim Graham wrote: Hi Alexandr, This looks great. It's good to go, but you might want to fix one indenting issue before you push: X11SD and XRSD both had the same edit, but you made a different decision on whether to get rid of some extra parentheses or not and XRSD was le