Hi Prasanta,
Fix looks fine to me. We are taking care of both having the dialog within
proper monitor and also making sure that it stays within the window bounds and
also consistent with native print dialog.
Thanks,
Jay
-Original Message-
From: Philip Race
Sent: Wednesday, March 02,
The logic here has mixed up the opacities and what needs to be done
about them.
If the source image is opaque, then this is not a BG operation at all
because the bg color would not show through an opaque image, so checking
the srcData is both wrong and should be a NOP here. If we get into tha
Oh sorry, I just realised you did not add the new bug id to the test
it should now say
@bug 8041644 8044788
No need for an updated webrev ..
-phil.
On 3/2/16, 2:20 PM, Philip Race wrote:
+1
>The fix looks good. But you should remove the "-Dsun.java2d.d3d"
option in th
> test(don't change it
+1
>The fix looks good. But you should remove the "-Dsun.java2d.d3d"
option in th
> test(don't change it to true) otherwise it will fail on non-windows
platform, because the "=false" is
> ignored if pipeline is not available.
Removing it was the right thing to do but it would not have failed
approved.
On 3/1/16, 1:21 AM, prasanta sadhukhan wrote:
Hi Phil,
Please find my modified webrev
http://cr.openjdk.java.net/~psadhukhan/8138749/webrev.07/
which takes care of the fact (as compared to webrev.06), if dialog
does not exceed window bounds at both left or top, do not modify
dialog
Hi, Jay.
The fix looks fine. Probably we can improve the fix a little bit.
It seems that makeBufferedImage() is used only in two places in
DrawImage.java. And after the fix in both cases we have:
int type = ((srcData.getTransparency() == Transparency.OPAQUE)
? BufferedImage.TYP
Looks fine.
On 02.03.16 10:16, Prahalad Kumar Narayanan wrote:
Dear Sergey, Phil & Java 2D-Dev Group
Good day to you.
A Quick Follow-up to Bug: JDK-8044788
Bug Link: https://bugs.openjdk.java.net/browse/JDK-8044788
Review Fixes:
The following fixes have been incorporated collating all of Serg
Hi,
I have updated the changes to select proper Buffer Image type based on source
transparency and not just using ARGB directly.
Please find the updated webrev for review:
http://cr.openjdk.java.net/~jdv/8139183/webrev.01/
Thanks,
Jay
From: Jayathirth D V
Sent: Wednesday, March
Hi,
Please review the following fix in JDK9:
Bug : https://bugs.openjdk.java.net/browse/JDK-8139183
Webrev : http://cr.openjdk.java.net/~jdv/8139183/webrev.00/
Issue : When we scale any buffered image using drawImage() API which takes
scale coordinates we are losing alpha channel
