[OpenJDK 2D-Dev] Review Request for JDK-6185114: Undefined Exception in SampleModel, method createCompatibleSampleModel

2016-03-16 Thread Ajit Ghaisas
Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-6185114 Issue : Undefined Exception in SampleModel, method createCompatibleSampleModel Root Cause : The SampleModel constructor documentation says - it throws the IllegalArgumentException if the product of width and height

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6379088, , Suboptimal expression in javax.imageio.ImageTypeSpecifier.getBitsPerBand(int)

2016-03-16 Thread prasanta sadhukhan
Thanks Jay. Sergey, could you please give your +1 on this? Regards Prasanta On 3/16/2016 2:46 PM, Jayathirth D V wrote: Change is fine. Looks like this is the only place in ImageTypeSpecifier where we are not using short-circuit logical "or". -Original Message- From: prasanta

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6379088, , Suboptimal expression in javax.imageio.ImageTypeSpecifier.getBitsPerBand(int)

2016-03-16 Thread Jayathirth D V
Change is fine. Looks like this is the only place in ImageTypeSpecifier where we are not using short-circuit logical "or". -Original Message- From: prasanta sadhukhan Sent: Tuesday, March 15, 2016 5:36 PM To: Sergey Bylokhov; Jayathirth D V; 2d-dev@openjdk.java.net Subject: [9] RFR:

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8066139, , Null return from PrintJob.getGraphics() running closed/java/awt/PrintJob/HighResTest/HighResTest.java

2016-03-16 Thread Jayathirth D V
Looks good to go.   Thanks, Jay   From: prasanta sadhukhan Sent: Wednesday, March 16, 2016 2:17 PM To: Jayathirth D V Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8066139, , Null return from PrintJob.getGraphics() running

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8066139, , Null return from PrintJob.getGraphics() running closed/java/awt/PrintJob/HighResTest/HighResTest.java

2016-03-16 Thread prasanta sadhukhan
Hi Jay, Updated testcase http://cr.openjdk.java.net/~psadhukhan/8066139/webrev.03/ Regards Prasanta On 3/16/2016 12:58 PM, Jayathirth D V wrote: HI Prasanta, Changes are fine. Both the print dialogs are coming and there is no NPE. In test case please change copyright year to 2016 and also

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8066139, , Null return from PrintJob.getGraphics() running closed/java/awt/PrintJob/HighResTest/HighResTest.java

2016-03-16 Thread Jayathirth D V
HI Prasanta,   Changes are fine. Both the print dialogs are coming and there is no NPE. In test case please change copyright year to 2016 and also it is better to have jtreg comments before import statements for readability.   Thanks, Jay   From: Phil Race Sent: Wednesday, March 16,

[OpenJDK 2D-Dev] [9] RFR: JDK-8151110, , libfontmanager should free memory with delete[] if it was allocated with new[]

2016-03-16 Thread prasanta sadhukhan
Hi Phil, Please review a small fix for bug: https://bugs.openjdk.java.net/browse/JDK-8151110 webrev: http://cr.openjdk.java.net/~psadhukhan/8151110/webrev.00/ where the issue was found that the allocation of memory was done through new operator but free was done through free(). Since they