Hi Phil,
On 3/29/2016 6:45 AM, Philip Race wrote:
Please add an evaluation to the bug report.
As to the fix I am under the impression that min&max page are
meant to constrain what the user can enter in the dialog so
if min page & max page are set to "1" then the problem
may be with those settin
Please add an evaluation to the bug report.
As to the fix I am under the impression that min&max page are
meant to constrain what the user can enter in the dialog so
if min page & max page are set to "1" then the problem
may be with those settings ?
i.e the application can set those values and e
This all looks fine to me. Although no new Exception types are thrown
I think we need a CCC anyway, so please prepare and get that approved
before pushing.
-phil.
On 3/28/16, 3:30 AM, Jayathirth D V wrote:
Hi Phil,
After discussion with Sergey we have come to conclusion that Sergey is
okay w
Hello Everyone on Java2D Group
Good day to you.
This is a follow-up to Review Request on bug:
Bug : JDK-8015070
Bug Link : https://bugs.openjdk.java.net/browse/JDK-8015070
First, Thanks to Jim and Sergey for their feedback on the changes so far.
Inferences from Jim 's Feedback
Hi Phil,
After discussion with Sergey we have come to conclusion that Sergey is okay
with throwing exception or returning null/false.
So I have modified the webrev to throw exception.
Also in write() I have modified the catch block to just throw the caught
exception without adding messag
Hi,
Thanks Jim for thorough review.
Here is the updated webrev :
http://cr.openjdk.java.net/~arapte/ajit/6353518/webrev.04/
In this update :
1) I have corrected missing space after casting
2) I have modified code to adapt suggested indentation for blocks having
condit
Sorry, just a reminder.
Thanks,
Alexander
On 3/23/2016 5:09 PM, Alexander Stepanov wrote:
Hello,
Could you please review the following fix
http://cr.openjdk.java.net/~avstepan/8152183/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8152183
Just a single test added.
Thanks,
Alexander
Hi All,
Please review a print job attribute fix for jdk9.
Bug: https://bugs.openjdk.java.net/browse/JDK-6357905
webrev: http://cr.openjdk.java.net/~psadhukhan/6357905/webrev.00/
The issue was in the Print-dialog, when some pages are specified using
"Pages" within "Page range", java.awt.JobAttri
