Hi Prasanta,
+1.Last line of jtreg comment is still not proper. No need for one more webrev.
Please change it before pushing.
Thanks,
Jay
-Original Message-
From: prasanta sadhukhan
Sent: Friday, April 15, 2016 11:36 AM
To: Jayathirth D V
Cc: 2d-dev@openjdk.java.net; Philip Race
Subject
Thanks Jay. Please find the modified webrev with proper indentation of
testcase.
http://cr.openjdk.java.net/~psadhukhan/6801613/webrev.01/
Regards
Prasanta
On 4/15/2016 10:46 AM, Jayathirth D V wrote:
Hi Prasanta,
Changes are working fine.
Jtreg comment in test case is not properly indented an
Looks fine.
From: prasanta sadhukhan
Sent: Friday, April 15, 2016 11:18 AM
To: Jayathirth D V; Philip Race
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6921664, , The amount of copies and
the printer job name is not passed to the implementing
Thanks Jay.
Please f
Thanks Jay.
Please find the new webrev adding @Override annotation and I also
changed the copyright to 2016.
http://cr.openjdk.java.net/~psadhukhan/6921664/webrev.01/
Regards
Prasanta
On 4/15/2016 10:09 AM, Jayathirth D V wrote:
Hi Prasanta,
Change is working fine, +1.
Additional comments :
Hi Prasanta,
Changes are fine.
Please add your analysis in JBS. Some lines in test case has more than 80
characters, please update them before pushing.
I have updated the OS and CPU as generic for new bug
https://bugs.openjdk.java.net/browse/JDK-8154218 since we know it is common
problem among
Hi Prasanta,
Changes are working fine.
Jtreg comment in test case is not properly indented and add '*' for each
multiline as per coding guidelines before pushing the change.
Also summary of test case should mention about what is test doing, instead of
the problem statement.
Thanks,
Jay
-Or
Hi Prasanta,
Change is working fine, +1.
Additional comments : Please add your analysis in JBS and also remove/update
the present Javadoc comment in test case and add Override annotation for
subclasses present in test case.
Thanks,
Jay
From: prasanta sadhukhan
Sent: Thursday, Apri
Looks good.
Jennifer
On 04/04/2016 03:33 PM, Phil Race wrote:
https://bugs.openjdk.java.net/browse/JDK-8134986
When converted from a HashSet to a HashMap contains() should have
changed to containsKey(). It does not lead to duplicate fonts because
it is caught later on but it might lead to waste
Hi Jay,
Could you please give your +1 on this?
Regards
Prasanta
On 4/13/2016 9:05 PM, Philip Race wrote:
I have updated the synopsis, please use this in the commit :-
"The number of copies and the job name are not passed to a 3rd party
PrintService"
Fix looks fine.
-phil
On 4/4/16, 4:21 A
Hi Jay,
Could you please give your +1 on this?
Regards
Prasanta
On 4/13/2016 9:11 PM, Philip Race wrote:
+1 although I think robot may be able to automate this.
-phil.
On 4/5/16, 4:08 AM, prasanta sadhukhan wrote:
Hi All,
Please review a fix for jdk9
Bug: https://bugs.openjdk.java.net/brow
Looks good to me.
Regards
Prasanta
On 4/14/2016 6:42 PM, Sergey Bylokhov wrote:
On 13.04.16 14:53, prasanta sadhukhan wrote:
I guess you forgot to add 7102282 to the bugid.
Thanks for review! The fix is updated:
http://cr.openjdk.java.net/~serb/7102282/webrev.01
Regards
Prasanta
On 04/13
On 13.04.16 14:53, prasanta sadhukhan wrote:
I guess you forgot to add 7102282 to the bugid.
Thanks for review! The fix is updated:
http://cr.openjdk.java.net/~serb/7102282/webrev.01
Regards
Prasanta
On 04/13/2016 01:37 AM, Sergey Bylokhov wrote:
Hello,bu
Please review the fix for jdk9.
Hi Phil,
Thank you very much for your reviewing the code and approving the fix.
I have uploaded the webrev to OpenJDK:
http://cr.openjdk.java.net/~aivanov/dmitry.batrak/8146035/jdk9/webrev.00/
The patch is the same.
On 12.04.2016 20:22, Phil Race wrote:
Alexey didn't say this but he already p
13 matches
Mail list logo
