Thanks Phil and Jim for your review.
-Original Message-
From: Philip Race
Sent: Friday, May 06, 2016 4:17 AM
To: Jayathirth D V
Cc: Jim Graham; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-7116979 : Unexpected pixel
colour when converting images to
Yes, this is ready to push.
-phil.
On 5/3/16, 12:23 AM, Jayathirth D V wrote:
Hi Prahalad,
Changes are working fine.+1.
In test case please make jtreg comments as multiline comments and move them
below copyright and above import statements for readability before pushing.
Thanks,
Jay
Looks good to me.
-phil.
On 5/4/16, 10:46 PM, Jayathirth D V wrote:
Hi,
Gentle reminder. Please review.
Thanks,
Jay
-Original Message-
From: Jayathirth D V
Sent: Monday, May 02, 2016 4:05 PM
To: Jim Graham; Philip Race
Cc: 2d-dev@openjdk.java.net
Subject: RE: [OpenJDK 2D-Dev] Review
Hi Jay,
We are currently discussing the best strategy for equals/hashcode on
trees of related objects via the CCC. Let us get that settled first
before we go any further...
...jim
On 05/05/2016 12:11 AM, Jayathirth D V wrote:
Hi Jim,
For ComponentColorModel will
Looks fine.
On 29.04.16 22:35, Phil Race wrote:
Bug : https://bugs.openjdk.java.net/browse/JDK-8155682
Webrev: http://cr.openjdk.java.net/~prr/8155682/
None of these flags have been referenced since (I think) the current
D3D pipeline was integrated in 6u10/jdk7.
JPRT built successfully.
I
Hi Jim,
For ComponentColorModel will it be fine if we verify equals() and hashCode()
based on following properties set in Constructor : transferType, signed,
needScaleInit, noUnnorm, nonStdScale?
And for PixelInterleavedSampleModel and BandedSampleModel there are no unique
properties set in
Hi Jim,
I am trying to modify/add equals()/hashCode() methods in
java.awt.image.ComponentSampleModel() and its subclasses.
In BandedSampleModel and PixelInterleavedSampleModel I see that we have just
hashCode() functions and not equals() and these hashCode() function are
returning just
