Re: [OpenJDK 2D-Dev] Review request for: JDK-8147542 Linux: ClassCastException when repainting after display resolution change

Thank you very much! Could you please help me with integrating the fix into 8u and 9? I don’t have push permissions for the latest releases of JDK. Best Regards, Alexey > On 22 Jul 2016, at 23:22, Jim Graham wrote: > > +1 from me too... > > ...jim > > On 07/22/2016 10:16 AM, P

Re: [OpenJDK 2D-Dev] RFR: 8162432: Clean up references in font code to old Solaris releases.

+1 Brian On Jul 22, 2016, at 3:19 PM, Phil Race wrote: > https://bugs.openjdk.java.net/browse/JDK-8162432 > http://cr.openjdk.java.net/~prr/8162432/ > > There's no need for the isSolaris8/9 or isOpenSolaris variables any more. > > -phil.

[OpenJDK 2D-Dev] RFR: 8162432: Clean up references in font code to old Solaris releases.

https://bugs.openjdk.java.net/browse/JDK-8162432 http://cr.openjdk.java.net/~prr/8162432/ There's no need for the isSolaris8/9 or isOpenSolaris variables any more. -phil.

Re: [OpenJDK 2D-Dev] RFR 8148454: [PIT] Failure of ReplaceMetadataTest on TIFF with IllegalStateException

Brian, I verified that the failing tests now pass. You also need to update the ProblemList. -phil. On 07/22/2016 01:57 PM, Brian Burkhalter wrote: Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8148454 Patch: http://cr.openjdk.java.net/~bpb/8148454/webrev

Re: [OpenJDK 2D-Dev] RFR: 8162429: Clean up obsolete font preferences for JDS.

+1 Brian On Jul 22, 2016, at 1:02 PM, Phil Race wrote: > https://bugs.openjdk.java.net/browse/JDK-8162429 > http://cr.openjdk.java.net/~prr/8162429/ > > Clean up some now obsolete font code. > > -phil.

[OpenJDK 2D-Dev] RFR 8148454: [PIT] Failure of ReplaceMetadataTest on TIFF with IllegalStateException

Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8148454 Patch: http://cr.openjdk.java.net/~bpb/8148454/webrev.00/ Problem was that the superclass ‘output’ variable was being incorrectly reset to null. The TIFF writer mostly uses its internal ‘stream’ variable

Re: [OpenJDK 2D-Dev] Review request for: JDK-8147542 Linux: ClassCastException when repainting after display resolution change

+1 from me too... ...jim On 07/22/2016 10:16 AM, Phil Race wrote: This is OK by me. -phil. On 07/22/2016 02:20 AM, Alexey Ushakov wrote: Friendly reminder :) Best Regards, Alexey On 13 Jul 2016, at 12:33, Alexey Ushakov mailto:alexey.usha...@jetbrains.com>> wrote: Hi, Is

Re: [OpenJDK 2D-Dev] Review Request for JDK-8160943 : [PIT] new failure of closed/javax/imageio/ReadAllThumbnailsTest.java

I found it. The bug is still there. ImageIO has been writing out bad length fields for APP0/JFXX thumbnails for years now. When we write a JFXX APP0 marker in JFIFMarkerSegment.java, we write out the length as: LENGTH_SIZE + DATA_SIZE + thumb.getLength() LENGTH_SIZE is 2 which accounts

[OpenJDK 2D-Dev] RFR: 8162429: Clean up obsolete font preferences for JDS.

https://bugs.openjdk.java.net/browse/JDK-8162429 http://cr.openjdk.java.net/~prr/8162429/ Clean up some now obsolete font code. -phil.

Re: [OpenJDK 2D-Dev] RFR 8140314: Verify IIOMetadataFormat class on loading

Looks reasonable to me. Brian On Jul 22, 2016, at 12:04 PM, Phil Race wrote: > https://bugs.openjdk.java.net/browse/JDK-8140314 > http://cr.openjdk.java.net/~prr/8140314.1/ > > This code was refactored a fair amount in preparation for jigsaw and was > failing > at one point when Class.forName

Re: [OpenJDK 2D-Dev] RFR(S): 8161923: Fix two memory issues.

Hi, now we have a row of solutions ... I would like to finish this up, please. Could I just keep the version right now? Or which one? Also we lost the mailinglists for some reason. For the records: I had posted webrev02: http://cr.openjdk.java.net/~goetz/wr16/8161923-jdkMem/webrev.02/ Best regar

Re: [OpenJDK 2D-Dev] RFR 8161902: [PIT][TEST_BUG]sun/awt/image/OffScreenImageSource/ImageConsumerUnregisterTest.java compilation fails

+1 -phil. On 07/22/2016 12:11 PM, Jayathirth D V wrote: Hi, Please review the following fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-8161902 Webrev : http://cr.openjdk.java.net/~jdv/8161902/webrev.00/ Root cause : Inva

[OpenJDK 2D-Dev] RFR 8161902: [PIT][TEST_BUG]sun/awt/image/OffScreenImageSource/ImageConsumerUnregisterTest.java compilation fails

Hi, Please review the following fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-8161902 Webrev : http://cr.openjdk.java.net/~jdv/8161902/webrev.00/ Root cause : Invalid class name used while constructing the object. Solution : Use proper class-name for constructor(In this

[OpenJDK 2D-Dev] RFR 8140314: Verify IIOMetadataFormat class on loading

https://bugs.openjdk.java.net/browse/JDK-8140314 http://cr.openjdk.java.net/~prr/8140314.1/ This code was refactored a fair amount in preparation for jigsaw and was failing at one point when Class.forName(Module, String) did not work for the un-named module. Now the residual issue is that we

Re: [OpenJDK 2D-Dev] RFR 8149016: Misleading IllegalArgumentException message when a type that is neither LONG nor IFD pointer is supplied to TIFFField constructor

two cases of missing spaces between if and ( .. else if(type < TIFFTag.MIN_DATATYPE || type > TIFFTag.MAX_DATATYPE) { 722 throw new IllegalArgumentException("Unknown data type "+type); 723 } else if(!tag.isDataTypeOK(type)) { Fix before pushing. Otherwise fine. -phil. O

[OpenJDK 2D-Dev] RFR 8149016: Misleading IllegalArgumentException message when a type that is neither LONG nor IFD pointer is supplied to TIFFField constructor

Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8149016 Patch: http://cr.openjdk.java.net/~bpb/8149016/webrev.00/ The problem is that the constructor TIFFField(TIFFTag tag, int type, long offset, TIFFDirectory dir) {} begins with an invocation of the constru

Re: [OpenJDK 2D-Dev] Review request for: JDK-8147542 Linux: ClassCastException when repainting after display resolution change

This is OK by me. -phil. On 07/22/2016 02:20 AM, Alexey Ushakov wrote: Friendly reminder :) Best Regards, Alexey On 13 Jul 2016, at 12:33, Alexey Ushakov mailto:alexey.usha...@jetbrains.com>> wrote: Hi, Is there any concerns about this fix? Best Regards, Alexey On 06 Jul 2016, at 15:22

Re: [OpenJDK 2D-Dev] RFR: JDK-8160664 JVM crashed with font manager on Solaris 12

Hi, That looks reasonable .. but before an OK I would like to see the results of running the test case in the bug report after that fix. Run the test case with -Dsun.java2d.debugfonts=true so we can see what the JDK is doing internally. You can add the log to the bug report. Basically fontco

[OpenJDK 2D-Dev] RFR: JDK-8160664 JVM crashed with font manager on Solaris 12

Hi, Could I get a review for the simple fix for https://bugs.openjdk.java.net/browse/JDK-8160664 A webrev of the change is available here: http://cr.openjdk.java.net/~aivanov/martin.walsh/8160664/jdk9/webrev.00/ Thanks, Martin

Re: [OpenJDK 2D-Dev] [9] RFR JDK-4882305: StreamPrintServ.getSupportedAttributeValues returns null for Orientation attr

Hi Prasanta,   1.   The test contains commented code – that needs to be removed 2.   The test only tests for image/jpeg docFlavor – what about image/gif and image/png docflavors testing? 3.   The year in banner at the top of PSStreamPrintService.java can be updated   Regards, A

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6575247: Banner checkbox in PrinterJob print dialog doesn't work

Hi Phil, I have modified the code to check if job-sheets is supported and then only proceed to print the banner page. Also, rectified the jobTitle and banner confusion by adding jobsheet check. Also added the same code in UnixPrintJob even though I found its printExecCmd() does not get execute

Re: [OpenJDK 2D-Dev] Review request for: JDK-8147542 Linux: ClassCastException when repainting after display resolution change

Friendly reminder :) Best Regards, Alexey > On 13 Jul 2016, at 12:33, Alexey Ushakov wrote: > > Hi, > > Is there any concerns about this fix? > > Best Regards, > Alexey > >> On 06 Jul 2016, at 15:22, Alexey Ushakov > > wrote: >> >> Hello Phil and Sergey,