Re: [OpenJDK 2D-Dev] [9] RFR JDK-8145014: "IIOException: Couldn't seek!" when calling TIFFImageReader.getNumImages()

+1 -phil. On 8/10/16, 7:36 PM, Brian Burkhalter wrote: Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8145014 Patch: http://cr.openjdk.java.net/~bpb/8145014/webrev.00/ In the locateImage() method handle zero-entry IFDs and EOFExceptions, hopefully

[OpenJDK 2D-Dev] [9] RFR JDK-8145014: "IIOException: Couldn't seek!" when calling TIFFImageReader.getNumImages()

Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8145014 Patch: http://cr.openjdk.java.net/~bpb/8145014/webrev.00/ In the locateImage() method handle zero-entry IFDs and EOFExceptions, hopefully returning the correct viable number of leading images in the

Re: [OpenJDK 2D-Dev] [9]Fix for JDK-8158356 : SIGSEGV when attempting to rotate BufferedImage using AffineTransform by NaN degrees

Agreed, I had previously asked for that too (off-line). ie. root cause why a NaN would cause a crash .. -phil. On 8/10/16, 2:47 PM, Jim Graham wrote: This does address the specific test case directly, but I'd be happier if we dug down and figured out where it went wrong in trying to transform

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6574279: validatePage from PrinterJob returns argument under linux

There does not seem to be a link to the new webrev in here. Is it this : http://cr.openjdk.java.net/~psadhukhan/6574279/webrev.01/ ? > to default Paper (Letter in US, A4 otherwise) imageable area I don't think that will ever be A4. Where is that coming from ? And you still have not fixed the

Re: [OpenJDK 2D-Dev] [9]Fix for JDK-8158356 : SIGSEGV when attempting to rotate BufferedImage using AffineTransform by NaN degrees

This does address the specific test case directly, but I'd be happier if we dug down and figured out where it went wrong in trying to transform the image and put in a fix that addressed the root problem whether it comes from the inputs being NaN or from some other similar condition that could

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

Ah, yes, only ToolkitImages can be "not yet loaded" in that manner. A quick look suggests that a MRCI should not be an instance of MRTI, but MRCI.map() does not force its argument to be an instance of MRCI, just MRI, so it would be possible for someone to pass an MRTI to MRCI.map() and then it

Re: [OpenJDK 2D-Dev] [9]Fix for JDK-8158356 : SIGSEGV when attempting to rotate BufferedImage using AffineTransform by NaN degrees

1) The spec for the constructors needs to be updated to include this reason for throwing ImagingOpException. A CCC request will be needed. 2) The C usage of "isnan()" may be problematic in some compilation environments. For example I believe this will not compile with VS2010, and many folks

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

On 09/08/16 03:49, Jim Graham wrote: Does MultiResolutionCachedImage.map() work if the Image hasn't been loaded yet (where getWidth/Height(Observer) can return -1)? Can it ever be called in a case like that? Could we rely on the fact that getWidth/Height(Observer) returns -1 only for

[OpenJDK 2D-Dev] [9]Fix for JDK-8158356 : SIGSEGV when attempting to rotate BufferedImage using AffineTransform by NaN degrees

Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-8158356 Issue : AffineTransform using NaN value as input parameter results in SIGSEGV. Fix : Transformation matrix is checked for NaN values in AffineTransformOp.validateTransform(). Also, at native level a separate

[OpenJDK 2D-Dev] [9] RFR JDK-6357887: selected printertray is ignored under linux

Hi All, Please review a fix for an issue where it is seen that the selected printer tray is ignored in linux and default standard tray is used for printing. Bug: https://bugs.openjdk.java.net/browse/JDK-6357887 webrev: http://cr.openjdk.java.net/~psadhukhan/6357887/webrev.00/ Issue was lpr