Re: [OpenJDK 2D-Dev] [9] RFR JDK-4924727 : reader.abort() method does not work when called inside imageStarted for PNG

2016-08-17 Thread Phil Race
I think we can - get all plugins,and for each - write a file in that format - read it back and apply the test It is also worth verifying that the writer abort checks are in sync with the reader aborts, ie happen at such equivalent points as might exist. -phil. On 08/15/2016 11:30 AM, Sergey

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6574279: validatePage from PrinterJob returns argument under linux

2016-08-17 Thread Phil Race
The cups docs say you can get physical margins as described here : http://opensource.apple.com//source/cups/cups-62/doc/spm.shtml?txt#CUPS_API PPD files specify all of the available pages sizes and the physical margins associated with them. ... ppd_sizet_ size =

Re: [OpenJDK 2D-Dev] [9] RFC JDK-8154058: [TIFF] ignoreMetadata parameter of TIFFImageReader's setInput() method affects TIFFImageReadParam in non-obvious way

2016-08-17 Thread Phil Race
Hi, That all seems fine (for the case of ignoreMetaData == true). But there may be still a bug - of some kind - uncovered by this test. The submitter has this case : ignore = false: EXIF: true Fax : true GPS : true which means that all metadata is being read .. as is the default per the

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8149562: TIFFField#createFromMetadataNode javadoc should provide information about sibling/child nodes that should be part of parameter node

2016-08-17 Thread Phil Race
+1 -phil. On 08/16/2016 09:02 AM, Brian Burkhalter wrote: Please review at your convenience. Issue:https://bugs.openjdk.java.net/browse/JDK-8149562 Patch:[1] Add one sentence to the TIFFField.createFromMetadataNode method specification stating that the supplied Node parameter must adhere to

Re: [OpenJDK 2D-Dev] [9] RFR 8164205 [PIT][TEST_BUG] test javax/print/attribute/ServiceDlgPageRangeTest.java doesn't compile

2016-08-17 Thread Phil Race
+1 -phil. ]On 08/17/2016 09:06 AM, Prasanta Sadhukhan wrote: will add this bugid to the test as well which is missing in the below diff. Regards Prasanta On 8/17/2016 8:33 PM, Prasanta Sadhukhan wrote: Hi All, Please review a modification to the testcase (wrong version was putbacked by

Re: [OpenJDK 2D-Dev] [9] RFR 8164205 [PIT][TEST_BUG] test javax/print/attribute/ServiceDlgPageRangeTest.java doesn't compile

2016-08-17 Thread Prasanta Sadhukhan
will add this bugid to the test as well which is missing in the below diff. Regards Prasanta On 8/17/2016 8:33 PM, Prasanta Sadhukhan wrote: Hi All, Please review a modification to the testcase (wrong version was putbacked by mistake) hg diff

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6357887: selected printertray is ignored under linux

2016-08-17 Thread Philip Race
This all looks fine although this can be a simple call to attributes.get(CustomMediaTray.class) can't it ? 502 for (int i=0; i< attrs.length; i++) { 503 Attribute attr = attrs[i]; 504 try { 505 if (attr instanceof CustomMediaTray) { 506

[OpenJDK 2D-Dev] [9] RFR 8164205 [PIT][TEST_BUG] test javax/print/attribute/ServiceDlgPageRangeTest.java doesn't compile

2016-08-17 Thread Prasanta Sadhukhan
Hi All, Please review a modification to the testcase (wrong version was putbacked by mistake) hg diff test/javax/print/attribute/ServiceDlgPageRangeTest.java diff -r 0d3894b7fc66 test/javax/print/attribute/ServiceDlgPageRangeTest.java ---

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8163922: Print-to-file is disabled for SERVICE_FORMATTED docflavor in linux

2016-08-17 Thread Philip Race
+1 with the caveat that I am assuming you tested this did not regress anything else .. -phil. On 8/11/16, 10:22 PM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen that Print-to-File option is disabled even for SERVICE_FORMATTED DocFlavor after

Re: [OpenJDK 2D-Dev] [9] Review Request: 8164104 Cleanup of javaclient related mapfiles

2016-08-17 Thread Sergey Bylokhov
Tested on solarisX64/solarisSparc/linuxX64 no issues were found(SwingSet2/Java2Demo). But I wonder why the text on solarissparc filled by yellow shadow(Is it a known issue)? On 16.08.16 19:33, Phil Race wrote: I think "JPRT is OK" is good but may be not enough here? I am not sure if the build