Re: [OpenJDK 2D-Dev] Request for Review: JDK-8162591 All existing gradient paint implementations have issues with coordinates/sizes larger than Short.MAX_VALUE (exactly) on any Linux systems

2016-09-28 Thread Sergey Bylokhov
Thanks. On 28.09.16 8:45, Clemens Eisserer wrote: HI Jim, All of those conditions are optimized equivalents to getting the determinant. invert() is a destructive call, but since getTransform is documented to return a copy, that is fine - but getDeterminant() will involve less math to check th

Re: [OpenJDK 2D-Dev] [8u Backport] Fix for JDK-8158356 : SIGSEGV when attempting to rotate BufferedImage using AffineTransform by NaN degrees

2016-09-28 Thread Philip Race
+1 -phil On 9/14/16, 2:52 AM, Ajit Ghaisas wrote: Hi Jim, I agree upon aborting the operation in case the non-finite slope is not due to divide by 0 case. As this is the 8u backport of the fix done in 9, I will address the review comment in JDK-8166009. The original backport

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8166685: We should unpin stream and pixel buffer in case of setjmp during writeImage in JPEG.

2016-09-28 Thread Philip Race
+1 -phil. On 9/26/16, 12:35 AM, Jayathirth D V wrote: Hi, Please review the following fix in JDK9 at your convenience: Bug : https://bugs.openjdk.java.net/browse/JDK-8166685 Webrev : http://cr.openjdk.java.net/~jdv/8166685/webrev.00/

Re: [OpenJDK 2D-Dev] Different rounding applied by ProcessPath and ShapeSpanIterator

2016-09-28 Thread Clemens Eisserer
Hi Jim, > They do operate differently. They aren't meant to be mixed and matched. Thanks a lot for the detailed description of the relationship between SSI and ProcessPath. I did some further digging as to why the xrender pipeline has issues with the test attached to the mentioned bug report - b

[OpenJDK 2D-Dev] HiDPI support issues on Windows

2016-09-28 Thread Anton Tarasov
Hello, JDK9 comes with HiDPI support on Windows/Linux which is really great. As we gave it a try, we found it looking pretty good with an integer scale (2x) but revealed some rendering flaws with float scales. Let me please demonstrate it with SwingSet2 + JDK9-ea-b137 + Windows 8.1 in 150% s