Re: [OpenJDK 2D-Dev] REG : JDK-8168609 : No link to BMP specification in javax.imageio package documentation

2016-10-26 Thread Jayathirth D V
Hi Brian, Thanks for your input. I will make changes and include the first hyperlink. Thanks, Jay From: Brian Burkhalter Sent: Tuesday, October 25, 2016 8:13 PM To: Jayathirth D V Cc: Philip Race; 2d-dev Subject: Re: REG : JDK-8168609 : No link to BMP specification in javax.imageio pac

[OpenJDK 2D-Dev] [9] RFR JDK-8168609: No link to BMP specification in javax.imageio package documentation

2016-10-26 Thread Jayathirth D V
Hello All, Please review the following api-doc-only change to the javax.imageio package summary in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-8168609 Webrev : http://cr.openjdk.java.net/~jdv/8168609/webrev.00/

[OpenJDK 2D-Dev] [PATCH] Make automatic font substitution on macOS work for surrogate pairs

2016-10-26 Thread Dmitry Batrak
Hello, I'd like to propose a patch to make automatic font substitution on macOS work for surrogate pairs. I have a Contributor status via agreement signed by JetBrains, hope someone can sponsor the patch. Currently, if requested font cannot render a Unicode character represented by a surrogate pa

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168609: No link to BMP specification in javax.imageio package documentation

2016-10-26 Thread Brian Burkhalter
Hi Jay, Note that [1] use the same link minus the version number [2]. I wonder whether it would be better to do that? Also I noticed that I forgot to update the copyright year when I checked in the same file yesterday so you might want to update it now. Thanks, Brian [1] http://www.digitalpr

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8162796: [macosx] LinearGradientPaint and RadialGradientPaint are not printed on OS X.

2016-10-26 Thread Philip Race
+1 -phil. On 10/25/16, 11:01 PM, Prasanta Sadhukhan wrote: Please find the webrev with modified testcase http://cr.openjdk.java.net/~psadhukhan/8162796/webrev.03/ Regards Prasanta On 10/26/2016 2:45 AM, Philip Race wrote: Hi, This looks to work properly although I have a couple of nits and

[OpenJDK 2D-Dev] [9] RFR JDK-8164750: TIFF reading fails when ignoring metadata with BaselineTIFFTagSet removed

2016-10-26 Thread Brian Burkhalter
Please review at your convenience: Issue: https://bugs.openjdk.java.net/browse/JDK-8164750 Patch: http://cr.openjdk.java.net/~bpb/8164750/webrev.00/ Currently if ignoreMetadata == true and the set of allowed TIFFTagSets does not contain the BaselineTIFFTagSet instance then image reading will f

Re: [OpenJDK 2D-Dev] [PATCH] Make automatic font substitution on macOS work for surrogate pairs

2016-10-26 Thread Philip Race
Hi, I can file a bug on this if I can't find one. If you can email me the test it will help even if it is not checked in. -phil. On 10/26/16, 6:28 AM, Dmitry Batrak wrote: Hello, I'd like to propose a patch to make automatic font substitution on macOS work for surrogate pairs. I have a Contr