Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

Hi Laurent, I'm just reading through the code now to get a handle on the nature of the changes...(and starting with the 2D version)... [D]Dasher.java - why the changes from (firstSegIdx > 0) to (firstSegIdx != 0)? [D]Dasher.java - why is there a new goto_starting() which is only used from one p

Re: [OpenJDK 2D-Dev] RFR: 8186317: Cache font layout tables for use by harfbuzz

The change looks good to me On Fri, 25 Aug 2017 13:16:03 -0700, Phil Race wrote: > Dmitry commented on what JetBrains are doing but do I have any takers > to actually review this change ? > > -phil. > > On 08/16/2017 02:07 PM, Phil Race wrote: >> Bug: https://bugs.openjdk.java.net/browse/JDK-8

Re: [OpenJDK 2D-Dev] RFR: 8186317: Cache font layout tables for use by harfbuzz

Dmitry commented on what JetBrains are doing but do I have any takers to actually review this change ? -phil. On 08/16/2017 02:07 PM, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8186317 Webrev: http://cr.openjdk.java.net/~prr/8186317/ In the ICU code path, we cache the layo

Re: [OpenJDK 2D-Dev] [10] Review Request: 8184435 Cleanup of javadoc in javax.print package

I don't see that this changes the spec. in a way that needs a CSR. So I'll review it but it is possible that you may be told it can be withdrawn as unnecessary. FYI I reviewed this mostly by reading the specdiff so I wasn't looking directly at source only changes like line length. I'm not sure

[OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

Hi, Please review Marlin/FX upgrades that provide an efficient path clipper in Stroker (float / double variants) fixing the bug JDK-8184429 Marlin2D patch (jdk10): http://cr.openjdk.java.net/~lbourges/marlin/marlin-080.0/ MarlinFX patch (openjfx1