Re: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly sets bKGD chunk

2018-04-17 Thread Jayathirth D V
Hi Prahalad, Thanks for the review. I have updated the test case to dispose the image reader. Please find updated webrev: http://cr.openjdk.java.net/~jdv/6574555/webrev.02/ Regards, Jay From: Prahalad Kumar Narayanan Sent: Tuesday, April 17, 2018 11:50 AM To: Jayathirth D V; Ph

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly sets bKGD chunk

2018-04-17 Thread Prahalad Kumar Narayanan
Hello Jay Changes are good. Thanks Have a good day Prahalad N. From: Jayathirth D V Sent: Tuesday, April 17, 2018 2:23 PM To: Prahalad Kumar Narayanan; Philip Race; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly sets bKGD chunk Hi Prahal

[OpenJDK 2D-Dev] [11] RFR JDK-5109146: PNGMetadata Background color initialization from standard metadata is incomplete

2018-04-17 Thread Jayathirth D V
Hello All, Please review the following fix in JDK11 : Bug : https://bugs.openjdk.java.net/browse/JDK-5109146 Webrev : http://cr.openjdk.java.net/~jdv/5109146/webrev.00/ Issue: PNGMetadata.mergeStandardTree() function doesn't set proper bKGD colortype. Solution: When bKGD R, G, B

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

2018-04-17 Thread Phil Race
+1 -phil. On 04/13/2018 01:31 AM, Jayathirth D V wrote: Hi Phil, Thanks for your inputs. I have updated the code to reflect the changes mentioned by you and changed test case to use ByteArrayInput/OutputStream. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/6788458/we

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly sets bKGD chunk

2018-04-17 Thread Phil Race
+1 from me .. -phil. On 04/17/2018 02:27 AM, Prahalad Kumar Narayanan wrote: Hello Jay Changes are good. Thanks Have a good day Prahalad N. *From:*Jayathirth D V *Sent:* Tuesday, April 17, 2018 2:23 PM *To:* Prahalad Kumar Narayanan; Philip Race; 2d-dev *Subject:* RE: [OpenJDK 2D-Dev] [11