Hi Phil, Steven,
Thank you so much for your support, and sorry for taking your time.
As Akira-san suggested, Harfbuzz has VS capability.
It seems difficult to use its glyph picking up mechanism in this case,
but its layout mechanism we can use. And, I tried to use it.
Regarding default UVS tabl
Oh .. so this is doing what I suggested a couple of emails back.
If we see a VS we always delegate to TextLayout ?
Yes, it does simplify the patch a lot and I am perfectly OK with
this approach but I am surprised as, but Toshio was very keen on
having it there without TextLayout being needed .. w
Phil, does this help:
https://gist.github.com/srl295/a81ec3a8495d53b85f368a7872138e86#file-webrev-02-vs-03-diff
it is a diff between the 02 and 03 versions.
On Fri, Jun 22, 2018 at 2:59 PM Phil Race wrote:
> Please save me time and tell me where I will find the changes from the .02
> version
I'll generate a delta
El El vie, jun. 22, 2018 a las 2:59 PM, Phil Race
escribió:
> Please save me time and tell me where I will find the changes from the .02
> version ?
> In particular I mean where are the changes associated with
> "Use TextLayout (Harfbuzz) if VS appears." ?
>
>
> -phil.
>
>
Please save me time and tell me where I will find the changes from the
.02 version ?
In particular I mean where are the changes associated with
"Use TextLayout (Harfbuzz) if VS appears." ?
-phil.
On 06/22/2018 12:59 PM, Steven R. Loomis wrote:
Updated webrev:
http://cr.openjdk.java.net/~srl/8
Updated webrev:
http://cr.openjdk.java.net/~srl/8187100/webrev.03
- Use TextLayout (Harfbuzz) if VS appears.
- Composite font's behavior was changed to not change the font by VS.
These changes made the patch so simplified.
- add comment about suggested DejaVu version
On Thu, May 31, 2018 at 3:
The DnD & clipboard cases on such a desktop are the only possible use I
can think of
for this charset, so if it were to exist anywhere it would be in the
desktop module,
since it depends on all the X decoders that were moved there.
But since MToolkit is gone so we don't have direct need for it.
On 6/22/18, 2:15 AM, Prasanta Sadhukhan wrote:
you are using in java
409 prevRemotePrinters = GetRemotePrintersNames();
431 String[] currentRemotePrinters = GetRemotePrintersNames();
I am not sure how this compiles any more (the java code) since the
native declar
Looks good.
Naoto
On 6/21/18 10:21 AM, Naoto Sato wrote:
Hi Dipak,
Please use Locale.toLowerCase(Locale.ROOT) instead of no-arg
toLowerCase(), as it could fail in tr locale (line 60 in the test case).
Naoto
On 6/18/18 12:29 AM, Dipak Kumar wrote:
Hi Phil,
I am able to make the test autom
Thanks Alan.
Now we can use OpenJDK JDK11 GUI feature on IBM AIX's CJK locales.
And AIX's desktop is still CDE/Motif...
We may need COMPOUND_TEXT charset for clipboard and DnD feature against
CDE/Motif.
To 2d-dev:
Could you reconsider about COMPOUND_TEXT charset ?
Thanks,
Ichiroh Takiguchi
IB
you are using in java
409 prevRemotePrinters = GetRemotePrintersNames(); 431 String[]
currentRemotePrinters = GetRemotePrintersNames();
while you are at it, please change
269 if (info4->Attributes & 0x0010) { to if (info4->Attributes &
PRINTER_ATTRIBUTE_NETWORK) { as the hardcoded valu
Hi Prasanta, Here is the new webrev for that change:
http://cr.openjdk.java.net/~sveerabhadra/8153732/webrev.06/
Thanks and regards,
Shashi
From: Prasanta Sadhukhan
Sent: Friday, June 22, 2018 2:00 PM
To: Shashidhara Veerabhadraiah ; Philip
Race ; 2d-dev <2d-dev@openjdk.java.net>
Subjec
btw,
GetRemotePrintersNames violates camelcase style. I suggest to use
getRemotePrintersNames
Regards
Prasanta
On 6/22/2018 1:56 PM, Shashidhara Veerabhadraiah wrote:
Thank you Prasanta for the review.
Thanks and regards,
Shashi
*From:*Prasanta Sadhukhan
*Sent:* Friday, June 22, 2018 1:42
Thank you Prasanta for the review.
Thanks and regards,
Shashi
From: Prasanta Sadhukhan
Sent: Friday, June 22, 2018 1:42 PM
To: Shashidhara Veerabhadraiah ; Philip
Race ; 2d-dev <2d-dev@openjdk.java.net>
Subject: Re: [OpenJDK 2D-Dev] [11] JDK-8153732: Windows remote
printer changes do n
looks good. One more thing, you could probably use
if (info4->Attributes & PRINTER_ATTRIBUTE_NETWORK) {
instead of hardcoding
if (info4->Attributes & 0x0010) {
Also,
getAllPrinterNames() shares more than 80% code with your recently addedGetRemotePrintersNames(). Probably we could optimis
Hi Steven.
Sorry, I forgot read this E-Mail.
I will check this site next week.
> https://www.unicode.org/L2/topical/mongolian/
Thanks.
Akira Nakajima
On 2018/06/22 1:14, Steven R. Loomis wrote:
There is much discussion about the encoding of Mongolian- see
https://www.unicode.org/L2/topical/mo
Hi Prasanta, Thank you for the review. Here is the new Webrev:
http://cr.openjdk.java.net/~sveerabhadra/8153732/webrev.05/
For the EnumPrinters case, I think the cReturned is sufficient as it is set to
zero every time we start.
Thanks and regards,
Shashi
From: Prasanta Sadhukhan
17 matches
Mail list logo
