Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211422: Reading PNG with corrupt CRC for IEND chunk throws IIOException

Thanks Sergey for the approval. Need one more review. Please review the webrev : http://cr.openjdk.java.net/~jdv/8211422/webrev.01/ Regards, Jay -Original Message- From: Sergey Bylokhov Sent: Thursday, November 15, 2018 10:58 PM To: Jayathirth D V; 2d-dev@openjdk.java.net Subject: Re:

[OpenJDK 2D-Dev] RFR: 8130264 : change the mechanism by which JDK loads the platform-specific PrinterJob implementation

bug: http://cr.openjdk.java.net/~prr/8130264/ webrev: http://cr.openjdk.java.net/~prr/8130264/ Currently java launcher code embeds the name of the java.desktop module's PrinterJob implementation class for each platform in a system property which is later read by the java.desktop code to use to

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211422: Reading PNG with corrupt CRC for IEND chunk throws IIOException

Looks fine. On 14/11/2018 04:35, Jayathirth D V wrote: Hi Sergey, Thanks for the review. I have updated the code to not move the changes out of switch. Apart from that I have refined comments to make it clear why we are not reading CRC for IEND chunk. Also chunkCRC value needs to be

Re: [OpenJDK 2D-Dev] RFR(XS): 8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it

Looks ok to me. Thanks for handling the configure changes! /Erik On 2018-11-15 08:06, Volker Simonis wrote: Hi, can I please have a review for the following small change: http://cr.openjdk.java.net/~simonis/webrevs/2018/8213944/ https://bugs.openjdk.java.net/browse/JDK-8213944 Change

Re: [OpenJDK 2D-Dev] RFR(XS): 8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it

PS I am not sure why xrandr headers would not be available for AIX. They are a standard part of the xdistribution. If true, think what you are going to have to do is add a --with-xrandr-include option and provide it that way. -phil. On 11/15/18, 8:55 AM, Philip Race wrote: Hmm. I don't like

Re: [OpenJDK 2D-Dev] RFR(XS): 8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it

Hmm. I don't like the ifdefs. Xrandr is a requirement for the build. If its not there at runtime that's OK. -phil. On 11/15/18, 8:06 AM, Volker Simonis wrote: Hi, can I please have a review for the following small change: http://cr.openjdk.java.net/~simonis/webrevs/2018/8213944/

Re: [OpenJDK 2D-Dev] RFR: 8210863: Remove Xrandr include files from JDK sources

Sorry, I'm a little late to the game, but this change broke the AIX build. It also misses a configure check for Xrandr which now became a build dependency. I've opened "8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it" and sent around a RFR on this [1] list

[OpenJDK 2D-Dev] RFR(XS): 8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it

Hi, can I please have a review for the following small change: http://cr.openjdk.java.net/~simonis/webrevs/2018/8213944/ https://bugs.openjdk.java.net/browse/JDK-8213944 Change JDK-8210863 removed the Xrandr.h/randr.h headers from the OpenJDK sources but forgot to add a configure check for the