Re: [OpenJDK 2D-Dev] [15] RFR JDK-6532025: GIF reader throws misleading exception with truncated images

Hi Phil, Thanks for your inputs. Yes we don’t need extra “left > 0” check, I have removed it and I have updated the test case to print “Test passed”. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/6532025/webrev.01/

Re: [OpenJDK 2D-Dev] RFR: 8240518: Incorrect JNU_ReleaseStringPlatformChars in Windows Print

Hi Toshio, I will commit this for you. Regards, Pankaj On 06/03/20 6:10 AM, Toshio 5 Nakamura wrote: Hi Sergey, Prasanta, Pankaj, Thank you for the review. May I ask a sponsor of the fix as well? I'm not a committer. Best Regards, Toshio Nakamura Pankaj Bansal wrote on 2020/03/05

Re: [OpenJDK 2D-Dev] [15] RFR JDK-6532025: GIF reader throws misleading exception with truncated images

I don't understand why you need to recheck that left > 0. Nothing can change it between the while loop check and your check while (left > 0) { int nbytes = stream.read(block, off, left); +if (nbytes == -1 && left > 0) { +

Re: [OpenJDK 2D-Dev] [15] RFR JDK-6532025: GIF reader throws misleading exception with truncated images

Hi Brian, Thanks for the clarification and approval. @Others : Need one more review please take a look. Regards, Jay > On 06-Mar-2020, at 2:05 AM, Brian Burkhalter > wrote: > > Hi Jay, > > I think the overall change is fine. > > Regards, > > Brian > >> On Mar 5, 2020, at 9:18 AM,

Re: [OpenJDK 2D-Dev] RFR: 8240518: Incorrect JNU_ReleaseStringPlatformChars in Windows Print

Hi Sergey, Prasanta, Pankaj, Thank you for the review. May I ask a sponsor of the fix as well? I'm not a committer. Best Regards, Toshio Nakamura Pankaj Bansal wrote on 2020/03/05 18:22:43: > From: Pankaj Bansal > To: Toshio 5 Nakamura , awt- > d...@openjdk.java.net, 2d-dev

Re: [OpenJDK 2D-Dev] [15] RFR JDK-6532025: GIF reader throws misleading exception with truncated images

Hi Jay, I think the overall change is fine. Regards, Brian > On Mar 5, 2020, at 9:18 AM, Jayathirth D v wrote: > > Hello Brian, > > Thanks for the review. GIF stream in regression test case would match > warn.gif stream behaviour that’s why it going into GIFImageReader.getCode(). > > Are

Re: [OpenJDK 2D-Dev] [15] RFR JDK-6532025: GIF reader throws misleading exception with truncated images

Hello Brian, Thanks for the review. GIF stream in regression test case would match warn.gif stream behaviour that’s why it going into GIFImageReader.getCode(). Are you okay with overall webrev.00 patch or have you just approved GIFImageReader change? Please clarify. Regards, Jay > On

Re: [OpenJDK 2D-Dev] [15] RFR JDK-6532025: GIF reader throws misleading exception with truncated images

Hello Jay, The source fix looks OK to me. I get the same exception as in the bug description when I run the test against my unpatched local JDK 15 build. Thanks, Brian > On Mar 5, 2020, at 2:12 AM, Jayathirth D v wrote: > > Please review the following fix for JDK 15: > > Bug :

[OpenJDK 2D-Dev] [15] RFR JDK-6532025: GIF reader throws misleading exception with truncated images

Hello All, Please review the following fix for JDK 15: Bug : https://bugs.openjdk.java.net/browse/JDK-6532025 Webrev : http://cr.openjdk.java.net/~jdv/6532025/webrev.00/ Root cause : When

Re: [OpenJDK 2D-Dev] RFR: 8240518: Incorrect JNU_ReleaseStringPlatformChars in Windows Print

Looks good to me -Pankaj -Original Message- From: Sergey Bylokhov Sent: Thursday, March 5, 2020 2:35 PM To: Toshio 5 Nakamura ; awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net> Subject: Re: RFR: 8240518: Incorrect JNU_ReleaseStringPlatformChars in Windows Print (CC)

Re: [OpenJDK 2D-Dev] RFR: 8240518: Incorrect JNU_ReleaseStringPlatformChars in Windows Print

+1 Regards Prasanta On 05-Mar-20 2:34 PM, Sergey Bylokhov wrote: (CC) 2d-dev, Looks fine. On 3/4/20 4:48 am, Toshio 5 Nakamura wrote: Hi, I'd like to ask review and sponsor of this fix. Issue: https://bugs.openjdk.java.net/browse/JDK-8240518 Fix:

Re: [OpenJDK 2D-Dev] RFR: 8219578 No associated icon for the leaf node of Jtree

Change looks good to me. Thanks, Jay -Original Message- From: Philip Race Sent: Thursday, March 5, 2020 7:26 AM To: Sergey Bylokhov Cc: awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net>; swing-...@openjdk.java.net Subject: Re: RFR: 8219578 No associated icon for the leaf

Re: [OpenJDK 2D-Dev] RFR: 8240518: Incorrect JNU_ReleaseStringPlatformChars in Windows Print

(CC) 2d-dev, Looks fine. On 3/4/20 4:48 am, Toshio 5 Nakamura wrote: Hi, I'd like to ask review and sponsor of this fix. Issue: https://bugs.openjdk.java.net/browse/JDK-8240518 Fix: http://cr.openjdk.java.net/~tnakamura/8240518/webrev.00 Eclipse OpenJ9 VM detects two errors about