Re: [OpenJDK 2D-Dev] RFR: 8230672: Spec. for FontMetrics.getMaxAdvance is too prescriptive.

2020-04-23 Thread Mario Torre
It seems good to me. I also like that you mention actual examples, it will make life a bit easier when trying to understand why things don't seem to work as expected, so the actual text works for me, there's a couple of places where you have double spaces that you may want to fix, for example a "ch

Re: [OpenJDK 2D-Dev] RFR: 8230672: Spec. for FontMetrics.getMaxAdvance is too prescriptive.

2020-04-23 Thread Sergey Bylokhov
Hi, Phil. Isn't all/some of the new text in getMaxAdvance() is also applicable to charWidth()? If I read the current doc properly then it looks like the charWidth() should return "advance" of some specific "advance", and getMaxAdvance() is "just" maximum value of any possible results from the

Re: [OpenJDK 2D-Dev] RFR: 8230672: Spec. for FontMetrics.getMaxAdvance is too prescriptive.

2020-04-23 Thread Philip Race
No, I don't see the relationship. charWidth() is accurate if you use the FontMetrics from the render context. -phil. On 4/23/20, 9:19 AM, Sergey Bylokhov wrote: Hi, Phil. Isn't all/some of the new text in getMaxAdvance() is also applicable to charWidth()? If I read the current doc properly t

Re: [OpenJDK 2D-Dev] RFR: 8230672: Spec. for FontMetrics.getMaxAdvance is too prescriptive.

2020-04-23 Thread Sergey Bylokhov
On 4/23/20 9:34 am, Philip Race wrote: No, I don't see the relationship. charWidth() is accurate if you use the FontMetrics from the render context. If it is always accurate why it is not recommended in the new documentation? Why we suggest to "render each such character". 299 * None o

Re: [OpenJDK 2D-Dev] RFR: 8230672: Spec. for FontMetrics.getMaxAdvance is too prescriptive.

2020-04-23 Thread Philip Race
I am not 100% sure what you are getting at, but maybe "render each such character" could be rephrased as "query the advance of each such character". But I would not point to charWidth() for this because it is not adequate for all code points. Does that clear it up ? -phil. On 4/23/20, 9:49 AM,