Looks fine to me. Had to recall the vi settings that visualize spaces
and tabs but
it was worth it. Some places looks hilarious, like this one:
http://cr.openjdk.java.net/~kizune/tmp/extra_spaces.png
I mean - someone spent a lot of time creating this invisible art.
Good it is going to be gone.
/
Hi Philip,
The MacosxDebuggerLocal.m changes look fine. It took a while to detect
what was actually changed since the html files seem to convert tabs to
spaces. I ended up looking in the patch file, and could see the tabs there.
thanks,
Chris
On 8/5/20 6:46 PM, Philip Race wrote:
Bug: http
Bug: https://bugs.openjdk.java.net/browse/JDK-8240487
Webrev: http://cr.openjdk.java.net/~prr/8240487/
In advance of the move to Project Skara/git it is desirable to clean up
whitespace in source files
that are not currently checked by jcheck so we can add these extensions
to jcheck at that tim
There are also several unused imports in WBMPImageWriter.java which can
be removed.
On 05/08/2020 22:49, Alexey Ivanov wrote:
*WBMPImageWriter.java*
Missing @Override annotation:
137 public boolean canWriteRasters() {
--
Regards,
Alexey
Hi Abhishek,
*BMPImageReader.java*
When @Override is added to anonymous classes, the annotation is not
aligned to the method declaration; at time the indentation of the method
declaration is unnecessarily modified:
1937 @Override
1938 public void imageProgress(ImageRe