Re: [OpenJDK 2D-Dev] RFR: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open

2020-09-21 Thread Sergey Bylokhov
On Fri, 18 Sep 2020 17:05:42 GMT, skodanda wrote: > Hello All, > > Could you please review a TEST_BUG fix for the JDK 16? > > Bug: https://bugs.openjdk.java.net/browse/JDK-8248352 > > Problem description: The test > test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can potentially

Re: [OpenJDK 2D-Dev] RFR: 8234393 [macos] printing ignores printer tray

2020-09-21 Thread Vipin Mv1
Hi, May I ask for a status on this please. -Vipin Mv1/India/IBM wrote: - To: Philip Race From: Vipin Mv1/India/IBM Date: 08/31/2020 05:52PM Cc: 2d-dev@openjdk.java.net Subject: Re: [EXTERNAL] Re: [OpenJDK 2D-Dev] RFR: 823

Re: [OpenJDK 2D-Dev] RFR: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open

2020-09-21 Thread skodanda
On Tue, 22 Sep 2020 03:00:20 GMT, Sergey Bylokhov wrote: >> Marked as reviewed by prr (Reviewer). > > Since you remove the @headful keyword, did you check that the test works fine > via mach5? It will now select a > completely different set of test systems. Dear Sergey, I did test my changes v

Re: [OpenJDK 2D-Dev] RFR: 8252195: AWT Accessibility API nested classes rely on default constructors

2020-09-21 Thread Sergey Bylokhov
On Mon, 21 Sep 2020 20:17:36 GMT, Phil Race wrote: > https://bugs.openjdk.java.net/browse/JDK-8252195 > is another one of the issues adding missing explicit no-args constructors in > the desktop module. > > As well as being nested, these are all concrete, but protected, classes and > so the co

Re: [OpenJDK 2D-Dev] RFR: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open

2020-09-21 Thread Sergey Bylokhov
On Fri, 18 Sep 2020 23:01:57 GMT, Phil Race wrote: >> Hello All, >> >> Could you please review a TEST_BUG fix for the JDK 16? >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8248352 >> >> Problem description: The test >> test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can poten

Re: [OpenJDK 2D-Dev] RFR: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open

2020-09-21 Thread Phil Race
On Fri, 18 Sep 2020 17:05:42 GMT, skodanda wrote: > Hello All, > > Could you please review a TEST_BUG fix for the JDK 16? > > Bug: https://bugs.openjdk.java.net/browse/JDK-8248352 > > Problem description: The test > test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can potentially

[OpenJDK 2D-Dev] RFR: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open

2020-09-21 Thread skodanda
Hello All, Could you please review a TEST_BUG fix for the JDK 16? Bug: https://bugs.openjdk.java.net/browse/JDK-8248352 Problem description: The test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can potentially leave the frame open if it fails. If it were not for the frame, the t

[OpenJDK 2D-Dev] RFR: 8252195: AWT Accessibility API nested classes rely on default constructors

2020-09-21 Thread Phil Race
https://bugs.openjdk.java.net/browse/JDK-8252195 is another one of the issues adding missing explicit no-args constructors in the desktop module. As well as being nested, these are all concrete, but protected, classes and so the constructors are protected. CSR here https://bugs.openjdk.java.net