On Fri, 25 Sep 2020 21:45:39 GMT, Sergey Bylokhov wrote:
> We have a number of missing javadoc tags and comments in the desktop module.
> Most of the missing comments are related to the serialized form.
>
> The fix:
> - Adds missing comments to the non-static/non-transient fields(even
> priva
On Fri, 25 Sep 2020 21:45:39 GMT, Sergey Bylokhov wrote:
> We have a number of missing javadoc tags and comments in the desktop module.
> Most of the missing comments are related to the serialized form.
>
> The fix:
> - Adds missing comments to the non-static/non-transient fields(even
> priva
On Tue, 29 Sep 2020 19:33:48 GMT, Paul Hohensee wrote:
>> Please review this small patch to enable the OSX build using Xcode 12.0.
>>
>> Thanks,
>> Paul
>
> Paul Hohensee has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev
> excludes the unre
Hmm. I'm running Xcode 12.0.1 on 10.15.6 and don't see it. Are you sure you
have the '&' in front of locs_buf? I.e.,
buffer.insts()->initialize_shared_locs((relocInfo*)&locs_buf,
sizeof(locs_buf) / sizeof(relocInfo));
> On Sep 29, 2020, at 4:05 PM, Lutz Schmidt wrote:
>
> On Tue, 29 Sep 2020 19:33:48 GMT, Paul Hohensee wrote:
>
>>> Please review this small patch to enable the OSX build using Xcode 12.0.
>>>
>>> Thanks,
>>> Paul
>>
>> Paul Hohensee has updated the pull request with a new target base due to
On Tue, 29 Sep 2020 19:33:48 GMT, Paul Hohensee wrote:
>> Please review this small patch to enable the OSX build using Xcode 12.0.
>>
>> Thanks,
>> Paul
>
> Paul Hohensee has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev
> excludes the unre
On Tue, 29 Sep 2020 19:33:48 GMT, Paul Hohensee wrote:
>> Please review this small patch to enable the OSX build using Xcode 12.0.
>>
>> Thanks,
>> Paul
>
> Paul Hohensee has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev
> excludes the unre
> Please review this small patch to enable the OSX build using Xcode 12.0.
>
> Thanks,
> Paul
Paul Hohensee has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev
excludes the unrelated changes brought in by the merge/rebase. The pull request
cont
Thanks for the reviews/discussion, and apologies for the delayed reply: I've
been OOTO.
Kim is correct, initialize_shared_locs specifically adjusts the alignment of
its buffer argument, which is why short works. char would work as well, but
short happens to be the size of a relocInfo. Maybe the
Hi, Matthias, Kim. No problem opening a separate issue to fix CSystemColors.m.
Thanks,
Paul
On 9/29/20, 4:23 AM, "hotspot-dev on behalf of Kim Barrett"
wrote:
> On Sep 29, 2020, at 3:14 AM, Matthias Baesken
wrote:
>
> On Fri, 25 Sep 2020 06:06:31 GMT, Kim Barrett
wrote:
>
> On Sep 29, 2020, at 10:18 AM, Hohensee, Paul wrote:
> Code that calls initialize_shared_locs is inconsistent even within itself.
> E.g., in c1_Compilation.cpp, we have
Agreed there seems to be a bit of a mess around that function.
> Anyway, I just wanted to make the compiler warning go away,
> Hi, Matthias, Kim. No problem opening a separate issue to fix CSystemColors.m.
Hi Paul, did that :
https://bugs.openjdk.java.net/browse/JDK-8253791
https://github.com/openjdk/jdk/pull/403
Best regards, Matthias
-Original Message-
From: Hohensee, Paul
Sent: Dienstag, 29. September
On Tue, 29 Sep 2020 07:11:34 GMT, Matthias Baesken wrote:
>> src/java.desktop/macosx/native/libawt_lwawt/awt/CSystemColors.m line 129:
>>
>>> 127: NSColor* result = nil;
>>> 128:
>>> 129: if (colorIndex < ((useAppleColor) ?
>>> sun_lwawt_macosx_LWCToolkit_NUM_APPLE_COLORS :
>>> java_awt
> On Sep 29, 2020, at 3:59 AM, Matthias Baesken
> wrote:
>
> On Fri, 25 Sep 2020 02:23:07 GMT, David Holmes wrote:
>
>>> Please review this small patch to enable the OSX build using Xcode 12.0.
>>>
>>> Thanks,
>>> Paul
>>
>> src/hotspot/share/runtime/sharedRuntime.cpp line 2851:
>>
>>> 2849
> On Sep 29, 2020, at 3:14 AM, Matthias Baesken
> wrote:
>
> On Fri, 25 Sep 2020 06:06:31 GMT, Kim Barrett wrote:
>
>>> Please review this small patch to enable the OSX build using Xcode 12.0.
>>>
>>> Thanks,
>>> Paul
>>
>> src/java.desktop/macosx/native/libawt_lwawt/awt/CSystemColors.m line
On Fri, 25 Sep 2020 02:23:07 GMT, David Holmes wrote:
>> Please review this small patch to enable the OSX build using Xcode 12.0.
>>
>> Thanks,
>> Paul
>
> src/hotspot/share/runtime/sharedRuntime.cpp line 2851:
>
>> 2849: if (buf != NULL) {
>> 2850: CodeBuffer buffer(buf);
>> 2851:
On Fri, 25 Sep 2020 06:06:31 GMT, Kim Barrett wrote:
>> Please review this small patch to enable the OSX build using Xcode 12.0.
>>
>> Thanks,
>> Paul
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/CSystemColors.m line 129:
>
>> 127: NSColor* result = nil;
>> 128:
>> 129: if (color
17 matches
Mail list logo
