Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2 [v3]

2020-11-05 Thread Magnus Ihse Bursie
On Thu, 5 Nov 2020 17:52:53 GMT, Phil Race wrote: >> @mrserb Good catch! Yes indeed, it looks like `range-loop-analysis` needs to >> be disabled for clang for Xcode 12 to not complain. > > I added that to the disabled warnings .. now I suppose the actions will > re-run but I don't see any sign

Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2 [v3]

2020-11-05 Thread Phil Race
On Thu, 5 Nov 2020 13:36:18 GMT, Magnus Ihse Bursie wrote: >> Looks like the build on macOS via GitHub will be broken by this fix? > > @mrserb Good catch! Yes indeed, it looks like `range-loop-analysis` needs to > be disabled for clang for Xcode 12 to not complain. I added that to the disabled

Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2 [v3]

2020-11-05 Thread Phil Race
> This upgrades JDK to import the current 2.7.2 version of harfbuzz - an > OpenType text shaping library > > https://bugs.openjdk.java.net/browse/JDK-8247872 > > This has passed building and headless and headful automated tests on all > platforms. Phil Race has updated the pull request increme

Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2 [v2]

2020-11-05 Thread Magnus Ihse Bursie
On Thu, 5 Nov 2020 11:24:28 GMT, Sergey Bylokhov wrote: >>> I'm just a bit curious about the added, empty, >>> `src/java.desktop/share/native/libharfbuzz/abc.txt`... >>> >>> If it really is in upstream source, I'm not saying you should remove it. It >>> just looks very odd. It's not a merge ar

[OpenJDK 2D-Dev] Integrated: 8255937: Better cleanup for test/jdk/javax/imageio/stream/StreamFlush.java

2020-11-05 Thread Sergey Bylokhov
On Thu, 5 Nov 2020 09:06:39 GMT, Sergey Bylokhov wrote: > The test leaves two temporary files due to unclosed file streams. This pull request has now been integrated. Changeset: d3c43c28 Author:Sergey Bylokhov URL: https://git.openjdk.java.net/jdk/commit/d3c43c28 Stats: 19 lines

Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2 [v2]

2020-11-05 Thread Sergey Bylokhov
On Mon, 2 Nov 2020 16:23:19 GMT, Phil Race wrote: >> I'm just a bit curious about the added, empty, >> `src/java.desktop/share/native/libharfbuzz/abc.txt`... >> >> If it really is in upstream source, I'm not saying you should remove it. It >> just looks very odd. It's not a merge artifact? >>

Re: [OpenJDK 2D-Dev] RFR: 8255937: Better cleanup for test/jdk/javax/imageio/stream/StreamFlush.java

2020-11-05 Thread Jayathirth D V
On Thu, 5 Nov 2020 09:06:39 GMT, Sergey Bylokhov wrote: > The test leaves two temporary files due to unclosed file streams. Marked as reviewed by jdv (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1074

[OpenJDK 2D-Dev] RFR: 8255937: Better cleanup for test/jdk/javax/imageio/stream/StreamFlush.java

2020-11-05 Thread Sergey Bylokhov
The test leaves two temporary files due to unclosed file streams. - Commit messages: - Update StreamFlush.java Changes: https://git.openjdk.java.net/jdk/pull/1074/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1074&range=00 Issue: https://bugs.openjdk.java.net/browse