Re: [OpenJDK 2D-Dev] RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-12-08 Thread Phil Race
On Wed, 9 Dec 2020 00:14:23 GMT, Andrii Rodionov wrote: > No, we produce only one image. The headless/non-headless mode is defined by > the system property `-Djava.awt.headless=...`. > Here is a command example for native image generation: > `$ ~/graalvm-ce-java11-21.0.0-dev/bin/native-image >

Re: [OpenJDK 2D-Dev] RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-12-08 Thread Andrii Rodionov
On Tue, 8 Dec 2020 23:10:08 GMT, Phil Race wrote: >> The following PR fixes https://bugs.openjdk.java.net/browse/JDK-8254024 >> >> Starting from version 11.0.9, all JDK libraries also build as static >> libraries (JEP 178: Statically-Linked JNI Libraries). >> The purpose of using static librari

Re: [OpenJDK 2D-Dev] RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-12-08 Thread Phil Race
On Thu, 8 Oct 2020 12:57:29 GMT, Andrii Rodionov wrote: > This happens in libawt while it loads awt-xawt or awt_headless and in > mlib_image. So I am supposing this means you are producing two different static images ? - either all the time or based on a build flag ? One is linking in the X11

Re: [OpenJDK 2D-Dev] RFR: 8257733: Move module-specific data from make to respective module [v2]

2020-12-08 Thread Magnus Ihse Bursie
On Tue, 8 Dec 2020 17:33:16 GMT, Alan Bateman wrote: >> The mapping and nr tables, and the *-X.java.template files in >> make/data/charsetmapping are used to generate source code for the java.base >> and jdk.charsets modules. The stdcs-$OS files configure the package and >> module that each ch

Re: [OpenJDK 2D-Dev] RFR: 8257733: Move module-specific data from make to respective module [v2]

2020-12-08 Thread Naoto Sato
On Tue, 8 Dec 2020 17:33:16 GMT, Alan Bateman wrote: >> The mapping and nr tables, and the *-X.java.template files in >> make/data/charsetmapping are used to generate source code for the java.base >> and jdk.charsets modules. The stdcs-$OS files configure the package and >> module that each ch

Re: [OpenJDK 2D-Dev] RFR: 8257733: Move module-specific data from make to respective module [v2]

2020-12-08 Thread Mandy Chung
On Tue, 8 Dec 2020 18:16:15 GMT, Mandy Chung wrote: >> @wangweij Moving build tools is a related, but separate, question, which is >> addressed by https://bugs.openjdk.java.net/browse/JDK-8241463. >> >> I send out a review earlier this year (see >> https://mail.openjdk.java.net/pipermail/build

Re: [OpenJDK 2D-Dev] RFR: 8257733: Move module-specific data from make to respective module [v2]

2020-12-08 Thread Mandy Chung
On Tue, 8 Dec 2020 16:19:05 GMT, Magnus Ihse Bursie wrote: >> Is there a plan to move make/jdk/src/classes/build/tools/intpoly into >> java.base as well? >> >> Update: I see all subdirs in tools are still there. > > @wangweij Moving build tools is a related, but separate, question, which is >

Re: [OpenJDK 2D-Dev] RFR: 8257733: Move module-specific data from make to respective module [v2]

2020-12-08 Thread Alan Bateman
On Tue, 8 Dec 2020 12:15:38 GMT, Alan Bateman wrote: >> Also, to clarify, for me there is a fundamental difference between >> `src/$MODULE` and `make/modules/$MODULE`. The former is the home of files >> that are part of the module, owned by the content team, and the `$MODULE` >> part is essent

Re: [OpenJDK 2D-Dev] RFR: 8257733: Move module-specific data from make to respective module [v2]

2020-12-08 Thread Magnus Ihse Bursie
On Tue, 8 Dec 2020 15:25:47 GMT, Weijun Wang wrote: >> The mapping and nr tables, and the *-X.java.template files in >> make/data/charsetmapping are used to generate source code for the java.base >> and jdk.charsets modules. The stdcs-$OS files configure the package and >> module that each cha

Re: [OpenJDK 2D-Dev] RFR: 8257733: Move module-specific data from make to respective module [v2]

2020-12-08 Thread Magnus Ihse Bursie
On Tue, 8 Dec 2020 12:15:38 GMT, Alan Bateman wrote: >> Also, to clarify, for me there is a fundamental difference between >> `src/$MODULE` and `make/modules/$MODULE`. The former is the home of files >> that are part of the module, owned by the content team, and the `$MODULE` >> part is essent

Re: [OpenJDK 2D-Dev] RFR: 8257733: Move module-specific data from make to respective module [v2]

2020-12-08 Thread Weijun Wang
On Tue, 8 Dec 2020 12:15:38 GMT, Alan Bateman wrote: >> Also, to clarify, for me there is a fundamental difference between >> `src/$MODULE` and `make/modules/$MODULE`. The former is the home of files >> that are part of the module, owned by the content team, and the `$MODULE` >> part is essent

Re: [OpenJDK 2D-Dev] RFR: 8257733: Move module-specific data from make to respective module [v2]

2020-12-08 Thread Erik Joelsson
On 2020-12-08 00:30, Magnus Ihse Bursie wrote: On Tue, 8 Dec 2020 02:40:43 GMT, Mandy Chung wrote: I have reviewed all lines in the patch file with or near instances of `jdk.compiler` Hi Magnus, I see the motivation of moving these build files for better identification of ownership. Pl

Re: [OpenJDK 2D-Dev] RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image [v3]

2020-12-08 Thread Andrii Rodionov
On Fri, 4 Dec 2020 12:00:56 GMT, Doug Simon wrote: >> @dougxc could you please review AWT static-libs enhancement for GraalVM >> Native Image? > >> @dougxc could you please review AWT static-libs enhancement for GraalVM >> Native Image? > > Sorry, this needs to be reviewed by people who unders

Re: [OpenJDK 2D-Dev] RFR: 8257733: Move module-specific data from make to respective module [v2]

2020-12-08 Thread Alan Bateman
On Tue, 8 Dec 2020 08:32:28 GMT, Magnus Ihse Bursie wrote: >> @mlchung If you don't have any strong preference, I implore you to accept >> this change. I **vastly** prefer to move the data out of `make`! >> >> This is not just about Skara tooling. When working with make files, autoconf >> and

Re: [OpenJDK 2D-Dev] RFR: 8257733: Move module-specific data from make to respective module [v2]

2020-12-08 Thread Magnus Ihse Bursie
On Tue, 8 Dec 2020 08:27:16 GMT, Magnus Ihse Bursie wrote: >> Hi Magnus, >> >> I see the motivation of moving these build files for better identification >> of ownership. Placing them under >> `src/$MODULE/{share,$OS}/data` is one option. Given that skara will >> automatically determine app

Re: [OpenJDK 2D-Dev] RFR: 8257733: Move module-specific data from make to respective module [v2]

2020-12-08 Thread Magnus Ihse Bursie
On Tue, 8 Dec 2020 02:40:43 GMT, Mandy Chung wrote: >> I have reviewed all lines in the patch file with or near instances of >> `jdk.compiler` > > Hi Magnus, > > I see the motivation of moving these build files for better identification of > ownership. Placing them under > `src/$MODULE/{shar