Re: [OpenJDK 2D-Dev] RFR: 8181571: printing to CUPS fails on mac sandbox app [v3]

On Thu, 12 Aug 2021 19:34:44 GMT, Phil Race wrote: >> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Return null if printers are not found in sandboxed app on MacOS > > src/java.

Re: [OpenJDK 2D-Dev] RFR: 8181571: printing to CUPS fails on mac sandbox app [v2]

cupsServer() function and not changing the interface string to >> "localhost". >> Security changes in 10.12.4 reject the TCP connection which they say confuses >> network-client access with print access. They don't seem interested in >> loosening that change. > >

Re: [OpenJDK 2D-Dev] RFR: 8181571: printing to CUPS fails on mac sandbox app

On Wed, 28 Jul 2021 17:18:12 GMT, NikolayTach wrote: > [JDK-8247768 ](https://bugs.openjdk.java.net/browse/JDK-8247768) > Same here played 6 times yet moved, 8 issues missed. What is the relation between JDK-8247768 and the current pull request? Should something be updated in the pull request

[OpenJDK 2D-Dev] Integrated: 8265761: Font with missed font family name is not properly printed on Windows

On Thu, 22 Apr 2021 15:13:45 GMT, Alexander Scherbatiy wrote: > PDFBox 1.8 uses > [Graphics2D.drawGlyphVector()](https://github.com/apache/pdfbox/blob/41ae21bd4c3f304373d3b05f63af5325df248019/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDSimpleFont.java#L352) > method wi

Re: [OpenJDK 2D-Dev] RFR: 8265761: Font with missed font family name is not properly printed on Windows [v2]

On Wed, 28 Apr 2021 13:55:28 GMT, Alexander Scherbatiy wrote: >> PDFBox 1.8 uses >> [Graphics2D.drawGlyphVector()](https://github.com/apache/pdfbox/blob/41ae21bd4c3f304373d3b05f63af5325df248019/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDSimpleFont.java#L352) >>

Re: [OpenJDK 2D-Dev] RFR: 8265761: Font with missed font family name is not properly printed on Windows [v2]

e fix properly prints all three lines: > [sample-doc-with-fix.pdf](https://bugs.openjdk.java.net/secure/attachment/94349/sample-doc-with-fix.pdf) > > The provided manual test uses the created SampleBowMissedFamilyName.ttf font > with empty font family name. Alexander Scherbatiy has

Re: [OpenJDK 2D-Dev] RFR: 8265761: Font with missed font family name is not properly printed on Windows

On Thu, 22 Apr 2021 15:13:45 GMT, Alexander Scherbatiy wrote: > PDFBox 1.8 uses > [Graphics2D.drawGlyphVector()](https://github.com/apache/pdfbox/blob/41ae21bd4c3f304373d3b05f63af5325df248019/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDSimpleFont.java#L352) > method wi

Re: [OpenJDK 2D-Dev] RFR: 8265761: Font with missed font family name is not properly printed on Windows

On Sun, 25 Apr 2021 20:53:11 GMT, Sergey Bylokhov wrote: >> Would it be better to use isBlank() instead of isEmpty() to check a font >> family name is blank? >> >> if (family.isBlank()) { >> return false; >> } > > I think so. I changed the test SampleBow font

Re: [OpenJDK 2D-Dev] RFR: 8265761: Font with missed font family name is not properly printed on Windows

On Fri, 23 Apr 2021 07:02:45 GMT, Sergey Bylokhov wrote: >> PDFBox 1.8 uses >> [Graphics2D.drawGlyphVector()](https://github.com/apache/pdfbox/blob/41ae21bd4c3f304373d3b05f63af5325df248019/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDSimpleFont.java#L352) >> method with scaled glyphs

Re: [OpenJDK 2D-Dev] RFR: 8265761: Font with missed font family name is not properly printed on Windows

On Thu, 22 Apr 2021 15:13:45 GMT, Alexander Scherbatiy wrote: > PDFBox 1.8 uses > [Graphics2D.drawGlyphVector()](https://github.com/apache/pdfbox/blob/41ae21bd4c3f304373d3b05f63af5325df248019/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDSimpleFont.java#L352) > method wi

[OpenJDK 2D-Dev] RFR: 8265761: Font with missed font family name is not properly printed on Windows

PDFBox 1.8 uses [Graphics2D.drawGlyphVector()](https://github.com/apache/pdfbox/blob/41ae21bd4c3f304373d3b05f63af5325df248019/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDSimpleFont.java#L352) method with scaled glyphs to print a text and PDF 2.0 uses

[OpenJDK 2D-Dev] Integrated: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows

On Fri, 26 Feb 2021 19:40:22 GMT, Alexander Scherbatiy wrote: > Printing text using GlyphVector outline has bad quality on printers with low > DPI on Windows. > The GDI system used for text printing on Windows accepts only integer path > coordinates. > Rounding GlyphVector outl

Re: [OpenJDK 2D-Dev] RFR: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows [v2]

est.java > java/awt/print/PrinterJob/PrintLatinCJKTest.java > java/awt/print/PrinterJob/PrintTextTest.java > java/awt/print/PrinterJob/SwingUIText.java > java/awt/PrintJob/ConstrainedPrintingTest/ConstrainedPrintingTest.java > java/awt/PrintJob/PageSetupDlgBlockingTest/PageSetupDlgBlo

Re: [OpenJDK 2D-Dev] RFR: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows [v2]

On Wed, 10 Mar 2021 09:31:32 GMT, Prasanta Sadhukhan wrote: >> Alexander Scherbatiy has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Use DASSERT to check SetGraphicsMode and WorldTransform results >> -

[OpenJDK 2D-Dev] RFR: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows

Printing text using GlyphVector outline has bad quality on printers with low DPI on Windows. The GDI system used for text printing on Windows accepts only integer path coordinates. Rounding GlyphVector outline coordinates leads to distorted printed text. The issue had been reported as

[OpenJDK 2D-Dev] Integrated: 8256264: Printed GlyphVector outline with low DPI has bad quality on Windows

On Thu, 12 Nov 2020 10:32:16 GMT, Alexander Scherbatiy wrote: > Printing text using GlyphVector outline has bad quality on printers with low > DPI on Windows. > The GDI system used for text printing on Windows accepts only integer path > coordinates. > Rounding GlyphVector outl

Re: [OpenJDK 2D-Dev] RFR: 8256264: Printed GlyphVector outline with low DPI has bad quality on Windows [v3]

bled "sun.java2d.print.enablePathPrecisionScale" option. > > [fill-glyph-vector-outline-diff.png](https://bugs.openjdk.java.net/secure/attachment/91400/fill-glyph-vector-outline-diff.png) > shows difference of GlyphVector outline printing before and after the fix. Alexander

Re: [OpenJDK 2D-Dev] RFR: 8256264: Printed GlyphVector outline with low DPI has bad quality on Windows

On Sat, 28 Nov 2020 20:07:22 GMT, Sergey Bylokhov wrote: >> I prepared a simple [print >> test](http://cr.openjdk.java.net/~alexsch/8256264/performance/PrintTextPerformanceTest.java) >> sample which uses 4 different fonts (plain and bold) with different sizes >> and prints 640 lines on 10

Re: [OpenJDK 2D-Dev] RFR: 8256264: Printed GlyphVector outline with low DPI has bad quality on Windows

On Fri, 20 Nov 2020 06:31:24 GMT, Sergey Bylokhov wrote: >> Printing text using GlyphVector outline has bad quality on printers with low >> DPI on Windows. >> The GDI system used for text printing on Windows accepts only integer path >> coordinates. >> Rounding GlyphVector outline coordinates

Re: [OpenJDK 2D-Dev] RFR: 8256264: Printed GlyphVector outline with low DPI has bad quality on Windows [v2]

bled "sun.java2d.print.enablePathPrecisionScale" option. > > [fill-glyph-vector-outline-diff.png](https://bugs.openjdk.java.net/secure/attachment/91400/fill-glyph-vector-outline-diff.png) > shows difference of GlyphVector outline printing before and after the fix. Alexander

[OpenJDK 2D-Dev] RFR: 8256264: Printed GlyphVector outline with low DPI has bad quality on Windows

Printing text using GlyphVector outline has bad quality on printers with low DPI on Windows. The GDI system used for text printing on Windows accepts only integer path coordinates. Rounding GlyphVector outline coordinates leads to distorted printed text. To reproduce the issue run the

Re: [OpenJDK 2D-Dev] [9] Review request for 8163854 Add ToolkitImage.getImage() method which loads an image with schema variant

. I am asking if the existing Toolkit APIs can load a multi-res image and if not, why not and can we fix that instead .. -phil. On 8/24/16, 9:36 AM, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8163854 webrev: http://cr.openjdk.java

Re: [OpenJDK 2D-Dev] 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

On 22/08/16 11:06, Avik Niyogi wrote: + awt-dev On 22-Aug-2016, at 12:28 pm, Avik Niyogi > wrote: Hi All, Kindly review the proposed specifications for JDK9. *Bug: https://bugs.openjdk.java.net/browse/JDK-8138771* *Webrev:

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

to the new instance if the source is an MRCI? Perhaps a special case for MRCI as well that calls mrciInstance.map(mapper) instead of constructing a brand new object from scratch? ...jim On 08/11/2016 01:32 AM, Alexander Scherbatiy wrote: Could you review the updated fix: http

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

we change the argument of MRCI.map() to MRCI? (And then you don't need to cast to Image and use getWidth/Height(Observer) to get its dimensions.) If that is not feasible, we should have it do something different for a non-MRCI... ...jim On 8/10/16 5:35 AM, Alexander Scherbatiy wrote: O

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

for ToolkitImage? If so, the passed MultiResolutionToolkitImage is handled in MultiResolutionToolkitImage.map() method. If no, the fix should be updated to load the image size in some way. Thanks, Alexandr. ...jim On 08/08/2016 12:48 PM, Alexander Scherbatiy wrote: Just a friendly reminder

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

Just a friendly reminder. Thanks, Alexandr. On 27/06/16 22:17, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8151303/webrev.02 The fix does not use a new public API to apply filters to multi-resolution images. Thanks

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

ects, or creating a new MR-aware filtering mechanism and using it in Swing. Similarly, other 3rd party libraries that accept images and do anything more than display them will have to be upgraded as well before they become "MR aware" or "MR accepting" or whatever term appli

Re: [OpenJDK 2D-Dev] [9] Review request for 8073320 Windows HiDPI Graphics support

e to allow non-integer (and X/Y) scales https://bugs.openjdk.java.net/browse/JDK-8153522 Thanks, Alexandr. ...jim On 9/22/2015 2:33 AM, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8073320 we

[OpenJDK 2D-Dev] [9] Review request for 8152309 Seamless way of using image filters with multi-resolution images

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8152309 webrev: http://cr.openjdk.java.net/~alexsch/8152309/webrev.00 The purpose of the fix is to allow to apply an image filter for a multi-resolution image to get new multi-resolution image so the code

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

Scherbatiy wrote: On 15/03/16 18:06, Sergey Bylokhov wrote: On 15.03.16 17:01, Alexander Scherbatiy wrote: One update will be that FilteredImageSource should implement MultiResolutionImageProducer even it is used for non multi-resolution images. The MRI can be created using two general ways

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

On 15/03/16 18:06, Sergey Bylokhov wrote: On 15.03.16 17:01, Alexander Scherbatiy wrote: One update will be that FilteredImageSource should implement MultiResolutionImageProducer even it is used for non multi-resolution images. The MRI can be created using two general ways: using fixed

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

, Alexandr. ...jim On 3/11/16 5:42 AM, Alexander Scherbatiy wrote: On 09/03/16 16:58, Sergey Bylokhov wrote: Probably we should enhance ImageProducer/Tk.createImage/ImageFilter to support this functionality? It seems that the number of usage of this check "image instanceof MultiResolution

Re: [OpenJDK 2D-Dev] thoughts on multiresolution images

Hello Alan, Thank you for the feedback. On 04/03/16 19:59, Alan Snyder wrote: I am writing to share some thoughts based on recent experience using multiresolution images. My experience was not entirely pleasant. I am using JDK 8, although I see no relevant differences in JDK 9. One of

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

r. I think that at least our own API should support MultiResolutionImage w/o such checks, otherwise the user will need to do the same. cc 2d-dev On 09.03.16 15:30, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8151303 we

Re: [OpenJDK 2D-Dev] [9] Review request for 8142966 Wrong cursor position in text components on HiDPI display

anks, Alexandr. ...jim On 2/6/2016 7:28 AM, Alexander Scherbatiy wrote: On 05/02/16 23:39, Phil Race wrote: Two things strike me when I read this 1) Initial surprise at how deep into the font code it goes. Perhaps there are alternatives. 2) That it changes to using the linear metrics for me

Re: [OpenJDK 2D-Dev] [9] Review request for 8142966 Wrong cursor position in text components on HiDPI display

gt;fDevTx); Thanks, Alexandr. -phil. On 01/27/2016 01:26 PM, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8142966 webrev: http://cr.openjdk.java.net/~alexsch/8142966/webev.00/ The proposed fix rounds a glyph advance first and th

Re: [OpenJDK 2D-Dev] [9] Review request for 8076545 Text size is twice bigger under Windows L on Win 8.1 with HiDPI display

be independent of the monitor in a multi-mon situation and so when we move to a 2nd monitor that inverted size remains valid ? If so looks good to me. -phil. On 11/16/2015 06:07 AM, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsc

[OpenJDK 2D-Dev] [9] Review request for 8142966 Wrong cursor position in text components on HiDPI display

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8142966 webrev: http://cr.openjdk.java.net/~alexsch/8142966/webev.00/ The proposed fix rounds a glyph advance first and then scales it if UI scales do not equal to one. Thanks, Alexandr.

Re: [OpenJDK 2D-Dev] Review request for JDK-8147413 : api/java_awt/Image/MultiResolutionImage/index.html\#MultiResolutionRenderingHints[test_VALUE_RESOLUTION_VARIANT_BASE] started to fail

I have created two separated issues on it: 8148045 Handle null resolution variant in SunGraphics2D https://bugs.openjdk.java.net/browse/JDK-8148045 8148046 Investigate the case where MRI.getResolutionVariant() returns MultiResolutionImage

Re: [OpenJDK 2D-Dev] Review request for JDK-8147413 : api/java_awt/Image/MultiResolutionImage/index.html\#MultiResolutionRenderingHints[test_VALUE_RESOLUTION_VARIANT_BASE] started to fail

On 21/01/16 00:57, Phil Race wrote: It seems like the expectation was that BASE could be drawn by the old imaging path. which would be lower overhead. The BASE rendering hint check was used in the initial fix 8011059 to fall down to the main image and had the problem with the SurfaceManager

Re: [OpenJDK 2D-Dev] Review request for 8069348 SunGraphics2D.copyArea() does not properly work for scaled graphics in D3D

Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8069348/webrev.03 On 28/11/15 02:43, Jim Graham wrote: Hi Alexandr, On 11/27/15 2:06 AM, Alexander Scherbatiy wrote: OSXOffscreenSD.java (and all *SD.java), line 481 - should we just make this part

Re: [OpenJDK 2D-Dev] Review request for 8069348 SunGraphics2D.copyArea() does not properly work for scaled graphics in D3D

there... ...jim On 11/20/15 7:38 AM, Sergey Bylokhov wrote: On 20.11.15 14:49, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8069348 webrev: http://cr.openjdk.java.net/~alexsch/8069348/webrev.00 For some reasons

[OpenJDK 2D-Dev] Review request for 8069348 SunGraphics2D.copyArea() does not properly work for scaled graphics in D3D

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8069348 webrev: http://cr.openjdk.java.net/~alexsch/8069348/webrev.00 For some reasons Blit operation does not properly work in the SunGraphics2D.copyArea() method with scaled transform neither on Windows

Re: [OpenJDK 2D-Dev] [9] Review request for 8076545 Text size is twice bigger under Windows L on Win 8.1 with HiDPI display

you in such a case ? I'd be a little surprised if they did that rather than round. Is the SetFontProperty that does not accept a scale parameter still used somewhere ? -phil. On 10/29/2015 04:53 AM, Sergey Bylokhov wrote: On 17.07.15 16:27, Alexander Scherbatiy wrote: - Sergey's point about multi-

Re: [OpenJDK 2D-Dev] [9] Review request for 8073320 Windows HiDPI Graphics support

, Jim Graham wrote: Hi Alexandr, On 11/11/15 3:08 AM, Alexander Scherbatiy wrote: On 11/10/2015 10:41 PM, Jim Graham wrote: In drawHiDPIImage, in the VolatileImage case you ignore the transform, but I suppose that is OK because you pass it through to the scaleImage() case. However if it came

Re: [OpenJDK 2D-Dev] [9] Review request for 8073320 Windows HiDPI Graphics support

e latest webrev. Thanks, Alexandr. Looks almost good to go from my perspective. What is the plan for Swing testing and fixing those bugs? ...jim On 10/22/15 8:28 AM, Alexander Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/80

Re: [OpenJDK 2D-Dev] [9] Review request for 8137571 Linux HiDPI Graphics support

developers to do a decent amount of testing with their applications to let us know if our choices were fine? More comments inline below: On 11/6/15 2:00 AM, Alexander Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8137571/webrev.03/ - pixbuf

Re: [OpenJDK 2D-Dev] [rfc]Stream doesn't reset mark in finally

On 11/7/2015 11:38 AM, Jiri Vanek wrote: Hello! Looking to imageIO.java (if this is bad thread, please redirect me!) 2d-dev alias should be also the right place to ask image related questions in AWT. Thanks, Alexandr. when reading images

Re: [OpenJDK 2D-Dev] Duplicated (or better multiplicated) image-decoder resolvers in openjdk

Adding 2d-dev alias to the cc. Thanks, Alexandr. On 11/4/2015 5:42 PM, Jiri Vanek wrote: ping? On 10/30/2015 02:13 PM, Jiri Vanek wrote: Hello! Recently I was doing ico imagereader-spi provider for icedtea-web (which is javaws (and plugin) implementation for openjdk) Yes, ico is

Re: [OpenJDK 2D-Dev] [9] Review request for 8137571 Linux HiDPI Graphics support

7:03 AM, Alexander Scherbatiy wrote: On 10/10/2015 3:16 AM, Jim Graham wrote: Hi Alexandr, Is it possible to create a diff of this without the fixes from 8073320 mixed in? This bug is really just focused on the Linux support of that other framework, right? Here is the webrev which

Re: [OpenJDK 2D-Dev] RFR: 8138817: JNI warnings loading fonts on MacOSX

The fix looks good to me. Thanks, Alexandr. On 10/5/2015 3:27 PM, Sergey Bylokhov wrote: Looks fine On 02.10.15 23:43, Philip Race wrote: Fix some JNI warnings. http://cr.openjdk.java.net/~prr/8138817/ https://bugs.openjdk.java.net/browse/JDK-8138817 -phil.

Re: [OpenJDK 2D-Dev] [9] Review request for 8073320 Windows HiDPI Graphics support

caleDownXY/ScaleUpXY when these methods are applied to the x/y and width/height. Could I move this update to a separate fix? Thanks, Alexandr. On 21.10.15 16:34, Alexander Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8073320/webrev.01/

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8041900 [macosx] Java forces the use of discrete GPU

The fix looks good to me. On 10/19/2015 4:36 PM, Sergey Bylokhov wrote: Hello. Please review an updated version of the fix: http://cr.openjdk.java.net/~serb/8041900/webrev.00 This version fix the problem of incorrect scale under retina display after gpu is switched. The problem is that we

[OpenJDK 2D-Dev] [9] Review request for 8137571 Linux HiDPI Graphics support

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8137571 webrev: http://cr.openjdk.java.net/~alexsch/8137571/webrev.00 This is an initial part of the HiDPI Graphics support on Linux for the JEP 263: HiDPI Graphics on Windows and Linux

Re: [OpenJDK 2D-Dev] [9] Review request for 8073320 Windows HiDPI Graphics support

issue to make these options crossplatform. Scaling options scale the size of a window on Windows and Linux but do not scale it on Mac OS. If it makes sense I will add the same "sun.java2d.uiScale" option to these three platforms. Thanks, Alexandr. On 22.09.15 12:33,

Re: [OpenJDK 2D-Dev] RFR: [9] JDK-8076540[macosx] NPE due to incorrect threading

to constructor from applet init() so that "dialog" gets initialised properly. The crash was because dialog was not initialised but dialog.displayMessage() was called. Regards Prasanta On 9/29/2015 6:50 PM, Alexander Scherbatiy wrote: On 9/29/2015 8:25 AM, prasanta sadhukhan wrote: Gentl

Re: [OpenJDK 2D-Dev] RFR: [9] JDK-8076540[macosx] NPE due to incorrect threading

On 9/29/2015 8:25 AM, prasanta sadhukhan wrote: Gentle reminder to approve and commit this change. Could you describe which changes were made in the fix? Thanks, Alexandr. Regards Prasanta On 9/28/2015 4:55 PM, prasanta sadhukhan wrote: Hi Alexander, Can this please be approved

[OpenJDK 2D-Dev] [9] Review request for 8073320 Windows HiDPI Graphics support

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8073320 webrev: http://cr.openjdk.java.net/~alexsch/8073320/webrev.00 This is an initial part of the HiDPI Graphics support on Windows for the JEP 263: HiDPI Graphics on Windows and Linux

Re: [OpenJDK 2D-Dev] AWT Dev Review request for 8029339 Custom MultiResolution image support on HiDPI displays

can work out if its OSX with one line of code rather than introducing a dependency. I have updated the tests to use only jdk.testlibrary.OSInfo. Thanks, Alexandr. -phil. On 8/19/15 4:51 AM, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http

[OpenJDK 2D-Dev] Internal API usage: sun.font.FontUtilities

(Font) to obtain an instance of CompositeFont. Best regards, Andrej Golovnin On Mon, Jul 27, 2015 at 2:30 PM, Alexander Scherbatiy alexandr.scherba...@oracle.com wrote: According to the JEP 200: The Modular JDK (see http://openjdk.java.net/jeps/200) we expect that the standard Java SE modules

Re: [OpenJDK 2D-Dev] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

Alexandr, On 7/21/15 7:41 AM, Alexander Scherbatiy wrote: Hello Jim, Thank your for the review. Could you review the updated fix there the suggested comments are updated: http://cr.openjdk.java.net/~alexsch/8029339/webrev.09/ Minor comments embedded below. On 7/14/2015 2:36 AM

Re: [OpenJDK 2D-Dev] [9] Review request for 8076545 Text size is twice bigger under Windows LF on Win 8.1 with HiDPI display

scaling level for all my displays. If I unset it I am able to change the size of all items. However, the DPI which returns GetDPIForMonitor is still 2 on HiDPI displays. Thanks, Alexandr. -phil. On 7/3/2015 10:06 AM, Alexander Scherbatiy wrote: Hello, Could you review the fix

Re: [OpenJDK 2D-Dev] AWT Dev Review request for 8029339 Custom MultiResolution image support on HiDPI displays

On 7/14/2015 3:18 AM, Alan Snyder wrote: I have a concern about how custom multiresolution images are supported based on a problem I ran into using the JDK 8 classes, which are similar. The problem is that the selection of a variant image happens during painting. That is a very bad time to

Re: [OpenJDK 2D-Dev] AWT Dev Review request for 8029339 Custom MultiResolution image support on HiDPI displays

, Alexander Scherbatiy alexandr.scherba...@oracle.com mailto:alexandr.scherba...@oracle.com wrote: On 7/14/2015 3:18 AM, Alan Snyder wrote: I have a concern about how custom multiresolution images are supported based on a problem I ran into using the JDK 8 classes, which are similar. The problem

[OpenJDK 2D-Dev] [9] Review request for 8076545 Text size is twice bigger under Windows LF on Win 8.1 with HiDPI display

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8076545 webrev: http://cr.openjdk.java.net/~alexsch/8076545/webrev.00 Windows LF fonts and size of components are rescaled according to the system DPI. Thanks, Alexandr.

Re: [OpenJDK 2D-Dev] Swing Dev JDK 9 RFR of JDK-8129822: Define headful jtreg keyword

On 6/25/2015 2:42 AM, joe darcy wrote: Hello, To support the next iteration of tiered testing in JDK 9, with an eye toward running client library tests, please review the patch below which addresses JDK-8129822: Define headful jtreg keyword Some test environments are headless,

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review request for 8069361 SunGraphics2D.getDefaultTransform() does not include scale factor

be checked) is the same as a transform of the Graphics. The method CGraphicsConfig.getDefaultTransform() can use getScaleInstance but it is up to you. On 14.04.15 17:51, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8069361 webrev: http

Re: [OpenJDK 2D-Dev] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

) and managing/finding the variants. ...jim On 4/1/15 6:46 AM, Alexander Scherbatiy wrote: On 3/27/2015 12:48 AM, Jim Graham wrote: Hi Alexander, http://cr.openjdk.java.net/~alexsch/8029339/webrev.07/ I have updated the fix according to the comments except RenderingHints

[OpenJDK 2D-Dev] [9] Review request for 8069361 SunGraphics2D.getDefaultTransform() does not include scale factor

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8069361 webrev: http://cr.openjdk.java.net/~alexsch/8069361/webrev.00 SunGraphics2D.getDefaultTransform() now returns transform which includes GraphicsConfiguration default transform. This can break a

Re: [OpenJDK 2D-Dev] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

test pass when the implementation doesn't use unmodifiable lists? MRITest.java: - also uses scale rather than DPI in several places ...jim On 3/13/15 6:34 AM, Alexander Scherbatiy wrote: Hello, Could you review the proposed API based on MultiresolutionImage interface

Re: [OpenJDK 2D-Dev] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

a stumbling block... ...jim On 1/22/2015 6:49 AM, Alexander Scherbatiy wrote: Hi Phil, I have prepared two versions of the proposed API: I) Resolution variants are added directly to the Image: http://cr.openjdk.java.net/~alexsch/8029339/list/webrev.00 II

[OpenJDK 2D-Dev] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

Hi Phil, I have prepared two versions of the proposed API: I) Resolution variants are added directly to the Image: http://cr.openjdk.java.net/~alexsch/8029339/list/webrev.00 II) MultiResolutionImage interface is used: http://cr.openjdk.java.net/~alexsch/8029339/webrev.05 It

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

Hi Phil, Could you look at the two suggested ways of the multi-resolution image support API implementation? Thanks, Alexandr. On 8/20/2014 8:10 PM, Alexander Scherbatiy wrote: Hi Phil, I have prepared the fix where resolution variants are added directly to the Image

Re: [OpenJDK 2D-Dev] How to draw HiDPI image resources as BufferedImage?

Hi Tobias, The public API that allows to do that is discussed on the following thread: JDK-8029339 Custom MultiResolution image support on HiDPI displays http://mail.openjdk.java.net/pipermail/awt-dev/2014-August/008371.html Thanks, Alexandr. On 11/25/2014 12:32 PM, Tobias Bley

Re: [OpenJDK 2D-Dev] [9] Review Request: 8055326 Fix typos in client-related packages

The fix looks good to me. Thanks, Alexandr. On 9/10/2014 4:11 PM, Sergey Bylokhov wrote: Hi, Phil. It seems both changes are unnecessary: http://cr.openjdk.java.net/~serb/8055326/webrev.01 On 21.08.2014 22:04, Phil Race wrote: Was the additional spce on the 2nd line intended here ?

[OpenJDK 2D-Dev] [9] Review request for 8057940 JCK test api/java_awt/Image/renderable/ParameterBlock fails with StackOverflowError

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8057940 webrev: http://cr.openjdk.java.net/~alexsch/8057940/webrev.00 The fix reverts JDK-8049893 change which introduces infinity loop in the ParameterBlock.add(int)/set(int) methods after replacing Integer

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

); } Thanks, Alexandr. On 7/29/2014 6:44 PM, Alexander Scherbatiy wrote: On 6/11/2014 7:18 PM, Alexander Scherbatiy wrote: Hi Phil , I just prepared a simple FAQ about the Custom MultiResolution image API. Hope it will be helpful. 1. Scale naming convention for high-resolution images

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

Just friendly remainder. Thanks, Alexandr. On 7/8/2014 7:02 PM, Alexander Scherbatiy wrote: Hi Phil, Could you review the fix? Thanks, Alexandr. On 6/11/2014 7:18 PM, Alexander Scherbatiy wrote: Hi Phil , I just prepared a simple FAQ about the Custom MultiResolution

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

or the low-resolution image faster. Thanks, Alexandr. -phil. On 5/16/2014 9:16 AM, Alexander Scherbatiy wrote: Hi Phil, I need a reviewer from the 2d group for the fix. Could you take a look at the fix and review it? Thanks, Alexandr. On 5/12/2014 6:35 PM, Alexander Scherbatiy

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

Hi Phil, I need a reviewer from the 2d group for the fix. Could you take a look at the fix and review it? Thanks, Alexandr. On 5/12/2014 6:35 PM, Alexander Scherbatiy wrote: There was a long thread about the image with sub-pixel resolution drawing on Mac OS X: http

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

/browse/JDK-7124410 Thanks, Alexandr. On 4/25/2014 6:45 PM, Alexander Scherbatiy wrote: On 4/25/2014 2:17 AM, Jim Graham wrote: Hi Alexandr, I asked for who was requesting these facilities and you responded with the solution you are planning to provide. I don't care what the solution looks

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

for these capabilities? This is the request from the AWT team for the HiDPI support. Thanks, Alexandr. ...jim On 4/4/14 4:53 AM, Alexander Scherbatiy wrote: On 4/3/2014 2:23 AM, Jim Graham wrote: Hi Alexandr, The back and forth is getting confusing here, so I thought I'd try

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

AM, Alexander Scherbatiy wrote: Below are some thoughts about TK.createMRImage(...) method On 3/24/2014 4:52 PM, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8029339/webrev.03/ - baseImageWidth/Height arguments are added

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

Scherbatiy wrote: Below are some thoughts about TK.createMRImage(...) method On 3/24/2014 4:52 PM, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8029339/webrev.03/ - baseImageWidth/Height arguments are added

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

Below are some thoughts about TK.createMRImage(...) method On 3/24/2014 4:52 PM, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8029339/webrev.03/ - baseImageWidth/Height arguments are added to the getResolutionVariant

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

/14 7:33 AM, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8029339/webrev.02/ - transform is removed from the getResolutionVariant(...) method I notice that you reverted the changes to SG2D so that it now calculates

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

? ...jim On 3/20/14 7:52 AM, Alexander Scherbatiy wrote: Hello, Could you review the updated version of the fix: http://cr.openjdk.java.net/~alexsch/8029339/webrev.01/ - The getResolutionVariant(int width, int height) method from MultiResolutionImage class is changed to Image

Re: [OpenJDK 2D-Dev] [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

On 2/22/2014 3:54 AM, Jim Graham wrote: Hi Alexandr, On 2/18/14 7:33 AM, Alexander Scherbatiy wrote: Hi Jim, Let's divide the discussion into two part. 1. Where it is better to hold resolution variants? Putting resolution variants in Image class brings some questions like

Re: [OpenJDK 2D-Dev] [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

by default. Thanks, Alexandr. On 2/13/2014 4:42 AM, Jim Graham wrote: On 2/12/14 5:59 AM, Alexander Scherbatiy wrote: On 2/8/2014 4:19 AM, Jim Graham wrote: The primary thing that I was concerned about was the presence of integers in the API when Windows uses non-integer multiples It would

Re: [OpenJDK 2D-Dev] [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

. Thanks, Alexandr. ...jim On 2/7/14 3:00 AM, Alexander Scherbatiy wrote: On 1/22/2014 6:40 AM, Jim Graham wrote: Hi Alexander, Before we get too far down the road on this API, I think we understand the way in which MacOS processes multi-resolution images for HiDPI screens

Re: [OpenJDK 2D-Dev] [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8029339 webrev: http://cr.openjdk.java.net/~alexsch/8029339/webrev.00 This is a proposal to introduce an API that allows to create a custom multi resolution image. I. It seems reasonable

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

, but that is the only remaining blocker that I can see... On 12/3/13 3:48 AM, Alexander Scherbatiy wrote: On 12/3/2013 1:16 AM, Jim Graham wrote: On 12/2/13 4:55 AM, Alexander Scherbatiy wrote: On 11/30/2013 3:27 AM, Jim Graham wrote: Hi Alexander, I suppose the wrapping solution works

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

for each frame. If you are going to use observer wrappers then you must cache the wrapper so you reuse the same wrapper on every new call. On 12/2/13 4:55 AM, Alexander Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8011059/webrev.12/ - Image

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

to get the dimensions from there instead of passing them into the constructor, with appropriate checks for -1's... ...jim On 11/28/13 6:45 AM, Alexander Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8011059/webrev.11/ I have moved

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

. - don't draw hidpi image, if it was loaded with errors. - sun.com package should be used? - If MediaTracker was requested to load MultiResolutionImage,it should load all versions? On 26.11.2013 2:31, Jim Graham wrote: On 11/25/13 5:51 AM, Alexander Scherbatiy wrote: On 11/23/2013 5:11 AM, Jim

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8011059/webrev.10/ - FLIP and TRANSLATE bit masks are also included for the SCALE transform checking - LWCToolkit checks an image in cache before requesting multi-resolution image creation to prevent excessive

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

. There are no compatibility problems. If multi-resolution images are not used nothing should be changed. If they used, image observers should be updated accordingly. Thanks, Alexandr. On 11/21/2013 6:15 AM, Alexander Scherbatiy wrote: To check if it is identity-ish, I'd use: ((type

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

another engineer on that code. Some more inline comments: On 11/19/2013 5:06 AM, Alexander Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8011059/webrev.08/ - Some related to the ToolkitImage staff is moved from SunToolkit to ToolkitImageUtil

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

On 11/20/2013 3:17 PM, Jim Graham wrote: In looking through the ToolkitImage code some more it occurs to me that it was already designed (moreso in a previous life) to hold onto multiple representations of the image anyway. In a prior life in 1.0 and 1.1 it held separate ImageRepresentation

  1   2   >