On Wed, 25 Aug 2021 12:47:41 GMT, Andrey Turbanov
wrote:
>> src/java.base/share/classes/java/net/URLPermission.java line 222:
>>
>>> 220:
>>> 221: List l = normalizeMethods(methods);
>>> 222: l.sort(null);
>>
>> I am not opposed to this change, but I find this is slightly
On Sun, 22 Aug 2021 23:02:06 GMT, Sergey Bylokhov wrote:
>> This is the continuation of JDK-8233884, JDK-8271456, and JDK-8272120.
>>
>> In many places standard charsets are looked up via their names, for example:
>> absolutePath.getBytes("UTF-8");
>>
>> This could be done more efficiently(up
On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
There are a bunch of calls to `Collections.sort()` without a comparator
specified (at least in java.desktop):
On Sun, 1 Aug 2021 07:07:21 GMT, Sergey Bylokhov wrote:
> This is a request to clean up a desktop module as was done in JDK-8233884 for
> "java.base" module.
>
> In many places standard charsets are looked up via their names, for example:
> absolutePath.getBytes("UTF-8");
>
> This could be
On Sun, 1 Aug 2021 07:07:21 GMT, Sergey Bylokhov wrote:
> This is a request to clean up a desktop module as was done in JDK-8233884 for
> "java.base" module.
>
> In many places standard charsets are looked up via their names, for example:
> absolutePath.getBytes("UTF-8");
>
> This could be
On Wed, 12 May 2021 00:06:34 GMT, Sergey Bylokhov wrote:
> Performance in one of the tests in the bimg_misc group is dropped by 20%(or
> 5% of the group) after some unused code was removed from the libawt. I assume
> the size of the lib became smaller and GCC heuristics were changed to do not
On Fri, 12 Mar 2021 07:22:26 GMT, Aleksey Shipilev wrote:
>> SonarCloud reports multiple incorrect double-checked locking cases in
>> `sun.java2d.CRenderer`. For example:
>>
>>
>> Arc2D arcToShape;
>>
>> ...
>> if (arcToShape == null) {
>> synchronized (this)
On Mon, 3 May 2021 23:10:13 GMT, Phil Race wrote:
> This is just clean up. The value will be zero by default and explicitly (if
> you follow along far enough) zero.
> The no-args constructor just merges physical fonts and those are set up with
> zero anyway
Marked as reviewed by azvegint
On Wed, 28 Apr 2021 01:21:15 GMT, Yasumasa Suenaga wrote:
> We can see following warnings in mlib_ImageAffine_BC_S32.c,
> mlib_ImageAffine_BL_S32.c, mlib_ImageScanPoly.c . They are caused by
> indentation in mlib_ImageAffine.h .
>
>
> In file included from
>
On Fri, 16 Apr 2021 05:57:13 GMT, Ajit Ghaisas wrote:
> This PR makes Metal as the default Java2D rendering pipeline for macOS.
>
> Note : from JBS description :
> The plan of record has always been that for JDK 17 the new Metal pipeline
> will be OFF by default and must be explicitly enabled
On Thu, 8 Apr 2021 13:00:49 GMT, Aleksey Shipilev wrote:
> Noticed this when backporting JDK-8242557: there is a trivial copy-paste
> error in exception message. See:
> https://hg.openjdk.java.net/jdk/jdk/rev/645c71334acd#l1.58
Marked as reviewed by azvegint (Reviewer).
-
PR:
On Thu, 8 Apr 2021 14:43:50 GMT, Andrey Turbanov
wrote:
>> There are few possible cleanups in java.desktop related to legacy
>> StringBuffer usages:
>> 1. In few places StringBuffer can be replaced with plain String
>> concatenation.
>> 2. StringBuffer can be replaced with StringBuilder.
On Sun, 4 Apr 2021 07:58:44 GMT, Sergey Bylokhov wrote:
>> - The hand-crafted methods for addition and multiplication are replaced by
>> the "Math" versions.
>> - Cleanup: the usage of do/while(false) is removed
>
> src/java.desktop/share/classes/sun/java2d/cmm/lcms/LCMSImageLayout.java line
>
On Wed, 7 Apr 2021 06:39:48 GMT, Andrey Turbanov
wrote:
>> There are few possible cleanups in java.desktop related to legacy
>> StringBuffer usages:
>> 1. In few places StringBuffer can be replaced with plain String
>> concatenation.
>> 2. StringBuffer can be replaced with StringBuilder.
On Tue, 30 Mar 2021 19:05:37 GMT, Andrey Turbanov
wrote:
>> There are few possible cleanups in java.desktop related to legacy
>> StringBuffer usages:
>> 1. In few places StringBuffer can be replaced with plain String
>> concatenation.
>> 2. StringBuffer can be replaced with StringBuilder.
On Sat, 3 Apr 2021 22:28:54 GMT, Alex Blewitt
wrote:
>> 8264680: Use the blessed modifier order in java.desktop
>
> Alex Blewitt has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Additionally remove detritus from PNGImageDecoder.java
On Wed, 31 Mar 2021 21:31:43 GMT, Sergey Bylokhov wrote:
>> The lcms 2.8 version added support for the cmsFLAGS_COPY_ALPHA flag:
>> https://sourceforge.net/p/lcms/mailman/lcms-user/thread/001c01d1c0f3%2484a7cb30%248df76190%24%40ProDigitalSoftware.com/#msg35143398
>>
>> which supports alpha
On Mon, 29 Mar 2021 07:36:35 GMT, Sergey Bylokhov wrote:
> The lcms 2.8 version added support for the cmsFLAGS_COPY_ALPHA flag:
> https://sourceforge.net/p/lcms/mailman/lcms-user/thread/001c01d1c0f3%2484a7cb30%248df76190%24%40ProDigitalSoftware.com/#msg35143398
>
> which supports alpha channel
On Tue, 23 Mar 2021 00:14:59 GMT, Sergey Bylokhov wrote:
> Some codes have outdated assumptions about the initialization of ColorSpace
> class.
> - The ColorSpace.getInstance() will never throw an IllegalArgumentException
> for the builtin profiles
> - The ColorSpace.getInstance() will not
On Mon, 22 Mar 2021 15:55:16 GMT, Aleksey Shipilev wrote:
> SonarCloud reports the problem in ComponentSampleModel.equals:
> Correct one of the identical sub-expressions on both sides of operator "&&"
>
> ...near "this.numBands == that.numBands". It is checked twice. hashCode also
>
On Fri, 19 Mar 2021 20:36:57 GMT, Alexey Ivanov wrote:
> If `JNU_NewStringPlatform` fails to allocate new Java String object for
> printer name, `std::bad_alloc` is thrown. The handler for the exception does
> not release the local reference to the `nameArray`, thus it will be leaked.
Marked
On Fri, 19 Mar 2021 21:28:54 GMT, Alexey Ivanov wrote:
>> `PrintServiceLookupProvider` has `defaultPrinter` and `printers` fields but
>> they are used only in `getDefaultPrintService()` and `refreshServices()`
>> correspondingly. Thus these two fields can be converted to local variables
>> in
On Thu, 18 Mar 2021 17:30:06 GMT, Phil Race wrote:
>> This seems to be a code path that has has not been exercised.
>> We need to check for null values in the array.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8263439:
On Fri, 12 Mar 2021 05:10:25 GMT, Sergey Bylokhov wrote:
> FYI: probably is better/simpler to review it via webrev.
>
> After migration to the lcms from the kcms the performance of some operations
> was regressed. One possible workaround was to split the operation into
> multiple threads. But
On Fri, 12 Mar 2021 05:10:25 GMT, Sergey Bylokhov wrote:
> FYI: probably is better/simpler to review it via webrev.
>
> After migration to the lcms from the kcms the performance of some operations
> was regressed. One possible workaround was to split the operation into
> multiple threads. But
On Tue, 16 Mar 2021 20:08:59 GMT, Sergey Bylokhov wrote:
> The root cause is using the wrong endian, the ICC profile uses big-endian
> notation. We even have special methods to convert the data, but for some
> reason, their usage was dropped in the JDK-6523398.
Marked as reviewed by azvegint
On Tue, 16 Mar 2021 16:56:22 GMT, Phil Race wrote:
>> From a build perspective this partially reverts
>> https://bugs.openjdk.java.net/browse/JDK-8249821 except that it keeps
>> the harfbuzz sources separate and still supports building and running
>> against a system harfbuzz which is only of
On Mon, 15 Mar 2021 18:57:28 GMT, Phil Race wrote:
>> From a build perspective this partially reverts
>> https://bugs.openjdk.java.net/browse/JDK-8249821 except that it keeps
>> the harfbuzz sources separate and still supports building and running
>> against a system harfbuzz which is only of
On Sat, 13 Mar 2021 00:15:16 GMT, Phil Race wrote:
> From a build perspective this partially reverts
> https://bugs.openjdk.java.net/browse/JDK-8249821 except that it keeps
> the harfbuzz sources separate and still supports building and running against
> a system harfbuzz which is only of
On Sat, 6 Mar 2021 03:26:07 GMT, Sergey Bylokhov wrote:
> This is mostly the polish of the different methods in this package.
>
> Most changes are spacing and formatting, plus code simplification. No
> semantic changes, mach5 is green.
Marked as reviewed by azvegint (Reviewer).
-
On Wed, 3 Mar 2021 03:55:42 GMT, Sergey Bylokhov wrote:
>> The java.awt.color.ColorSpace.getName() method does not use any kind of
>> synchronization to properly initialize and use the static cache for the
>> color components names.
>
>
On Wed, 3 Mar 2021 03:46:59 GMT, Sergey Bylokhov wrote:
> The java.awt.color.ColorSpace.getName() method does not use any kind of
> synchronization to properly initialize and use the static cache for the color
> components names.
Marked as reviewed by azvegint (Reviewer).
-
PR:
On Sun, 28 Feb 2021 04:59:48 GMT, Sergey Bylokhov wrote:
> A few utility methods in the ICC_Profile class are unused since 1997, I think
> we can delete them.
Marked as reviewed by azvegint (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2764
On Wed, 24 Feb 2021 18:57:25 GMT, Sergey Bylokhov wrote:
> This bug was reported as a leak of the ImageObserver when the user draws a
> multiresolution image.
>
> The multiresolution image is an image that contains a few images inside, when
> the app uses the observer to get notifications
On Wed, 24 Feb 2021 18:57:25 GMT, Sergey Bylokhov wrote:
> This bug was reported as a leak of the ImageObserver when the user draws a
> multiresolution image.
>
> The multiresolution image is an image that contains a few images inside, when
> the app uses the observer to get notifications
On Wed, 17 Feb 2021 15:54:22 GMT, Prasanta Sadhukhan
wrote:
>> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
>> would actually clear the existing clipping area, which is incorrect.
>> This statement is applicable only to G2D.setClip() and not for the clip()
>>
On Thu, 11 Feb 2021 04:14:54 GMT, Prasanta Sadhukhan
wrote:
>> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
>> would actually clear the existing clipping area, which is incorrect.
>> This statement is applicable only to G2D.setClip() and not for the clip()
>>
On Tue, 9 Feb 2021 13:13:51 GMT, Jayathirth D V wrote:
>> Also, if there is no clip set, then the spec statement " If s is null, this
>> method clears the current Clip" does not carry any meaning, so in both
>> regard, setClip() should be there, I presume.
>
> @prsadhuk At first glance i also
On Tue, 9 Feb 2021 11:57:44 GMT, Prasanta Sadhukhan
wrote:
> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
> would actually clear the existing clipping area, which is incorrect.
> This statement is applicable only to G2D.setClip() and not for the clip()
>
On Sun, 7 Feb 2021 05:36:52 GMT, Sergey Bylokhov wrote:
> Short fix description:
>
> The fix changes the initialization of the built-in color profiles/spaces from
> the lazy initialization per requested profile via static synchronization to
> the lazy initialization of all profiles/spaces on
On Mon, 8 Feb 2021 09:30:02 GMT, Prasanta Sadhukhan
wrote:
> Constructor AreaAveragingScaleFilter(int, int) for
> java.awt.image.AreaAveragingScaleFilter class throws IllegalArgumentException
> when 0 is passed for width,height but it's not specified in the spec.
> Updated spec to illustrate
On Sat, 6 Feb 2021 07:25:08 GMT, Sergey Bylokhov wrote:
>> Both methods are implemented in a similar way.
>> 1. Requests the size of the profile/tag data
>> 2. Creates an array of the correct size
>> 3. Requests the data and copy it to the array
>>
>> If the data will be changed concurrently
On Sat, 6 Feb 2021 02:11:16 GMT, Sergey Bylokhov wrote:
>> In a few places where we use streams the try/with/res blocks are added.
>
> Sergey Bylokhov has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
>
On Fri, 5 Feb 2021 04:05:12 GMT, Sergey Bylokhov wrote:
> In a few places where we use streams the try/with/res blocks are added.
test/jdk/java/awt/color/ICC_Profile/WriteProfileToFile.java line 43:
> 41: testViaDataArray(gold);
> 42: testViaFile(gold);
> 43:
On Fri, 5 Feb 2021 04:05:12 GMT, Sergey Bylokhov wrote:
> In a few places where we use streams the try/with/res blocks are added.
test/jdk/java/awt/color/ICC_Profile/WriteProfileToFile.java line 83:
> 81: }
> 82: }
> 83: }
Just a matter of taste, but if you OK with not
On Thu, 4 Feb 2021 01:56:57 GMT, Sergey Bylokhov wrote:
> Some broken data in the InputStream may cause the wrong exception to be
> thrown - ArrayIndexOutOfBoundsException instead of IllegalArgumentException,
> if the data is too small and we try to validate it.
Marked as reviewed by azvegint
+1
Thanks,
Alexander.
On 16/09/2017 07:16, Sergey Bylokhov wrote:
That's of course a stylistic issue, but I think that the keywords(not
necessary a java) look better when they are highlighted. Depending
from the style it can look like this:
http://cr.openjdk.java.net/~serb/8187399/img.png
+1
Thanks,
Alexander.
On 14/09/2017 04:09, Sergey Bylokhov wrote:
Hello,
Please review the fix for jdk10.
Some of the tidy warnings were fixed.
Report is here:
http://cr.openjdk.java.net/~jjg/doc-report/jdk-by-module/java.desktop/report.html
Description:
- java/awt/Desktop.java: the
Thanks for clarification, looks good to me.
Thanks,
Alexander.
On 07/06/2017 23:22, Sergey Bylokhov wrote:
Hi, Alexander.
These closing tags are optional in html5 standard [1]. On the link to
the SO there are three the example which work differently but
according standards[2][3][4].
[1]
Looks good to me.
Thanks,
Alexander.
On 10/29/2015 12:06 PM, prasanta sadhukhan wrote:
Hi All,
Please review a small fix in jdk9 whereby JNICheck issued a warning
that Exception is not checked after calling a JNI method.
This is in continuation to JDK-8130507
+1
Thanks,
Alexander.
On 10/26/2015 04:53 PM, Sergey Bylokhov wrote:
Looks fine.
On 26.10.15 13:47, prasanta sadhukhan wrote:
It seems jtreg uses test.jdk and not test.java so modified test program
to check for test.jdk to differentiate between jtreg and non-jtreg
execution
Modified webrev
+1
--
Thanks,
Alexander.
On 22.07.2015 20:28, Sergey Bylokhov wrote:
Looks fine.
On 22.07.15 19:46, Phil Race wrote:
Could I please also have a code review from some one ?
There's not much time before PIT freeze ..
-phil
On 07/21/2015 02:04 PM, Seán Coffey wrote:
Looks fine to me Phil.
Looks fine to me.
Thanks,
Alexander.
On 07/02/2015 10:29 AM, pooja chopra wrote:
Hi All,
Please review below fix.
Regards,
Pooja
On 6/17/2015 12:06 PM, pooja chopra wrote:
Hi All ,
Gentle Reminder. Please review below fix .
Regards,
Pooja
On 5/22/2015 10:34 PM, Sergey Bylokhov wrote:
cc 2d
The fix looks fine to me.
--
Thanks,
Alexander.
On 10.06.2015 20:51, Sergey Bylokhov wrote:
Hello.
Please review a small cleanup for jdk9. Unused fields/methods were
removed.
Bug: https://bugs.openjdk.java.net/browse/JDK-8014241
Webrev can be found at:
Hi Sergey,
the fix looks fine to me.
--
Thanks,
Alexander.
On 08.06.2015 19:52, Sergey Bylokhov wrote:
Hello.
Please review the small fix for jdk9.
Two simple warnings were fixed.
The fix contributed by Staffan Larsen.
Bug: https://bugs.openjdk.java.net/browse/JDK-8080993
Webrev can be found
Sure, looks good to me.
Thanks,
Alexander.
On 06/05/2015 06:34 PM, Andrew Hughes wrote:
- Original Message -
Hi Andrew,
We have removed a workaround[0] for interlaced images support, there is
no need in it after 5.0.0 [1]:
DGifSlurp() and EGifSpew() now read and write interlaced
Hi Andrew,
We have removed a workaround[0] for interlaced images support, there is
no need in it after 5.0.0 [1]:
DGifSlurp() and EGifSpew() now read and write interlaced images properly.
I didn't test it, but it seems to me that interlaced images will look
bad after building against GIFLIB
Hello Yasumasa,
I prefer to avoid such pragma usage, as for me code is more readable
without it.
So we can add array-bounds to DISABLED_WARNINGS_gcc in
make/lib/Awt2dLibraries.gmk for BUILD_LIBJAVAJPEG and BUILD_LIBMLIB_IMAGE.
We can nullify row_pointers and image_data after setjmp call to
-8080695
https://bugs.openjdk.java.net/browse/JDK-8080695 committed?
Thanks,
Yasumasa
2015/05/28 18:19 Alexander Zvegintsev
alexander.zvegint...@oracle.com
mailto:alexander.zvegint...@oracle.com:
Hello Yasumasa,
I prefer to avoid such pragma usage, as for me code is more
readable
it?
Thanks,
Yasumasa
On 2015/05/28 22:00, Alexander Zvegintsev wrote:
I think that you can just exclude libsplashscreen part from your fix,
since it is covered by JDK-8080695.
Thanks,
Alexander.
On 05/28/2015 02:52 PM, Yasumasa Suenaga wrote:
Hi Alexander,
Thank you for your comment
the fix looks good to me too.
--
Thanks,
Alexander.
On 09.05.2015 1:34, Sergey Bylokhov wrote:
Hi, Phil.
Thanks for a review! The new version:
http://cr.openjdk.java.net/~serb/6587235/webrev.01
On 08.05.15 22:52, Phil Race wrote:
273 * codeRuntimePermission(accessClassInPackage.+pkg)/code
the fix looks good to me.
Thanks,
Alexander.
On 02/24/2015 02:26 PM, prasanta sadhukhan wrote:
Thanks Alexander.
Here is the updated webrev
http://cr.openjdk.java.net/~serb/prasanta/8039345/webrev.02
Regards
Prasanta
On 2/19/2015 8:55 PM, Alexander Zvegintsev wrote:
Could you explain bit
Hello Prasanta,
I have a couple of comments regarding the test:
We should invoke swing methods on EDT [0].
I think that this test might be improved by showing an instruction
window before test begins. Instruction should explain what is about
to happen, what behavior is correct. Tester will get
and ComponentResizeTest
extends JFrame for no reason.
[0]
http://hg.openjdk.java.net/jdk9/client/jdk/file/c867d4d46b58/test/javax/swing/JTree/6505523/bug6505523.java
Thanks,
Alexander.
On 02/19/2015 04:56 PM, prasanta sadhukhan wrote:
Hi ALexander.
On 2/19/2015 6:55 PM, Alexander Zvegintsev wrote:
Hello
Hello Sergey,
The fix looks good to me in general, but I have a few comments:
It would be nice to add @Override annotation to
java.awt.Window.adjustDescendantsOnParent()
--- old/src/java.desktop/share/classes/java/awt/Component.java 2014-09-10
15:11:22.601342000 +0400
+++
Hi Sergey,
the fix looks good to me.
--
Thanks,
Alexander.
On 08/01/2014 02:25 PM, Sergey Bylokhov wrote:
Hello.
Please review a small fix for jdk9. Unused property files were removed.
Bug: https://bugs.openjdk.java.net/browse/JDK-8026497
Webrev can be found at:
66 matches
Mail list logo
