Re: [OpenJDK 2D-Dev] RFR: 8u backport of 8040808: Uninitialised memory in OGLBufImgsOps.c, D3DBufImgOps.cpp

+1 PS. Usually we don't need a new technical review if the back-port is identical to the original fix. -- best regards, Anthony On 7/15/2014 2:23 AM, Sergey Bylokhov wrote: Hi, Phil. Looks fine. On 7/14/14 10:19 PM, Phil Race wrote: http://cr.openjdk.java.net/~prr/8040808.8u/ Identical to

Re: [OpenJDK 2D-Dev] [9] Review Request: 8046245 JDK 9 client build failure on Solaris

Looks fine. -- best regards, Anthony On 6/7/2014 5:44 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. Description: The fix 8041129 reuse LoadIntArgbPreTo1IntArgb macros, which adds an additional dependency to libxawt from libawt - div8table. But div8table is not listed in the

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

thony Petrov wrote: On 5/23/2014 3:12 PM, Anton V. Tarasov wrote: On 23.05.2014 14:47, Anthony Petrov wrote: 1. The host bounds are not related to the /content/. Hence, adding this method to the LightweightContent interface would look inconsistent from API perspective. It's not strictly abo

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

On 5/23/2014 3:12 PM, Anton V. Tarasov wrote: On 23.05.2014 14:47, Anthony Petrov wrote: 1. The host bounds are not related to the /content/. Hence, adding this method to the LightweightContent interface would look inconsistent from API perspective. It's not strictly about content (the

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

014 1:44, Sergey Bylokhov wrote: On 5/21/14 10:13 PM, Anthony Petrov wrote: Hi Sergey, The original fix provides some updates and clarifications to the javadoc for the LightweightContent.imageBufferReset() method, but they are missing from your fix. Is this intentional? Nope. I just missed this

Re: [OpenJDK 2D-Dev] RFR: 8043805: Allow using a system-installed libjpeg

Thanks, Omair. -- best regards, Anthony On 5/23/2014 1:01 AM, Omair Majid wrote: * Anthony Petrov [2014-05-22 16:48]: I think that it would be useful to have a bug id prior to sending a review request, so that a review thread for the bug can be easily found in the mailing archive. In the

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

I think that it would be useful to have a bug id prior to sending a review request, so that a review thread for the bug can be easily found in the mailing archive. In the future, please do file a bug first and put its id in the subject line of your review requests. -- best regards, Anthony On

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

wrote: Hi Sergey, On 22.05.2014 1:44, Sergey Bylokhov wrote: On 5/21/14 10:13 PM, Anthony Petrov wrote: Hi Sergey, The original fix provides some updates and clarifications to the javadoc for the LightweightContent.imageBufferReset() method, but they are missing from your fix. Is this intentional

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

anced in the future. The fix is covering hdpi support in SwingNode on osx + system look and feel(Aqua). http://cr.openjdk.java.net/~serb/8029455/webrev.01 Notes: - This fix depends from two other fixes: JDK- 8041129 and JDK-8041644. Both are under review on 2d alias. On 5/13/14 9:29 PM, Anthony P

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

Thanks for the update, Omair. The fix looks good to me now. -- best regards, Anthony On 5/20/2014 9:11 PM, Omair Majid wrote: Hi, Updated webrevs: http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/01/ http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/01.jdk/ * Anthony Petrov

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

Hi Omair, common/autoconf/libraries.m4 624 [use libjpeg from build system or OpenJDK source (system, bundled) @<:bundled@:>@])]) "@<:bundled@:>@" should read "@<:@bundled@:>@" - note the missing @. make/lib/Awt2dLibraries.gmk 1236 LIBJPEG_CFLAGS := $(JDK_TOPDIR)/src/share/native

Re: [OpenJDK 2D-Dev] Request for review: 8026385: [macosx] (awt) setjmp/longjmp changes the process signal mask on OS X

The splashscreen changes look fine to me. Approved. -- best regards, Anthony On 5/16/2014 7:18 PM, David DeHaven wrote: Could someone on AWT team approve the splashscreen changes? -DrD- Approved. -phil. On 5/15/2014 9:31 AM, David DeHaven wrote: Ping! Does this look OK? I've also filed

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

Hi Jim, Sergey, and Anton, I'd like to revive this old thread and finally push this fix, which has been reviewed and approved on this mailing list back in February. The only additional change that I want to introduce, is the addition of default implementations for the LightweightContent.imageB

Re: [OpenJDK 2D-Dev] Review request for 8034218: AIX: Provide a better fontconfig.properties file

(adding in 2d-dev@ since fonts belong there) -- best regards, Anthony On 5/12/2014 8:06 PM, Volker Simonis wrote: Hi Jonathan, thanks for submitting this patch. Overall it looks good, but I don't think we should reference the fonts under $JRE_LIB_FONTS/ in the OpenJDK version of fontconfig.pr

Re: [OpenJDK 2D-Dev] Dont use libjpeg-internal macros in splashscreen

The fix looks good to me, too. -- best regards, Anthony On 5/1/2014 1:19 AM, Phil Race wrote: Trying again with awt as "To:" rather than bcc: .. -phil. On 4/30/2014 2:12 PM, Phil Race wrote: Looks OK to me, but adding awt-dev as splashscreen is owned by AWT. -phil. On 4/30/2014 1:48 PM, Om

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

Hi Anton, I skimmed through the code that I'm familiar with, and the changes look good to me. Someone from Swing and 2D should review their parts, too. -- best regards, Anthony On 2/3/2014 6:36 PM, Anton V. Tarasov wrote: Hi Jim, Please look at the updated version: http://cr.openjdk.java.n

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

Hi Anton, I suggest to rename the OffscreenHiDPIImage.hidpiEnabled and its corresponding setter/getter to something like "reportLayoutSize" and add a good javadoc for it so that it's clear what this boolean flag does just by looking at its name. -- best regards, Anthony On 1/21/2014 5:29 PM

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

On 12/12/2013 07:18 PM, Anton V. Tarasov wrote: [cc'ing to j2d alias] On 11.12.2013 21:29, Sergey Bylokhov wrote: On 11.12.2013 20:23, Anton V. Tarasov wrote: - CGraphicsDevice This setter is only called from CPlatformLWView.getGraphicsDevice(). I've explained it in my previous message. It'

Re: [OpenJDK 2D-Dev] Somewhat wonkier Windows problem

[ adding 2d-dev@ ] On 05/24/2013 11:23 AM, Erik Joelsson wrote: On 2013-05-23 20:10, David Chase wrote: One change to add (a by-hand "diff") to common/autoconf/toolchain_windows.m4 : AC_MSG_CHECKING([for DirectX SDK lib dir]) if test "x$with_dxsdk_lib" != x; then DXSDK_LIB_PATH="$wi

Re: [OpenJDK 2D-Dev] [7u] Request for review: 8000629 [macosx] Blurry rendering with Java 7 on Retina display

Hi Sergey, The fix looks fine to me. -- best regards, Anthony On 05/13/13 19:24, Sergey Bylokhov wrote: Hello, Please review the fix for jdk 7u. I send additional review request for jdk7, because there is a difference in the fix from the version of jdk8. Only one sensitive change is one line 1

Re: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux

have the lock on this thread and its a Reentrant lock but it does increase the risk of deadlock, plus its got JNI up-call overhead .. but we seem to have a ton of that anyway. -phil. On 3/26/2013 5:40 AM, Anton Litvinov wrote: Hello, Please review the following fix for a bug. The fix passed 3 c

Re: [OpenJDK 2D-Dev] Review Request: JDK-8000406 - change files using @GenerateNativeHeader to use @Native

Hi Dan, Changes to awt code look fine to me. -- best regards, Anthony On 4/2/2013 2:16, Dan Xu wrote: Hi All, In this fix, I have updated files in JDK libraries to use @Native annotation instead of @GenerateNativeHeader to mark classes that contain no native methods but constants used by

Re: [OpenJDK 2D-Dev] [8] Request for review: 8000629 [macosx] Blurry rendering with Java 7 on Retina display

OK. Thanks for filing the bug. -- best regards, Anthony On 03/28/13 16:37, Sergey Bylokhov wrote: This only applies to a few specific applets, Most of our demos just does not work, because of that I leave it here. and the problem is not directly related to HiDPI support because you'll run i

Re: [OpenJDK 2D-Dev] [8] Request for review: 8000629 [macosx] Blurry rendering with Java 7 on Retina display

On 03/27/13 20:12, Sergey Bylokhov wrote: On 3/27/13 6:52 PM, Anthony Petrov wrote: (there's also other usages of int in shared code) Why do we use integer values here? There's no 100% guarantee that the scale factor is integer on Mac (or other platforms when we support HiDPI renderi

Re: [OpenJDK 2D-Dev] [8] Request for review: 8000629 [macosx] Blurry rendering with Java 7 on Retina display

Hi Sergey, src/macosx/classes/sun/java2d/opengl/CGLLayer.java 48 private int scale = 1; src/macosx/classes/sun/awt/CGraphicsDevice.java 222 public int getScaleFactor() { src/macosx/classes/sun/java2d/opengl/CGLSurfaceData.java 45 protected final int scale; (there's also o

Re: [OpenJDK 2D-Dev] [7u-dev] Request for review for CR 8007748 - MacOSX build error : cast of type 'SEL' to 'uintptr_t' (aka 'unsigned long') is deprecated; use sel_getName instead

Looks fine to me. Thanks for back-porting this fix. -- best regards, Anthony On 03/08/13 14:05, Dalibor Topic wrote: Bug: http://bugs.sun.com/view_bug.do?bug_id=8007748 JDK 8 changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/5f0217537435 - the changeset applies with no changes to jdk7u-d

Re: [OpenJDK 2D-Dev] [8] Review request for 8007295: Reduce number of warnings in awt classes

Looks good to me. There's also some 2D code, so I'm adding 2d-dev@ for an additional review. -- best regards, Anthony On 3/4/2013 20:15, mikhail cherkasov wrote: Hi all, Please review the following changes: Webrev: http://cr.openjdk.java.net/~mcherkas/8007295/webrev.00/

Re: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux

connected with XErrorHandler into the particular "WITH_XERROR_HANDLER", "RESTORE_XERROR_HANDLER" functions or macros. Thank you, Anton On 1/31/2013 4:57 PM, Anthony Petrov wrote: Hi Anton, A couple comments: 1. src/solaris/classes/sun/awt/X11/XErrorHandlerUtil.java 80

Re: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux

hetic Java error handlers. 4. Removal of X error handling code used by the native error handlers from "solaris/native/sun/awt/awt_util.c" "solaris/native/sun/awt/awt_util.h" files. Thank you, Anton On 1/11/2013 3:45 PM, Anthony Petrov wrote: I'm not Jim, but as

Re: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux

and leave it there forever... ...jim On 1/9/13 8:08 AM, Anthony Petrov wrote: Hi Anton et al., If I read the description of the bug correctly, specifically this part: The problem occurs, if another thread (for example, GTK thread) is doing the same sort of thing concurren

Re: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux

I'd rather see some way to prevent double-adding the handler in the first place as well. Since it is only ever used on errors I also think it is OK to set it once and leave it there forever... ...jim On 1/9/13 8:08 AM, Anthony Petrov wrote: Hi Anton et al., If I read the description of th

Re: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux

Hi Anton et al., If I read the description of the bug correctly, specifically this part: The problem occurs, if another thread (for example, GTK thread) is doing the same sort of thing concurrently. This can lead to the following situation. JVM thread: Sets J2DXErrHandler(), saves ANY_PREVIOU

Re: [OpenJDK 2D-Dev] Fwd: openjdk7 - use installed png and jpeg libraries

(CC'ing awt-dev@ and 2d-dev@) There's an RFE: 6565114: Allow using system copies of libjpeg, libpng and giflib for splashscreen http://bugs.sun.com/view_bug.do?bug_id=6565114 I think that the scope of this RFE might be extended to support using system copies of the libraries for the core JDK

Re: [OpenJDK 2D-Dev] [8] Request for review: 7124219 [macosx] Unable to draw images to fullscreen

Nice refactoring. The fix looks good to me. -- best regards, Anthony On 11/16/2012 8:45 PM, Sergey Bylokhov wrote: Hi Everyone, Please review the fix. This is not a direct forward port from jdk 7. Changes description: 1 All stuff related to the backbuffer now located in CGLGraphicsConfig. Imp

Re: [OpenJDK 2D-Dev] JVM crash in AWT native code - just in lambda forest

BTW, this is 2D code. I'm cc'ing 2d-dev@ and bcc'ing awt-dev@. -- best regards, Anthony On 10/07/12 23:16, Peter Levart wrote: Hi all, I'm cross-posting this to lambda and awt lists. Although it happens in AWT code, the crash might or might not have anything to do with AWT. See below... When

Re: [OpenJDK 2D-Dev] Review: Removing GenerateNativeHeader where not needed

Looks good to me. Although most of the changes are in Java2D code, so I'm also CC'ing 2d-dev@ to take a look. -- best regards, Anthony On 7/3/2012 10:23 PM, Erik Joelsson wrote: The build infra project added the use of the annotation GenerateNativeHeader. It was addded to java classes without

Re: [OpenJDK 2D-Dev] Request for review: updated 2 files to use generic type

This topic is more appropriate for 2d-dev@. I'm bcc'ing awt-dev@. -- best regards, Anthony On 06/18/12 06:48, Sean Chou wrote: Hello awt-dev guys, I updated 2 files(src/share/classes/sun/font/StrikeCache.java, src/share/classes/sun/java2d/Disposer.java) to use generic type, but I'm not su

Re: [OpenJDK 2D-Dev] [7u6] request for review: 7154088: [macosx] Regression: Component.createImage do not inherits component attributes

Looks fine. -- best regards, Anthony On 5/24/2012 7:02 PM, Andrew Brygin wrote: Hello, could you please review a backport of the fix for 7154088 to 7u6? This fix just delegates a creation of an appropriate off-screen image to the platform-specific graphics configuration. The change can b

Re: [OpenJDK 2D-Dev] Antialiasing of fonts without Gnome or KDE

I'm CC'ing 2d-dev@ and BCC'ing awt-dev@ because fonts rendering is handled by Java2D team. -- best regards, Anthony On 4/23/2012 8:08 PM, Christophe Garion wrote: Hello, First of all, I am sorry if this is not the right list to post on. I am using a "non standard" WM (Xmonad) without Gnome or

Re: [OpenJDK 2D-Dev] Warning Fixes from LJC Hack Session

Hi Michael, The changes to List.java and Window.java look fine to me. -- best regards, Anthony On 2/4/2012 8:40 PM, Michael Barker wrote: Patch with BeanSupportContext changes removed. Mike. On Sat, Feb 4, 2012 at 3:48 PM, Chris Hegarty wrote: I think you should just drop the changes to th

Re: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 51 new changesets

[ adding Pavel and swing-dev@ to the CC list ] -- best regards, Anthony On 8/18/2011 10:45 PM, Mario Torre wrote: > 2011/8/18 : >> Changeset: 34fdcdb70d20 >> Author:rupashka >> Date: 2011-07-28 18:13 +0400 >> URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/34fdcdb70d20 >> >> 69957

Re: [OpenJDK 2D-Dev] KDE Task bar is always on top of fullscreen Java applications

OpenJDK requires a lot of time. Could someone with a ready environment make a build for me with this fix? My "patch" is in the bug report here: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7057287 Best regards Julien Gouesse Message du 23/06/11 14:50 De : "Anthony Pet

Re: [OpenJDK 2D-Dev] 7002627 : JNI Critical Arrays should be released with the original (unmodified) pointer

I'm adding the patch attached to the original message on the awt-dev@ list. -- best regards, Anthony On 12/20/2010 3:57 PM, Anthony Petrov wrote: Hi Steve, This is a 2D issue, and as such I'm CC'ing 2d-dev@ and BCC'ing awt-...@. -- best regards, Anthony On 12/20/2010 1

Re: [OpenJDK 2D-Dev] 7002627 : JNI Critical Arrays should be released with the original (unmodified) pointer

Hi Steve, This is a 2D issue, and as such I'm CC'ing 2d-dev@ and BCC'ing awt-...@. -- best regards, Anthony On 12/20/2010 11:04 AM, Steve Poole wrote: Hi all - please find attached a patch for your consideration. I've build and tested the change on Linux and Solaris at head (which is to

Re: [OpenJDK 2D-Dev] Reviewer needed - new regression tests which check 2D renderer behaviour

Hi Pavel, I think these are 2D tests. I'm copying 2d-dev@, and BCC'ing awt-...@. -- best regards, Anthony On 12/14/2010 5:27 PM, Pavel Tisnovsky wrote: Hi all, I'd like to add five new regression tests which check 2D renderer behaviour. Corrections checked by these tests were already pushed b

Re: [OpenJDK 2D-Dev] Use of obsolete png_check_sig function in splashscreen_png.c

Hi Andrew, On 06/07/2010 10:05 PM, Andrew John Hughes wrote: >From our side, I think it would be more useful to see in-tree support for building against the system libpng as we never use the in-tree version anyway. Using the system version means we are better covered for security updates and ne

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW]: Update fontconfig property files

Hi Andrew, I'm CC'ing the 2d-dev mailing list since font-related code is under their maintenance. -- best regards, Anthony On 3/10/2010 4:14 PM Andrew John Hughes wrote: The current fontconfig property files in OpenJDK: jdk/src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Fedora.pro

Re: [OpenJDK 2D-Dev] Review Request for 6879044

On 9/23/2009 8:15 PM Mandy Chung wrote: Have it been discussed whether that is feasible to modify the VM in order to eliminate the static dependency if a particular object never gets initialized? The HotSpot VM does lazy resolution and it doesn't load the type of an object if it's not initial

Re: [OpenJDK 2D-Dev] Review Request for 6879044

On 09/23/2009 03:41 PM, Alan Bateman wrote: If AWT initialized the loggers lazily, and only did it when the logging is actually enabled (checking for some system property, or whatever other way), would we still be statically linked to the j.u.logging package in case of a regular client applicat

Re: [OpenJDK 2D-Dev] Review Request for 6879044

Hi Mandy, If AWT initialized the loggers lazily, and only did it when the logging is actually enabled (checking for some system property, or whatever other way), would we still be statically linked to the j.u.logging package in case of a regular client application that does not use/enable log

Re: [OpenJDK 2D-Dev] Review Request for 6879044

On 09/17/2009 03:32 PM, Oleg Sukhodolsky wrote: imho removing dependency on j.u.logging for me looks as strange as removing dependency on j.l.Object or java.util.* :) For example, if the libraries are broken up into a set of fine grain modules then why would I need to have a logging module ins

Re: [OpenJDK 2D-Dev] Review Request for 6879044

On 09/17/2009 12:56 PM, Alan Bateman wrote: I haven't seen any proposals to eliminate the logging but rather the suggestion is that this logging should be re-examined because there are way too many loggers created at startup. For example, one of the suggestions that Mandy has put in 6880089 [1]

Re: [OpenJDK 2D-Dev] Review Request for 6879044

Hi Mandy, On 09/15/2009 10:43 PM, Mandy Chung wrote: > Is it really that unlikely that fine() will be > called that we need not initialise this early? AWT team, can you confirm? I didn't examine this particular AWTEvent class. I can confirm that in many places we call the fine() method dir

Re: [OpenJDK 2D-Dev] One or many GraphicsConfiguration(s) per toplevel?

Hi Dmitri, On 01/21/2009 10:23 PM Anthony Petrov wrote: Yeah, I see the point. Another option is to make the field private, create a final package-private getter (though why? we have a lovely public one already), and private setter. The setter would be invoked through the sun.awt.AWTAccessor

Re: [OpenJDK 2D-Dev] One or many GraphicsConfiguration(s) per toplevel?

On 1/21/2009 9:16 PM Dmitri Trembovetski wrote: Perhaps it would make sense to move the graphicsConfig member to the Window class and use its value for Component.getGraphicsConfiguration()? A component not currently contained in a toplevel window obviously should have a null GC. Thoughts? M

Re: [OpenJDK 2D-Dev] One or many GraphicsConfiguration(s) per toplevel?

Hi Dmitri, On 1/21/2009 8:43 PM Dmitri Trembovetski wrote: implementation of this method in the Container class that recursively calls this method for every child of the container. The question is: is it really possible for one toplevel to contain components having different GraphicsDevice's

Re: [OpenJDK 2D-Dev] One or many GraphicsConfiguration(s) per toplevel?

Hi Roman, On 01/21/2009 06:17 PM Roman Kennke wrote: The question is: is it really possible for one toplevel to contain components having different GraphicsDevice's (and/or different GraphicsConfiguration's)? Not sure, but in Xinerama-mode, when half of a window is on one screen and the other

[OpenJDK 2D-Dev] One or many GraphicsConfiguration(s) per toplevel?

Hello 2D and AWT teams, While working on the fix for 6783411 to enable re-parenting heavyweight components between toplevel windows, I found the Component.checkGD() method which verifies equality of GraphicsDevice's (by the way, a minor question: is it correct to check the equality of the GD (