[OpenJDK 2D-Dev] RFR[8250855]: 'Address reliance on default constructors in the Java 2D APIs'

2020-08-28 Thread Conor Cleary
Hello all, Could someone please review my changes for JDK-8250855, 'Address reliance on default constructors in the Java 2D APIs'? This issue relates to JDK-8250639 '☂ Address reliance on default constructors in the java.desktop module'. The changes address the reliance on default constructor

Re: [OpenJDK 2D-Dev] RFR[8250855]: 'Address reliance on default constructors in the Java 2D APIs'

2020-09-08 Thread Conor Cleary
ected constructor: "Constructor for subclasses to call": https://cr.openjdk.java.net/~psadhukhan/8250850/webrev.1/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalTheme.java.sdiff.html Actually the current text is also fine to me, but looks like many people use the text above as

[OpenJDK 2D-Dev] RFR: 8250855: Address reliance on default constructors in the Java 2D APIs

2020-09-14 Thread Conor Cleary
This issue relates to JDK-8250639 '☂ Address reliance on default constructors in the java.desktop module'. The changes address the reliance on default constructors by adding in basic constructors in the following classes: - java.awt.Image - java.awt.PrintJob - java.awt.font.GlyphVector - java.aw

Re: [OpenJDK 2D-Dev] RFR: 8250855: Address reliance on default constructors in the Java 2D APIs

2020-09-15 Thread Conor Cleary
On Mon, 14 Sep 2020 21:27:46 GMT, Sergey Bylokhov wrote: >> This issue relates to JDK-8250639 '☂ Address reliance on default >> constructors in the java.desktop module'. The changes >> address the reliance on default constructors by adding in basic constructors >> in the following classes: >> -

Re: [OpenJDK 2D-Dev] RFR: 8250859: Address reliance on default constructors in the Accessibility APIs

2020-09-15 Thread Conor Cleary
On Tue, 15 Sep 2020 10:04:49 GMT, Conor Cleary wrote: > This issue relates to JDK-8250639 '☂ Address reliance on default constructors > in the java.desktop module'. The > following classes have had an explicit no-arg constructor added, with a > protected access modifie

[OpenJDK 2D-Dev] RFR: 8250859: Address reliance on default constructors in the Accessibility APIs

2020-09-15 Thread Conor Cleary
This issue relates to JDK-8250639 '☂ Address reliance on default constructors in the java.desktop module'. The following classes have had an explicit no-arg constructor added, with a protected access modifier and accompanying API description: - Default ctor on com.sun.java.accessibility.util.Swi

Re: [OpenJDK 2D-Dev] RFR: 8250859: Address reliance on default constructors in the Accessibility APIs [v2]

2020-09-17 Thread Conor Cleary
On Wed, 16 Sep 2020 08:52:35 GMT, Chris Hegarty wrote: > The CSR lists `com.sun.java.accessibility.util.SwingEventMonitor` as being > changed, but I cannot find that class in > this PR. Changes to this class were indeed missing. This has now been addressed. Thanks for spotting that! -

Re: [OpenJDK 2D-Dev] RFR: 8250859: Address reliance on default constructors in the Accessibility APIs [v2]

2020-09-17 Thread Conor Cleary
.accessibility.util.AccessibilityListenerList > - Default ctor on com.sun.java.accessibility.util.EventID > > specdiff: > http://cr.openjdk.java.net/~ccleary/issues/webrevs-store/8250859/webrevs/webrev.00/specdiff/overview-summary.html > bug: > https://bugs.openjdk.java.net/browse/J

[OpenJDK 2D-Dev] Integrated: 8250855: Address reliance on default constructors in the Java 2D APIs

2020-09-24 Thread Conor Cleary
On Mon, 14 Sep 2020 14:32:18 GMT, Conor Cleary wrote: > This issue relates to JDK-8250639 '☂ Address reliance on default constructors > in the java.desktop module'. The changes > address the reliance on default constructors by adding in basic constructors > in

[OpenJDK 2D-Dev] Integrated: 8250859: Address reliance on default constructors in the Accessibility APIs

2020-09-24 Thread Conor Cleary
On Tue, 15 Sep 2020 10:04:49 GMT, Conor Cleary wrote: > This issue relates to JDK-8250639 '☂ Address reliance on default constructors > in the java.desktop module'. The > following classes have had an explicit no-arg constructor added, with a > protected access modifie