Re: [OpenJDK 2D-Dev] RFR [XS]: 8234795: ix build fails on macOS lower than 10.13 after 8214578 was: build fails on macOS 10.12 after 8214578: [macos] Problem with backslashes on macOS/JIS keyboard: Ja

dk.java.net> > Cc: 2d-dev@openjdk.java.net; Lindenmaier, Goetz > > Subject: Re: RFR [XS]: 8234795: ix build fails on macOS lower than 10.13 after > 8214578 was: build fails on macOS 10.12 after 8214578: [macos] Problem with > backslashes on macOS/JIS keyboard: Java ignores system se

Re: [OpenJDK 2D-Dev] RFR: 8223869: Problem list java/awt/FontMetrics/MaxAdvanceIsMax.java on more platforms

good. Change looks good. Best regards, Goetz. From: Langer, Christoph Sent: Thursday, September 26, 2019 9:44 AM To: 2d-dev@openjdk.java.net Cc: Lindenmaier, Goetz ; Baesken, Matthias Subject: RFR: 8223869: Problem list java/awt/FontMetrics/MaxAdvanceIsMax.java on more platforms Hi, as ea

Re: [OpenJDK 2D-Dev] [11u] java/awt/FontMetrics/MaxAdvanceIsMax.java test failure (was: [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1)

Buzz to the latest 2.3.1) > > > > On 14/05/2019 17:41, Martin Balao wrote: > > Hi Goetz, > > > > On 5/13/19 1:38 PM, Lindenmaier, Goetz wrote: > >> > >> Can I somehow verify that it's the font that has the problem? > >> Can I fix th

Re: [OpenJDK 2D-Dev] [11u] java/awt/FontMetrics/MaxAdvanceIsMax.java test failure (was: [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1)

mark the test with @key intermittent if it depends on the system setup that much? Best regards, Goetz. > -Original Message- > From: Martin Balao > Sent: Tuesday, May 14, 2019 6:41 PM > To: Lindenmaier, Goetz ; 'Severin Gehwolf' > ; Langer, Christoph ; > jdk-

[OpenJDK 2D-Dev] FW: 8223869: Problem list java/awt/FontMetrics/MaxAdvanceIsMax.java on more platforms

Hi, I sent this to core-libs yesterday, but apparently 2d the the right list. I would like to problem list this test on ppc and s390. We see it failing, and it seems to be a Problem not related to the VM, see also the description in JDK-8221305

Re: [OpenJDK 2D-Dev] [11u] java/awt/FontMetrics/MaxAdvanceIsMax.java test failure (was: [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1)

Mai 2019 18:27 > To: Lindenmaier, Goetz ; 'Severin Gehwolf' > ; Langer, Christoph ; jdk- > updates-...@openjdk.java.net > Cc: 2d-dev <2d-dev@openjdk.java.net>; build-...@openjdk.java.net; Martin > Balao Alonso > Subject: Re: [11u] java/awt/FontMetrics/MaxAdvanceI

Re: [OpenJDK 2D-Dev] [11u] java/awt/FontMetrics/MaxAdvanceIsMax.java test failure (was: [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1)

ightly tests of 11.0.3 and jdk/jdk are scheduled on a SLES 12.3, therefor they don't show the problem. I'll send you a jtr file of the failure off-list. Best regards, Goetz. > -Original Message- > From: Severin Gehwolf > Sent: Tuesday, May 7, 2019 5:20 PM > To: L

Re: [OpenJDK 2D-Dev] [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1

Hi Christoph, I had a look at this change. The integration is good. I thought about the adaptions you had to do. They look good for the compilers you mention, and I would assume they also work with more recent ones. I guess nobody uses more recent compilers on Solaris. On AIX I know further

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file"

. > -Original Message- > From: Baesken, Matthias > Sent: Thursday, December 6, 2018 1:18 PM > To: 2d-dev@openjdk.java.net > Cc: Lindenmaier, Goetz > Subject: Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt > chunk length is not proper" on opening png fil

Re: [OpenJDK 2D-Dev] RFR(XS): 8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it

Hi Volker, I had a look at your change. It looks good. I appreciate a lot you added a check in configure. Maybe it would be better to pass a WITHOUT_XRANDR or the like to the build, and check for such a define in the code. But I think we should push this change for now to fix the build. A follow

Re: [OpenJDK 2D-Dev] RFR JDK-8209786: gcc 7.3 compiler errors on zLinux

Yes, that's fine. I can sponsor it tomorrow. I'm not in the office today. Best regards, Goetz. > -Original Message- > From: Andrew Leonard > Sent: Donnerstag, 6. September 2018 12:29 > To: Magnus Ihse Bursie ; Lindenmaier, Goetz > > Cc: 2d-dev <

Re: [OpenJDK 2D-Dev] RFR(M): 8170798: Fix minor issues in java2d and sound coding.

all our testing successfully. I'll push it Monday to client if there are no objections. Best regards, Goetz. > -Original Message- > From: Sergey Bylokhov [mailto:sergey.bylok...@oracle.com] > Sent: Mittwoch, 14. Dezember 2016 19:29 > To: Lindenmaier, Goetz > Cc: Ph

Re: [OpenJDK 2D-Dev] RFR(M): 8170798: Fix minor issues in java2d and sound coding.

lly. OK, I removed these changes. But submitting upstream will probably mean that I don't get the fixes into jdk9 any more. > Local changes may make sense in >(c) ICU layout >(d) libjpeg6b >since these are at a different stage in their life > > Having said

[OpenJDK 2D-Dev] [ping] RE: RFR(M): 8170798: Fix minor issues in java2d and sound coding.

Could someone please have a look at these changes? Thanks, Goetz. > -Original Message- > From: Lindenmaier, Goetz > Sent: Freitag, 9. Dezember 2016 08:58 > To: 2d-dev <2d-dev@openjdk.java.net>; 'sound-...@openjdk.java.net' d...@openjdk.java.net> > S

[OpenJDK 2D-Dev] RFR(M): 8170798: Fix minor issues in java2d and sound coding.

Hi, This change fixes some minor issues found in our code scans. I hope this correctly addresses corelib and serviceability issues. Please review: http://cr.openjdk.java.net/~goetz/wr16/8170798-java2d_sound/webrev.01/ Best regards, Goetz. Changes in detail: hg-ot-font.cc Looks l

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

Hi Phil, does that mean I can push the change, or will this happen through jprt? Best regards, Goetz. > -Original Message- > From: Philip Race [mailto:philip.r...@oracle.com] > Sent: Tuesday, December 06, 2016 4:21 AM > To: Lindenmaier, Goetz > Cc: Sergey Bylo

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

-Original Message- > From: Phil Race [mailto:philip.r...@oracle.com] > Sent: Monday, December 05, 2016 7:26 PM > To: Lindenmaier, Goetz ; Sergey Bylokhov > > Cc: awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net> > Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix mi

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

Hi Phil, that would be great, unfortunately I don't have access to JPRT. Thanks, Goetz. > -Original Message- > From: Phil Race [mailto:philip.r...@oracle.com] > Sent: Friday, December 02, 2016 8:46 PM > To: Lindenmaier, Goetz ; Sergey Bylokhov > > Cc: awt-.

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

st regards, Goetz. > -Original Message- > From: Phil Race [mailto:philip.r...@oracle.com] > Sent: Donnerstag, 1. Dezember 2016 22:31 > To: Lindenmaier, Goetz ; Sergey Bylokhov > ; Vincent Ryan > Cc: awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net>;

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

Ah, no, that is just the field that is initialized with the Result of gtk3_get_color_for_flags() why I need to initialize it there. Best regards, Goetz. > -Original Message- > From: Lindenmaier, Goetz > Sent: Donnerstag, 1. Dezember 2016 12:10 > To: 'Prasanta Sadhu

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

Hi Prasanta, good point, I added that too. Best regards, Goetz. > -Original Message- > From: Prasanta Sadhukhan [mailto:prasanta.sadhuk...@oracle.com] > Sent: Donnerstag, 1. Dezember 2016 06:05 > To: Phil Race ; Sergey Bylokhov > ; Lindenmaier, Goetz > ; Vince

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

ginal Message- > From: Phil Race [mailto:philip.r...@oracle.com] > Sent: Mittwoch, 30. November 2016 20:59 > To: Sergey Bylokhov ; Lindenmaier, Goetz > ; Vincent Ryan > Cc: awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net>; security- > d...@openjdk.java.net >

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

gt; From: Langer, Christoph > Sent: Mittwoch, 30. November 2016 20:47 > To: Lindenmaier, Goetz > Cc: awt-...@openjdk.java.net; security-...@openjdk.java.net; 2d- > d...@openjdk.java.net; Vincent Ryan > Subject: RE: RFR(M): 8170525: Fix minor issues in awt coding > > Hi Goetz, >

Re: [OpenJDK 2D-Dev] RFR(XS): 8161923: Fix free in awt_PrintControl.

Thanks Vadim! Best regards, Goetz. > -Original Message- > From: Vadim Pakhnushev [mailto:vadim.pakhnus...@oracle.com] > Sent: Donnerstag, 25. August 2016 15:54 > To: Lindenmaier, Goetz ; 2d-dev <2d- > d...@openjdk.java.net> > Subject: Re: [OpenJDK 2D-Dev] RFR(X

[OpenJDK 2D-Dev] RFR(XS): 8161923: Fix free in awt_PrintControl.

Hi, Could I please get a review for this tiny fix? http://cr.openjdk.java.net/~goetz/wr16/8161923-jdkMem/webrev.03/ Best regards, Goetz.

Re: [OpenJDK 2D-Dev] RFR(S): 8161923: Fix two memory issues.

regards, Goetz. > -Original Message- > From: Vadim Pakhnushev [mailto:vadim.pakhnus...@oracle.com] > Sent: Friday, July 22, 2016 9:09 AM > To: Phil Race ; Lindenmaier, Goetz > > Subject: Re: [OpenJDK 2D-Dev] RFR(S): 8161923: Fix two memory > issues. > > I'

Re: [OpenJDK 2D-Dev] RFR(L): 8160974: [TESTBUG] Mark more headful tests with @key headful.

Message- > From: Volker Simonis [mailto:volker.simo...@gmail.com] > Sent: Mittwoch, 20. Juli 2016 15:30 > To: Sergey Bylokhov > Cc: Lindenmaier, Goetz ; awt- > d...@openjdk.java.net; swing-...@openjdk.java.net; 2d-dev <2d- > d...@openjdk.java.net> > Subject: Re

[OpenJDK 2D-Dev] RFR(S): 8161923: Fix two memory issues.

Hi This changes fixes two memory issues. In awt_PrintControl.cpp, a wrong pointer is freed. In LigatureSubstProc2.cpp, line 157: stack[++mm] = componentGlyph; can overwrite the stack by one element. It will write stack[nComponents], because ++mm increments before accessing the array. Fix: i

Re: [OpenJDK 2D-Dev] RFR(L): 8160974: [TESTBUG] Mark more headful tests with @key headful.

Hi Sergey, thanks a lot for looking at this! Best regards, Goetz. > -Original Message- > From: Sergey Bylokhov [mailto:sergey.bylok...@oracle.com] > Sent: Tuesday, July 19, 2016 9:17 PM > To: Lindenmaier, Goetz ; awt- > d...@openjdk.java.net; swing-...@openjdk.java.

Re: [OpenJDK 2D-Dev] RFR(XS): 8160721: Avoid deoptimizations in Font.equals.

Hi Volker, thanks for looking at this, and doing the test example! Best regards, Goetz. > -Original Message- > From: Volker Simonis [mailto:volker.simo...@gmail.com] > Sent: Freitag, 15. Juli 2016 12:09 > To: Lindenmaier, Goetz > Cc: Phil Race ; awt-...@openjdk.j

[OpenJDK 2D-Dev] [ping] RFR(L): 8160974: [TESTBUG] Mark more headful tests with @key headful.

Hi, could someone please have a look at this? It's L, but the change is only one line in a lot of tests ... Thanks! Goetz. > -Original Message- > From: Lindenmaier, Goetz > Sent: Donnerstag, 7. Juli 2016 17:01 > To: 'awt-...@openjdk.java.net' ; swing- >

[OpenJDK 2D-Dev] RFR(L): 8160974: [TESTBUG] Mark more headful tests with @key headful.

Hi, This change is 'L' because there are changes to a lot of files, but the changes are all similar, so it's rather easy to review. Similar to 8159690 I added @key headful to another around 600 tests. I used different patterns to grep for the headful exceptions. These are now all I could find wit

Re: [OpenJDK 2D-Dev] RFR(XS): 8160721: Avoid deoptimizations in Font.equals.

Hi, can I consider this reviewed? Remi Forax and Phil Race had a look at this. Best regards, Goetz. > -Original Message- > From: Lindenmaier, Goetz > Sent: Montag, 4. Juli 2016 08:33 > To: 'Phil Race' ; awt-...@openjdk.java.net; 2d-dev > <2d-dev@openjdk.java

Re: [OpenJDK 2D-Dev] RFR(XS): 8160721: Avoid deoptimizations in Font.equals.

uli 2016 19:35 > To: Lindenmaier, Goetz ; awt- > d...@openjdk.java.net > Subject: Re: RFR(XS): 8160721: Avoid deoptimizations in > Font.equals. > > Please resend this to 2d-dev. All font related API and implementation > is part of 2D, not AWT. > > -phil. > >

Re: [OpenJDK 2D-Dev] RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

aightened out. Best regards, Goetz. > -Original Message- > From: Phil Race [mailto:philip.r...@oracle.com] > Sent: Montag, 20. Juni 2016 22:18 > To: Lindenmaier, Goetz > Cc: Sergey Bylokhov ; Alexandr Scherbatiy > ; Volker Simonis > ; awt-...@openjdk.java.net; 2d

Re: [OpenJDK 2D-Dev] RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

eitag, 17. Juni 2016 16:21 > To: Lindenmaier, Goetz ; Alexandr Scherbatiy > ; Volker Simonis > > Cc: awt-...@openjdk.java.net; swing-...@openjdk.java.net; 2d-dev <2d- > d...@openjdk.java.net> > Subject: Re: RFR(L): 8159690: [TESTBUG] Mark > headful tests with @key headf