Andrew Brygin wrote:
> There is short status for other two your suggested fixes:
> - 5082756: finished engineering review, waiting for CCC decision.
> - 6541476: as we had commited fix for this bug id I'd submitted new
> bug report (6782079) for this problem. Fix is being reviewed now.
>
Andrew Brygin wrote:
> yes, I agree that the reaching the length limit likely signifies that
> png header is corrupt. Our usual policy is to try to be tolerant to
> errors in the images. There are too many not very well formed images
> around and being too strict we may reject too much. That's why
Hi Andrew,
Looking at the patch from the webrev you sent me via private email, and
comparing it to my previous bug6541476-corrections.patch, I have some
comments.
The addition of a maxLength parameter to readNullTerminatedString makes
sense, as it avoids some problems on malformed input. It is my
Andrew Brygin wrote:
> As you probably saw your fix for 5106550 was just pushed into 2d
> workspace
> (http://hg.openjdk.java.net/jdk7/2d/jdk/rev/9d14b0582e1a)
Yes, I noticed, thanks.
Comparing that changeset with my patch, I found that the patch now also
ignores invalid keywords for the nativ
know. If there is
something else that would require a bump of metadata versions, now would
be a good time to collect this information.
Greetings,
Martin von Gagern
signature.asc
Description: OpenPGP digital signature
Dalibor Topic wrote:
> On a side note, it'd be nice to be able to find the different patches
> that seem to have fallen through the cracks more easily then by
> testing everyone's patience by requiring repeated pings from
> submitter - any way we could leverage gmane or markmail to do that?
How wo
Mark Wielaard wrote:
> Martin, if you like we can use IcedTea http://icedtea.classpath.org/ as
> staging area for these fixes. That is what I do after testing. The above
> two fixes are already in IcedTea6 for a couple of months since I know
> other users are seeing the same bugs. That way things a
Hi Igor,
thanks for your status update.
Igor Nekrestyanov wrote:
> My understanding of current situation with Martin's fixes is the following:
> - for 2 of Martin's fixes internal formal review procedure is in progress
>(we do review all changes and save approved webrevs and this is
>ano
I don't see much
benefit comparing webrev output over the unified diffs I sent.
5106550: http://article.gmane.org/gmane.comp.java.openjdk.2d.devel/522
5082756: http://article.gmane.org/gmane.comp.java.openjdk.2d.devel/523
6541476: http://article.gmane.org/gmane.comp.java.openjdk.2d.devel/526
Hello Andrew,
Andrew Brygin wrote:
> fix looks fine for me in general, just one minor note:
Thanks for looking at this. Let me know when you think it ready for
inclusion.
> There is getBooleanAttribute() method in the GIFMetadata class, which
> probably should be modified as a part of this fix.
more confident that
the test does what I expect, as I know it can read correct images and
only fails for truncated ones. I guess I could write test cases for the
other issues classified as "bug" above, if you think that worthwhile.
Please review my patch, and let me know when I should c
ocally and export a mercurial
patch instead.
Greetings,
Martin von Gagern
diff --git a/src/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java
b/src/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java
--- a/src/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java
+++ b
n, I will commit it locally and export a mercurial
patch instead.
Greetings,
Martin von Gagern
diff --git
a/src/share/classes/com/sun/imageio/plugins/gif/GIFImageMetadata.java
b/src/share/classes/com/sun/imageio/plugins/gif/GIFImageMetadata.java
--- a/src/share/classes/com/sun/imageio/
e patch straight out of my patch
queue. I submit it here, waiting for comments, discussion, sponsorship.
Once you consider it ready for inclusion, I can commit it localy and
post a patch exported by hg.
Greetings,
Martin von Gagern
diff --git a/src/share/classes/com/sun/imageio/plugins/png/PNG
is from my mercurial patch queue. Once you consider
it ready for inclusion, I will commit it locally and export a mercurial
patch instead.
Greetings,
Martin von Gagern
diff --git a/src/share/classes/com/sun/imageio/plugins/png/PNGMetadata.java
b/src/share/classes/com/sun/imageio/plugins/png/PNGMet
report?
4. I tend to have multiple commits per fix. Do you want a diff for each,
or rather a single hg bundle containing them all, or both of this?
5. Would you prefer a public hg branch somewhere to exchange the current
state of affairs?
Greetings,
Martin von Gagern
-BEGIN PGP SIGNATURE---
16 matches
Mail list logo
